vlan: fix typo in vlan_dev_hard_start_xmit()

PATCH In review Wei Yongjun 4 participants 4 messages Jun 1, 2011 – Jun 2, 2011

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Wei Yongjun

author

2011-06-01 08:54 UTC #0 lore raw

PATCH 1/1 vlan: fix typo in vlan_dev_hard_start_xmit()

commit 4af429d29b341bb1735f04c2fb960178ed5d52e7 (vlan: lockless transmit path) have a typo in vlan_dev_hard_start_xmit(), using u64_stats_update_begin() to end the stat update, it should be u64_stats_update_end().

Signed-off-by Wei Yongjun <[email protected]>

---
 net/8021q/vlan_dev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

net/8021q/vlan_dev.c +1 -1

index f247f5b..7ea5cf9 100644
@@ -165,7 +165,7 @@ static netdev_tx_t vlan_dev_hard_start_xmit(struct sk_buff *skb,
 		u64_stats_update_begin(&stats->syncp);
 		stats->tx_packets++;
 		stats->tx_bytes += len;
-		u64_stats_update_begin(&stats->syncp);
+		u64_stats_update_end(&stats->syncp);
 	} else {
 		this_cpu_inc(vlan_dev_info(dev)->vlan_pcpu_stats->tx_dropped);
 	}

Signature · 1 line

1.6.5.2

WANG Cong

Reviewed-by on v1 1/1

2011-06-01 13:55 UTC #1 lore raw

Quoted 6 lines · Wei Yongjun

commit 4af429d29b341bb1735f04c2fb960178ed5d52e7 (vlan: lockless transmit path) have a typo in vlan_dev_hard_start_xmit(), using u64_stats_update_begin() to end the stat update, it should be u64_stats_update_end().
Signed-off-by Wei Yongjun <[email protected]>

Yup, good catch!

Reviewed-by WANG Cong <[email protected]>

Eric Dumazet

Acked-by on v1 1/1

2011-06-01 15:07 UTC #2 lore raw

In reply to Wei Yongjun

Quoted 6 lines · Wei Yongjun

commit 4af429d29b341bb1735f04c2fb960178ed5d52e7 (vlan: lockless transmit path) have a typo in vlan_dev_hard_start_xmit(), using u64_stats_update_begin() to end the stat update, it should be u64_stats_update_end().
Signed-off-by Wei Yongjun <[email protected]>

Good catch, Thanks !

Acked-by Eric Dumazet <[email protected]>

David Miller

maintainer

2011-06-02 04:09 UTC #3 lore raw

From: Eric Dumazet <[email protected]>
Date: Wed, 01 Jun 2011 17:07:07 +0200

Quoted 11 lines · Wei Yongjun

Quoted 6 lines
commit 4af429d29b341bb1735f04c2fb960178ed5d52e7 (vlan: lockless transmit path) have a typo in vlan_dev_hard_start_xmit(), using u64_stats_update_begin() to end the stat update, it should be u64_stats_update_end().
Signed-off-by Wei Yongjun <[email protected]>
Good catch, Thanks !
Acked-by Eric Dumazet <[email protected]>

Applied and queued up for -stable.

Thanks!