cifs: make CIFS depend on CRYPTO_ECB

PATCH In review Suresh Jayaraman 3 participants 5 messages Jun 3, 2011 4 messages not in the archive

Subsystems (2)

SMB client (CIFS) Kernel SMB3 server (ksmbd)

lore

Share & tools

lore

Suresh Jayaraman

author

2011-06-03 08:49 UTC #0 lore raw

PATCH 1/1 cifs: make CIFS depend on CRYPTO_ECB

When CONFIG_CRYPTO_ECB is not set, trying to mount a CIFS share with NTLM security resulted in mount failure with the following error:
"CIFS VFS: could not allocate des crypto API"

Seems like a leftover from commit 43988d7.

Signed-off-by Suresh Jayaraman <[email protected]>

---
 fs/cifs/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

fs/cifs/Kconfig +1 -0

index 1cd4c3a..66c68ab 100644
@@ -7,6 +7,7 @@ config CIFS
 	select CRYPTO_MD5
 	select CRYPTO_HMAC
 	select CRYPTO_ARC4
+	select CRYPTO_ECB
 	select CRYPTO_DES
 	help
 	  This is the client VFS module for the Common Internet File System

Signature · 1 line

1.7.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jeff Layton

Reviewed-by

2011-06-03 13:10 UTC #2 lore raw

Quoted 16 lines · On Fri, 03 Jun 2011 14:19:01 +0530 Suresh Jayaraman…

When CONFIG_CRYPTO_ECB is not set, trying to mount a CIFS share with NTLM security resulted in mount failure with the following error:
"CIFS VFS: could not allocate des crypto API"
Seems like a leftover from commit 43988d7.
Signed-off-by Suresh Jayaraman <[email protected]>
---
 fs/cifs/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/cifs/Kconfig +0 -0
index 1cd4c3a..66c68ab 100644

fs/cifs/Kconfig config CIFS · line 13

Quoted 7 lines

fs/cifs/Kconfig +1 -0

@@ -7,6 +7,7 @@ config CIFS
 	select CRYPTO_MD5
 	select CRYPTO_HMAC
 	select CRYPTO_ARC4
+	select CRYPTO_ECB
 	select CRYPTO_DES
 	help
 	  This is the client VFS module for the Common Internet File System

Reviewed-by Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20110603091007.7c7b9910-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org

Steve French

2011-06-03 17:39 UTC #4 lore raw

Merged. This is a strange dependency - it looks like thee real problem is that the two crypto libs we depend on that depend on this don't select ECB but it is harmless to add the select.

Quoted 29 lines · Jeff Layton

Quoted 16 lines · On Fri, 03 Jun 2011 14:19:01 +0530 Suresh Jayaraman…
When CONFIG_CRYPTO_ECB is not set, trying to mount a CIFS share with NTLM security resulted in mount failure with the following error:
"CIFS VFS: could not allocate des crypto API"
Seems like a leftover from commit 43988d7.
Signed-off-by Suresh Jayaraman <[email protected]>
---
fs/cifs/Kconfig | 1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/cifs/Kconfig +0 -0
index 1cd4c3a..66c68ab 100644
@@ -7,6 +7,7 @@ config CIFS
Quoted 7 lines
select CRYPTO_MD5
select CRYPTO_HMAC
select CRYPTO_ARC4
+ select CRYPTO_ECB
select CRYPTO_DES
help
This is the client VFS module for the Common Internet File System
Reviewed-by Jeff Layton <[email protected]>

Signature · 3 lines

Thanks,

Steve

A message that is not in the archive (sent off-list or not yet received): BANLkTimhjwe1Ry8JR+bTixSRmd86gHADTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Jeff Layton

2011-06-03 18:02 UTC #6 lore raw

Quoted 4 lines · On Fri, 3 Jun 2011 12:39:41 -0500 Steve French…

Merged. This is a strange dependency - it looks like thee real problem is that the two crypto libs we depend on that depend on this don't select ECB but it is harmless to add the select.

Hmm...then maybe the patch should this dependency there so that other kernel subsystems don't get bitten by the same problem?

Quoted 33 lines · Jeff Layton

Quoted 29 lines
Quoted 16 lines · On Fri, 03 Jun 2011 14:19:01 +0530 Suresh Jayaraman…
When CONFIG_CRYPTO_ECB is not set, trying to mount a CIFS share with NTLM security resulted in mount failure with the following error:
"CIFS VFS: could not allocate des crypto API"
Seems like a leftover from commit 43988d7.
Signed-off-by Suresh Jayaraman <[email protected]>
---
fs/cifs/Kconfig | 1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/cifs/Kconfig +0 -0
index 1cd4c3a..66c68ab 100644
@@ -7,6 +7,7 @@ config CIFS
Quoted 7 lines
select CRYPTO_MD5
select CRYPTO_HMAC
select CRYPTO_ARC4
+ select CRYPTO_ECB
select CRYPTO_DES
help
This is the client VFS module for the Common Internet File System
Reviewed-by Jeff Layton <[email protected]>

Signature · 1 line

Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20110603140218.02d3315e-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org

Suresh Jayaraman

author

2011-06-03 18:29 UTC #8 lore raw

Quoted 10 lines · Jeff Layton

Quoted 4 lines · On Fri, 3 Jun 2011 12:39:41 -0500 Steve French…
Merged. This is a strange dependency - it looks like thee real problem is that the two crypto libs we depend on that depend on this don't select ECB but it is harmless to add the select.
Hmm...then maybe the patch should this dependency there so that other kernel subsystems don't get bitten by the same problem?

I looked at a few in-tree examples:

Quoted 1 line

From drivers/net/Kconfig

config PPP_MPPE
tristate "PPP MPPE compression (encryption) (EXPERIMENTAL)" depends on PPP && EXPERIMENTAL
select CRYPTO
select CRYPTO_SHA1
select CRYPTO_ARC4
select CRYPTO_ECB
(we seem to have both ARC4 and ECB explicitly)

Quoted 1 line

From net/sunrpc/Kconfig:

config RPCSEC_GSS_KRB5

        tristate "Secure RPC: Kerberos V mechanism"
        depends on SUNRPC && CRYPTO
        depends on CRYPTO_MD5 && CRYPTO_DES && CRYPTO_CBC && CRYPTO_CTS
        depends on CRYPTO_ECB && CRYPTO_HMAC && CRYPTO_SHA1 && CRYPTO_AES
        depends on CRYPTO_ARC4

Quoted 1 line

From drivers/crypto/Kconfig:

config CRYPTO_DEV_PICOXCELL
tristate "Support for picoXcell IPSEC and Layer2 crypto engines" depends on ARCH_PICOXCELL
select CRYPTO_AES
select CRYPTO_AUTHENC
select CRYPTO_ALGAPI
select CRYPTO_DES
select CRYPTO_CBC
select CRYPTO_ECB
select CRYPTO_SEQIV

and others in
drivers/net/wireless/hostap/Kconfig
drivers/net/wireless/ipw2x00/Kconfig

Looks like none of them will be affected as they use explicitly. However, it is not clear to me why they the crypto lib itself is not marking the dependency..

Quoted 35 lines

Quoted 33 lines · Jeff Layton
Quoted 29 lines
Quoted 16 lines · On Fri, 03 Jun 2011 14:19:01 +0530 Suresh Jayaraman…
When CONFIG_CRYPTO_ECB is not set, trying to mount a CIFS share with NTLM security resulted in mount failure with the following error:
"CIFS VFS: could not allocate des crypto API"
Seems like a leftover from commit 43988d7.
Signed-off-by Suresh Jayaraman <[email protected]>
---
 fs/cifs/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/cifs/Kconfig +0 -0
index 1cd4c3a..66c68ab 100644
fs/cifs/Kconfig config CIFS · line 13
Quoted 7 lines
fs/cifs/Kconfig +1 -0
@@ -7,6 +7,7 @@ config CIFS
      select CRYPTO_MD5
      select CRYPTO_HMAC
      select CRYPTO_ARC4
+     select CRYPTO_ECB
      select CRYPTO_DES
      help
        This is the client VFS module for the Common Internet File System
Reviewed-by Jeff Layton <[email protected]>

Signature · 1 line

Suresh Jayaraman