Skip to contentSkip to conversation

x86: cleanup "idle=mwait" removal warning message

PATCH In review Németh Márton 2 participants 2 messages Jun 4, 2011 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: cleanup "idle=mwait" removal warning message

From: Márton Németh <[email protected]>

Cleanup the warning message. This will remove the following warning message when compiling:

* arch/x86/kernel/process.c:645:1: warning: unknown escape sequence '\i'

---

arch/x86/kernel/process.c renamed from arch/x86/kernel/process.c.orig +1 -1
@@ -642,7 +642,7 @@ static int __init idle_setup(char *str)
 		boot_option_idle_override = IDLE_POLL;
 	} else if (!strcmp(str, "mwait")) {
 		boot_option_idle_override = IDLE_FORCE_MWAIT;
-		WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
+		WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012\n");
 	} else if (!strcmp(str, "halt")) {
 		/*
 		 * When the boot option of idle=halt is added, halt is
maintainer
#1 lore raw
Quoted 6 lines · Németh Márton

From: Márton Németh <[email protected]>

Cleanup the warning message. This will remove the following warning message when compiling:

* arch/x86/kernel/process.c:645:1: warning: unknown escape sequence '\i'

Yeah, yours is correct.

But I think we fixed that already in an orchestrated and concentrated effort of at least 4 people fixing one printk string culminating in Linus intervening with an evil merge: af0d6a0a

:-)

Keep up the good work, though, the next issue is right around the corner, I'm sure.

Signature · 2 lines
Regards/Gruss,
    Boris.