Skip to contentSkip to conversation

: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

PATCH RESEND In review Tomoya MORINAGA 2 participants 7 messages Jun 7, 2011 – Jun 20, 2011

lore
Share & tools
lore

Tomoya MORINAGA

author
#0 lore raw

PATCH RESEND 1/1 : RE: [PATCH v2 3/3] pch_gpio: support interrupt function

Hi Grant,

Let me resend again.
I haven't received your answer the following my question yet.

Quoted 4 lines · Grant Likely

Take a look at the new irq_chip_generic infrastructure. You don't need to implement a memory mapped irq controller from scratch anymore. Most of the access functions can be taken directly from irq_chip_generic instead.

Let me clarify your saying.
a) We shouldn't use request_irq( ) ?
b) Does Your "irq_chip_generic" mean irq_set_handler_data( ) /
irq_set_chained_handler( ) ?
If yes, Using these functions, I saw IRQ shared other function's
interrupt becomes invalid.

Signature · 2 lines
tomoya
OKI SEMICONDUCTOR CO., LTD.
#1 lore raw
Quoted 11 lines · Tomoya MORINAGA

Hi Grant,

Let me resend again.
I haven't received your answer the following my question yet.

Quoted 4 lines · Grant Likely

Take a look at the new irq_chip_generic infrastructure. You don't need to implement a memory mapped irq controller from scratch anymore. Most of the access functions can be taken directly from irq_chip_generic instead.

Quoted 7 lines

Let me clarify your saying.
a) We shouldn't use request_irq( ) ?
b) Does Your "irq_chip_generic" mean irq_set_handler_data( ) /
irq_set_chained_handler( ) ?
If yes, Using these functions, I saw IRQ shared other function's
interrupt becomes invalid.

No, I'm saying that you don't need to implement new irq_chip operations if you use the new irq_chip_generic implementation.

g.

author
#2 lore raw
Quoted 2 lines · Grant Likely

No, I'm saying that you don't need to implement new irq_chip operations if you use the new irq_chip_generic implementation.

I understand your saying. It seems "new irq_chip_generic" was implemented in linux-3.0. However "irq_chip_generic" is not implemented in stable kernel version. Right ? So, first of all, could you accept this patch ?
After the kernel version becomes stable, I will resubmit a patch for "new irq_chip_generic".

Signature · 2 lines
tomoya
OKI SEMICONDUCTOR CO., LTD.
#3 lore raw
Quoted 11 lines · Tomoya MORINAGA
Quoted 2 lines · Grant Likely

No, I'm saying that you don't need to implement new irq_chip operations if you use the new irq_chip_generic implementation.

I understand your saying. It seems "new irq_chip_generic" was implemented in linux-3.0.
However "irq_chip_generic" is not implemented in stable kernel version. Right ?
So, first of all, could you accept this patch ?
After the kernel version becomes stable, I will resubmit a patch for "new irq_chip_generic".

Ah, I understand what you're asking.

Sorry, but I cannot pickup this patch for the stable series. It is a new feature, not a bug fix. Only bug fixes should be going into the stable kernel series.

g.

author
#4 lore raw
Quoted 6 lines · Grant Likely

Ah, I understand what you're asking.

Sorry, but I cannot pickup this patch for the stable series. It is a new feature, not a bug fix. Only bug fixes should be going into the stable kernel series.

My request didn't mean like above.
I meant that I want you to add the patch to next version linux, namely "3.1" Because "irq_chip_generic" is implemented only RC version, namely "3.0-rcX"

Anyway, I don't think you change your opinion.
Thus, I must re-coding using "irq_chip_generic".

Thanks,

Signature · 2 lines
tomoya
OKI SEMICONDUCTOR CO., LTD.
author
#5 lore raw
In reply to Grant Likely

Hi Grant

Quoted 4 lines · Grant Likely

You don't need to implement new irq_chip
operations if you use the new irq_chip_generic implementation.

I have recently started implementing GPIO interrupt using irq_chip_generic. However, the compile becomes failed.
irq_alloc_generic_chip: undefined reference
irq_setup_generic_chip: undefined reference

It seems irq_chip_generic is only ARM code.(linux-3.0-rc3) Does X86 support irq_chip_generic ?

Signature · 2 lines
tomoya
OKI SEMICONDUCTOR CO., LTD.
#6 lore raw
Quoted 8 lines · Tomoya MORINAGA

Hi Grant

Quoted 4 lines · Grant Likely

You don't need to implement new irq_chip
operations if you use the new irq_chip_generic implementation.

Quoted 7 lines

I have recently started implementing GPIO interrupt using irq_chip_generic. However, the compile becomes failed.
 irq_alloc_generic_chip: undefined reference
 irq_setup_generic_chip: undefined reference

It seems irq_chip_generic is only ARM code.(linux-3.0-rc3) Does X86 support irq_chip_generic ?

Make sure your driver has "select GENERIC_IRQ_CHIP" in the Kconfig entry.

g.