Skip to contentSkip to conversation

ecn match ported to ipv6

RFC Eric Dumazet 4 participants 7 messages Jun 8, 2011 – Jun 9, 2011 1 message not in the archive netfilter

lore
Share & tools
lore
#0 lore raw

Dave Taht mentioned in bloat list that netfilter ecn match was ipv4 only.

Is there any plan to make the switch from net/ipv4/netfilter/ipt_ecn.c to net/netfilter/xt_ecn.c ?

I can probably do it but not before ~ten days, so if someone is interested, this will please Dave ;)

Thanks

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

---------- Forwarded message ----------
From: Dave Taht <[email protected]>
Date: Wed, Jun 8, 2011 at 9:47 AM
Subject: Re: [RFC] ecn match ported to ipv6
To: Eric Dumazet <[email protected]>
Cc: Patrick McHardy <[email protected]>, Jan Engelhardt <[email protected]>, Netfilter Development Mailinglist <[email protected]>

Quoted 9 lines · Eric Dumazet

Dave Taht mentioned in bloat list that netfilter ecn match was ipv4 only.

Is there any plan to make the switch from net/ipv4/netfilter/ipt_ecn.c to net/netfilter/xt_ecn.c ?

I can probably do it but not before ~ten days, so if someone is interested, this will please Dave ;)

The larger question I had was this

"iptables seems to think ecn can only be looked at in TCP streams, where (for example), ecn bits can be copied to the outer header of a udp vpn stream, and marked

when needed."

ECN is an ip level standard, not just a tcp one.

http://www.ietf.org/rfc/rfc3168.txt

Example of ECN on ipsec:

http://huchra.bufferbloat.net/~d/veryhappynetwork.png

Also ECN marking in various qdiscs like HTB as presently being discussed on the bloat list

https://lists.bufferbloat.net/pipermail/bloat/2011-June/000555.html

and a truly crazy idea regarding combining DSCP with firewalling is here:

https://lists.bufferbloat.net/pipermail/bloat/2011-June/000558.html

To give some context as to what we've been up to regarding bufferbloat, I have a test lab setup with a bunch of wndr3700v2 routers at georgia tech, and have pushed  every ecn and bufferbloat related patch in linux head into the openwrt distro, and am playing with all sorts of techniques now, with increasingly good results.

The 'uberwrt' project is in addition to the debloat-testing work and has various subprojects... mostly targeting the wndr3700v2 and nanostation M5 as these have a completely open source wireless and wired stack.

http://www.bufferbloat.net/projects/uberwrt/wiki

--
Dave Täht
SKYPE: davetaht
US Tel: 1-239-829-5608
http://www.bufferbloat.net

--
Dave Täht
SKYPE: davetaht
US Tel: 1-239-829-5608
http://the-edge.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to a message not in the archive
Quoted 10 lines · Dave Taht
Quoted 8 lines · Eric Dumazet

Dave Taht mentioned in bloat list that netfilter ecn match was ipv4 only.

Is there any plan to make the switch from net/ipv4/netfilter/ipt_ecn.c to net/netfilter/xt_ecn.c ?

I can probably do it but not before ~ten days, so if someone is interested, this will please Dave ;)

That should be a relatively quick job, I'll give it a shot while my dinner is cooking :)

Quoted 9 lines

The larger question I had was this

"iptables seems to think ecn can only be looked at in TCP streams, where (for example), ecn bits can be copied to the outer header of a udp vpn stream, and marked

when needed."

ECN is an ip level standard, not just a tcp one.

That probably needs a new revision and is slightly more work, lets begin by porting it to IPv6, then we can add this on top.

Quoted 10 lines

http://www.ietf.org/rfc/rfc3168.txt

Example of ECN on ipsec:

http://huchra.bufferbloat.net/~d/veryhappynetwork.png

Also ECN marking in various qdiscs like HTB as presently being discussed on the bloat list

https://lists.bufferbloat.net/pipermail/bloat/2011-June/000555.html

I'd suggest to make this generic so other qdiscs can use it as well.

Quoted 15 lines

and a truly crazy idea regarding combining DSCP with firewalling is here:

https://lists.bufferbloat.net/pipermail/bloat/2011-June/000558.html

To give some context as to what we've been up to regarding bufferbloat, I have a test lab setup with a bunch of wndr3700v2 routers at georgia tech, and have pushed every ecn and bloat related patch in linux head into the openwrt distro, and am playing with all sorts of techniques now, with increasingly good results.

The 'uberwrt' project is in addition to the debloat-testing work and has various subprojects...

http://www.bufferbloat.net/projects/uberwrt/wiki

#4 lore raw
Quoted 21 lines · Patrick McHardy
Quoted 10 lines · Dave Taht
Quoted 8 lines · Eric Dumazet

Dave Taht mentioned in bloat list that netfilter ecn match was ipv4 only.

Is there any plan to make the switch from net/ipv4/netfilter/ipt_ecn.c to net/netfilter/xt_ecn.c ?

I can probably do it but not before ~ten days, so if someone is interested, this will please Dave ;)

That should be a relatively quick job, I'll give it a shot while my dinner is cooking :)

Quoted 6 lines

The larger question I had was this

"iptables seems to think ecn can only be looked at in TCP streams, where (for example), ecn bits can be copied to the outer header of a udp vpn stream, and marked

Quoted 6 lines
Quoted 3 lines

when needed."

ECN is an ip level standard, not just a tcp one.

That probably needs a new revision and is slightly more work, lets begin by porting it to IPv6, then we can add this on top.

Moving it to xt_ecn first seems like producing a smaller patchset because you don't have to potentially duplicate the functions first. :)

#5 lore raw
Quoted 25 lines · Jan Engelhardt
Quoted 23 lines · Patrick McHardy
Quoted 10 lines · Dave Taht
Quoted 8 lines · Eric Dumazet

Dave Taht mentioned in bloat list that netfilter ecn match was ipv4 only.

Is there any plan to make the switch from net/ipv4/netfilter/ipt_ecn.c to net/netfilter/xt_ecn.c ?

I can probably do it but not before ~ten days, so if someone is interested, this will please Dave ;)

That should be a relatively quick job, I'll give it a shot while my dinner is cooking :)

Quoted 8 lines

The larger question I had was this

"iptables seems to think ecn can only be looked at in TCP streams, where (for example), ecn bits can be copied to the outer header of a udp vpn stream, and marked

when needed."

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

ECN is an ip level standard, not just a tcp one.

That probably needs a new revision and is slightly more work, lets begin by porting it to IPv6, then we can add this on top.

Moving it to xt_ecn first seems like producing a smaller patchset because you don't have to potentially duplicate the functions first. :)

It actually already supports matching on IP header ECN bits:

[!] --ecn-ip-ect [0..3] Match ECN codepoint in IPv4 header

#6 lore raw
Quoted 31 lines · Patrick McHardy
Quoted 30 lines · Jan Engelhardt
Quoted 27 lines · Patrick McHardy
Quoted 10 lines · Dave Taht
Quoted 8 lines · Eric Dumazet

Dave Taht mentioned in bloat list that netfilter ecn match was ipv4 only.

Is there any plan to make the switch from net/ipv4/netfilter/ipt_ecn.c to net/netfilter/xt_ecn.c ?

I can probably do it but not before ~ten days, so if someone is interested, this will please Dave ;)

That should be a relatively quick job, I'll give it a shot while my dinner is cooking :)

Quoted 9 lines

The larger question I had was this

"iptables seems to think ecn can only be looked at in TCP streams, where (for example), ecn bits can be copied to the outer header of a udp vpn stream, and marked

when needed."

ECN is an ip level standard, not just a tcp one.

That probably needs a new revision and is slightly more work, lets begin by porting it to IPv6, then we can add this on top.

Quoted 7 lines
Quoted 2 lines

Moving it to xt_ecn first seems like producing a smaller patchset because you don't have to potentially duplicate the functions first. :)

It actually already supports matching on IP header ECN bits:

[!] --ecn-ip-ect [0..3] Match ECN codepoint in IPv4 header

Sorry, my bad. It's even documented as existing.

So it's just a pair of convienence functions (
--ecn-ip-ece --ecn-ip-cwr )

and ipv6 iptables support for ECN that are MIA.

I'll argue that extending the blackhole-ing feature to also include ip

--ecn-tcp-remove

might be good... although in my testing I have not found a blackhole yet, they must still be out there.

Signature · 8 lines
Dave Täht
SKYPE: davetaht
US Tel: 1-239-829-5608
http://the-edge.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#7 lore raw
Quoted 37 lines · Dave Taht
Quoted 36 lines · Patrick McHardy
Quoted 25 lines · Jan Engelhardt
Quoted 23 lines · Patrick McHardy
Quoted 10 lines · Dave Taht
Quoted 8 lines · Eric Dumazet

Dave Taht mentioned in bloat list that netfilter ecn match was ipv4 only.

Is there any plan to make the switch from net/ipv4/netfilter/ipt_ecn.c to net/netfilter/xt_ecn.c ?

I can probably do it but not before ~ten days, so if someone is interested, this will please Dave ;)

That should be a relatively quick job, I'll give it a shot while my dinner is cooking :)

Quoted 8 lines

The larger question I had was this

"iptables seems to think ecn can only be looked at in TCP streams, where (for example), ecn bits can be copied to the outer header of a udp vpn stream, and marked

when needed."

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

ECN is an ip level standard, not just a tcp one.

That probably needs a new revision and is slightly more work, lets begin by porting it to IPv6, then we can add this on top.

Moving it to xt_ecn first seems like producing a smaller patchset because you don't have to potentially duplicate the functions first. :)

It actually already supports matching on IP header ECN bits:

Quoted 7 lines
Quoted 2 lines

[!] --ecn-ip-ect [0..3] Match ECN codepoint in IPv4 header

Sorry, my bad. It's even documented as existing.

So it's just a pair of convienence functions (
--ecn-ip-ece --ecn-ip-cwr )

Yeah, that would make usage easier.

Quoted 1 line

and ipv6 iptables support for ECN that are MIA.

Sent out patches a few seconds ago.

Quoted 6 lines

I'll argue that extending the blackhole-ing feature to also include ip

--ecn-tcp-remove

might be good... although in my testing I have not found a blackhole yet, they must still be out there.

That would be the ECN target, not the match.