ses: requesting a fault indication

PATCH New Douglas Gilbert 1 participant 1 message Jun 9, 2011 SCSI

Share & tools

Douglas Gilbert

author

2011-06-09 04:27 UTC #0 lore raw

PATCH 1/1 ses: requesting a fault indication

Noticed that when the sysfs interface of the SCSI SES driver was used to request a fault indication the LED flashed but the buzzer didn't sound. So it was doing what REQUEST IDENT (locate) should do.

Changelog:
- fix the setting of REQUEST FAULT for the device slot and array device slot elements in the enclosure control diagnostic page
- note the potentially defective code that reads the FAULT SENSED and FAULT REQUESTED bits from the enclosure status diagnostic page

The attached patch is against git/scsi-misc-2.6

Signed-off-by Douglas Gilbert <[email protected]>

drivers/scsi/ses.c +5 -1

index eb7a3e8..eba183c 100644
@@ -160,6 +160,10 @@ static unsigned char *ses_get_page2_descriptor(struct enclosure_device *edev,
 	return NULL;
 }
 
+/* For device slot and array device slot elements, byte 3 bit 6
+ * is "fault sensed" while byte 3 bit 5 is "fault reqstd". As this
+ * code stands these bits are shifted 4 positions right so in
+ * sysfs they will appear as bits 2 and 1 respectively. Strange. */
 static void ses_get_fault(struct enclosure_device *edev,
 			  struct enclosure_component *ecomp)
 {

@@ -181,7 +185,7 @@ static int ses_set_fault(struct enclosure_device *edev,
 		/* zero is disabled */
 		break;
 	case ENCLOSURE_SETTING_ENABLED:
-		desc[2] = 0x02;
+		desc[3] = 0x20;
 		break;
 	default:
 		/* SES doesn't do the SGPIO blink settings */