Skip to contentSkip to conversation

for bug 754635: -d option outs wrong info about sections

PATCH In review ferux 3 participants 3 messages Jun 12, 2011 – Jun 14, 2011

lore
Share & tools
lore

ferux

author
#0 lore raw

PATCH 1/1 for bug 754635: -d option outs wrong info about sections

Patch to correct log output about sections from:
start end size prot
00010000-00019000 00009000 r-x
00019000-0007b000 00062000 rw-
00040000-00041000 00001000 ---
00041000-00041800 00000800 rw-
00041800-0005d800 0001c000 r-x
0005d800-0005e800 00001000 rw-

to:
start end size prot
10000000-10019000 00019000 r-x
10019000-1006b000 00052000 rw-
40000000-40001000 00001000 ---
40001000-40801000 00800000 rw-
40801000-4081d000 0001c000 r-x
4081d000-4081e000 00001000 rw-

I described this bug: https://bugs.launchpad.net/qemu/+bug/754635.

Signed-off-by Max Rozhkov <address@hidden>

---

exec.c 2011-06-12 16:15:10.652434003 +0400 renamed from exec.c.orig 2011-06-12 16:14:51.362434004 +0400 +1 -1
@@ -2340,7 +2340,7 @@ int walk_memory_regions(void *priv, walk
     data.prot = 0;
 
     for (i = 0; i < V_L1_SIZE; i++) {
-        int rc = walk_memory_regions_1(&data, (abi_ulong)i << V_L1_SHIFT,
+        int rc = walk_memory_regions_1(&data, (abi_ulong)i << (V_L1_SHIFT + TARGET_PAGE_BITS),
                                        V_L1_SHIFT / L2_BITS - 1, 

l1_map + i);
         if (rc != 0) {
             return rc;
Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · ferux

Patch to correct log output about sections from:
start end size prot
00010000-00019000 00009000 r-x
00019000-0007b000 00062000 rw-
00040000-00041000 00001000 ---
00041000-00041800 00000800 rw-
00041800-0005d800 0001c000 r-x
0005d800-0005e800 00001000 rw-

to:
start end size prot
10000000-10019000 00019000 r-x
10019000-1006b000 00052000 rw-
40000000-40001000 00001000 ---
40001000-40801000 00800000 rw-
40801000-4081d000 0001c000 r-x
4081d000-4081e000 00001000 rw-

Quoted 3 lines

I described this bug: https://bugs.launchpad.net/qemu/+bug/754635.

Signed-off-by Max Rozhkov <address@hidden>
Acked-by Richard Henderson <[email protected]>

r~

#2 lore raw
In reply to ferux

Hi,

Am 12.06.2011 um 15:14 schrieb ferux:

Quoted 18 lines

Patch to correct log output about sections from:
start end size prot
00010000-00019000 00009000 r-x
00019000-0007b000 00062000 rw-
00040000-00041000 00001000 ---
00041000-00041800 00000800 rw-
00041800-0005d800 0001c000 r-x
0005d800-0005e800 00001000 rw-

to:
start end size prot
10000000-10019000 00019000 r-x
10019000-1006b000 00052000 rw-
40000000-40001000 00001000 ---
40001000-40801000 00800000 rw-
40801000-4081d000 0001c000 r-x
4081d000-4081e000 00001000 rw-

Quoted 1 line

I described this bug: https://bugs.launchpad.net/qemu/+bug/754635.

The subject and description need to be improved.

The subject might be something like: Fix -d option output about sections

with description: Correct log output about sections from:
[...]
to:
[...]
[What was wrong / why is that correct?]
This resolves bug: ...

I.e. make it self-descriptive and tell us for offline-reading what the patch does and why.

Quoted 1 line
Signed-off-by Max Rozhkov <address@hidden>

Please provide a proper address under which the author can be contacted in case of problems or questions.

exec.c 2011-06-12 16:15:10.652434003 +0400 int walk_memory_regions(void *priv, walk · line 2345

Quoted 10 lines
exec.c 2011-06-12 16:15:10.652434003 +0400 renamed from exec.c.orig 2011-06-12 16:14:51.362434004 +0400 +1 -1
@@ -2340,7 +2340,7 @@ int walk_memory_regions(void *priv, walk
    data.prot = 0;
 
    for (i = 0; i < V_L1_SIZE; i++) {
-        int rc = walk_memory_regions_1(&data, (abi_ulong)i <<  
 V_L1_SHIFT,
+        int rc = walk_memory_regions_1(&data, (abi_ulong)i <<  
 (V_L1_SHIFT + TARGET_PAGE_BITS),

Line length > 80 chars.

Andreas

Quoted 4 lines
exec.c 2011-06-12 16:15:10.652434003 +0400 renamed from exec.c.orig 2011-06-12 16:14:51.362434004 +0400 +0 -0
                                        V_L1_SHIFT / L2_BITS - 1,  

l1_map + i);
        if (rc != 0) {
            return rc;