OMAP: fix build breaks on OMAP boards

PATCH New Aneesh V 2 participants 27 messages Jun 7, 2011 – Jun 13, 2011

Share & tools

Aneesh V

author

2011-06-07 15:13 UTC #0 lore raw

cover OMAP: fix build breaks on OMAP boards

Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:

CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR

They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.

None of these have been tested as I do not have any of these boards.

Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks

 include/configs/omap1510inn.h |    3 +++
 include/configs/omap1610h2.h  |    3 +++
 include/configs/omap1610inn.h |    3 +++
 include/configs/omap2420h4.h  |    3 +++
 include/configs/omap5912osk.h |    3 +++
 include/configs/omap730p2.h   |    3 +++
 6 files changed, 18 insertions(+), 0 deletions(-)

Aneesh V

author

2011-06-07 15:13 UTC #1 lore raw

PATCH 1/6 omap1610h2: fix build breaks

Provide SDRAM base address and use SRAM for initial stack

---
 include/configs/omap1610h2.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

include/configs/omap1610h2.h +3 -0

index 2936dcc..57a7956 100644
@@ -189,4 +189,7 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here */
 
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 0x20000000
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 08:24 UTC #2 lore raw

PATCH 1/6 omap1610h2: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

---
 include/configs/omap1610h2.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap1610h2.h +5 -0

index 2936dcc..cb2a07f 100644
@@ -172,6 +172,8 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 
 #endif
 
+#define PHYS_SRAM		0x20000000
+
 /*-----------------------------------------------------------------------
  * FLASH and environment organization
  */

@@ -189,4 +191,7 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-07 15:13 UTC #3 lore raw

PATCH 2/6 omap5912osk: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap5912osk.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

include/configs/omap5912osk.h +3 -0

index b875464..d8be4a1 100644
@@ -199,4 +199,7 @@
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 0x20000000
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 08:24 UTC #4 lore raw

PATCH 2/6 omap5912osk: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap5912osk.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap5912osk.h +5 -0

index b875464..db25b86 100644
@@ -168,6 +168,8 @@
 
 #define CONFIG_SYS_MONITOR_BASE       CONFIG_SYS_FLASH_BASE  /* Monitor at beginning of flash */
 
+#define PHYS_SRAM		0x20000000
+
 /*-----------------------------------------------------------------------
  * FLASH driver setup
  */

@@ -199,4 +201,7 @@
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR PHYS_SRAM
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-07 15:13 UTC #5 lore raw

PATCH 3/6 omap1510inn: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap1510inn.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

include/configs/omap1510inn.h +3 -0

index 9ff4f84..7a215ef 100644
@@ -190,4 +190,7 @@
 #define CONFIG_ENV_SIZE		CONFIG_ENV_SECT_SIZE
 #define CONFIG_ENV_OFFSET		( CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN )	/* Environment after Monitor */
 
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 0x20000000
+
 #endif	/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 08:24 UTC #6 lore raw

PATCH 3/6 omap1510inn: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap1510inn.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap1510inn.h +5 -0

index 9ff4f84..62c1721 100644
@@ -161,6 +161,8 @@
 
 #define CONFIG_SYS_FLASH_BASE		PHYS_FLASH_1
 
+#define PHYS_SRAM		0x20000000
+
 /*-----------------------------------------------------------------------
  * FLASH and environment organization
  */

@@ -190,4 +192,7 @@
 #define CONFIG_ENV_SIZE		CONFIG_ENV_SECT_SIZE
 #define CONFIG_ENV_OFFSET		( CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN )	/* Environment after Monitor */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif	/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Albert ARIBAUD

2011-06-08 20:20 UTC #7 lore raw

cover OMAP: fix build breaks on OMAP boards

In reply to Aneesh V

Hi Aneesh,

Le 07/06/2011 17:13, Aneesh V a ?crit :

Quoted 21 lines

Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:
CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR
They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.
None of these have been tested as I do not have any of these boards.
Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks

Quoted 7 lines

  include/configs/omap1510inn.h |    3 +++
  include/configs/omap1610h2.h  |    3 +++
  include/configs/omap1610inn.h |    3 +++
  include/configs/omap2420h4.h  |    3 +++
  include/configs/omap5912osk.h |    3 +++
  include/configs/omap730p2.h   |    3 +++
  6 files changed, 18 insertions(+), 0 deletions(-)

Could you post a V2 series with a symbolic constant rather than a magic number for SP? Something like:

...
#define PHYS_SRAM 0x20000000
...
#define CONFIG_SYS_INIT_SP_ADDR PHYS_SRAM

... so that readers of the code know exactly that SP is set to SRAM base.

Amicalement,

Signature · 1 line

Albert.

Aneesh V

author

2011-06-09 07:52 UTC #8 lore raw

cover OMAP: fix build breaks on OMAP boards

Quoted 35 lines · Albert ARIBAUD

Hi Aneesh,
Le 07/06/2011 17:13, Aneesh V a ?crit :
Quoted 21 lines
Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:
CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR
They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.
None of these have been tested as I do not have any of these boards.
Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks
Quoted 7 lines
include/configs/omap1510inn.h | 3 +++ include/configs/omap1610h2.h | 3 +++ include/configs/omap1610inn.h | 3 +++ include/configs/omap2420h4.h | 3 +++ include/configs/omap5912osk.h | 3 +++ include/configs/omap730p2.h | 3 +++
6 files changed, 18 insertions(+), 0 deletions(-)
Could you post a V2 series with a symbolic constant rather than a magic number for SP? Something like:

Quoted 7 lines

...
#define PHYS_SRAM 0x20000000
...
#define CONFIG_SYS_INIT_SP_ADDR PHYS_SRAM
... so that readers of the code know exactly that SP is set to SRAM base.

Will do.

Thanks,
Aneesh

Aneesh V

author

2011-06-09 08:24 UTC #9 lore raw

cover OMAP: fix build breaks on OMAP boards

In reply to Aneesh V

Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:

CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR

They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.

None of these have been tested as I do not have any of these boards.

V2:
* Replaced the magic number used for CONFIG_SYS_INIT_SP_ADDR with a symbolic name - PHYS_SRAM - indicating that SRAM is used for the intial stack. Made this change in all the patches.

Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks

 include/configs/omap1510inn.h |    5 +++++
 include/configs/omap1610h2.h  |    5 +++++
 include/configs/omap1610inn.h |    3 +++
 include/configs/omap2420h4.h  |    4 ++++
 include/configs/omap5912osk.h |    5 +++++
 include/configs/omap730p2.h   |    5 +++++
 6 files changed, 27 insertions(+), 0 deletions(-)

Aneesh V

author

2011-06-07 15:13 UTC #10 lore raw

PATCH 4/6 omap1610inn: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap1610inn.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

include/configs/omap1610inn.h +3 -0

index 0b41c46..22be002 100644
@@ -194,4 +194,7 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 0x20000000
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 08:24 UTC #11 lore raw

PATCH 4/6 omap1610inn: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap1610inn.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

include/configs/omap1610inn.h +3 -0

index 0b41c46..9b9c8d1 100644
@@ -194,4 +194,7 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	0x20000000
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-07 15:13 UTC #12 lore raw

PATCH 5/6 omap2420h4: fix build breaks

In reply to Aneesh V

DRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap2420h4.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

include/configs/omap2420h4.h +3 -0

index 2888c7b..6ac75a6 100644
@@ -271,4 +271,7 @@
 #define MTDPARTS_DEFAULT	"mtdparts=omap2420-1:-(jffs2)"
 */
 
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 0x4020F800
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 08:24 UTC #13 lore raw

PATCH 5/6 omap2420h4: fix build breaks

In reply to Aneesh V

DRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap2420h4.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

include/configs/omap2420h4.h +4 -0

index 2888c7b..01f402b 100644
@@ -220,6 +220,7 @@
 #define PHYS_FLASH_2             (H4_CS0_BASE+SZ_32M) /* same cs, 2 chips in series */
 #define PHYS_FLASH_SIZE_2        SZ_32M
 
+#define PHYS_SRAM		0x4020F800
 /*-----------------------------------------------------------------------
  * FLASH and environment organization
  */

@@ -271,4 +272,7 @@
 #define MTDPARTS_DEFAULT	"mtdparts=omap2420-1:-(jffs2)"
 */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-07 15:13 UTC #14 lore raw

PATCH 6/6 omap730p2: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap730p2.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

include/configs/omap730p2.h +3 -0

index fa3681e..56ec3a9 100644
@@ -200,4 +200,7 @@
 #define CONFIG_ENV_SIZE		   0x20000	  /* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET		   0x20000	  /* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 0x20000000
+
 #endif	  /* ! __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 08:24 UTC #15 lore raw

PATCH 6/6 omap730p2: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap730p2.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap730p2.h +5 -0

index fa3681e..bf8e000 100644
@@ -180,6 +180,8 @@
 #error Unknown Boot Chip-Select number
 #endif
 
+#define PHYS_SRAM		0x20000000
+
 #define CONFIG_SYS_FLASH_BASE		   PHYS_FLASH_1
 
 /*-----------------------------------------------------------------------

@@ -200,4 +202,7 @@
 #define CONFIG_ENV_SIZE		   0x20000	  /* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET		   0x20000	  /* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif	  /* ! __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 11:24 UTC #16 lore raw

v3 cover OMAP: fix build breaks on OMAP boards

In reply to Aneesh V

Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:

CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR

They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.

None of these have been tested as I do not have any of these boards.

V2:
* Replaced the magic number used for CONFIG_SYS_INIT_SP_ADDR with a symbolic name - PHYS_SRAM - indicating that SRAM is used for the intial stack. Made this change in all the patches.
V3:
* Missed doing the V2 change for omap1610inn. Fixed that

Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks

 include/configs/omap1510inn.h |    5 +++++
 include/configs/omap1610h2.h  |    5 +++++
 include/configs/omap1610inn.h |    5 +++++
 include/configs/omap2420h4.h  |    4 ++++
 include/configs/omap5912osk.h |    5 +++++
 include/configs/omap730p2.h   |    5 +++++
 6 files changed, 29 insertions(+), 0 deletions(-)

Albert ARIBAUD

2011-06-13 10:59 UTC #17 lore raw

v3 cover OMAP: fix build breaks on OMAP boards

Hi Aneesh,

Le 09/06/2011 13:24, Aneesh V a ?crit :

Quoted 29 lines

Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:
CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR
They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.
None of these have been tested as I do not have any of these boards.
V2:
* Replaced the magic number used for CONFIG_SYS_INIT_SP_ADDR with a symbolic name - PHYS_SRAM - indicating that SRAM is used for the intial stack. Made this change in all the patches.
V3:
* Missed doing the V2 change for omap1610inn. Fixed that
Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks

Quoted 7 lines

  include/configs/omap1510inn.h |    5 +++++
  include/configs/omap1610h2.h  |    5 +++++
  include/configs/omap1610inn.h |    5 +++++
  include/configs/omap2420h4.h  |    4 ++++
  include/configs/omap5912osk.h |    5 +++++
  include/configs/omap730p2.h   |    5 +++++
  6 files changed, 29 insertions(+), 0 deletions(-)

Hmm, seems like they don't apply cleanly above current u-boot-arm/master. Can you rebase and resend as V4 ?

Amicalement,

Signature · 1 line

Albert.

Aneesh V

author

2011-06-13 11:12 UTC #18 lore raw

v3 cover OMAP: fix build breaks on OMAP boards

Quoted 40 lines · Albert ARIBAUD

Hi Aneesh,
Le 09/06/2011 13:24, Aneesh V a ?crit :
Quoted 29 lines
Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:
CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR
They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.
None of these have been tested as I do not have any of these boards.
V2:
* Replaced the magic number used for CONFIG_SYS_INIT_SP_ADDR with a symbolic name - PHYS_SRAM - indicating that SRAM is used for the intial stack. Made this change in all the patches.
V3:
* Missed doing the V2 change for omap1610inn. Fixed that
Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks
Quoted 7 lines
include/configs/omap1510inn.h | 5 +++++
include/configs/omap1610h2.h | 5 +++++
include/configs/omap1610inn.h | 5 +++++
include/configs/omap2420h4.h | 4 ++++
include/configs/omap5912osk.h | 5 +++++
include/configs/omap730p2.h | 5 +++++
6 files changed, 29 insertions(+), 0 deletions(-)

Quoted 2 lines

Hmm, seems like they don't apply cleanly above current u-boot-arm/master. Can you rebase and resend as V4 ?

Sure.

br,
Aneesh

Aneesh V

author

2011-06-13 11:17 UTC #19 lore raw

v3 cover OMAP: fix build breaks on OMAP boards

In reply to Albert ARIBAUD

Hi Albert,

Quoted 40 lines · Albert ARIBAUD

Hi Aneesh,
Le 09/06/2011 13:24, Aneesh V a ?crit :
Quoted 29 lines
Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:
CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR
They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.
None of these have been tested as I do not have any of these boards.
V2:
* Replaced the magic number used for CONFIG_SYS_INIT_SP_ADDR with a symbolic name - PHYS_SRAM - indicating that SRAM is used for the intial stack. Made this change in all the patches.
V3:
* Missed doing the V2 change for omap1610inn. Fixed that
Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks
Quoted 7 lines
include/configs/omap1510inn.h | 5 +++++
include/configs/omap1610h2.h | 5 +++++
include/configs/omap1610inn.h | 5 +++++
include/configs/omap2420h4.h | 4 ++++
include/configs/omap5912osk.h | 5 +++++
include/configs/omap730p2.h | 5 +++++
6 files changed, 29 insertions(+), 0 deletions(-)

Quoted 2 lines

Hmm, seems like they don't apply cleanly above current u-boot-arm/master. Can you rebase and resend as V4 ?

I see that my patches are already applied there?

br,
Aneesh

Albert ARIBAUD

2011-06-13 11:58 UTC #20 lore raw

v3 cover OMAP: fix build breaks on OMAP boards

Le 13/06/2011 13:17, Aneesh V a ?crit :

Quoted 43 lines

Hi Albert,
Quoted 40 lines · Albert ARIBAUD
Hi Aneesh,
Le 09/06/2011 13:24, Aneesh V a ?crit :
Quoted 36 lines
Fix build breaks for OMAP boards.
All the build breaks were due to couple of missing defines in the config file, namely:
CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR
They have been fixed by providing the right SDRAM base address and by using SRAM base as the initial stack address.
None of these have been tested as I do not have any of these boards.
V2:
* Replaced the magic number used for CONFIG_SYS_INIT_SP_ADDR with a symbolic name - PHYS_SRAM - indicating that SRAM is used for the intial stack. Made this change in all the patches.
V3:
* Missed doing the V2 change for omap1610inn. Fixed that
Aneesh V (6):
omap1610h2: fix build breaks
omap5912osk: fix build breaks
omap1510inn: fix build breaks
omap1610inn: fix build breaks
omap2420h4: fix build breaks
omap730p2: fix build breaks
include/configs/omap1510inn.h | 5 +++++
include/configs/omap1610h2.h | 5 +++++
include/configs/omap1610inn.h | 5 +++++
include/configs/omap2420h4.h | 4 ++++
include/configs/omap5912osk.h | 5 +++++
include/configs/omap730p2.h | 5 +++++
6 files changed, 29 insertions(+), 0 deletions(-)

Quoted 7 lines

Quoted 2 lines
Hmm, seems like they don't apply cleanly above current u-boot-arm/master. Can you rebase and resend as V4 ?
I see that my patches are already applied there?
br,
Aneesh

Oops. They were in the u-boot-ti pull request I /just/ applied. Please bear with me while I hit my forehead on my desk repeatedly.

Amicalement,

Signature · 1 line

Albert.

Aneesh V

author

2011-06-09 11:24 UTC #21 lore raw

PATCH v3 1/6 omap1610h2: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

---
 include/configs/omap1610h2.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap1610h2.h +5 -0

index 2936dcc..cb2a07f 100644
@@ -172,6 +172,8 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 
 #endif
 
+#define PHYS_SRAM		0x20000000
+
 /*-----------------------------------------------------------------------
  * FLASH and environment organization
  */

@@ -189,4 +191,7 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 11:24 UTC #22 lore raw

PATCH v3 2/6 omap5912osk: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap5912osk.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap5912osk.h +5 -0

index b875464..db25b86 100644
@@ -168,6 +168,8 @@
 
 #define CONFIG_SYS_MONITOR_BASE       CONFIG_SYS_FLASH_BASE  /* Monitor at beginning of flash */
 
+#define PHYS_SRAM		0x20000000
+
 /*-----------------------------------------------------------------------
  * FLASH driver setup
  */

@@ -199,4 +201,7 @@
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR PHYS_SRAM
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 11:24 UTC #23 lore raw

PATCH v3 3/6 omap1510inn: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap1510inn.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap1510inn.h +5 -0

index 9ff4f84..62c1721 100644
@@ -161,6 +161,8 @@
 
 #define CONFIG_SYS_FLASH_BASE		PHYS_FLASH_1
 
+#define PHYS_SRAM		0x20000000
+
 /*-----------------------------------------------------------------------
  * FLASH and environment organization
  */

@@ -190,4 +192,7 @@
 #define CONFIG_ENV_SIZE		CONFIG_ENV_SECT_SIZE
 #define CONFIG_ENV_OFFSET		( CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN )	/* Environment after Monitor */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif	/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 11:24 UTC #24 lore raw

PATCH v3 4/6 omap1610inn: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap1610inn.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap1610inn.h +5 -0

index 0b41c46..e82b4b2 100644
@@ -177,6 +177,8 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 
 #endif
 
+#define PHYS_SRAM		0x20000000
+
 /*-----------------------------------------------------------------------
  * FLASH and environment organization
  */

@@ -194,4 +196,7 @@ extern unsigned long omap_flash_base;		/* set in flash__init */
 #define CONFIG_ENV_SIZE	0x20000	/* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET	0x20000	/* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 11:24 UTC #25 lore raw

PATCH v3 5/6 omap2420h4: fix build breaks

In reply to Aneesh V

DRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap2420h4.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

include/configs/omap2420h4.h +4 -0

index 2888c7b..01f402b 100644
@@ -220,6 +220,7 @@
 #define PHYS_FLASH_2             (H4_CS0_BASE+SZ_32M) /* same cs, 2 chips in series */
 #define PHYS_FLASH_SIZE_2        SZ_32M
 
+#define PHYS_SRAM		0x4020F800
 /*-----------------------------------------------------------------------
  * FLASH and environment organization
  */

@@ -271,4 +272,7 @@
 #define MTDPARTS_DEFAULT	"mtdparts=omap2420-1:-(jffs2)"
 */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif							/* __CONFIG_H */

Signature · 1 line

1.7.0.4

Aneesh V

author

2011-06-09 11:24 UTC #26 lore raw

PATCH v3 6/6 omap730p2: fix build breaks

In reply to Aneesh V

Provide SDRAM base address and use SRAM for initial stack

Signed-off-by Aneesh V <[email protected]>

---
 include/configs/omap730p2.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

include/configs/omap730p2.h +5 -0

index fa3681e..bf8e000 100644
@@ -180,6 +180,8 @@
 #error Unknown Boot Chip-Select number
 #endif
 
+#define PHYS_SRAM		0x20000000
+
 #define CONFIG_SYS_FLASH_BASE		   PHYS_FLASH_1
 
 /*-----------------------------------------------------------------------

@@ -200,4 +202,7 @@
 #define CONFIG_ENV_SIZE		   0x20000	  /* Total Size of Environment Sector */
 #define CONFIG_ENV_OFFSET		   0x20000	  /* environment starts here  */
 
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR 	PHYS_SRAM
+
 #endif	  /* ! __CONFIG_H */

Signature · 1 line

1.7.0.4