Add Highbank platform

From: Rob Herring <[email protected]>

Move the register definitions into the sdhci.c file. Set the base address from the board init code.

The Samsung SDHCI controller has extra registers. Make them conditional on CONFIG_MMC_S5P.

Signed-off-by Rob Herring <[email protected]>

---

?arch/arm/include/asm/arch-s5pc1xx/mmc.h ?| ? 73 --------------------------
?arch/arm/include/asm/arch-s5pc2xx/mmc.h ?| ? 73 --------------------------
?board/samsung/goni/goni.c ? ? ? ? ? ? ? ?| ? ?4 +-
?board/samsung/universal_c210/universal.c | ? ?8 ++-
?drivers/mmc/sdhci.c ? ? ? ? ? ? ? ? ? ? ?| ? 82 +++++++++++++++++++++++-------
?include/sdhci.h ? ? ? ? ? ? ? ? ? ? ? ? ?| ? 18 +++++++

?6 files changed, 89 insertions(+), 169 deletions(-) ?delete mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h ?delete mode 100644 arch/arm/include/asm/arch-s5pc2xx/mmc.h ?create mode 100644 include/sdhci.h

board/samsung/universal_c210/universal.c +0 -0

index b65bc6e..b0e76e8 100644
@@ -23,10 +23,10 @@

?*/

?#include <common.h>
+#include <sdhci.h>
?#include <asm/io.h>
?#include <asm/arch/adc.h>
?#include <asm/arch/gpio.h>
-#include <asm/arch/mmc.h>

?DECLARE_GLOBAL_DATA_PTR;

board/samsung/universal_c210/universal.c +1 -0

@@ -151,6 +151,7 @@ int checkboard(void)
 ?int board_mmc_init(bd_t *bis)
 ?{
 ? ? ? ?int i, err;
+ ? ? ? u32 base;
 
 ? ? ? ?switch (get_hwrev()) {

? ? ? ?case 0:

board/samsung/universal_c210/universal.c +0 -0

@@ -217,7 +218,8 @@ int board_mmc_init(bd_t *bis)
 ? ? ? ? * mmc0 ?: eMMC (8-bit buswidth)
 ? ? ? ? * mmc2 ?: SD card (4-bit buswidth)

? ? ? ? */
- ? ? ? err = s5p_mmc_init(0, 8);
+ ? ? ? base = samsung_get_base_mmc();
+ ? ? ? err = sdhci_mmc_init((void *)base, 8);

? ? ? ?/*
? ? ? ? * Check the T-flash ?detect pin

board/samsung/universal_c210/universal.c +0 -0

@@ -241,7 +243,7 @@ int board_mmc_init(bd_t *bis)

? ? ? ? ? ? ? ? ? ? ? ?/* GPK2[0:6] drv 4x */
? ? ? ? ? ? ? ? ? ? ? ?gpio_set_drv(&gpio2->k2, i, GPIO_DRV_4X); ? ? ? ? ? ? ? ?}
- ? ? ? ? ? ? ? err = s5p_mmc_init(2, 4);
+ ? ? ? ? ? ? ? err = sdhci_mmc_init((void *)(base + 0x20000), 4);

? ? ? ?}

? ? ? ?return err;

drivers/mmc/sdhci.c +0 -0

index 280738f..c82bde0 100644
@@ -21,18 +21,56 @@

?#include <common.h>
?#include <mmc.h>
?#include <asm/io.h>
-#include <asm/arch/mmc.h>
?#include <asm/arch/clk.h>

drivers/mmc/sdhci.c +33 -0

+struct sdhci_mmc {
+ ? ? ? unsigned int ? ?sysad;
+ ? ? ? unsigned short ?blksize;
+ ? ? ? unsigned short ?blkcnt;
+ ? ? ? unsigned int ? ?argument;
+ ? ? ? unsigned short ?trnmod;
+ ? ? ? unsigned short ?cmdreg;
+ ? ? ? unsigned int ? ?rspreg0;
+ ? ? ? unsigned int ? ?rspreg1;
+ ? ? ? unsigned int ? ?rspreg2;
+ ? ? ? unsigned int ? ?rspreg3;
+ ? ? ? unsigned int ? ?bdata;
+ ? ? ? unsigned int ? ?prnsts;
+ ? ? ? unsigned char ? hostctl;
+ ? ? ? unsigned char ? pwrcon;
+ ? ? ? unsigned char ? blkgap;
+ ? ? ? unsigned char ? wakcon;
+ ? ? ? unsigned short ?clkcon;
+ ? ? ? unsigned char ? timeoutcon;
+ ? ? ? unsigned char ? swrst;
+ ? ? ? unsigned int ? ?norintsts; ? ? ?/* errintsts */
+ ? ? ? unsigned int ? ?norintstsen; ? ?/* errintstsen */
+ ? ? ? unsigned int ? ?norintsigen; ? ?/* errintsigen */
+ ? ? ? unsigned short ?acmd12errsts;
+ ? ? ? unsigned char ? res1[2];
+ ? ? ? unsigned int ? ?capareg;
+ ? ? ? unsigned char ? res2[4];
+ ? ? ? unsigned int ? ?maxcurr;
+ ? ? ? unsigned char ? res3[0x34];
+ ? ? ? unsigned int ? ?control2;
+ ? ? ? unsigned int ? ?control3;
+ ? ? ? unsigned char ? res4[4];
+ ? ? ? unsigned int ? ?control4;

+
?/* support 4 mmc hosts */
?struct mmc mmc_dev[4];
?struct mmc_host mmc_host[4];

drivers/mmc/sdhci.c +1 -6

-
-static inline struct s5p_mmc *s5p_get_base_mmc(int dev_index)
-{
- ? ? ? unsigned long offset = dev_index * sizeof(struct s5p_mmc);
- ? ? ? return (struct s5p_mmc *)(samsung_get_base_mmc() + offset);
-}
+int dev_count;

?static void mmc_prepare_data(struct mmc_host *host, struct mmc_data *data) ?{

drivers/mmc/sdhci.c +1 -0

@@ -255,6 +293,7 @@ static void mmc_change_clock(struct mmc_host *host, uint clock)
 ? ? ? ?unsigned long timeout;
 ? ? ? ?unsigned long ctrl2;
 
+#ifdef CONFIG_S5P_MMC

? ? ? ?/*
? ? ? ? * SELBASECLK[5:4]
? ? ? ? * 00/01 = HCLK

drivers/mmc/sdhci.c +1 -1

@@ -265,7 +304,7 @@ static void mmc_change_clock(struct mmc_host *host, uint clock)
 ? ? ? ?ctrl2 &= ~(3 << 4);
 ? ? ? ?ctrl2 |= (2 << 4);
 ? ? ? ?writel(ctrl2, &host->reg->control2);
-
+#endif
 ? ? ? ?writew(0, &host->reg->clkcon);
 

? ? ? ?/* XXX: we assume that clock is between 40MHz and 50MHz */

drivers/mmc/sdhci.c +1 -0

@@ -320,6 +359,7 @@ static void mmc_set_ios(struct mmc *mmc)
 
 ? ? ? ?debug("bus_width: %x, clock: %d\n", mmc->bus_width, mmc->clock);
 
+#ifdef CONFIG_S5P_MMC

? ? ? ?/*
? ? ? ? * SELCLKPADDS[17:16]
? ? ? ? * 00 = 2mA

drivers/mmc/sdhci.c +0 -0

@@ -349,7 +389,7 @@ static void mmc_set_ios(struct mmc *mmc)
 ? ? ? ? * ? ? ?10 = Delay4 (inverter delay + 2ns)

? ? ? ? */
? ? ? ?writel(0x8080, &host->reg->control3);

drivers/mmc/sdhci.c +1 -1

-
+#endif

? ? ? ?mmc_change_clock(host, mmc->clock);

? ? ? ?ctrl = readb(&host->reg->hostctl);

drivers/mmc/sdhci.c +1 -1

@@ -445,14 +485,21 @@ static int mmc_core_init(struct mmc *mmc)
 ? ? ? ?return 0;
 ?}
 
-static int s5p_mmc_initialize(int dev_index, int bus_width)
+static int sdhci_mmc_initialize(void *base, int bus_width)
 ?{
 ? ? ? ?struct mmc *mmc;

drivers/mmc/sdhci.c +2 -2

- ? ? ? mmc_host[dev_index].clock = 0;
- ? ? ? mmc_host[dev_index].reg = s5p_get_base_mmc(dev_index);
+ ? ? ? host->clock = 0;
+ ? ? ? host->reg = base;
 ? ? ? ?mmc->b_max = 0;
 ? ? ? ?mmc_register(mmc);

Dear Rob Herring,

Quoted 56 lines · Rob Herring

From: Rob Herring<[email protected]>

Move the register definitions into the sdhci.c file. Set the base address from the board init code.

The Samsung SDHCI controller has extra registers. Make them conditional on CONFIG_MMC_S5P.

Signed-off-by Rob Herring<[email protected]>

---
  arch/arm/include/asm/arch-s5pc1xx/mmc.h  |   73 --------------------------
  arch/arm/include/asm/arch-s5pc2xx/mmc.h  |   73 --------------------------
  board/samsung/goni/goni.c                |    4 +-
  board/samsung/universal_c210/universal.c |    8 ++-
  drivers/mmc/sdhci.c                      |   82 +++++++++++++++++++++++-------
  include/sdhci.h                          |   18 +++++++
  6 files changed, 89 insertions(+), 169 deletions(-)

delete mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h delete mode 100644 arch/arm/include/asm/arch-s5pc2xx/mmc.h create mode 100644 include/sdhci.h

board/samsung/universal_c210/universal.c +4 -2

index b65bc6e..b0e76e8 100644
@@ -23,10 +23,10 @@
  */
 
  #include<common.h>
+#include<sdhci.h>
  #include<asm/io.h>
  #include<asm/arch/adc.h>
  #include<asm/arch/gpio.h>
-#include<asm/arch/mmc.h>
 
  DECLARE_GLOBAL_DATA_PTR;
 

@@ -151,6 +151,7 @@ int checkboard(void)
  int board_mmc_init(bd_t *bis)
  {
        int i, err;
+       u32 base;
 
        switch (get_hwrev()) {
        case 0:

@@ -217,7 +218,8 @@ int board_mmc_init(bd_t *bis)
         * mmc0  : eMMC (8-bit buswidth)
         * mmc2  : SD card (4-bit buswidth)
         */
-       err = s5p_mmc_init(0, 8);
+       base = samsung_get_base_mmc();
+       err = sdhci_mmc_init((void *)base, 8);
 
        /*
         * Check the T-flash  detect pin

board/samsung/universal_c210/universal.c int board_mmc_init(bd_t *bis) · line 246

Quoted 5 lines

board/samsung/universal_c210/universal.c +1 -1

@@ -241,7 +243,7 @@ int board_mmc_init(bd_t *bis)
                        /* GPK2[0:6] drv 4x */
                        gpio_set_drv(&gpio2->k2, i, GPIO_DRV_4X);
                }
-               err = s5p_mmc_init(2, 4);
+               err = sdhci_mmc_init((void *)(base + 0x20000), 4);

No, please use the macro instead of constant. (pass the device number to macro)

Quoted 51 lines

board/samsung/universal_c210/universal.c +0 -0

        }
 
        return err;

drivers/mmc/sdhci.c +37 -1

index 280738f..c82bde0 100644
@@ -21,18 +21,56 @@
  #include<common.h>
  #include<mmc.h>
  #include<asm/io.h>
-#include<asm/arch/mmc.h>
  #include<asm/arch/clk.h>
 
+struct sdhci_mmc {
+       unsigned int    sysad;
+       unsigned short  blksize;
+       unsigned short  blkcnt;
+       unsigned int    argument;
+       unsigned short  trnmod;
+       unsigned short  cmdreg;
+       unsigned int    rspreg0;
+       unsigned int    rspreg1;
+       unsigned int    rspreg2;
+       unsigned int    rspreg3;
+       unsigned int    bdata;
+       unsigned int    prnsts;
+       unsigned char   hostctl;
+       unsigned char   pwrcon;
+       unsigned char   blkgap;
+       unsigned char   wakcon;
+       unsigned short  clkcon;
+       unsigned char   timeoutcon;
+       unsigned char   swrst;
+       unsigned int    norintsts;      /* errintsts */
+       unsigned int    norintstsen;    /* errintstsen */
+       unsigned int    norintsigen;    /* errintsigen */
+       unsigned short  acmd12errsts;
+       unsigned char   res1[2];
+       unsigned int    capareg;
+       unsigned char   res2[4];
+       unsigned int    maxcurr;
+       unsigned char   res3[0x34];
+       unsigned int    control2;
+       unsigned int    control3;
+       unsigned char   res4[4];
+       unsigned int    control4;
+       unsigned char   res5[0x6e];
+       unsigned short  hcver;
+};
+

drivers/mmc/sdhci.c line 68

Quoted 6 lines

drivers/mmc/sdhci.c +6 -0

+struct mmc_host {
+       struct sdhci_mmc *reg;
+       unsigned int version;   /* SDHCI spec. version */
+       unsigned int clock;     /* Current clock (MHz) */
+       int dev_index;
+};

Please move this structures to header file.

Quoted 62 lines

drivers/mmc/sdhci.c +11 -9

+
  /* support 4 mmc hosts */
  struct mmc mmc_dev[4];
  struct mmc_host mmc_host[4];
-
-static inline struct s5p_mmc *s5p_get_base_mmc(int dev_index)
-{
-       unsigned long offset = dev_index * sizeof(struct s5p_mmc);
-       return (struct s5p_mmc *)(samsung_get_base_mmc() + offset);
-}
+int dev_count;
 
  static void mmc_prepare_data(struct mmc_host *host, struct mmc_data *data)
  {

@@ -255,6 +293,7 @@ static void mmc_change_clock(struct mmc_host *host, uint clock)
        unsigned long timeout;
        unsigned long ctrl2;
 
+#ifdef CONFIG_S5P_MMC
        /*
         * SELBASECLK[5:4]
         * 00/01 = HCLK

@@ -265,7 +304,7 @@ static void mmc_change_clock(struct mmc_host *host, uint clock)
        ctrl2&= ~(3<<  4);
        ctrl2 |= (2<<  4);
        writel(ctrl2,&host->reg->control2);
-
+#endif
        writew(0,&host->reg->clkcon);
 
        /* XXX: we assume that clock is between 40MHz and 50MHz */

@@ -320,6 +359,7 @@ static void mmc_set_ios(struct mmc *mmc)
 
        debug("bus_width: %x, clock: %d\n", mmc->bus_width, mmc->clock);
 
+#ifdef CONFIG_S5P_MMC
        /*
         * SELCLKPADDS[17:16]
         * 00 = 2mA

@@ -349,7 +389,7 @@ static void mmc_set_ios(struct mmc *mmc)
         *      10 = Delay4 (inverter delay + 2ns)
         */
        writel(0x8080,&host->reg->control3);
-
+#endif
        mmc_change_clock(host, mmc->clock);
 
        ctrl = readb(&host->reg->hostctl);

@@ -445,14 +485,21 @@ static int mmc_core_init(struct mmc *mmc)
        return 0;
  }
 
-static int s5p_mmc_initialize(int dev_index, int bus_width)
+static int sdhci_mmc_initialize(void *base, int bus_width)
  {
        struct mmc *mmc;
+       struct mmc_host *host;
+
+       if (dev_count>= 4)
+               return -1;
 

drivers/mmc/sdhci.c static int mmc_core_init(struct mmc *mmc) · line 499

Quoted 5 lines

drivers/mmc/sdhci.c +4 -1

-       mmc =&mmc_dev[dev_index];
+       mmc =&mmc_dev[dev_count];
+       host =&mmc_host[dev_count];
+       host->dev_index = dev_count;
+       dev_count++;

NAK.
dev_index is not a count number, it's a h/w device number. This change is wrong. (Maybe you misunderstood this concept) Please keep the dev_index.

Quoted 52 lines · Minkyu Kang

Dear Rob Herring,

Quoted 48 lines · On 12 June 2011 06:46, Rob Herring<[email protected]> ?wrote:

drivers/mmc/sdhci.c +0 -0

index 280738f..c82bde0 100644
@@ -21,18 +21,56 @@

?#include<common.h>
?#include<mmc.h>
?#include<asm/io.h>
-#include<asm/arch/mmc.h>
?#include<asm/arch/clk.h>

drivers/mmc/sdhci.c +37 -0

+struct sdhci_mmc {
+ ? ? ? unsigned int ? ?sysad;
+ ? ? ? unsigned short ?blksize;
+ ? ? ? unsigned short ?blkcnt;
+ ? ? ? unsigned int ? ?argument;
+ ? ? ? unsigned short ?trnmod;
+ ? ? ? unsigned short ?cmdreg;
+ ? ? ? unsigned int ? ?rspreg0;
+ ? ? ? unsigned int ? ?rspreg1;
+ ? ? ? unsigned int ? ?rspreg2;
+ ? ? ? unsigned int ? ?rspreg3;
+ ? ? ? unsigned int ? ?bdata;
+ ? ? ? unsigned int ? ?prnsts;
+ ? ? ? unsigned char ? hostctl;
+ ? ? ? unsigned char ? pwrcon;
+ ? ? ? unsigned char ? blkgap;
+ ? ? ? unsigned char ? wakcon;
+ ? ? ? unsigned short ?clkcon;
+ ? ? ? unsigned char ? timeoutcon;
+ ? ? ? unsigned char ? swrst;
+ ? ? ? unsigned int ? ?norintsts; ? ? ?/* errintsts */
+ ? ? ? unsigned int ? ?norintstsen; ? ?/* errintstsen */
+ ? ? ? unsigned int ? ?norintsigen; ? ?/* errintsigen */
+ ? ? ? unsigned short ?acmd12errsts;
+ ? ? ? unsigned char ? res1[2];
+ ? ? ? unsigned int ? ?capareg;
+ ? ? ? unsigned char ? res2[4];
+ ? ? ? unsigned int ? ?maxcurr;
+ ? ? ? unsigned char ? res3[0x34];
+ ? ? ? unsigned int ? ?control2;
+ ? ? ? unsigned int ? ?control3;
+ ? ? ? unsigned char ? res4[4];
+ ? ? ? unsigned int ? ?control4;
+ ? ? ? unsigned char ? res5[0x6e];
+ ? ? ? unsigned short ?hcver;
+};
+

Quoted 8 lines

drivers/mmc/sdhci.c

Quoted 6 lines

drivers/mmc/sdhci.c +6 -0

+struct mmc_host {
+ ? ? ? struct sdhci_mmc *reg;
+ ? ? ? unsigned int version; ? /* SDHCI spec. version */
+ ? ? ? unsigned int clock; ? ? /* Current clock (MHz) */
+ ? ? ? int dev_index;
+};

Please move this structures to header file.

Why? There is no header anymore. These structures are only used within the .c file, so there is no point in having a header. They were almost the same before and just duplicated code. The only difference was padding added to the end of the struct used to calculate base address and the 2nd controller. Using the size of the struct to calculate base addresses doesn't work for all platforms. The fact that there were already 2 structs for 2 platforms is evidence of that.

Quoted 9 lines

Quoted 9 lines

drivers/mmc/sdhci.c +1 -1

-static int s5p_mmc_initialize(int dev_index, int bus_width)
+static int sdhci_mmc_initialize(void *base, int bus_width)

?{
? ? ? ?struct mmc *mmc;
+ ? ? ? struct mmc_host *host;
+
+ ? ? ? if (dev_count>= 4)
+ ? ? ? ? ? ? ? return -1;

Quoted 11 lines

Quoted 5 lines

- ? ? ? mmc =&mmc_dev[dev_index];
+ ? ? ? mmc =&mmc_dev[dev_count];
+ ? ? ? host =&mmc_host[dev_count];
+ ? ? ? host->dev_index = dev_count;
+ ? ? ? dev_count++;

NAK.
dev_index is not a count number, it's a h/w device number. This change is wrong. (Maybe you misunderstood this concept) Please keep the dev_index.

What have I broken? The only thing the index was used for was getting the base address and indexing to driver struct. I've simply pulled out the base address from the driver so the board code can specify it. You still have an index that is controlled by order the board code initializes each controller.

?arch/arm/include/asm/arch-s5pc1xx/mmc.h ?| ? 73 ------------------------------
?arch/arm/include/asm/arch-s5pc2xx/cpu.h ?| ? ?4 ++
?arch/arm/include/asm/arch-s5pc2xx/mmc.h ?| ? 73 ------------------------------
?board/samsung/goni/goni.c ? ? ? ? ? ? ? ?| ? ?4 +-
?board/samsung/universal_c210/universal.c | ? ?6 +-
?drivers/mmc/sdhci.c ? ? ? ? ? ? ? ? ? ? ?| ? 31 +++++++------
?include/sdhci.h ? ? ? ? ? ? ? ? ? ? ? ? ?| ? 62 +++++++++++++++++++++++++

?7 files changed, 88 insertions(+), 165 deletions(-) ?delete mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h ?delete mode 100644 arch/arm/include/asm/arch-s5pc2xx/mmc.h ?create mode 100644 include/sdhci.h

arch/arm/include/asm/arch-s5pc2xx/cpu.h +4 -0

@@ -108,6 +108,10 @@ SAMSUNG_BASE(uart, UART_BASE)
 ?SAMSUNG_BASE(usb_phy, USBPHY_BASE)
 ?SAMSUNG_BASE(usb_otg, USBOTG_BASE)
 ?SAMSUNG_BASE(watchdog, WATCHDOG_BASE)
+
+#define samsung_get_base_mmc_offset(idx) ? ? ? (samsung_get_base_mmc() + \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?0x10000 * (idx))
+

?#endif

?#endif /* _S5PC2XX_CPU_H */

Dear Rob Herring,

Quoted 15 lines · Rob Herring

 arch/arm/include/asm/arch-s5pc1xx/mmc.h  |   73 ------------------------------
 arch/arm/include/asm/arch-s5pc2xx/cpu.h  |    4 ++
 arch/arm/include/asm/arch-s5pc2xx/mmc.h  |   73 ------------------------------
 board/samsung/goni/goni.c                |    4 +-
 board/samsung/universal_c210/universal.c |    6 +-
 drivers/mmc/sdhci.c                      |   31 +++++++------
 include/sdhci.h                          |   62 +++++++++++++++++++++++++
 7 files changed, 88 insertions(+), 165 deletions(-)
 delete mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h
 delete mode 100644 arch/arm/include/asm/arch-s5pc2xx/mmc.h
 create mode 100644 include/sdhci.h

arch/arm/include/asm/arch-s5pc2xx/cpu.h SAMSUNG_BASE(uart, UART_BASE) · line 117

Quoted 10 lines

arch/arm/include/asm/arch-s5pc2xx/cpu.h +4 -0

@@ -108,6 +108,10 @@ SAMSUNG_BASE(uart, UART_BASE)
 SAMSUNG_BASE(usb_phy, USBPHY_BASE)
 SAMSUNG_BASE(usb_otg, USBOTG_BASE)
 SAMSUNG_BASE(watchdog, WATCHDOG_BASE)
+
+#define samsung_get_base_mmc_offset(idx)       (samsung_get_base_mmc() + \
+                                                0x10000 * (idx))
+
 #endif
 
 #endif /* _S5PC2XX_CPU_H */

Looks fine.
But, missing arch/arm/include/asm/arch-s5pc1xx/cpu.h

Dear Jaehoon,

Please test this patch on s5pc1xx and s5pc2xx.

Thanks
Minkyu Kang

Tested-by Jaehoon Chung <[email protected]>

But Mr.Kang mentioned missing arch/arm/include/asm/arch-s5pc1xx/cpu.h Need the below patch..
(s5pc2xx and s5pc1xx are working well)

arch/arm/include/asm/arch-s5pc1xx/cpu.h +0 -0

index e74959f..86b7bd2 100644

Quoted 6 lines · Jaehoon Chung

Tested-by Jaehoon Chung <[email protected]>

But Mr.Kang mentioned missing arch/arm/include/asm/arch-s5pc1xx/cpu.h Need the below patch..
(s5pc2xx and s5pc1xx are working well)

arch/arm/include/asm/arch-s5pc1xx/cpu.h SAMSUNG_BASE(mmc, MMC_BASE) · line 99

Quoted 11 lines

arch/arm/include/asm/arch-s5pc1xx/cpu.h +3 -0

index e74959f..86b7bd2 100644
@@ -94,6 +94,9 @@ SAMSUNG_BASE(mmc, MMC_BASE)
 SAMSUNG_BASE(sromc, SROMC_BASE)
 SAMSUNG_BASE(timer, PWMTIMER_BASE)
 SAMSUNG_BASE(uart, UART_BASE)
+
+#define samsung_get_base_mmc_offset(idx)       (samsung_get_base_mmc() + \
+                                                0x10000 * (idx))

I think.. offset is wrong.
In case of s5pc1xx, 0x10_0000 is right.
Please check.

include/sdhci.h new file +8 -0

@@ -0,0 +1,18 @@
+/*
+ * Copyright 2011 Calxeda, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT

From: Rob Herring<[email protected]>

cpu_init_crit can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init.

Signed-off-by Rob Herring<[email protected]>

---

From: Rob Herring<[email protected]>

Add basic support for Calxeda Highbank platform. This includes support for serial, mmc, and sata.

Signed-off-by Jason Hobbs<[email protected]>

Signed-off-by Rob Herring<[email protected]>

---

Hi Rob,

Le 11/06/2011 23:46, Rob Herring a ?crit :

Quoted 6 lines

From: Rob Herring<[email protected]>

Add basic support for Calxeda Highbank platform. This includes support for
serial, mmc, and sata.

Quoted 3 lines

Signed-off-by Jason Hobbs<[email protected]>

Signed-off-by Rob Herring<[email protected]>

---

This one will get in when all previous ones in the series are applied. Please ping me as a reminder if needed.

Amicalement,