Skip to contentSkip to conversation

ASoC: Remove unused and about to be broken SND_SOC_CUSTOM I/O bus

PATCH In review Mark Brown 2 participants 2 messages Jun 13, 2011

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Remove unused and about to be broken SND_SOC_CUSTOM I/O bus

This will be removed in -next so let's drop it from mainline as soon as we can in order to minimise surprises.

---

This posting is against -next, sorry, but the update for 3.0 is trivially obvious.

 include/sound/soc.h |    3 +--
 sound/soc/soc-io.c  |    3 ---
 2 files changed, 1 insertions(+), 5 deletions(-)
include/sound/soc.h +1 -2
index 4334ab2..6424b10 100644
@@ -258,8 +258,7 @@ typedef int (*hw_write_t)(void *,const char* ,int);
 extern struct snd_ac97_bus_ops soc_ac97_ops;
 
 enum snd_soc_control_type {
-	SND_SOC_CUSTOM = 1,
-	SND_SOC_I2C,
+	SND_SOC_I2C = 1,
 	SND_SOC_SPI,
 };
 
sound/soc/soc-io.c +0 -3
index df9338a..cca490c 100644
@@ -367,9 +367,6 @@ int snd_soc_codec_set_cache_io(struct snd_soc_codec *codec,
 	codec->bulk_write_raw = snd_soc_hw_bulk_write_raw;
 
 	switch (control) {
-	case SND_SOC_CUSTOM:
-		break;
-
 	case SND_SOC_I2C:
 #if defined(CONFIG_I2C) || (defined(CONFIG_I2C_MODULE) && defined(MODULE))
 		codec->hw_write = (hw_write_t)i2c_master_send;
Signature · 1 line
1.7.5.4
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Mark Brown

This will be removed in -next so let's drop it from mainline as soon as we can in order to minimise surprises.

Quoted 9 lines

---

This posting is against -next, sorry, but the update for 3.0 is trivially obvious.

 include/sound/soc.h |    3 +--
 sound/soc/soc-io.c  |    3 ---
 2 files changed, 1 insertions(+), 5 deletions(-)