libexport.a: fix using bad index for loop at cltsetup()
Subsystems (2)
PATCH 1/1 libexport.a: fix using bad index for loop at cltsetup()
At cltsetup(), for address checking, it should use clp's naddr for index, not cltarg's naddr(and it's always zero here).
Signed-off-by Mi Jinlong <[email protected]>
--- support/export/nfsctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
support/export/nfsctl.c +1 -1
@@ -78,7 +78,7 @@ cltsetup(struct nfsctl_client *cltarg, nfs_client *clp)str_tolower (cltarg->cl_ident); j =0 ; -for (i =0 ; i < cltarg->cl_naddr && i <NFSCLNT_ADDRMAX ; i++) { +for (i =0 ; i < clp->m_naddr && i <NFSCLNT_ADDRMAX ; i++) {const struct sockaddr_in *sin =get_addrlist_in (clp, i);if (sin->sin_family ==AF_INET ) cltarg->cl_addrlist[j++] = sin->sin_addr;
Signature · 1 line
1.7.5.4
Quoted 2 lines · Mi Jinlong
At
cltsetup(), for address checking, it should use clp's naddr for index, not cltarg's naddr(and it's always zero here).
After sending this patch, I find this problem was introduced by 6299a.
Signature · 3 lines
---- thanks Mi Jinlong
Quoted 19 lines
Signed-off-by Mi Jinlong <[email protected]>--- support/export/nfsctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)support/export/nfsctl.c +1
-1@@ -78,7 +78,7 @@ cltsetup(struct nfsctl_client *cltarg, nfs_client *clp)str_tolower (cltarg->cl_ident); j =0 ; -for (i =0 ; i < cltarg->cl_naddr && i <NFSCLNT_ADDRMAX ; i++) { +for (i =0 ; i < clp->m_naddr && i <NFSCLNT_ADDRMAX ; i++) {const struct sockaddr_in *sin =get_addrlist_in (clp, i);if (sin->sin_family ==AF_INET ) cltarg->cl_addrlist[j++] = sin->sin_addr;
Quoted 13 lines · Mi Jinlong
At
cltsetup(), for address checking, it should use clp's naddr for index, not cltarg's naddr(and it's always zero here).Signed-off-by Mi Jinlong <[email protected]>--- support/export/nfsctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)support/export/nfsctl.c +0
-0
support/export/nfsctl.c cltsetup(struct nfsctl_client *cltarg, nfs_client *clp) · line 84
Quoted 8 lines
support/export/nfsctl.c +1
-1@@ -78,7 +78,7 @@ cltsetup(struct nfsctl_client *cltarg, nfs_client *clp)str_tolower (cltarg->cl_ident); j =0 ; -for (i =0 ; i < cltarg->cl_naddr && i <NFSCLNT_ADDRMAX ; i++) { +for (i =0 ; i < clp->m_naddr && i <NFSCLNT_ADDRMAX ; i++) {const struct sockaddr_in *sin =get_addrlist_in (clp, i);if (sin->sin_family ==AF_INET ) cltarg->cl_addrlist[j++] = sin->sin_addr;
Committed..
steved.