Skip to contentSkip to conversation

beagleboard: enable HUB power on XM boards

PATCH New Christian Spielberger 3 participants 4 messages Jun 14, 2011 – Aug 13, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 beagleboard: enable HUB power on XM boards

Hello Eric,

we have both, a beagle xM-B and a beagle xM-C. The following works on both boards and is different from your patch. It is not possible to differentiate between Rev xM-A and xM-B. Anyway, the only difference is in the processors silicon revision (ES 1.0 to ES 1.1).

regards,
chris.

---
@@ -299,7 +309,15 @@ int misc_init_r(void)
setenv(expansion_config.env_var,
expansion_config.env_setting);

         twl4030_power_init();

- twl4030_led_init(TWL4030_LED_LEDEN_LEDAON |
TWL4030_LED_LEDEN_LEDBON);
+ switch (get_board_revision()) {
+ case REVISION_XM_C:
+ case REVISION_C4:
+ twl4030_led_init( TWL4030_LED_LEDEN_LEDAON |
TWL4030_LED_LEDEN_LEDBON );
+ break;
+ default:
+ twl4030_led_init( TWL4030_LED_LEDEN_LEDBON );
+ break;
+ }

         /* Configure GPIOs to output */
         writel(~(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1), 

&gpio6_base->oe);

#1 lore raw

PATCH 2/2 beagleboard: enable HUB power on XM boards

Hi Christian,

Quoted 27 lines · Christian Spielberger

we have both, a beagle xM-B and a beagle xM-C. The following works on both boards and is different from your patch. It is not possible to differentiate between Rev xM-A and xM-B. Anyway, the only difference is in the processors silicon revision (ES 1.0 to ES 1.1).

regards,
chris.

---

(quoted diff) +9 -1
@@ -299,7 +309,15 @@ int misc_init_r(void)
                  setenv(expansion_config.env_var,
 expansion_config.env_setting);
 
          twl4030_power_init();
-       twl4030_led_init(TWL4030_LED_LEDEN_LEDAON |
 TWL4030_LED_LEDEN_LEDBON);
+       switch (get_board_revision()) {
+               case REVISION_XM_C:
+               case REVISION_C4:
+                       twl4030_led_init( TWL4030_LED_LEDEN_LEDAON |
 TWL4030_LED_LEDEN_LEDBON );
+                       break;
+               default:
+                       twl4030_led_init( TWL4030_LED_LEDEN_LEDBON );
+                       break;
+       }
Quoted 3 lines
          /* Configure GPIOs to output */
          writel(~(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1),

&gpio6_base->oe);

ok thanks, I'll include it with an update to the previous patch that fix a problem when loading the kernel with USB clocks enabled.

Eric

#2 lore raw

PATCH 2/2 beagleboard: enable HUB power on XM boards

Quoted 8 lines · Eric B?nard

Hi Christian,

Quoted 5 lines · Christian Spielberger

we have both, a beagle xM-B and a beagle xM-C. The following works on both boards and is different from your patch. It is not possible to differentiate between Rev xM-A and xM-B. Anyway, the only difference is in the processors silicon revision (ES 1.0 to ES 1.1).

...

Quoted 3 lines

ok thanks, I'll include it with an update to the previous patch that fix a problem when loading the kernel with USB clocks enabled.

Eric, Christian,

Are either of you still planning to send an updated patch to get USB working on BB-xM-A/B (and not break it for <=BB-C5 and >=BB-xM-C)?

Regards,
Jason

#3 lore raw

PATCH 2/2 beagleboard: enable HUB power on XM boards

Hi Jason,

Quoted 11 lines · Jason Kridner
Quoted 8 lines · Eric B?nard

Hi Christian,

Quoted 5 lines · Christian Spielberger

we have both, a beagle xM-B and a beagle xM-C. The following works on both boards and is different from your patch. It is not possible to differentiate between Rev xM-A and xM-B. Anyway, the only difference is in the processors silicon revision (ES 1.0 to ES 1.1).

...

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

ok thanks, I'll include it with an update to the previous patch that fix a problem when loading the kernel with USB clocks enabled.

Eric, Christian,

Are either of you still planning to send an updated patch to get USB working on BB-xM-A/B (and not break it for<=BB-C5 and>=BB-xM-C)?

I do have this updated patch ready on a PC at work so I should be able to send it next week
Eric