Skip to contentSkip to conversation

Enable to set RTC for beagleboard

PATCH In review Jingdong Lu 4 participants 12 messages Jun 15, 2011 – Jun 16, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Enable to set RTC for beagleboard

From: Jingdong Lu <[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong Lu (1):
RTC: Enable to set RTC

 arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
#1 lore raw

PATCH 1/1 RTC: Enable to set RTC

From: Jingdong Lu <[email protected]>

"Msecure" signal provides for protection of the RTC register in TPS65950 be disabling that function via a control signal from the OMAP3530. So ensure msecure is mux'd to be able to set the RTC.
Fixes bug [YOCTO #767]

---
 arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +3 -0
index af1166b..925c0b3 100644
@@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
 	usb_ehci_init(&ehci_pdata);
 	omap3beagle_flash_init();
 
+	/* Ensure msecure is mux'd to be able to set the RTC. */
+	omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
+
 	/* Ensure SDRC pins are mux'd for self-refresh */
 	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
 	omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);
Signature · 1 line
1.7.0.4
#2 lore raw
In reply to Jingdong Lu
Quoted 4 lines · Jingdong Lu

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

Also for for any beagleboard changes, we should:

- check the various upstream trees and use their commits if possible. Or if you've checked and couldn't find anything. State that in the patch submission.

- reference the test platform details. Rev of the board, the model, etc.

Thanks for the patch, we just need to do a bit more checking on it before we can get it into the tree.

Cheers,

Bruce

Quoted 11 lines

Jingdong Lu (1):
RTC: Enable to set RTC

  arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#3 lore raw

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 13 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

Quoted 4 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

regards,

Koen

#4 lore raw
Quoted 16 lines · Koen Kooi

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 13 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

Quoted 6 lines
Quoted 4 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

Thanks Koen,

This confirms what I thought (zippy*), so clearly this is either a board with that setup, or runtime testing was .. unique. Either way, more details and research is needed for this one.

Cheers,

Bruce

Quoted 4 lines

regards,

Koen

#5 lore raw
Quoted 11 lines · Bruce Ashfield
Quoted 10 lines · Koen Kooi

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 6 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

I do not have something similar queued.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

Quoted 5 lines

Thanks Koen,

This confirms what I thought (zippy*), so clearly this is either a board with that setup, or runtime testing was .. unique. Either way, more details and research is needed for this one.

I'll wait to hear upstream status on this. Given the requirements for use, I wouldn't mind just closing 767 as will not fix as it can't work with the beagleboard out of the box anyway.

--
Darren

Quoted 11 lines

Cheers,

Bruce

Quoted 4 lines

regards,

Koen

_______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#6 lore raw
Quoted 35 lines · Darren Hart
Quoted 11 lines · Bruce Ashfield
Quoted 10 lines · Koen Kooi

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 6 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

I do not have something similar queued.

Quoted 10 lines
Quoted 7 lines
Quoted 3 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

Thanks Koen,

Quoted 8 lines
Quoted 3 lines

This confirms what I thought (zippy*), so clearly this is either a board with that setup, or runtime testing was .. unique. Either way, more details and research is needed for this one.

I'll wait to hear upstream status on this. Given the requirements for use, I wouldn't mind just closing 767 as will not fix as it can't work with the beagleboard out of the box anyway.

I'm ok with that resolution .. for the bug. But if the patch isn't already in another upstream tree, it's worth having (if benign to the rest of the variants) and then we can get it sent upstream from there.

I can change the bug's status if you like.

Cheers,

Bruce

Quoted 17 lines

--
Darren

Quoted 11 lines

Cheers,

Bruce

Quoted 4 lines

regards,

Koen

_______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto

#7 lore raw
Quoted 45 lines · Bruce Ashfield
Quoted 35 lines · Darren Hart
Quoted 11 lines · Bruce Ashfield
Quoted 10 lines · Koen Kooi

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 6 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

I do not have something similar queued.

Quoted 10 lines
Quoted 7 lines
Quoted 3 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

Thanks Koen,

Quoted 8 lines
Quoted 3 lines

This confirms what I thought (zippy*), so clearly this is either a board with that setup, or runtime testing was .. unique. Either way, more details and research is needed for this one.

I'll wait to hear upstream status on this. Given the requirements for use, I wouldn't mind just closing 767 as will not fix as it can't work with the beagleboard out of the box anyway.

Quoted 6 lines

I'm ok with that resolution .. for the bug. But if the patch isn't already in another upstream tree, it's worth having (if benign to the rest of the variants) and then we can get it sent upstream from there.

I can change the bug's status if you like.

I want to hear back from Jingdong regarding this patch first. Is this new code? If so, then yes, let's get it to mainline as Bruce suggested.

Quoted 23 lines

Cheers,

Bruce

Quoted 17 lines

--
Darren

Quoted 11 lines

Cheers,

Bruce

Quoted 4 lines

regards,

Koen

_______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#8 lore raw
Quoted 21 lines · Darren Hart
Quoted 19 lines · Bruce Ashfield
Quoted 18 lines · Darren Hart
Quoted 15 lines · Bruce Ashfield
Quoted 14 lines · Koen Kooi

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 11 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

I do not have something similar queued.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

The signal "msecure" on TPS65950 connects to "msecure" on OMAP3530 and setting/writing RTC register is controlled by OMAP3530 "msecure". So we should pull the "msecure" high on OMAP3530 so that we can set/write RTC register on TPS65950.

We test RTC on beagleboard by adding this patch. RTC can be set a correct date and it works well when power on.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

Because there is no backup battery on beagleboard C4, RTC can not be saved when power off. If we want to keep RTC without power, we should remove R66 and install a battery on board.

Quoted 14 lines
Quoted 14 lines
Quoted 9 lines
Quoted 5 lines

Thanks Koen,

This confirms what I thought (zippy*), so clearly this is either a board with that setup, or runtime testing was .. unique. Either way, more details and research is needed for this one.

I'll wait to hear upstream status on this. Given the requirements for use, I wouldn't mind just closing 767 as will not fix as it can't work with the beagleboard out of the box anyway.

I'm ok with that resolution .. for the bug. But if the patch isn't already in another upstream tree, it's worth having (if benign to the rest of the variants) and then we can get it sent upstream from there.

Quoted 5 lines
Quoted 1 line

I can change the bug's status if you like.

I want to hear back from Jingdong regarding this patch first. Is this new code? If so, then yes, let's get it to mainline as Bruce suggested.

This patch can be found on linux-omap tree.
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=e2a346a2a054f702fd76f328ff747b9ad9264a4c

arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC Without msecure beeing high it isn't possible to set (or start) the RTC.

Tested with a BeagleBoard C4.

So maybe I should recommit it by adding some upstream status and author.

regards,

Jingdong

Quoted 17 lines
Quoted 17 lines

Cheers,

Bruce

Quoted 13 lines

--
Darren

Quoted 9 lines

Cheers,

Bruce

Quoted 3 lines

regards,

Koen

_______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto

Signature · 3 lines
Lu Jingdong
[email protected]
China, Wind River
#9 lore raw
Quoted 36 lines · Lu Jingdong
Quoted 21 lines · Darren Hart
Quoted 19 lines · Bruce Ashfield
Quoted 18 lines · Darren Hart
Quoted 15 lines · Bruce Ashfield
Quoted 14 lines · Koen Kooi

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 11 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

I do not have something similar queued.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

The signal "msecure" on TPS65950 connects to "msecure" on OMAP3530 and setting/writing RTC register is controlled by
OMAP3530 "msecure". So we should pull the "msecure" high on OMAP3530 so that we can set/write RTC register on TPS65950.

We test RTC on beagleboard by adding this patch. RTC can be set a correct date and
it works well when power on.

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

Because there is no backup battery on beagleboard C4, RTC can not be saved when
power off. If we want to keep RTC without power, we should remove R66 and install
a battery on board.

Ack'd. For me, this is reasonable. Having a working RTC even if it doesn't survive power cycle is worth having. In particular, since the patch is simple.

Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 10 lines
Quoted 6 lines

Thanks Koen,

This confirms what I thought (zippy*), so clearly this is either a board with that setup, or runtime testing was .. unique. Either way, more details and research is needed for this one.

I'll wait to hear upstream status on this. Given the requirements for use, I wouldn't mind just closing 767 as will not fix as it can't work with the beagleboard out of the box anyway.

I'm ok with that resolution .. for the bug. But if the patch isn't already in another upstream tree, it's worth having (if benign to the rest of the variants) and then we can get it sent upstream from there.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

I can change the bug's status if you like.

I want to hear back from Jingdong regarding this patch first. Is this new code? If so, then yes, let's get it to mainline as Bruce suggested.

This patch can be found on linux-omap tree.
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=e2a346a2a054f702fd76f328ff747b9ad9264a4c

perfect.

Quoted 11 lines

arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC Without msecure beeing high it isn't possible to set (or start) the RTC.

Tested with a BeagleBoard C4.

So maybe I should recommit it by adding some upstream status and author.

This is key. We must have this in our patch commits. I can provide examples if you aren't familiar and Mark Hatle just sent out some oe-core examples of the same thing.

In this case you'd put something like:

commit e2a346a2a054f7 from git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git

after the shortlog, and before the long log. Add your Integrated-by:
to the sign off section of the patch.

Cheers,

Bruce

Quoted 22 lines

regards,

Jingdong

Quoted 17 lines
Quoted 17 lines

Cheers,

Bruce

Quoted 13 lines

--
Darren

Quoted 9 lines

Cheers,

Bruce

Quoted 3 lines

regards,

Koen

_______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto

#10 lore raw
Quoted 46 lines · Bruce Ashfield
Quoted 36 lines · Lu Jingdong
Quoted 21 lines · Darren Hart
Quoted 19 lines · Bruce Ashfield
Quoted 18 lines · Darren Hart
Quoted 15 lines · Bruce Ashfield
Quoted 14 lines · Koen Kooi

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 11 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

I do not have something similar queued.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

The signal "msecure" on TPS65950 connects to "msecure" on OMAP3530 and setting/writing RTC register is controlled by
OMAP3530 "msecure". So we should pull the "msecure" high on OMAP3530 so that we can set/write RTC register on TPS65950.

We test RTC on beagleboard by adding this patch. RTC can be set a correct date and
it works well when power on.

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

Because there is no backup battery on beagleboard C4, RTC can not be saved when
power off. If we want to keep RTC without power, we should remove R66 and install
a battery on board.

Quoted 3 lines

Ack'd. For me, this is reasonable. Having a working RTC even if it doesn't survive power cycle is worth having. In particular, since the patch is simple.

Agreed.

Quoted 44 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 11 lines
Quoted 7 lines

Thanks Koen,

This confirms what I thought (zippy*), so clearly this is either a board with that setup, or runtime testing was .. unique. Either way, more details and research is needed for this one.

I'll wait to hear upstream status on this. Given the requirements for use, I wouldn't mind just closing 767 as will not fix as it can't work with the beagleboard out of the box anyway.

I'm ok with that resolution .. for the bug. But if the patch isn't already in another upstream tree, it's worth having (if benign to the rest of the variants) and then we can get it sent upstream from there.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

I can change the bug's status if you like.

I want to hear back from Jingdong regarding this patch first. Is this new code? If so, then yes, let's get it to mainline as Bruce suggested.

This patch can be found on linux-omap tree.
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=e2a346a2a054f702fd76f328ff747b9ad9264a4c

perfect.

Quoted 11 lines

arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC Without msecure beeing high it isn't possible to set (or start) the RTC.

Tested with a BeagleBoard C4.

So maybe I should recommit it by adding some upstream status and author.

This is key. We must have this in our patch commits. I can provide examples if you aren't familiar and Mark Hatle just sent out some oe-core examples of the same thing.

Quoted 8 lines

In this case you'd put something like:

commit e2a346a2a054f7 from
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git

after the shortlog, and before the long log. Add your Integrated-by:
to the sign off section of the patch.

I will just pull the patch and add Jingdong as the Integrated-by.

--
Darren

Quoted 28 lines

Cheers,

Bruce

Quoted 22 lines

regards,

Jingdong

Quoted 17 lines
Quoted 17 lines

Cheers,

Bruce

Quoted 13 lines

--
Darren

Quoted 9 lines

Cheers,

Bruce

Quoted 3 lines

regards,

Koen

_______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#11 lore raw

Op 16 jun 2011, om 16:45 heeft Darren Hart het volgende geschreven:

Quoted 48 lines · Bruce Ashfield
Quoted 46 lines · Lu Jingdong
Quoted 44 lines · Darren Hart
Quoted 21 lines · Bruce Ashfield
Quoted 19 lines · Darren Hart
Quoted 18 lines · Bruce Ashfield
Quoted 15 lines · Koen Kooi
Quoted 14 lines

Op 15 jun 2011, om 15:21 heeft Bruce Ashfield het volgende geschreven:

Quoted 11 lines · Jingdong Lu
Quoted 4 lines

From: Jingdong Lu<[email protected]>

Ensure msecure is mux'd to be able to set the RTC for beagleboard. Fixes bug [YOCTO #767]

Jingdong,

The fix looks reasonable to me, Darren has been refreshing the beagleboard support as well, so I've cc'd him here to see if we have this change present in the work in progress trees.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

I do not have something similar queued.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

What tests did you run to ensure that the RTC worked on the beagleboard ? There was some debate around whether or not you needed an add-on card to get this functionality available ?

The signal "msecure" on TPS65950 connects to "msecure" on OMAP3530 and setting/writing RTC register is controlled by
OMAP3530 "msecure". So we should pull the "msecure" high on OMAP3530 so that we can set/write RTC register on TPS65950.

We test RTC on beagleboard by adding this patch. RTC can be set a correct date and
it works well when power on.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

You need to remove some resistors and add a battery, or add an expansionboard like the zippy or zippy2, which have a DS1307 RTC with battery.

Because there is no backup battery on beagleboard C4, RTC can not be saved when
power off. If we want to keep RTC without power, we should remove R66 and install
a battery on board.

Quoted 6 lines
Quoted 3 lines

Ack'd. For me, this is reasonable. Having a working RTC even if it doesn't survive power cycle is worth having. In particular, since the patch is simple.

Agreed.

FWIW, it survives warm resests.

regards,

Koen