Skip to contentSkip to conversation

pnfs-obj: No longer needed to take an extra ref at add_device

PATCH New Boaz Harrosh 1 participant 1 message Jun 17, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pnfs-obj: No longer needed to take an extra ref at add_device

Andy's last device_cache patches, already take an extra reference on the newly inserted device_id. So we can remove it from obj-io.

Without this patch the device_ids are leaked.

Andy's patches are not in Linus tree yet. So I'm not sure if they are scheduled for this Kernel or the next. This patch should be added as part of these.

---
 fs/nfs/objlayout/objio_osd.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/nfs/objlayout/objio_osd.c +0 -1
index f014038..70272d5 100644
@@ -108,7 +108,6 @@ _dev_list_add(const struct nfs_server *nfss,
 		de = n;
 	}
 
-	atomic_inc(&de->id_node.ref);
 	return de;
 }
 
Signature · 1 line
1.7.3.4