Skip to contentSkip to conversation

Fix loopback devices to emit uevent on auto release

PATCH In review Phillip Susi 2 participants 4 messages Jun 27, 2011 – Jul 7, 2011 Block layer

lore
Share & tools
lore

Phillip Susi

author
#0 lore raw

PATCH 1/1 Fix loopback devices to emit uevent on auto release

commit 4d5498b2b400ee4781b25fa9fa219eadf11c1ef5

Author: Phillip Susi <[email protected]>
Date:   Mon Jun 27 18:55:00 2011 -0400

Fixed loopback device to emit uevent on auto release

The loopback driver failed to emit the change uevent when auto releasing the device. Fixed lo_release() to pass the bdev to loop_clr_fd() so it can emit the event.

drivers/block/loop.c +1 -1
index dbf31ec..ba915ce 100644
@@ -1522,7 +1522,7 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
 		 * In autoclear mode, stop the loop thread
 		 * and remove configuration after last close.
 		 */
-		err = loop_clr_fd(lo, NULL);
+		err = loop_clr_fd(lo, lo->lo_device);
 		if (!err)
 			goto out_unlocked;
 	} else {
#1 lore raw
Quoted 16 lines · On Mon, 27 Jun 2011 19:30:49 -0400 Phillip Susi <[email protected]> wrote:

commit 4d5498b2b400ee4781b25fa9fa219eadf11c1ef5

Author: Phillip Susi <[email protected]>
Date:   Mon Jun 27 18:55:00 2011 -0400

Fixed loopback device to emit uevent on auto release

The loopback driver failed to emit the change uevent when auto releasing the device. Fixed lo_release() to pass the bdev to loop_clr_fd() so it can emit the event.

drivers/block/loop.c +0 -0
index dbf31ec..ba915ce 100644

drivers/block/loop.c static int lo_release(struct gendisk *disk, fmode_t mode) · line 1528

Quoted 8 lines
drivers/block/loop.c +1 -1
@@ -1522,7 +1522,7 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
 		 * In autoclear mode, stop the loop thread
 		 * and remove configuration after last close.
 		 */
-		err = loop_clr_fd(lo, NULL);
+		err = loop_clr_fd(lo, lo->lo_device);
 		if (!err)
 			goto out_unlocked;
 	} else {

The patch is missing your Signed-off-by:. Please review Documentation/SubmittingPatches section 12 to see what this means. Then, if agreeable, please send us that Signed-off-by:, thanks.

author
#2 lore raw
Quoted 3 lines · Andrew Morton

The patch is missing your Signed-off-by:. Please review Documentation/SubmittingPatches section 12 to see what this means. Then, if agreeable, please send us that Signed-off-by:, thanks.

Oops, yes of course. Please add it, or do you need me to resubmit the whole patch?

#3 lore raw
Quoted 6 lines · On Thu, 07 Jul 2011 14:56:57 -0400 Phillip Susi <[email protected]> wrote:
Quoted 3 lines · Andrew Morton

The patch is missing your Signed-off-by:. Please review Documentation/SubmittingPatches section 12 to see what this means. Then, if agreeable, please send us that Signed-off-by:, thanks.

Oops, yes of course. Please add it,

I added it it my copy, thanks.

Quoted 1 line

or do you need me to resubmit the whole patch?

That's OK, I'll scoot it along to Jens later on.