tools/hotplug/Linux/init.d/: Improved LSB headers

PATCH In review Fabio Fantoni 2 participants 8 messages Jun 6, 2011 – Jul 18, 2011

Share & tools

Fabio Fantoni

author

2011-06-06 11:00 UTC #0 lore raw

PATCH 1/1 tools/hotplug/Linux/init.d/: Improved LSB headers

I sent the patch given above here <http://xen.1045712.n5.nabble.com/PATCH-2-of-2-xendomains-remove-unnecessary-dependency-of-xend-td4429591.html#a4450722> from thunderbird to avoid formatting problems

# HG changeset patch
# User Fabio Fantoni
# Date 1307094826 -7200
# Node ID 7fe9e9a990cc42632352f569a24e8bdfad6eccd8 # Parent 0791661a32d8eba917c87feacf2c955b85521ad1 tools/hotplug/Linux/init.d/:
Improved LSB headers
xendomains service now working also without xend service

Signed-off-by Fabio Fantoni <[email protected]>

tools/hotplug/Linux/init.d/xen-watchdog Fri Jun 03 11:53:46 2011 +0200 renamed from tools/hotplug/Linux/init.d/xen-watchdog Thu Jun 02 18:46:35 2011 +0100 +4 -4

diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xen-watchdog
@@ -6,10 +6,10 @@
 # description: Run domain watchdog daemon
 ### BEGIN INIT INFO
 # Provides:          xen-watchdog
-# Required-Start:    xend
-# Should-Start:      $syslog $remote_fs
-# Required-Stop:     xend
-# Should-Stop:       $syslog $remote_fs
+# Required-Start:    $syslog $remote_fs
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop xen-watchdog

tools/hotplug/Linux/init.d/xend Fri Jun 03 11:53:46 2011 +0200 renamed from tools/hotplug/Linux/init.d/xend Thu Jun 02 18:46:35 2011 +0100 +2 -2

diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xend
@@ -8,9 +8,9 @@
 # description: Starts and stops the Xen control daemon.
 ### BEGIN INIT INFO
 # Provides:          xend
-# Required-Start:    $syslog $remote_fs xenstored
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
 # Should-Start:
-# Required-Stop:     $syslog $remote_fs xenstored
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
 # Should-Stop:
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6

tools/hotplug/Linux/init.d/xendomains Fri Jun 03 11:53:46 2011 +0200 renamed from tools/hotplug/Linux/init.d/xendomains Thu Jun 02 18:46:35 2011 +0100 +4 -4

diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xendomains
@@ -16,10 +16,10 @@
 #
 ### BEGIN INIT INFO
 # Provides:          xendomains
-# Required-Start:    $syslog $remote_fs xend
-# Should-Start:
-# Required-Stop:     $syslog $remote_fs xend
-# Should-Stop:
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop secondary xen domains

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Ian Jackson

2011-06-21 17:17 UTC #1 lore raw

Fabio Fantoni writes ("[Xen-devel] [PATCH] tools/hotplug/Linux/init.d/: Improved LSB headers"):

Quoted 3 lines

I sent the patch given above here
<http://xen.1045712.n5.nabble.com/PATCH-2-of-2-xendomains-remove-unnecessary-dependency-of-xend-td4429591.html#a4450722>
Quoted 1 line
from thunderbird to avoid formatting problems

I'm afraid your message has been mangled by nabble. I can't scrape it off a web page either.

Please join the mailing list and post to it in the usual way.

Ian.

Fabio Fantoni

author

2011-06-22 06:44 UTC #2 lore raw

Il 21/06/2011 19:17, Ian Jackson ha scritto:

Quoted 6 lines

I'm afraid your message has been mangled by nabble. I can't scrape it off a web page either.
Please join the mailing list and post to it in the usual way.
Ian.

I not understand the problem, I had alredy send this with mail client and not from nabble as advised by you in previous posts.

Here patch resend (from mail client):

Signed-off-by Fabio Fantoni <[email protected]>

tools/hotplug/Linux/init.d/xen-watchdog Fri Jun 03 11:53:46 2011 +0200 renamed from tools/hotplug/Linux/init.d/xen-watchdog Thu Jun 02 18:46:35 2011 +0100 +4 -4

diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xen-watchdog
@@ -6,10 +6,10 @@
 # description: Run domain watchdog daemon
 ### BEGIN INIT INFO
 # Provides:          xen-watchdog
-# Required-Start:    xend
-# Should-Start:      $syslog $remote_fs
-# Required-Stop:     xend
-# Should-Stop:       $syslog $remote_fs
+# Required-Start:    $syslog $remote_fs
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop xen-watchdog

tools/hotplug/Linux/init.d/xend Fri Jun 03 11:53:46 2011 +0200 renamed from tools/hotplug/Linux/init.d/xend Thu Jun 02 18:46:35 2011 +0100 +2 -2

diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xend
@@ -8,9 +8,9 @@
 # description: Starts and stops the Xen control daemon.
 ### BEGIN INIT INFO
 # Provides:          xend
-# Required-Start:    $syslog $remote_fs xenstored
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
 # Should-Start:
-# Required-Stop:     $syslog $remote_fs xenstored
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
 # Should-Stop:
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6

tools/hotplug/Linux/init.d/xendomains Fri Jun 03 11:53:46 2011 +0200 renamed from tools/hotplug/Linux/init.d/xendomains Thu Jun 02 18:46:35 2011 +0100 +4 -4

diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xendomains
@@ -16,10 +16,10 @@
 #
 ### BEGIN INIT INFO
 # Provides:          xendomains
-# Required-Start:    $syslog $remote_fs xend
-# Should-Start:
-# Required-Stop:     $syslog $remote_fs xend
-# Should-Stop:
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop secondary xen domains

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Ian Jackson

2011-06-27 14:26 UTC #3 lore raw

Fabio Fantoni writes ("Re: [Xen-devel] [PATCH] tools/hotplug/Linux/init.d/: Improved LSB headers"):

Quoted 2 lines

I not understand the problem, I had alredy send this with mail client and not from nabble as advised by you in previous posts.

I'm afraid it's still corrupted.

Quoted 1 line

Here patch resend (from mail client):

Perhaps the problem is the MIME signature. Look at this:

tools/hotplug/Linux/init.d/xen-watchdog Fri Jun 03 11:53:46 2011 +0200 line 14

Quoted 13 lines

# description: Run domain watchdog daemon
### BEGIN INIT INFO
# Provides: xen-watchdog
tools/hotplug/Linux/init.d/xen-watchdog Fri Jun 03 11:53:46 2011 +0200 renamed from tools/hotplug/Linux/init.d/xen-watchdog Thu Jun 02 18:46:35 2011 +0100 +4 -4
-# Required-Start:    xend
-# Should-Start:      $syslog $remote_fs
-# Required-Stop:     xend
-# Should-Stop:       $syslog $remote_fs
+# Required-Start:    $syslog $remote_fs
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs
+# Should-Stop:       xend
  # Default-Start:     2 3 4 5
  # Default-Stop:      0 1 6

This is not correct. There are extra spaces.

Ian.

Fabio Fantoni

author

2011-06-28 08:07 UTC #4 lore raw

Il 27/06/2011 16:26, Ian Jackson ha scritto:

Quoted 5 lines

I'm afraid it's still corrupted.
This is not correct. There are extra spaces.
Ian

I have redone patch and resend, also in attachment:

# HG changeset patch
# User Fabio Fantoni
# Date 1309247918 -7200
# Node ID f80fe58e5cc2fe406a3f93827e350bbc7ea4fedb # Parent 2f63562df1c4230492a81793dce3672f93c93d9a Improved LSB headers
xendomains service now working also without xend service

Signed-off-by Fabio Fantoni <[email protected]>

tools/hotplug/Linux/init.d/xen-watchdog Tue Jun 28 09:58:38 2011 +0200 renamed from tools/hotplug/Linux/init.d/xen-watchdog Mon Jun 27 17:37:12 2011 +0100 +4 -4

diff -r 2f63562df1c4 -r f80fe58e5cc2 tools/hotplug/Linux/init.d/xen-watchdog
@@ -6,10 +6,10 @@
 # description: Run domain watchdog daemon
 ### BEGIN INIT INFO
 # Provides:          xen-watchdog
-# Required-Start:    xend
-# Should-Start:      $syslog $remote_fs
-# Required-Stop:     xend
-# Should-Stop:       $syslog $remote_fs
+# Required-Start:    $syslog $remote_fs
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop xen-watchdog

tools/hotplug/Linux/init.d/xend Tue Jun 28 09:58:38 2011 +0200 renamed from tools/hotplug/Linux/init.d/xend Mon Jun 27 17:37:12 2011 +0100 +2 -2

diff -r 2f63562df1c4 -r f80fe58e5cc2 tools/hotplug/Linux/init.d/xend
@@ -8,9 +8,9 @@
 # description: Starts and stops the Xen control daemon.
 ### BEGIN INIT INFO
 # Provides:          xend
-# Required-Start:    $syslog $remote_fs xenstored
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
 # Should-Start:
-# Required-Stop:     $syslog $remote_fs xenstored
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
 # Should-Stop:
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6

tools/hotplug/Linux/init.d/xendomains Tue Jun 28 09:58:38 2011 +0200 renamed from tools/hotplug/Linux/init.d/xendomains Mon Jun 27 17:37:12 2011 +0100 +4 -4

diff -r 2f63562df1c4 -r f80fe58e5cc2 tools/hotplug/Linux/init.d/xendomains
@@ -16,10 +16,10 @@
 #
 ### BEGIN INIT INFO
 # Provides:          xendomains
-# Required-Start:    $syslog $remote_fs xend
-# Should-Start:
-# Required-Stop:     $syslog $remote_fs xend
-# Should-Stop:
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop secondary xen domains

Signed-off-by Fabio Fantoni <[email protected]>

tools/hotplug/Linux/init.d/xen-watchdog +4 -4

diff -r 2f63562df1c4 -r f80fe58e5cc2 tools/hotplug/Linux/init.d/xen-watchdog
@@ -6,10 +6,10 @@
 # description: Run domain watchdog daemon
 ### BEGIN INIT INFO
 # Provides:          xen-watchdog
-# Required-Start:    xend
-# Should-Start:      $syslog $remote_fs
-# Required-Stop:     xend
-# Should-Stop:       $syslog $remote_fs
+# Required-Start:    $syslog $remote_fs
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop xen-watchdog

tools/hotplug/Linux/init.d/xend +2 -2

diff -r 2f63562df1c4 -r f80fe58e5cc2 tools/hotplug/Linux/init.d/xend
@@ -8,9 +8,9 @@
 # description: Starts and stops the Xen control daemon.
 ### BEGIN INIT INFO
 # Provides:          xend
-# Required-Start:    $syslog $remote_fs xenstored
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled 
 # Should-Start:
-# Required-Stop:     $syslog $remote_fs xenstored
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled 
 # Should-Stop:
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6

tools/hotplug/Linux/init.d/xendomains +4 -4

diff -r 2f63562df1c4 -r f80fe58e5cc2 tools/hotplug/Linux/init.d/xendomains
@@ -16,10 +16,10 @@
 #
 ### BEGIN INIT INFO
 # Provides:          xendomains
-# Required-Start:    $syslog $remote_fs xend
-# Should-Start:
-# Required-Stop:     $syslog $remote_fs xend
-# Should-Stop:
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop secondary xen domains

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Ian Jackson

2011-07-08 17:11 UTC #5 lore raw

Fabio Fantoni writes ("Re: [Xen-devel] [PATCH] tools/hotplug/Linux/init.d/: Improved LSB headers"):

Quoted 1 line

I have redone patch and resend, also in attachment:

Marvellous, thanks, I have applied it.

Ian.

Fantu

author

2011-07-11 12:38 UTC #6 lore raw

Can be backport also to xen 4.1 branch?

--
View this message in context: http://xen.1045712.n5.nabble.com/PATCH-tools-hotplug-Linux-init-d-Improved-LSB-headers-tp4458270p4574835.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Ian Jackson

2011-07-18 16:49 UTC #7 lore raw

Fantu writes ("[Xen-devel] Re: [PATCH] tools/hotplug/Linux/init.d/: Improved LSB headers"):

Quoted 1 line

Can be backport also to xen 4.1 branch?

Done.

Ian.

# HG changeset patch
# User Fabio Fantoni <[email protected]> # Date 1311007753 -3600
# Node ID 45907272001e0447350716baf74ebce258766fb2 # Parent 89608751ccfc93a9b8d07488b72810b5cb8d1d35 tools/hotplug/Linux: start all xen daemons in runlevel 2

Backported from xen-4.1-testing.hg 23086:9b5fbd8ff152 -iwj.

Signed-off-by Fabio Fantoni <[email protected]>

Signed-off-by Ian Jackson <[email protected]>

Committed-by Ian Jackson <[email protected]>

tools/hotplug/Linux/init.d/xencommons +2 -2

diff -r 89608751ccfc -r 45907272001e tools/hotplug/Linux/init.d/xencommons
@@ -13,8 +13,8 @@
 # Should-Start:
 # Required-Stop:     $syslog $remote_fs
 # Should-Stop:
-# Default-Start:     3 4 5
-# Default-Stop:      1
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Default-Enabled:   yes
 # Short-Description: Start/stop xenstored and xenconsoled
 # Description:       Starts and stops the daemons neeeded for xl/libxenlight

tools/hotplug/Linux/init.d/xend +2 -2

diff -r 89608751ccfc -r 45907272001e tools/hotplug/Linux/init.d/xend
@@ -12,8 +12,8 @@
 # Should-Start:
 # Required-Stop:     $syslog $remote_fs
 # Should-Stop:
-# Default-Start:     3 4 5
-# Default-Stop:      0 1 2 6
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Default-Enabled:   yes
 # Short-Description: Start/stop xend
 # Description:       Starts and stops the Xen control daemon.

tools/hotplug/Linux/init.d/xendomains +2 -2

diff -r 89608751ccfc -r 45907272001e tools/hotplug/Linux/init.d/xendomains
@@ -20,8 +20,8 @@
 # Should-Start:
 # Required-Stop:     $syslog $remote_fs xend
 # Should-Stop:
-# Default-Start:     3 4 5
-# Default-Stop:      0 1 2 6
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Default-Enabled:   yes
 # Short-Description: Start/stop secondary xen domains
 # Description:       Start / stop domains automatically when domain 0