Skip to contentSkip to conversation

linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM

PATCH In review Joel A Fernandes 3 participants 3 messages Jun 30, 2011

lore
Share & tools
lore

Joel A Fernandes

author
#0 lore raw

PATCH 1/1 linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM

Signed-off-by Joel A Fernandes <[email protected]>
---
 ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +2 -2
index 513a101..fb91cb6 100644
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
  	omap3_beagle_i2c_init();
  
 -	if (cpu_is_omap3630()) {
-+	if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) &&
-+		(omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++	if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++		(omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
  		gpio_buttons[0].gpio = 4;
  	}
Signature · 1 line
1.7.1
#1 lore raw
Quoted 10 lines · Joel A Fernandes
Signed-off-by Joel A Fernandes<[email protected]>
---
  ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +0 -0
index 513a101..fb91cb6 100644

recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch index 4bde54b..664a9c6 100644 · line 150

Quoted 10 lines
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +2 -2
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
   	omap3_beagle_i2c_init();
 
  -	if (cpu_is_omap3630()) {
-+	if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB)&&
-+		(omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++	if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++		(omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
   		gpio_buttons[0].gpio = 4;
   	}

while the patch seems good it does not follow the submission guidelines.

#2 lore raw

Am Donnerstag, den 30.06.2011, 01:13 -0700 schrieb Khem Raj:

Quoted 13 lines · Joel A Fernandes
Quoted 12 lines
Signed-off-by Joel A Fernandes<[email protected]>
---
  ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +0 -0
index 513a101..fb91cb6 100644
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
   	omap3_beagle_i2c_init();
Quoted 10 lines

recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch index 4bde54b..664a9c6 100644 · line 150

Quoted 8 lines
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +2 -2
  -	if (cpu_is_omap3630()) {
-+	if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB)&&
-+		(omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++	if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++		(omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
   		gpio_buttons[0].gpio = 4;
   	}

while the patch seems good it does not follow the submission guidelines.

Please read the following policies [1] in the Wiki [2][3][4].

Thanks,

Paul

[1] http://openembedded.org/index.php/Category:Policy
[2] http://openembedded.org/index.php/Commit_Patch_Message_Guidelines
[3] http://openembedded.org/index.php/Commit_Policy
[4] http://openembedded.org/index.php/Commit_log_example