Skip to contentSkip to conversation

vl.c: Don't limit node count by smp count

PATCH RESEND Applied Sasha Levin 3 participants 3 messages Jun 30, 2011 – Jul 23, 2011

lore
Share & tools
lore

Sasha Levin

author
#0 lore raw

PATCH RESEND 1/1 vl.c: Don't limit node count by smp count

[I've sent this patch couple of months ago and noticed it
didn't make it's way in - so I'm sending it again]

It is possible to create CPU-less NUMA nodes, node amount shouldn't be limited by amount of CPUs.

Tested-by Michael Roth <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
---
 vl.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
vl.c +2 -2
index e0191e1..b95ae8d 100644
@@ -3147,8 +3147,8 @@ int main(int argc, char **argv, char **envp)
     if (nb_numa_nodes > 0) {
         int i;
 
-        if (nb_numa_nodes > smp_cpus) {
-            nb_numa_nodes = smp_cpus;
+        if (nb_numa_nodes > MAX_NODES) {
+            nb_numa_nodes = MAX_NODES;
         }
 
         /* If no memory size if given for any node, assume the default case
Signature · 1 line
1.7.6
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Sasha Levin

[I've sent this patch couple of months ago and noticed it
didn't make it's way in - so I'm sending it again]

It is possible to create CPU-less NUMA nodes, node amount shouldn't be limited by amount of CPUs.

Tested-by Michael Roth<[email protected]>
Signed-off-by Sasha Levin<[email protected]>
---
  vl.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
vl.c +0 -0
index e0191e1..b95ae8d 100644

vl.c int main(int argc, char **argv, char **envp) · line 3154

Quoted 10 lines
vl.c +2 -2
@@ -3147,8 +3147,8 @@ int main(int argc, char **argv, char **envp)
      if (nb_numa_nodes>  0) {
          int i;
 
-        if (nb_numa_nodes>  smp_cpus) {
-            nb_numa_nodes = smp_cpus;
+        if (nb_numa_nodes>  MAX_NODES) {
+            nb_numa_nodes = MAX_NODES;
          }
 
          /* If no memory size if given for any node, assume the default case
Acked-by Andre Przywara <[email protected]>

Regards,
Andre.

Signature · 2 lines
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Applied
#2 lore raw
In reply to Sasha Levin
Quoted 8 lines · Sasha Levin

[I've sent this patch couple of months ago and noticed it
didn't make it's way in - so I'm sending it again]

It is possible to create CPU-less NUMA nodes, node amount shouldn't be limited by amount of CPUs.

Tested-by Michael Roth<[email protected]>
Signed-off-by Sasha Levin<[email protected]>

Applied. Thanks.

Regards,

Anthony Liguori

Quoted 19 lines
---
  vl.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
vl.c +2 -2
index e0191e1..b95ae8d 100644
@@ -3147,8 +3147,8 @@ int main(int argc, char **argv, char **envp)
      if (nb_numa_nodes>  0) {
          int i;
 
-        if (nb_numa_nodes>  smp_cpus) {
-            nb_numa_nodes = smp_cpus;
+        if (nb_numa_nodes>  MAX_NODES) {
+            nb_numa_nodes = MAX_NODES;
          }
 
          /* If no memory size if given for any node, assume the default case