Skip to contentSkip to conversation

SPI: S5PC100: Enable the SPI driver for S5PC100

PATCH New Padmavathi Venna 4 participants 6 messages Jul 4, 2011 – Jul 6, 2011

Subsystems (2)
SPI Arm Samsung Exynos
lore
Share & tools
lore

Padmavathi Venna

author
#0 lore raw

PATCH 1/2 SPI: S5PC100: Enable the SPI driver for S5PC100

From: padmavathi venna <[email protected]>

The SPI module on S5PC100 is similar to the earlier Samsung SoCs like S3C64XX. Enable the existing SPI driver for use on S5PC100.

Signed-off-by padmavathi venna <[email protected]>
---
 drivers/spi/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/Kconfig +1 -1
index de35c3a..91d607b 100644
@@ -340,7 +340,7 @@ config SPI_S3C24XX_GPIO
 
 config SPI_S3C64XX
 	tristate "Samsung S3C64XX series type SPI"
-	depends on (ARCH_S3C64XX || ARCH_S5P64X0)
+	depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100)
 	select S3C64XX_DMA if ARCH_S3C64XX
 	help
 	  SPI driver for Samsung S3C64XX and newer SoCs.
Signature · 1 line
1.7.0.4
author
#1 lore raw

PATCH 2/2 SPI: S5PV210: Enable the SPI driver for S5PV210

The SPI module on S5PV210 is similar to the earlier Samsung SoCs like S3C64XX. Enable the existing SPI driver for use on S5PV210.

Signed-off-by Padmavathi Venna <[email protected]>
---
 drivers/spi/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/spi/Kconfig +2 -1
index 91d607b..ed1ebea 100644
@@ -340,7 +340,8 @@ config SPI_S3C24XX_GPIO
 
 config SPI_S3C64XX
 	tristate "Samsung S3C64XX series type SPI"
-	depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100)
+	depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100 \
+			|| ARCH_S5PV210)
 	select S3C64XX_DMA if ARCH_S3C64XX
 	help
 	  SPI driver for Samsung S3C64XX and newer SoCs.
Signature · 1 line
1.7.0.4
#2 lore raw

PATCH 2/2 SPI: S5PV210: Enable the SPI driver for S5PV210

Hi,

Patch 1/2 looks redundant as both changes can be very well accommodated in a single patch.

Quoted 22 lines · Padmavathi Venna

The SPI module on S5PV210 is similar to the earlier Samsung SoCs like S3C64XX. Enable the existing SPI driver for use on S5PV210.

Signed-off-by Padmavathi Venna<[email protected]>
---
  drivers/spi/Kconfig |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
drivers/spi/Kconfig +2 -1
index 91d607b..ed1ebea 100644
@@ -340,7 +340,8 @@ config SPI_S3C24XX_GPIO
 
  config SPI_S3C64XX
  	tristate "Samsung S3C64XX series type SPI"
-	depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100)
+	depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100 \
+			|| ARCH_S5PV210)
  	select S3C64XX_DMA if ARCH_S3C64XX
  	help
  	  SPI driver for Samsung S3C64XX and newer SoCs.
Signature · 1 line
Tushar Behera
#3 lore raw

PATCH 2/2 SPI: S5PV210: Enable the SPI driver for S5PV210

Hi Tushar,

Quoted 4 lines · Tushar Behera

Hi,

Patch 1/2 looks redundant as both changes can be very well accommodated in a single patch.

I thought it would be better to have seperate patch for two different SoCs. So I made
the patches like that.

Hi Kukjin,

Please comment on this. Shall I make a single patch for both of the SoCs?

Quoted 35 lines · Padmavathi Venna
Quoted 17 lines

The SPI module on S5PV210 is similar to the earlier Samsung SoCs like S3C64XX. Enable the existing SPI driver for use on S5PV210.

Signed-off-by Padmavathi Venna<[email protected]>

---
?drivers/spi/Kconfig | ? ?3 ++-
?1 files changed, 2 insertions(+), 1 deletions(-)

drivers/spi/Kconfig +0 -0
index 91d607b..ed1ebea 100644
@@ -340,7 +340,8 @@ config SPI_S3C24XX_GPIO

?config SPI_S3C64XX
? ? ? ?tristate "Samsung S3C64XX series type SPI"

Quoted 6 lines
- ? ? ? depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100)
+ ? ? ? depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100 \

+ ? ? ? ? ? ? ? ? ? ? ? || ARCH_S5PV210)
? ? ? ?select S3C64XX_DMA if ARCH_S3C64XX
? ? ? ?help
? ? ? ? ?SPI driver for Samsung S3C64XX and newer SoCs.

--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

#4 lore raw

PATCH 1/2 SPI: S5PC100: Enable the SPI driver for S5PC100

In reply to Padmavathi Venna

drivers/spi/Kconfig config SPI_S3C24XX_GPIO · line 343

Quoted 4 lines · Padmavathi Venna

config SPI_S3C64XX

drivers/spi/Kconfig +1 -1
 	tristate "Samsung S3C64XX series type SPI"
-	depends on (ARCH_S3C64XX || ARCH_S5P64X0)
+	depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100)

Just get rid of the unnecessary parens here.

#5 lore raw

PATCH 1/2 SPI: S5PC100: Enable the SPI driver for S5PC100

Hi Russell,

Quoted 7 lines · Russell King - ARM Linux
Quoted 4 lines · Padmavathi Venna

?config SPI_S3C64XX
? ? ? tristate "Samsung S3C64XX series type SPI"

- ? ? depends on (ARCH_S3C64XX || ARCH_S5P64X0)
+ ? ? depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_S5PC100)

Just get rid of the unnecessary parens here.

Thanks for your comment. I will remake the patch and will send the same.

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html