Skip to contentSkip to conversation

build: Add targets for auto gen of asm-offsets.h and use it in imx35

PATCH New Matthias Weisser 2 participants 3 messages Jun 30, 2011 – Jul 6, 2011 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: Add targets for auto gen of asm-offsets.h and use it in imx35

asm-offsets.h should be auto generated. This patch adds two rules to rules.mk which makes this possible and removes the rules on imx35.

---
 arch/arm/cpu/arm1136/mx35/Makefile |   11 -----------
 rules.mk                           |   10 ++++++++++
 2 files changed, 10 insertions(+), 11 deletions(-)
arch/arm/cpu/arm1136/mx35/Makefile +0 -11
index 20f36e3..284cdc5 100644
@@ -50,14 +50,3 @@ include $(SRCTREE)/rules.mk
 sinclude $(obj).depend
 
 #########################################################################
-
-$(TOPDIR)/include/asm/arch/asm-offsets.h:	$(TOPDIR)/include/autoconf.mk.dep \
-	./asm-offsets.s
-	@echo Generating $@
-	$(TOPDIR)/tools/scripts/make-asm-offsets ./asm-offsets.s $@
-
-asm-offsets.s:	$(TOPDIR)/include/autoconf.mk.dep \
-	./asm-offsets.c
-	$(CC) -DDO_DEPS_ONLY \
-		$(CFLAGS) $(CFLAGS_$(BCURDIR)/$(@F)) $(CFLAGS_$(BCURDIR)) \
-		-o $@ ./asm-offsets.c -c -S
rules.mk +10 -0
index c2860e5..5fd12a0 100644
@@ -42,4 +42,14 @@ $(HOSTOBJS): $(obj)%.o: %.c
 $(NOPEDOBJS): $(obj)%.o: %.c
 	$(HOSTCC) $(HOSTCFLAGS_NOPED) $(HOSTCFLAGS_$(@F)) $(HOSTCFLAGS_$(BCURDIR)) -o $@ $< -c
 
+$(TOPDIR)/include/asm/arch/asm-offsets.h:	$(TOPDIR)/include/autoconf.mk.dep \
+	$(TOPDIR)/$(CPUDIR)/$(SOC)/asm-offsets.s
+	@echo Generating $@
+	$(TOPDIR)/tools/scripts/make-asm-offsets $(TOPDIR)/$(CPUDIR)/$(SOC)/asm-offsets.s $@
+
+$(TOPDIR)/$(CPUDIR)/$(SOC)/asm-offsets.s:	$(TOPDIR)/include/autoconf.mk.dep \
+	$(TOPDIR)/$(CPUDIR)/$(SOC)/asm-offsets.c
+	$(CC) -DDO_DEPS_ONLY \
+		$(CFLAGS) $(CFLAGS_$(BCURDIR)/$(@F)) $(CFLAGS_$(BCURDIR)) \
+		-o $@ $(TOPDIR)/$(CPUDIR)/$(SOC)/asm-offsets.c -c -S
 #########################################################################
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 build: Add targets for auto gen of asm-offsets.h and use it in imx35

Quoted 3 lines · Matthias Weisser

asm-offsets.h should be auto generated. This patch adds two rules to rules.mk which makes this possible and removes the rules on imx35.

Hi Matthias,

rules.mk $(HOSTOBJS): $(obj)%.o: %.c

Quoted 5 lines
rules.mk +0 -0
index c2860e5..5fd12a0 100644
@@ -42,4 +42,14 @@ $(HOSTOBJS): $(obj)%.o: %.c

Agree. Moving the rules to a general place is the first step, as suggested by Wolfgang.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 build: Add targets for auto gen of asm-offsets.h and use it in imx35

In reply to Matthias Weisser
Quoted 14 lines · Matthias Weisser

asm-offsets.h should be auto generated. This patch adds two rules to rules.mk which makes this possible and removes the rules on imx35.

---
 arch/arm/cpu/arm1136/mx35/Makefile |   11 -----------
 rules.mk                           |   10 ++++++++++
 2 files changed, 10 insertions(+), 11 deletions(-)
arch/arm/cpu/arm1136/mx35/Makefile +0 -0
index 20f36e3..284cdc5 100644

arch/arm/cpu/arm1136/mx35/Makefile include $(SRCTREE)/rules.mk · line 51

Quoted 2 lines
arch/arm/cpu/arm1136/mx35/Makefile +0 -0
@@ -50,14 +50,3 @@ include $(SRCTREE)/rules.mk
 sinclude $(obj).depend
 

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================