Note on the large files support in sqlite(as part of Qt)
Hi all,
In git i saw a
http://git.buildroot.net/buildroot/commit/?id=7e4d47593850851d6fcaa6068258c16cc8761ab5
commit, but it seems it is no longer necessary.
Look at this page http://bugreports.qt.nokia.com/browse/QTBUG-15395
Patch from qt bugtracker already included in the upstream, at least it is in the Qt 4.7.3 release.
This means that the qt build system itself conveys the desired flag(-DSQLITE_DISABLE_LFS) for sqlite.
Regards, Sergey
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sergey" == Sergey Gusarov <[email protected]> writes:
Sergey> Hi all,
Sergey> In git i saw a
Sergey> http://git.buildroot.net/buildroot/commit/?id=7e4d47593850851d6fcaa6068258c16cc8761ab5
Sergey> commit, but it seems it is no longer necessary.
Sergey> Look at this page http://bugreports.qt.nokia.com/browse/QTBUG-15395
Sergey> Patch from qt bugtracker already included in the upstream, at least it Sergey> is in the Qt 4.7.3 release.
Sergey> This means that the qt build system itself conveys the desired
Sergey> flag(-DSQLITE_DISABLE_LFS) for sqlite.
Really?
$ grep -rls SQLITE_DISABLE_LFS qt-everywhere-opensource-src-4.7.3 qt-everywhere-opensource-src-4.7.3/src/3rdparty/sqlite/sqlite3.c $
Did you try it?
Signature · 1 line
Bye, Peter Korsgaard
Quoted 1 line · Peter Korsgaard
Quoted 1 line
Patch from qt bugtracker already included in the upstream, at least
it is in the Qt 4.7.3 release.
Quoted 4 lines
Really?
$ grep -rls SQLITE_DISABLE_LFS qt-everywhere-opensource-src-4.7.3 qt-everywhere-opensource-src-4.7.3/src/3rdparty/sqlite/sqlite3.c $
Oh, i was wrong. My Qt 4.7.3 sources were already patched. The patch is not yet included. Nevertheless, it seems correct errors in upsteam project more accurately.
Quoted 1 line
Did you try it?
Yes. I compiled qt with uclibc-based toolchain without LFS. You also can try to do this.
Regards, Sergey
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sergey" == Sergey Gusarov <[email protected]> writes:
Hi,
Sergey> Oh, i was wrong. My Qt 4.7.3 sources were already patched. The patch Sergey> is not yet included. Nevertheless, it seems correct errors in upsteam Sergey> project more accurately.
Sorry, I cannot parse the last sentence. What do you mean exactly? That I should have submitted a bug report to Qt?
Quoted 1 line
Quoted 1 line
Did you try it?
Sergey> Yes. I compiled qt with uclibc-based toolchain without LFS. You also Sergey> can try to do this.
Well, I did - That's why I added the commit in the first place. Are you saying that the commit somehow isn't needed?
From a quick look at the patch in the qt bugtracker, it seem like only the sqlite extension is fixed, not webkit.
Signature · 1 line
Bye, Peter Korsgaard
Quoted 1 line · Peter Korsgaard
Well, I did - That's why I added the commit in the first place. Are
you saying that the commit somehow isn't needed?
It seems that now we can not do anything. Just your decision may be irrelevant (redundant) in the near future
(depending on the activity of the qt developers).
Sorry for your troubles.
Regards, Sergey