New packages: acl and attr

PATCH New Yegor Yefremov 3 participants 3 messages Jul 12, 2011

Share & tools

Yegor Yefremov

author

2011-07-12 08:00 UTC #0 lore raw

PATCH v3 1/1 New packages: acl and attr

In addition to providing the acl and extended attributes functionality, these new packages satisfy newer udev versions, so you can build all extras.

Signed-off-by Heiko Zuerker <[email protected]>

Signed-off-by Daniel Mack <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>

---
 package/Config.in      |    2 ++
 package/acl/Config.in  |    8 ++++++++
 package/acl/acl.mk     |   28 ++++++++++++++++++++++++++++
 package/attr/Config.in |    7 +++++++
 package/attr/attr.mk   |   27 +++++++++++++++++++++++++++
 5 files changed, 72 insertions(+)
 create mode 100644 package/acl/Config.in
 create mode 100644 package/acl/acl.mk
 create mode 100644 package/attr/Config.in
 create mode 100644 package/attr/attr.mk

package/Config.in +2 -0

Index: b/package/Config.in
===================================================================
@@ -492,6 +492,8 @@
 endmenu
 
 menu "System tools"
+source "package/acl/Config.in"
+source "package/attr/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/bootutils/Config.in"
 endif

package/acl/Config.in new file +8 -0

Index: b/package/acl/Config.in
===================================================================
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_ACL
+	bool "acl"
+	select BR2_PACKAGE_ATTR
+	help
+	  POSIX Access Control Lists, which are used to define more
+	  fine-grained discretionary access rights for files and
+	  directories.
+	  This package also provides libacl.

package/acl/acl.mk new file +28 -0

Index: b/package/acl/acl.mk
===================================================================
@@ -0,0 +1,28 @@
+#############################################################
+#
+# acl
+#
+#############################################################
+
+ACL_VERSION = 2.2.49
+ACL_SOURCE = acl_$(ACL_VERSION).orig.tar.gz
+ACL_SITE = http://ftp.debian.org/debian/pool/main/a/acl
+ACL_INSTALL_STAGING = YES
+ACL_DEPENDENCIES = attr
+ACL_CONF_OPT = --enable-gettext=no
+
+# While the configuration system uses autoconf, the Makefiles are
+# hand-written and do not use automake. Therefore, we have to hack
+# around their deficiencies by passing installation paths.
+ACL_INSTALL_STAGING_OPT = 			\
+	prefix=$(STAGING_DIR)/usr 		\
+	exec_prefix=$(STAGING_DIR)/usr 		\
+	PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib	\
+	install-dev install-lib
+
+ACL_INSTALL_TARGET_OPT = 			\
+	prefix=$(TARGET_DIR)/usr 		\
+	exec_prefix=$(TARGET_DIR)/usr 		\
+	install install-lib
+
+$(eval $(call AUTOTARGETS,package,acl))

package/attr/Config.in new file +7 -0

Index: b/package/attr/Config.in
===================================================================
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_ATTR
+	bool "attr"
+	help
+	  Extended attributes are name:value pairs associated permanently with
+	  files and directories, similar to the environment strings associated
+	  with a process
+	  This package also provides libattr.

package/attr/attr.mk new file +27 -0

Index: b/package/attr/attr.mk
===================================================================
@@ -0,0 +1,27 @@
+#############################################################
+#
+# attr
+#
+#############################################################
+
+ATTR_VERSION = 2.4.46
+ATTR_SOURCE = attr_$(ATTR_VERSION).orig.tar.gz
+ATTR_SITE = http://ftp.debian.org/debian/pool/main/a/attr
+ATTR_INSTALL_STAGING = YES
+ATTR_CONF_OPT = --enable-gettext=no
+
+# While the configuration system uses autoconf, the Makefiles are
+# hand-written and do not use automake. Therefore, we have to hack
+# around their deficiencies by passing installation paths.
+ATTR_INSTALL_STAGING_OPT = 			\
+	prefix=$(STAGING_DIR)/usr 		\
+	exec_prefix=$(STAGING_DIR)/usr 		\
+	PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib 	\
+	install-dev install-lib
+
+ATTR_INSTALL_TARGET_OPT = 			\
+	prefix=$(TARGET_DIR)/usr 		\
+	exec_prefix=$(TARGET_DIR)/usr 		\
+	install install-lib
+
+$(eval $(call AUTOTARGETS,package,attr))

Thomas Petazzoni

2011-07-12 09:13 UTC #1 lore raw

PATCH v3 1/1 New packages: acl and attr

Le Tue, 12 Jul 2011 10:00:59 +0200,
Yegor Yefremov <[email protected]> a ?crit :

Quoted 7 lines

In addition to providing the acl and extended attributes functionality, these new packages satisfy newer udev versions, so you can build all extras.
Signed-off-by Heiko Zuerker <[email protected]>
Signed-off-by Daniel Mack <[email protected]>
Signed-off-by Yegor Yefremov <[email protected]>

Acked-by Thomas Petazzoni <[email protected]>

Peter, can you merge this relatively quickly ? I'd really like to see the rest of Yegor patches, in order to have a modern version of udev in Buildroot.

Thanks!

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Peter Korsgaard

2011-07-12 15:24 UTC #2 lore raw

PATCH v3 1/1 New packages: acl and attr

In reply to Yegor Yefremov

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yegor" == Yegor Yefremov <[email protected]> writes:

Yegor> In addition to providing the acl and extended attributes functionality, Yegor> these new packages satisfy newer udev versions, so you can build all extras.

Thanks, see below for a few comments..

Yegor> Signed-off-by: Heiko Zuerker <[email protected]> Yegor> Signed-off-by: Daniel Mack <[email protected]> Yegor> Signed-off-by: Yegor Yefremov <[email protected]> Yegor> ---

 Yegor>  package/Config.in      |    2 ++
 Yegor>  package/acl/Config.in  |    8 ++++++++
 Yegor>  package/acl/acl.mk     |   28 ++++++++++++++++++++++++++++
 Yegor>  package/attr/Config.in |    7 +++++++
 Yegor>  package/attr/attr.mk   |   27 +++++++++++++++++++++++++++
 Yegor>  5 files changed, 72 insertions(+)
 Yegor>  create mode 100644 package/acl/Config.in
 Yegor>  create mode 100644 package/acl/acl.mk
 Yegor>  create mode 100644 package/attr/Config.in
 Yegor>  create mode 100644 package/attr/attr.mk

Yegor> Index: b/package/Config.in
Yegor> =================================================================== Yegor> --- a/package/Config.in
Yegor> +++ b/package/Config.in
Yegor> @@ -492,6 +492,8 @@
Yegor> endmenu

Yegor> menu "System tools"
Yegor> +source "package/acl/Config.in"
Yegor> +source "package/attr/Config.in"

 Yegor>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 Yegor>  source "package/bootutils/Config.in"
 Yegor>  endif
 Yegor> Index: b/package/acl/Config.in
 Yegor> ===================================================================
 Yegor> --- /dev/null
 Yegor> +++ b/package/acl/Config.in
 Yegor> @@ -0,0 +1,8 @@
 Yegor> +config BR2_PACKAGE_ACL
 Yegor> +	bool "acl"
 Yegor> +	select BR2_PACKAGE_ATTR
 Yegor> +	help
 Yegor> +	  POSIX Access Control Lists, which are used to define more
 Yegor> +	  fine-grained discretionary access rights for files and
 Yegor> +	  directories.
 Yegor> +	  This package also provides libacl.

No upstream URL? (seems to be http://savannah.nongnu.org/projects/acl)

Yegor> Index: b/package/acl/acl.mk
Yegor> =================================================================== Yegor> --- /dev/null
Yegor> +++ b/package/acl/acl.mk
Yegor> @@ -0,0 +1,28 @@
Yegor> +############################################################# Yegor> +#
Yegor> +# acl
Yegor> +#
Yegor> +############################################################# Yegor> +
Yegor> +ACL_VERSION = 2.2.49
Yegor> +ACL_SOURCE = acl_$(ACL_VERSION).orig.tar.gz
Yegor> +ACL_SITE = http://ftp.debian.org/debian/pool/main/a/acl

Why are you using Debian as upstream instead of
http://download.savannah.gnu.org/releases/acl/? Latest release seems to be 2.2.51.

Yegor> +++ b/package/attr/Config.in

Ideally this should be 2 independent patches, but ok ..

Yegor> @@ -0,0 +1,7 @@
Yegor> +config BR2_PACKAGE_ATTR
Yegor> + bool "attr"
Yegor> + help

 Yegor> +	  Extended attributes are name:value pairs associated permanently with
 Yegor> +	  files and directories, similar to the environment strings associated
 Yegor> +	  with a process

A trailing dot (.) is missing. Instead of explaining what extended attributes are, perhaps we should rather explain what the package contains - E.G. something like:

Utilities/library for manipulating filesystem extended attributes

Yegor> + This package also provides libattr.

No upstream URL (seems to be http://savannah.nongnu.org/projects/attr)

Yegor> Index: b/package/attr/attr.mk
Yegor> =================================================================== Yegor> --- /dev/null
Yegor> +++ b/package/attr/attr.mk
Yegor> @@ -0,0 +1,27 @@
Yegor> +############################################################# Yegor> +#
Yegor> +# attr
Yegor> +#
Yegor> +############################################################# Yegor> +
Yegor> +ATTR_VERSION = 2.4.46
Yegor> +ATTR_SOURCE = attr_$(ATTR_VERSION).orig.tar.gz
Yegor> +ATTR_SITE = http://ftp.debian.org/debian/pool/main/a/attr

Again, why Debian instead of http://download.savannah.gnu.org/releases/attr/?

Yegor> +ATTR_INSTALL_STAGING = YES
Yegor> +ATTR_CONF_OPT = --enable-gettext=no
Yegor> +
Yegor> +# While the configuration system uses autoconf, the Makefiles are Yegor> +# hand-written and do not use automake. Therefore, we have to hack Yegor> +# around their deficiencies by passing installation paths.
Yegor> +ATTR_INSTALL_STAGING_OPT = \
Yegor> + prefix=$(STAGING_DIR)/usr \
Yegor> + exec_prefix=$(STAGING_DIR)/usr \
Yegor> + PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib \
Yegor> + install-dev install-lib
Yegor> +
Yegor> +ATTR_INSTALL_TARGET_OPT = \
Yegor> + prefix=$(TARGET_DIR)/usr \
Yegor> + exec_prefix=$(TARGET_DIR)/usr \
Yegor> + install install-lib
Yegor> +
Yegor> +$(eval $(call AUTOTARGETS,package,attr))

Signature · 1 line

Bye, Peter Korsgaard