MX51: efikamx: fix wrong name in boards.cfg
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Wrong name in boards.cfg for the efikamx board
makes that some files of the mx51evk instead of
efikamx are used.
--- boards.cfg | 2 +- include/configs/efikamx.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)
boards.cfg +1 -1
@@ -140,7 +140,7 @@ omap5912osk arm arm926ejs - ti edminiv2 arm arm926ejs - LaCie orion5x dkb arm arm926ejs - Marvell pantheon ca9x4_ct_vxp arm armv7 vexpress armltd -efikamx arm armv7 efikamx - mx5 mx51evk:IMX_CONFIG=board/efikamx/imximage.cfg +efikamx arm armv7 efikamx - mx5 efikamx:IMX_CONFIG=board/efikamx/imximage.cfg mx51evk arm armv7 mx51evk freescale mx5 mx51evk:IMX_CONFIG=board/freescale/mx51evk/imximage.cfg mx53ard arm armv7 mx53ard freescale mx5 mx53ard:IMX_CONFIG=board/freescale/mx53ard/imximage_dd3.cfg mx53evk arm armv7 mx53evk freescale mx5 mx53evk:IMX_CONFIG=board/freescale/mx53evk/imximage.cfg
include/configs/efikamx.h +2 -0
@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_TEXT_BASE 0x97800000 +#define CONFIG_SYS_L2CACHE_OFF /*
Signature · 1 line
1.7.1
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Dear Stefano Babic,
Quoted 10 lines · In message <[email protected]> you wrote:
Wrong name in boards.cfg for the efikamx board
makes that some files of the mx51evk instead of
efikamx are used.Signed-off-by Stefano Babic <[email protected]>CC Marek Vasut <[email protected]>--- boards.cfg | 2 +- include/configs/efikamx.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)
Um... the CONFIG_SYS_TEXT_BASE is unrelated and should be submitted in a separate patch.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de HEALTH WARNING: Care Should Be Taken When Lifting This Product, Since Its Mass, and Thus Its Weight, Is Dependent on Its Velocity Relative to the User.
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Quoted 14 lines · Wolfgang Denk
Dear Stefano Babic,
Quoted 10 lines · In message <[email protected]> you wrote:
Wrong name in boards.cfg for the efikamx board
makes that some files of the mx51evk instead of
efikamx are used.Signed-off-by Stefano Babic <[email protected]>CC Marek Vasut <[email protected]>--- boards.cfg | 2 +- include/configs/efikamx.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)
Quoted 3 lines
Um... the
CONFIG_SYS_TEXT_BASEis unrelated and should be submitted in a separate patch.
Agree. Fix in V2
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Quoted 12 lines · Stefano Babic
Quoted 11 lines · Wolfgang Denk
Dear Stefano Babic,
Quoted 8 lines · In message <[email protected]> you wrote:
Wrong name in boards.cfg for the efikamx board
makes that some files of the mx51evk instead of
efikamx are used.Signed-off-by Stefano Babic <[email protected]>CC Marek Vasut <[email protected]>---
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
boards.cfg | 2 +- include/configs/efikamx.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)Um... the
CONFIG_SYS_TEXT_BASEis unrelated and should be submitted in a separate patch.Agree. Fix in V2
Right, Jana's on vacation till 18th, but I guess I can split it and send pullrq ... whatever.
Quoted 3 lines
Best regards,
Stefano Babic
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
In reply to Stefano BabicQuoted 3 lines · Stefano Babic
Wrong name in boards.cfg for the efikamx board
makes that some files of the mx51evk instead of
efikamx are used.
Jana fixed this some time ago ... I have it in my tree and I send it recently to he ML ...
http://git.denx.de/?p=u-boot/u-boot-
pxa.git;a=commit;h=ce52afa30284fb08a3129ed86f053e2b0e9b9a5e
Quoted 13 lines
Signed-off-by Stefano Babic <[email protected]>CC Marek Vasut <[email protected]>--- boards.cfg | 2 +- include/configs/efikamx.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)boards.cfg +0
-0
boards.cfg omap5912osk arm arm926ejs - · line 141
Quoted 2 lines
boards.cfg +0
-0@@ -140,7 +140,7 @@ omap5912osk arm arm926ejs - ti edminiv2 arm arm926ejs - LaCie orion5x dkb arm
arm926ejs
Quoted 10 lines
boards.cfg +0
-0- Marvell pantheon ca9x4_ct_vxparm armv7 vexpress armltd -efikamx
arm armv7 efikamx -
mx5 mx51evk:IMX_CONFIG=board/efikamx/imximage.cfg +efikamx
arm armv7 efikamx -
mx5 efikamx:IMX_CONFIG=board/efikamx/imximage.cfg mx51evk
arm armv7 mx51evk freescale
mx5 mx51evk:IMX_CONFIG=board/freescale/mx51evk/imximage.cfg mx53ard
arm armv7 mx53ard freescale
mx5 mx53ard:IMX_CONFIG=board/freescale/mx53ard/imximage_dd3.cfg
mx53evk
Quoted 15 lines
arm armv7 mx53evk freescale
mx5 mx53evk:IMX_CONFIG=board/freescale/mx53evk/imximage.cfg diff --gita/include/configs/efikamx.hb/include/configs/efikamx.hindex a04ac49..9c98cdc 100644include/configs/efikamx.h +2
-0@@ -38,6 +38,8 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_TEXT_BASE 0x97800000 +#define CONFIG_SYS_L2CACHE_OFF /*
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Dear Marek Vasut,
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 3 lines · Stefano Babic
Wrong name in boards.cfg for the efikamx board
makes that some files of the mx51evk instead of
efikamx are used.Jana fixed this some time ago ... I have it in my tree and I send it recently to he ML ...
http://git.denx.de/?p=u-boot/u-boot-
pxa.git;a=commit;h=ce52afa30284fb08a3129ed86f053e2b0e9b9a5e
But this is wrong. This is a iMX system, so all patches must go through the iMX custodian and his repositor.
This has no place in the u-boot-pxa reporistory. Please make sure to remove it there before you send any pull requests to Albert.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Uncontrolled power will turn even saints into savages. And we can all be counted on to live down to our lowest impulses. -- Parmen, "Plato's Stepchildren", stardate 5784.3
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Quoted 11 lines · Wolfgang Denk
Dear Marek Vasut,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 3 lines · Stefano Babic
Wrong name in boards.cfg for the efikamx board
makes that some files of the mx51evk instead of
efikamx are used.Jana fixed this some time ago ... I have it in my tree and I send it recently to he ML ...
Quoted 8 lines
Quoted 2 lines
http://git.denx.de/?p=u-boot/u-boot-
pxa.git;a=commit;h=ce52afa30284fb08a3129ed86f053e2b0e9b9a5eBut this is wrong. This is a iMX system, so all patches must go through the iMX custodian and his repositor.
This has no place in the u-boot-pxa reporistory. Please make sure to remove it there before you send any pull requests to Albert.
Shall I prepare a branch with the stuff I want up and send pull rq to albert ?
Quoted 4 lines
Best regards,
Wolfgang Denk
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Dear Marek Vasut,
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 3 lines
This has no place in the u-boot-pxa reporistory. Please make sure to remove it there before you send any pull requests to Albert.
Shall I prepare a branch with the stuff I want up and send pull rq to albert ?
I'm a bit surprised by thi squestion. Yes, if you have any patches in the pxa repository that shall go intoi mainline, then you are supposed to send a pull request to Albert. Otherwise nothing will happen.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de All this doesn't alter anything, you know. The world is still full of stupid people. They don't use their brains. They don't seem to want to think straight. - Terry Pratchett, _Soul Music_
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Quoted 6 lines · Wolfgang Denk
Dear Marek Vasut,
Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 2 lines
This has no place in the u-boot-pxa reporistory. Please make sure to remove it there before you send any pull requests to Albert.
Quoted 6 lines
Quoted 2 lines
Shall I prepare a branch with the stuff I want up and send pull rq to albert ?
I'm a bit surprised by thi squestion. Yes, if you have any patches in the pxa repository that shall go intoi mainline, then you are supposed to send a pull request to Albert. Otherwise nothing will happen.
No, I mean branch in u-boot-pxa ... since they are unrelated.
Quoted 4 lines
Best regards,
Wolfgang Denk
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Quoted 7 lines · Marek Vasut
Quoted 6 lines · Wolfgang Denk
Dear Marek Vasut,
Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 2 lines
This has no place in the u-boot-pxa reporistory. Please make sure to remove it there before you send any pull requests to Albert.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Shall I prepare a branch with the stuff I want up and send pull rq to albert ?
I'm a bit surprised by thi squestion. Yes, if you have any patches in the pxa repository that shall go intoi mainline, then you are supposed to send a pull request to Albert. Otherwise nothing will happen.
No, I mean branch in u-boot-pxa ... since they are unrelated.
Marek,
I missed Jana's patches (they were sent yesterday, I see now), and I get the same bug today after rebuilding all i.MX boards - this is the reason for my patches on the same issue.
I will take Jana's patches and I will apply them to u-boot-imx. You do not need to apply to u-boot-imx, as they are unrelated to PXA
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
In reply to Marek VasutDear Marek Vasut,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 4 lines
I'm a bit surprised by thi squestion. Yes, if you have any patches in the pxa repository that shall go intoi mainline, then you are supposed to send a pull request to Albert. Otherwise nothing will happen.
No, I mean branch in u-boot-pxa ... since they are unrelated.
Patches are normally picked up by the respective custodian. If you are anot the responsible custodian, you normally don't have to care about patches - actually this is usually even counter productive.
I find the most efficient way to pick up patches to be from patchwork, because this already takes care about things like automatically adding the respective Acked-by: lines, etc.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sometimes a man will tell his bartender things he'll never tell his doctor.
-- Dr. Phillip Boyce, "The Menagerie" ("The Cage"),
stardate unknown.PATCH 1/1 MX51: efikamx: fix wrong name in boards.cfg
Quoted 5 lines · Wolfgang Denk
Quoted 1 line
No, I mean branch in u-boot-pxa ... since they are unrelated.
Patches are normally picked up by the respective custodian. If you are anot the responsible custodian, you normally don't have to care about patches - actually this is usually even counter productive.
Correct - I care about Jana's patches - drop them from u-boot-pxa
Quoted 3 lines
I find the most efficient way to pick up patches to be from patchwork, because this already takes care about things like automatically adding the respective Acked-by: lines, etc.
Agree. It is a very comfortable way to to things, and saves a lot of time.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================