am3517evm: change console device from ttyS2 to ttyO2

PATCH Superseded Yegor Yefremov 3 participants 6 messages Jul 18, 2011

lore

Share & tools

lore

Yegor Yefremov

author

2011-07-18 08:48 UTC #0 lore raw

PATCH v2 1/1 am3517evm: change console device from ttyS2 to ttyO2

Albert ARIBAUD

2011-07-18 09:41 UTC #1 lore raw

PATCH v2 1/1 am3517evm: change console device from ttyS2 to ttyO2

Le 18/07/2011 10:48, Yegor Yefremov a ?crit :

Quoted 19 lines

Quoted 1 line
From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
From: Yegor Yefremov<[email protected]>
Date: Mon, 18 Jul 2011 10:37:35 +0200
Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
the serial device names have been changed from ttySx to ttyOx, so the console device name should be also changed to support the latest kernel versions.
Signed-off-by Yegor Yefremov<[email protected]>
---
  include/configs/am3517_evm.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/am3517_evm.h +0 -0
index 80ad342..18aaadf 100644

include/configs/am3517_evm.h line 196

Quoted 8 lines

include/configs/am3517_evm.h +1 -1

@@ -190,7 +190,7 @@
 
  #define CONFIG_EXTRA_ENV_SETTINGS \
  	"loadaddr=0x82000000\0" \
-	"console=ttyS2,115200n8\0" \
+	"console=ttyO2,115200n8\0" \
  	"mmcargs=setenv bootargs console=${console} " \
  		"root=/dev/mmcblk0p2 rw " \
  		"rootfstype=ext3 rootwait\0" \

Cc:ing board maintainer, Vaibhav Hiremath <[email protected]> according to MAINTAINERS, for ACK.NAK.

(apologies: I should have done this already in reply to patch V1).

Amicalement,

Signature · 1 line

Albert.

Yegor Yefremov

author

2011-07-18 10:18 UTC #2 lore raw

PATCH v2 1/1 am3517evm: change console device from ttyS2 to ttyO2

Am 18.07.2011 11:41, schrieb Albert ARIBAUD:

Quoted 31 lines

Le 18/07/2011 10:48, Yegor Yefremov a ?crit :
Quoted 19 lines
Quoted 1 line
From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
From: Yegor Yefremov<[email protected]>
Date: Mon, 18 Jul 2011 10:37:35 +0200
Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
the serial device names have been changed from ttySx to ttyOx, so the console device name should be also changed to support the latest kernel versions.
Signed-off-by Yegor Yefremov<[email protected]>
---
  include/configs/am3517_evm.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/am3517_evm.h +0 -0
index 80ad342..18aaadf 100644
include/configs/am3517_evm.h line 196
Quoted 8 lines
include/configs/am3517_evm.h +1 -1
@@ -190,7 +190,7 @@
 
  #define CONFIG_EXTRA_ENV_SETTINGS \
      "loadaddr=0x82000000\0" \
-    "console=ttyS2,115200n8\0" \
+    "console=ttyO2,115200n8\0" \
      "mmcargs=setenv bootargs console=${console} " \
          "root=/dev/mmcblk0p2 rw " \
          "rootfstype=ext3 rootwait\0" \
Cc ing board maintainer, Vaibhav Hiremath <[email protected]> according to MAINTAINERS, for ACK.NAK.

Quoted 1 line

(apologies: I should have done this already in reply to patch V1).

Could you apply the patch (v2) now?

Yegor

Hiremath

2011-07-18 10:23 UTC #3 lore raw

PATCH v2 1/1 am3517evm: change console device from ttyS2 to ttyO2

Quoted 41 lines

-----Original Message-----
From: Yegor Yefremov [mailto:yegor_sub1 at visionsystems.de]
Sent: Monday, July 18, 2011 3:48 PM
To: Albert ARIBAUD
Cc: u-boot at lists.denx.de; Hiremath, Vaibhav
Subject: Re: [PATCH v2] am3517evm: change console device from ttyS2 to ttyO2
Am 18.07.2011 11:41, schrieb Albert ARIBAUD:
Quoted 10 lines
Le 18/07/2011 10:48, Yegor Yefremov a ?crit :
Quoted 9 lines
Quoted 1 line
From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
From: Yegor Yefremov<[email protected]>
Date: Mon, 18 Jul 2011 10:37:35 +0200
Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
the serial device names have been changed from ttySx to ttyOx, so the console device name should be also changed to support the latest kernel versions.
Quoted 6 lines
Review
Quoted 6 lines
Signed-off-by Yegor Yefremov<[email protected]>
---
  include/configs/am3517_evm.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0
b/include/configs/am3517_evm.h
Quoted 5 lines
Quoted 5 lines
index 80ad342..18aaadf 100644
include/configs/am3517_evm.h +0 -0
@@ -190,7 +190,7 @@
 
Quoted 9 lines
include/configs/am3517_evm.h line 196
Quoted 7 lines
include/configs/am3517_evm.h +1 -1
  #define CONFIG_EXTRA_ENV_SETTINGS \
      "loadaddr=0x82000000\0" \
-    "console=ttyS2,115200n8\0" \
+    "console=ttyO2,115200n8\0" \
      "mmcargs=setenv bootargs console=${console} " \
          "root=/dev/mmcblk0p2 rw " \
          "rootfstype=ext3 rootwait\0" \
Cc ing board maintainer, Vaibhav Hiremath <[email protected]> according to

Quoted 6 lines

MAINTAINERS, for ACK.NAK.
Quoted 2 lines
(apologies: I should have done this already in reply to patch V1).
Could you apply the patch (v2) now?

[Hiremath, Vaibhav] Acked-by: Vaibhav Hiremath <[email protected]>

Thanks,
Vaibhav

Quoted 1 line

Yegor

Albert ARIBAUD

2011-07-18 10:37 UTC #4 lore raw

PATCH v2 1/1 am3517evm: change console device from ttyS2 to ttyO2

Le 18/07/2011 12:23, Hiremath, Vaibhav a ?crit :

Quoted 43 lines

Quoted 43 lines
-----Original Message-----
From: Yegor Yefremov [mailto:yegor_sub1 at visionsystems.de]
Sent: Monday, July 18, 2011 3:48 PM
To: Albert ARIBAUD
Cc: u-boot at lists.denx.de; Hiremath, Vaibhav
Subject: Re: [PATCH v2] am3517evm: change console device from ttyS2 to ttyO2
Am 18.07.2011 11:41, schrieb Albert ARIBAUD:
Quoted 10 lines
Le 18/07/2011 10:48, Yegor Yefremov a ?crit :
Quoted 9 lines
Quoted 1 line
From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
From: Yegor Yefremov<[email protected]>
Date: Mon, 18 Jul 2011 10:37:35 +0200
Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
the serial device names have been changed from ttySx to ttyOx, so the console device name should be also changed to support the latest kernel versions.
Quoted 6 lines
Review
Quoted 6 lines
Signed-off-by Yegor Yefremov<[email protected]>
---
   include/configs/am3517_evm.h |    2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0
b/include/configs/am3517_evm.h
Quoted 5 lines
Quoted 5 lines
index 80ad342..18aaadf 100644
include/configs/am3517_evm.h +0 -0
@@ -190,7 +190,7 @@
 
Quoted 9 lines
include/configs/am3517_evm.h line 196
Quoted 7 lines
include/configs/am3517_evm.h +1 -1
   #define CONFIG_EXTRA_ENV_SETTINGS \
       "loadaddr=0x82000000\0" \
-    "console=ttyS2,115200n8\0" \
+    "console=ttyO2,115200n8\0" \
       "mmcargs=setenv bootargs console=${console} " \
           "root=/dev/mmcblk0p2 rw " \
           "rootfstype=ext3 rootwait\0" \
Cc ing board maintainer, Vaibhav Hiremath<[email protected]> according to
MAINTAINERS, for ACK.NAK.
Quoted 1 line

Quoted 8 lines

Quoted 4 lines
Quoted 1 line
(apologies: I should have done this already in reply to patch V1).
Could you apply the patch (v2) now?
[Hiremath, Vaibhav] Acked-by: Vaibhav Hiremath<[email protected]>
Thanks,
Vaibhav

Now, I can :)

(I did insert Vaibhav's Acked-by manually in the commit message, though)

Quoted 1 line

Quoted 1 line
Yegor

Amicalement,

Signature · 1 line

Albert.

Albert ARIBAUD

2011-07-18 10:37 UTC #5 lore raw

PATCH v2 1/1 am3517evm: change console device from ttyS2 to ttyO2

In reply to Yegor Yefremov

Hi Yegor,

Le 18/07/2011 10:48, Yegor Yefremov a ?crit :

Quoted 19 lines

Quoted 1 line
From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
From: Yegor Yefremov<[email protected]>
Date: Mon, 18 Jul 2011 10:37:35 +0200
Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
the serial device names have been changed from ttySx to ttyOx, so the console device name should be also changed to support the latest kernel versions.
Signed-off-by Yegor Yefremov<[email protected]>
---
  include/configs/am3517_evm.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/am3517_evm.h +0 -0
index 80ad342..18aaadf 100644

include/configs/am3517_evm.h line 196

Quoted 8 lines

include/configs/am3517_evm.h +1 -1

@@ -190,7 +190,7 @@
 
  #define CONFIG_EXTRA_ENV_SETTINGS \
  	"loadaddr=0x82000000\0" \
-	"console=ttyS2,115200n8\0" \
+	"console=ttyO2,115200n8\0" \
  	"mmcargs=setenv bootargs console=${console} " \
  		"root=/dev/mmcblk0p2 rw " \
  		"rootfstype=ext3 rootwait\0" \

Applied, with Vaibhav's Ack, to u-boot-arm/master, thanks!

Amicalement,

Signature · 1 line

Albert.