Armada100: Enable 88E3015 PHY support for GplugD
PATCH 3/4 Armada100: Enable 88E3015 PHY support for GplugD
This patch adds support for 88E3015 PHY for Marvell GplugD board.
--- board/Marvell/gplugd/gplugd.c | 35 +++++++++++++++++++++++++++++++++++ include/configs/gplugd.h | 14 ++++++++++++++ 2 files changed, 49 insertions(+), 0 deletions(-)
board/Marvell/gplugd/gplugd.c +35 -0
@@ -32,6 +32,8 @@#include <mvmfp.h> #include <asm/arch/mfp.h> #include <asm/arch/armada100.h> +#include <asm/gpio.h> +#include <miiphy.h> DECLARE_GLOBAL_DATA_PTR ;
@@ -49,6 +51,7 @@ int board_early_init_f(void) };/* configure MFP's */ mfp_config (mfp_cfg); +return 0 ; }
@@ -58,5 +61,37 @@ int board_init(void) gd->bd->bi_arch_number =MACH_TYPE_SHEEVAD ;/* adress of boot parameters */ gd->bd->bi_boot_params =armd1_sdram_base (0 ) +0x100 ; +/* Assert PHY_RST# */ +gpio_direction_output (CONFIG_SYS_GPIO_PHY_RST ,GPIO_CLR ); +udelay (10 ); +/* Deassert PHY_RST# */ +gpio_set_value (CONFIG_SYS_GPIO_PHY_RST ,GPIO_SET );return 0 ; } + +#ifdef CONFIG_RESET_PHY_R +/* Configure and initialize PHY chip 88E3015 */ +void reset_phy (void ) +{ +u16 phy_adr; +const char *name ="armd-fec0" ; + +if (miiphy_set_current_dev (name)) +return ; + +/* command to read PHY dev address */ +if (miiphy_read (name,0xff ,0xff , (u16 *) &phy_adr)) { +printf ("Err..%s could not read PHY dev address\n" , + __func__); +return ; + } + +/* Set Ethernet LED in TX blink mode */ +miiphy_write (name, phy_adr,PHY_LED_MAN_REG ,0x00 ); +miiphy_write (name, phy_adr,PHY_LED_PAR_SEL_REG ,PHY_LED_VAL ); + +/* reset the phy */ +miiphy_reset (name, phy_adr); +printf ("88E3015 Initialized on %s\n" , name); +} +#endif /* CONFIG_RESET_PHY_R */
include/configs/gplugd.h +14 -0
@@ -65,6 +65,20 @@#undef CONFIG_CMD_NET#undef CONFIG_CMD_NFS +/* GPIO Support */ +#define CONFIG_ARMADA100_GPIO + +/* PHY configuration */ +#define CONFIG_MII +#define CONFIG_CMD_MII +#define CONFIG_RESET_PHY_R +/* 88E3015 register definition */ +#define PHY_LED_PAR_SEL_REG 22 +#define PHY_LED_MAN_REG 25 +#define PHY_LED_VAL 0x5b/* LINK LED1, ACT LED2 */ +/* GPIO Configuration for PHY */ +#define CONFIG_SYS_GPIO_PHY_RST 104/* GPIO104 */ +/* * mv-common.h should be defined after CMD configs since it used them * to enable certain macros
Signature · 1 line
1.7.0.4
PATCH 3/4 Armada100: Enable 88E3015 PHY support for GplugD
Quoted 33 lines
-----Original Message-----
From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
Sent: Monday, July 18, 2011 3:12 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ajay Bhargav
Subject: [PATCH 3/4] Armada100: Enable 88E3015 PHY support for GplugDThis patch adds support for 88E3015 PHY for Marvell GplugD board.
Signed-off-by Ajay Bhargav <[email protected]>--- board/Marvell/gplugd/gplugd.c | 35 +++++++++++++++++++++++++++++++++++ include/configs/gplugd.h | 14 ++++++++++++++ 2 files changed, 49 insertions(+), 0 deletions(-)board/Marvell/gplugd/gplugd.c +2
-0@@ -32,6 +32,8 @@#include <mvmfp.h> #include <asm/arch/mfp.h> #include <asm/arch/armada100.h> +#include <asm/gpio.h> +#include <miiphy.h> DECLARE_GLOBAL_DATA_PTR ;
board/Marvell/gplugd/gplugd.c int board_early_init_f(void) · line 54
Quoted 4 lines
board/Marvell/gplugd/gplugd.c +1
-0@@ -49,6 +51,7 @@ int board_early_init_f(void) };/* configure MFP's */ mfp_config (mfp_cfg); +
Remove this unwanted commit line
board/Marvell/gplugd/gplugd.c int board_init(void) · line 68
Quoted 12 lines
board/Marvell/gplugd/gplugd.c +5
-0return 0 ; }@@ -58,5 +61,37 @@ int board_init(void) gd->bd->bi_arch_number =MACH_TYPE_SHEEVAD ;/* adress of boot parameters */ gd->bd->bi_boot_params =armd1_sdram_base (0 ) +0x100 ; +/* Assert PHY_RST# */ +gpio_direction_output (CONFIG_SYS_GPIO_PHY_RST ,GPIO_CLR ); +udelay (10 ); +/* Deassert PHY_RST# */ +gpio_set_value (CONFIG_SYS_GPIO_PHY_RST ,GPIO_SET );
May you please comment why do you need to set this GPIO?
Quoted 34 lines
board/Marvell/gplugd/gplugd.c +27
-0return 0 ; } + +#ifdef CONFIG_RESET_PHY_R +/* Configure and initialize PHY chip 88E3015 */ +void reset_phy (void ) +{ +u16 phy_adr; +const char *name ="armd-fec0" ; + +if (miiphy_set_current_dev (name)) +return ; + +/* command to read PHY dev address */ +if (miiphy_read (name,0xff ,0xff , (u16 *) &phy_adr)) { +printf ("Err..%s could not read PHY dev address\n" , + __func__); +return ; + } + +/* Set Ethernet LED in TX blink mode */ +miiphy_write (name, phy_adr,PHY_LED_MAN_REG ,0x00 ); +miiphy_write (name, phy_adr,PHY_LED_PAR_SEL_REG ,PHY_LED_VAL ); + +/* reset the phy */ +miiphy_reset (name, phy_adr); +printf ("88E3015 Initialized on %s\n" , name); +} +#endif /* CONFIG_RESET_PHY_R */ include/configs/gplugd.h +0
-0
include/configs/gplugd.h line 71
Quoted 7 lines
include/configs/gplugd.h +4
-0@@ -65,6 +65,20 @@#undef CONFIG_CMD_NET#undef CONFIG_CMD_NFS +/* GPIO Support */ +#define CONFIG_ARMADA100_GPIO + +/* PHY configuration */
This below configuration should be within #ifdef CONFIG_CMD_NET Or more it to asm/arch/config.h (recommended)
include/configs/gplugd.h line 84
Quoted 13 lines
include/configs/gplugd.h +10
-0+#define CONFIG_MII +#define CONFIG_CMD_MII +#define CONFIG_RESET_PHY_R +/* 88E3015 register definition */ +#define PHY_LED_PAR_SEL_REG 22 +#define PHY_LED_MAN_REG 25 +#define PHY_LED_VAL 0x5b/* LINK LED1, ACT LED2 */ +/* GPIO Configuration for PHY */ +#define CONFIG_SYS_GPIO_PHY_RST 104/* GPIO104 */ +/* * mv-common.h should be defined after CMD configs since it used them * to enable certain macros
Regards..
Prafulla . .
Quoted 2 lines
--
1.7.0.4
PATCH 3/4 Armada100: Enable 88E3015 PHY support for GplugD
Quoted 31 lines · ----- "Prafulla Wadaskar
Quoted 6 lines
-----Original Message-----
From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
Sent: Monday, July 18, 2011 3:12 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ajay Bhargav
Subject: [PATCH 3/4] Armada100: Enable 88E3015 PHY support forGplugD
Quoted 24 lines
This patch adds support for 88E3015 PHY for Marvell GplugD board.
Signed-off-by Ajay Bhargav <[email protected]>--- board/Marvell/gplugd/gplugd.c | 35 +++++++++++++++++++++++++++++++++++ include/configs/gplugd.h | 14 ++++++++++++++ 2 files changed, 49 insertions(+), 0 deletions(-)board/Marvell/gplugd/gplugd.c +2
-0@@ -32,6 +32,8 @@#include <mvmfp.h> #include <asm/arch/mfp.h> #include <asm/arch/armada100.h> +#include <asm/gpio.h> +#include <miiphy.h> DECLARE_GLOBAL_DATA_PTR ;
Quoted 7 lines
board/Marvell/gplugd/gplugd.c int board_early_init_f(void) · line 54
Quoted 5 lines
board/Marvell/gplugd/gplugd.c +1
-0@@ -49,6 +51,7 @@ int board_early_init_f(void) };/* configure MFP's */ mfp_config (mfp_cfg); +Remove this unwanted commit line
Okay..
Quoted 4 lines
Quoted 4 lines
board/Marvell/gplugd/gplugd.c +0
-0return 0 ; }
Quoted 11 lines
board/Marvell/gplugd/gplugd.c int board_init(void) · line 68
Quoted 9 lines
board/Marvell/gplugd/gplugd.c +5
-0@@ -58,5 +61,37 @@ int board_init(void) gd->bd->bi_arch_number =MACH_TYPE_SHEEVAD ;/* adress of boot parameters */ gd->bd->bi_boot_params =armd1_sdram_base (0 ) +0x100 ; +/* Assert PHY_RST# */ +gpio_direction_output (CONFIG_SYS_GPIO_PHY_RST ,GPIO_CLR ); +udelay (10 ); +/* Deassert PHY_RST# */ +gpio_set_value (CONFIG_SYS_GPIO_PHY_RST ,GPIO_SET );May you please comment why do you need to set this GPIO?
GPIO 104 is connected to reset pin of 88E3015 PHY. and a reset is required before initializing PHY chip.
Regards,
Ajay Bhargav
PATCH 3/4 Armada100: Enable 88E3015 PHY support for GplugD
Hi Ajay,
Le 19/07/2011 06:10, Ajay Bhargav a ?crit :
Quoted 6 lines
Quoted 3 lines
board/Marvell/gplugd/gplugd.c int board_init(void) · line 68
Quoted 1 line
board/Marvell/gplugd/gplugd.c +1
-0+gpio_set_value (CONFIG_SYS_GPIO_PHY_RST ,GPIO_SET );May you please comment why do you need to set this GPIO?
GPIO 104 is connected to reset pin of 88E3015 PHY. and a reset is required before initializing PHY chip.
I believe Prafulla would like this comment to appear in the code -- anyway, *I* would like it to. :)
Quoted 2 lines
Regards,
Ajay Bhargav
Amicalement,
Signature · 1 line
Albert.
PATCH 3/4 Armada100: Enable 88E3015 PHY support for GplugD
Hi Albert,
Quoted 2 lines
I believe Prafulla would like this comment to appear in the code -- anyway, *I* would like it to. :)
Got it.. will add that :)
Regards,
Ajay Bhargav
PATCH 3/4 Armada100: Enable 88E3015 PHY support for GplugD
In reply to Ajay BhargavQuoted 70 lines
-----Original Message-----
From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
Sent: Tuesday, July 19, 2011 9:41 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [PATCH 3/4] Armada100: Enable 88E3015 PHY support for GplugDQuoted 31 lines · ----- "Prafulla Wadaskar
Quoted 6 lines
-----Original Message-----
From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
Sent: Monday, July 18, 2011 3:12 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ajay Bhargav
Subject: [PATCH 3/4] Armada100: Enable 88E3015 PHY support forGplugD
Quoted 24 lines
This patch adds support for 88E3015 PHY for Marvell GplugD board.
Signed-off-by Ajay Bhargav <[email protected]>--- board/Marvell/gplugd/gplugd.c | 35 +++++++++++++++++++++++++++++++++++ include/configs/gplugd.h | 14 ++++++++++++++ 2 files changed, 49 insertions(+), 0 deletions(-)board/Marvell/gplugd/gplugd.c +2
-0@@ -32,6 +32,8 @@#include <mvmfp.h> #include <asm/arch/mfp.h> #include <asm/arch/armada100.h> +#include <asm/gpio.h> +#include <miiphy.h> DECLARE_GLOBAL_DATA_PTR ;Quoted 7 lines
board/Marvell/gplugd/gplugd.c int board_early_init_f(void) · line 54
Quoted 5 lines
board/Marvell/gplugd/gplugd.c +1
-0@@ -49,6 +51,7 @@ int board_early_init_f(void) };/* configure MFP's */ mfp_config (mfp_cfg); +Remove this unwanted commit line
Okay..
Quoted 4 lines
Quoted 4 lines
board/Marvell/gplugd/gplugd.c +0
-0return 0 ; }Quoted 11 lines
board/Marvell/gplugd/gplugd.c int board_init(void) · line 68
Quoted 9 lines
board/Marvell/gplugd/gplugd.c +5
-0@@ -58,5 +61,37 @@ int board_init(void) gd->bd->bi_arch_number =MACH_TYPE_SHEEVAD ;/* adress of boot parameters */ gd->bd->bi_boot_params =armd1_sdram_base (0 ) +0x100 ; +/* Assert PHY_RST# */ +gpio_direction_output (CONFIG_SYS_GPIO_PHY_RST ,GPIO_CLR ); +udelay (10 ); +/* Deassert PHY_RST# */ +gpio_set_value (CONFIG_SYS_GPIO_PHY_RST ,GPIO_SET );May you please comment why do you need to set this GPIO?
Quoted 2 lines
GPIO 104 is connected to reset pin of 88E3015 PHY. and a reset is required before initializing PHY chip.
So, good to put this as code comment :-)
Regards..
Prafulla . .
Quoted 3 lines
Regards,
Ajay Bhargav