Skip to contentSkip to conversation

Add remaining types to IMAGE_TYPES

PATCH In review Joshua Lock 3 participants 7 messages Jul 26, 2011

lore
Share & tools
lore
#0 lore raw

cover Add remaining types to IMAGE_TYPES

My original patch to add the IMAGE_TYPES variable for use in hob missed several image types from the list. The patch here fixes that.

The following changes since commit f10a3457cdfbb4a94978da998d178d4254632fa7:

Move architecture specific TARGET_OS mangling into tune files (2011-07-25 14:19:54 +0100)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib josh/image-types
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/image-types

Joshua Lock (1):
classes/image_types: IMAGE_TYPES was missing some entries

 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.6
#1 lore raw

PATCH 1/1 classes/image_types: IMAGE_TYPES was missing some entries

Some of these entries are required by the GUI to enable the expected workflow of the ADT, namely a compressed rootfs image.

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image_types.bbclass +1 -1
index 1108802..f1aef86 100644
@@ -103,4 +103,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
 # This variable is available to request which values are suitable for IMAGE_FSTYPES
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi"
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
Signature · 1 line
1.7.6
#2 lore raw

Re: [PATCH 1/1] classes/image_types: IMAGE_TYPES was missing some entries

Quoted 13 lines · Joshua Lock

Some of these entries are required by the GUI to enable the expected workflow of the ADT, namely a compressed rootfs image.

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image_types.bbclass +0 -0
index 1108802..f1aef86 100644

meta/classes/image_types.bbclass IMAGE_DEPENDS_ubi = "mtd-utils-native" · line 106

Quoted 5 lines
meta/classes/image_types.bbclass +1 -1
@@ -103,4 +103,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
 # This variable is available to request which values are suitable for IMAGE_FSTYPES
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi"
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

So, is there some way we can do this dynamically? Either oe-core is missing ext4, or we'll have to add that and all it's permutations. And then there's u-boot signed copies of all of the ext* compressed versions.

Signature · 2 lines
Tom Rini
Mentor Graphics Corporation
#3 lore raw

Re: [PATCH 1/1] classes/image_types: IMAGE_TYPES was missing some entries

Quoted 16 lines · Tom Rini
Quoted 15 lines · Joshua Lock

Some of these entries are required by the GUI to enable the expected workflow of the ADT, namely a compressed rootfs image.

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image_types.bbclass +0 -0
index 1108802..f1aef86 100644
@@ -103,4 +103,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
Quoted 7 lines

meta/classes/image_types.bbclass IMAGE_DEPENDS_ubi = "mtd-utils-native" · line 106

Quoted 3 lines
meta/classes/image_types.bbclass +1 -1
 # This variable is available to request which values are suitable for IMAGE_FSTYPES
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi"
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

So, is there some way we can do this dynamically? Either oe-core is missing ext4, or we'll have to add that and all it's permutations. And then there's u-boot signed copies of all of the ext* compressed versions.

The configs for the image types could do something like:

IMAGE_TYPE += "jffs2"
IMAGE_CMD_jffs2 = "xxx"

or we could switch to the syntax:

IMAGE_CMD[jffs2] = "xxx"

?

Cheers,

Richard

#4 lore raw

Re: [PATCH 1/1] classes/image_types: IMAGE_TYPES was missing some entries

In reply to Joshua Lock
Quoted 7 lines · Joshua Lock

Some of these entries are required by the GUI to enable the expected workflow of the ADT, namely a compressed rootfs image.

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

I've merged this since its obviously correct, we probably do need to think about better ways to generate it though as Tom mentions...

Cheers,

Richard

#5 lore raw

Re: [PATCH 1/1] classes/image_types: IMAGE_TYPES was missing some entries

Quoted 11 lines · Richard Purdie
Quoted 7 lines · Joshua Lock

Some of these entries are required by the GUI to enable the expected workflow of the ADT, namely a compressed rootfs image.

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

I've merged this since its obviously correct, we probably do need to think about better ways to generate it though as Tom mentions...

Agreed, I'll add this to my to do list.

Thanks,
Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
#6 lore raw

Re: [PATCH 1/1] classes/image_types: IMAGE_TYPES was missing some entries

Quoted 10 lines · Joshua Lock
Quoted 9 lines · Richard Purdie
Quoted 7 lines · Joshua Lock

Some of these entries are required by the GUI to enable the expected workflow of the ADT, namely a compressed rootfs image.

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 4 lines
Quoted 2 lines

I've merged this since its obviously correct, we probably do need to think about better ways to generate it though as Tom mentions...

Agreed, I'll add this to my to do list.

Thanks!

Signature · 2 lines
Tom Rini
Mentor Graphics Corporation