Skip to contentSkip to conversation

arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform

PATCH New Kyungmin Park 4 participants 4 messages Jul 27, 2011 – Aug 12, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/1 arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform

From: Evgeny Voevodin <[email protected]>

There is no TCMPB register for Pulse Width Modulation timer4 on samsung exynos4 board. Remove unsupported register write.

Signed-off-by Evgeny Voevodin <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---

 arch/arm/mach-exynos4/time.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-exynos4/time.c +0 -0

index 86b9fa0..48389bf 100644

--- a/arch/arm/mach-exynos4/time.c

+++ b/arch/arm/mach-exynos4/time.c

@@ -77,7 +77,6 @@ static void exynos4_pwm_init(unsigned int pwm_id, unsigned long tcnt)

tcon |= S3C2410_TCON_T4MANUALUPD;

__raw_writel(tcnt, S3C2410_TCNTB(4));

- __raw_writel(tcnt, S3C2410_TCMPB(4));

__raw_writel(tcon, S3C2410_TCON);

break;

Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform

Hello.

Quoted 34 lines · Kyungmin Park

From: Evgeny Voevodin<[email protected]>

There is no TCMPB register for Pulse Width Modulation timer4 on samsung exynos4 board. Remove unsupported register write.

Signed-off-by Evgeny Voevodin<[email protected]>
Signed-off-by Kyungmin Park<[email protected]>

---

  arch/arm/mach-exynos4/time.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-exynos4/time.c +0 -0

index 86b9fa0..48389bf 100644

--- a/arch/arm/mach-exynos4/time.c

+++ b/arch/arm/mach-exynos4/time.c

arch/arm/mach-exynos4/time.c +0 -0
@@ -77,7 +77,6 @@ static void exynos4_pwm_init(unsigned int pwm_id, unsigned long tcnt)
 
  		tcon |= S3C2410_TCON_T4MANUALUPD;

arch/arm/mach-exynos4/time.c static void exynos4_pwm_init(unsigned int pwm_id, unsigned long tcnt)

Quoted 10 lines
arch/arm/mach-exynos4/time.c +0 -1
 
  		__raw_writel(tcnt, S3C2410_TCNTB(4));
 
-		__raw_writel(tcnt, S3C2410_TCMPB(4));
 
  		__raw_writel(tcon, S3C2410_TCON);
 
 
 
  		break;

Looks like the patch was spolied by something -- the extra new lines were
added after each line.

WBR, Sergei

#2 lore raw

PATCH 1/1 arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform

From: Evgeny Voevodin <[email protected]>

There is no TCMPB register for Pulse Width Modulation timer4 on samsung exynos4 board. Remove unsupported register write.

Signed-off-by Evgeny Voevodin <[email protected]>
---
  arch/arm/mach-exynos4/time.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-exynos4/time.c +0 -0
index 86b9fa0..48389bf 100644
@@ -77,7 +77,6 @@ static void exynos4_pwm_init(unsigned int pwm_id,

unsigned long tcnt)
tcon |= S3C2410_TCON_T4MANUALUPD;

__raw_writel(tcnt, S3C2410_TCNTB(4));
- __raw_writel(tcnt, S3C2410_TCMPB(4));
__raw_writel(tcon, S3C2410_TCON);

break;

Signature · 1 line
1.7.4.1
#3 lore raw

PATCH 1/1 arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform

In reply to Sergei Shtylyov
Quoted 45 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Kyungmin Park

From: Evgeny Voevodin<[email protected]>

There is no TCMPB register for Pulse Width Modulation timer4 on samsung

exynos4 board. Remove unsupported register write.

arch/arm/mach-exynos4/time.c static void exynos4_pwm_init(unsigned int pwm_id,

Quoted 21 lines
Signed-off-by Evgeny Voevodin<[email protected]>
Signed-off-by Kyungmin Park<[email protected]>

---

  arch/arm/mach-exynos4/time.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-exynos4/time.c +0 -0

index 86b9fa0..48389bf 100644

--- a/arch/arm/mach-exynos4/time.c

+++ b/arch/arm/mach-exynos4/time.c

arch/arm/mach-exynos4/time.c +0 -0
@@ -77,7 +77,6 @@ static void exynos4_pwm_init(unsigned int pwm_id,

unsigned long tcnt)

Quoted 9 lines
arch/arm/mach-exynos4/time.c +0 -1
  		tcon |= S3C2410_TCON_T4MANUALUPD;
 
 
 
  		__raw_writel(tcnt, S3C2410_TCNTB(4));
 
-		__raw_writel(tcnt, S3C2410_TCMPB(4));
Quoted 8 lines
Quoted 6 lines
  		__raw_writel(tcon, S3C2410_TCON);

break;

Looks like the patch was spolied by something -- the extra new lines

were

Quoted 2 lines

added after each line.

Thanks, Sergei.

And this is not available now...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.