Skip to contentSkip to conversation

Fix a argument WARN bug of scripts/checkpatch.pl

PATCH In review gmail 3 participants 5 messages Jul 28, 2011 – Aug 1, 2011 Checkpatch

lore
Share & tools
lore

gmail

author
#0 lore raw

PATCH 1/1 Fix a argument WARN bug of scripts/checkpatch.pl

Sorry the prev patch have the format error. So I re-send it.

Get following error with a patch that have min_t error:
Use of uninitialized value in concatenation (.) or string at scripts/checkpatch.pl line 1256.
WARNING:
This is because:

				}
				WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
			}

It lost the first argument.
So make a patch to fix it.

Signed-off-by Hui Zhu <[email protected]>
---
 scripts/checkpatch.pl |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/checkpatch.pl +2 -1
@@ -2574,7 +2574,8 @@ sub process {
 				} else {
 					$cast = $cast2;
 				}
-				WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
+				WARN("MINMAX",
+				     "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
 			}
 		}
#1 lore raw
Quoted 2 lines · gmail

Sorry the prev patch have the format error.  So I re-send it.

Hi Hui

Would you please share howto tame gmail not to malform patch produced with git mail?

Thanks,
Hillf

author
#2 lore raw

Use thunderbird and smtp.

Thanks,
Hui

Quoted 11 lines · Hillf Danton
Quoted 2 lines · gmail

Sorry the prev patch have the format error.  So I re-send it.

Hi Hui

Would you please share howto tame gmail not to malform patch produced with git mail?

Thanks,
          Hillf

author
#3 lore raw
In reply to gmail

Ping

Thanks,
Hui

Quoted 31 lines · gmail

Sorry the prev patch have the format error.  So I re-send it.

Get following error with a patch that have min_t error:
Use of uninitialized value in concatenation (.) or string at
scripts/checkpatch.pl line 1256.
WARNING:
This is because:
                               }
                               WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr); }
It lost the first argument.
So make a patch to fix it.

Signed-off-by Hui Zhu <[email protected]>

---
 scripts/checkpatch.pl |    3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/checkpatch.pl +2 -1
@@ -2574,7 +2574,8 @@ sub process {
                                } else {
                                        $cast = $cast2;
                                }
-                               WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
+                               WARN("MINMAX",
+                                    "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
                        }
                }
maintainer Acked-by
#4 lore raw
Quoted 1 line · Hui Zhu

Ping

Please send the original patch again to Andrew Morton <[email protected]>

Acked-by Joe Perches <[email protected]>
Quoted 30 lines

Thanks,
Hui

Quoted 26 lines · gmail

Sorry the prev patch have the format error. So I re-send it.

Get following error with a patch that have min_t error:
Use of uninitialized value in concatenation (.) or string at scripts/checkpatch.pl line 1256.
WARNING:
This is because:

                               }
                               WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);

It lost the first argument.
So make a patch to fix it.

Signed-off-by Hui Zhu <[email protected]>
---
 scripts/checkpatch.pl |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/checkpatch.pl +2 -1
@@ -2574,7 +2574,8 @@ sub process {
                               } else {
                                       $cast = $cast2;
                               }
-                               WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
+                               WARN("MINMAX",
+                                    "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
                       }
               }