omap-common: move early UART clock setup to board.c

PATCH New Simon Schwarz 3 participants 8 messages Jul 28, 2011 – Jul 29, 2011 Arm (32-bit)

Share & tools

Simon Schwarz

author

2011-07-28 09:22 UTC #0 lore raw

PATCH 1/1 omap-common: move early UART clock setup to board.c

This patch moves the setup_clocks_for_console()-call from preloader_console_init() to s_init().
This is done to use the same implementation for OMAP3 and OMAP4

For discussion see: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/104120

This is based on the following patches:
- New SPL framework
- OMAP4 SPL
Both are already in u-boot-ti repo.

Simon Schwarz (1):
omap-common: move early UART clock setup to s_init

 arch/arm/cpu/armv7/omap-common/spl.c |    1 -
 arch/arm/cpu/armv7/omap4/board.c     |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

Signature · 1 line

1.7.4.1

Simon Schwarz

author

2011-07-28 09:22 UTC #1 lore raw

PATCH 1/1 omap-common: move early UART clock setup to s_init

Moves the early UART clock setup setup_clocks_for_console() from preloader_console_init() to s_init() of OMAP4.

Signed-off-by Simon Schwarz <[email protected]>

---
 arch/arm/cpu/armv7/omap-common/spl.c |    1 -
 arch/arm/cpu/armv7/omap4/board.c     |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/cpu/armv7/omap-common/spl.c +0 -1

index d177652..d380b3e 100644
@@ -259,7 +259,6 @@ void preloader_console_init(void)
 	gd->flags |= GD_FLG_RELOC;
 	gd->baudrate = CONFIG_BAUDRATE;
 
-	setup_clocks_for_console();
 	serial_init();		/* serial communications setup */
 
 	/* Avoid a second "U-Boot" coming from this string */

arch/arm/cpu/armv7/omap4/board.c +1 -0

index 5943d61..a9e90de 100644
@@ -196,6 +196,7 @@ void s_init(void)
 	watchdog_init();
 	set_mux_conf_regs();
 #ifdef CONFIG_SPL_BUILD
+	setup_clocks_for_console();
 	preloader_console_init();
 #endif
 	prcm_init();

Signature · 1 line

1.7.4.1

Andreas Bießmann

2011-07-28 09:44 UTC #2 lore raw

PATCH 1/1 omap-common: move early UART clock setup to s_init

Hi Simon,

Am 28.07.2011 11:22, schrieb Simon Schwarz:

Quoted 2 lines

Moves the early UART clock setup setup_clocks_for_console() from preloader_console_init() to s_init() of OMAP4.

I recommend putting this in your 'devkit8000 nand_spl support' series before the current '2/5 omap-common: add nand_spl support' and remove the '#ifdef CONFIG_OMAP34XX' in that patch. Albert how do you think about this?

arch/arm/cpu/armv7/omap-common/spl.c void preloader_console_init(void)

Quoted 11 lines

Signed-off-by Simon Schwarz <[email protected]>

---
 arch/arm/cpu/armv7/omap-common/spl.c |    1 -
 arch/arm/cpu/armv7/omap4/board.c     |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/cpu/armv7/omap-common/spl.c +0 -0

index d177652..d380b3e 100644
@@ -259,7 +259,6 @@ void preloader_console_init(void)

I recommend adding some comment for preloader_console_init() saying 'this requires UART clocks to be enabled before' in this patch.

arch/arm/cpu/armv7/omap-common/spl.c void preloader_console_init(void) · line 264

Quoted 7 lines

arch/arm/cpu/armv7/omap-common/spl.c +0 -1

 	gd->flags |= GD_FLG_RELOC;
 	gd->baudrate = CONFIG_BAUDRATE;
 
-	setup_clocks_for_console();
 	serial_init();		/* serial communications setup */
 
 	/* Avoid a second "U-Boot" coming from this string */

regards

Andreas Bie?mann

Simon Schwarz

author

2011-07-29 12:51 UTC #3 lore raw

PATCH 1/1 omap-common: move early UART clock setup to s_init

Hi Andreas,

Quoted 11 lines · Andreas Bie?mann

Hi Simon,
Am 28.07.2011 11:22, schrieb Simon Schwarz:
Quoted 2 lines
Moves the early UART clock setup setup_clocks_for_console() from preloader_console_init() to s_init() of OMAP4.
I recommend putting this in your 'devkit8000 nand_spl support' series before the current '2/5 omap-common: add nand_spl support' and remove the '#ifdef CONFIG_OMAP34XX' in that patch. Albert how do you think about this?

Since no one objected: I will do this in the next version.

Quoted 6 lines

Signed-off-by Simon Schwarz<[email protected]>

---
  arch/arm/cpu/armv7/omap-common/spl.c |    1 -
  arch/arm/cpu/armv7/omap4/board.c     |    1 +
  2 files changed, 1 insertions(+), 1 deletions(-)

Quoted 8 lines

arch/arm/cpu/armv7/omap-common/spl.c void preloader_console_init(void)
Quoted 5 lines
arch/arm/cpu/armv7/omap-common/spl.c +0 -0
index d177652..d380b3e 100644
@@ -259,7 +259,6 @@ void preloader_console_init(void)
I recommend adding some comment for preloader_console_init() saying 'this requires UART clocks to be enabled before' in this patch.

Will do.

Quoted 4 lines

Quoted 4 lines
arch/arm/cpu/armv7/omap-common/spl.c +0 -0
  	gd->flags |= GD_FLG_RELOC;
  	gd->baudrate = CONFIG_BAUDRATE;
 

Quoted 8 lines

arch/arm/cpu/armv7/omap-common/spl.c void preloader_console_init(void) · line 264
Quoted 4 lines
arch/arm/cpu/armv7/omap-common/spl.c +0 -1
-	setup_clocks_for_console();
  	serial_init();		/* serial communications setup */
 
  	/* Avoid a second "U-Boot" coming from this string */
regards
Andreas Bie?mann

Regards
Simon

Wolfgang Denk

2011-07-28 13:04 UTC #4 lore raw

PATCH 1/1 omap-common: move early UART clock setup to s_init

In reply to Simon Schwarz

Dear Simon Schwarz,

Quoted 8 lines · In message <[email protected]> you…

Moves the early UART clock setup setup_clocks_for_console() from preloader_console_init() to s_init() of OMAP4.
Signed-off-by Simon Schwarz <[email protected]>
---
 arch/arm/cpu/armv7/omap-common/spl.c |    1 -
 arch/arm/cpu/armv7/omap4/board.c     |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

I'm unhappy about the subject. not to mention again that you posted another (empty) patch with basicly the same subject line, but you say "omap-common:" in the subject, while the code looks to be OMAP4 specific? This is kind of misleading.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
365 Days of drinking Lo-Cal beer.                       = 1 Lite-year

Simon Schwarz

author

2011-07-28 14:49 UTC #5 lore raw

PATCH 1/1 omap-common: move early UART clock setup to s_init

Dear Wolfgang Denk,

Quoted 12 lines · Wolfgang Denk

Dear Simon Schwarz,
Quoted 8 lines · In message<[email protected]> you…
Moves the early UART clock setup setup_clocks_for_console() from preloader_console_init() to s_init() of OMAP4.
Signed-off-by Simon Schwarz<[email protected]>
---
  arch/arm/cpu/armv7/omap-common/spl.c |    1 -
  arch/arm/cpu/armv7/omap4/board.c     |    1 +
  2 files changed, 1 insertions(+), 1 deletions(-)

Quoted 5 lines

I'm unhappy about the subject. not to mention again that you posted another (empty) patch with basicly the same subject line, but you say "omap-common:" in the subject, while the code looks to be OMAP4 specific? This is kind of misleading.

Reason: omap-common because it is a omap-common change - the omap4 part is just to fix it up for the SOC which is using it already.

So maybe deleting setup_clocks_for_console() would have been a better subject, sorry.

Quoted 4 lines

Best regards,
Wolfgang Denk

Regards
Simon Schwarz

Wolfgang Denk

2011-07-28 13:02 UTC #6 lore raw

PATCH 1/1 omap-common: move early UART clock setup to board.c

In reply to Simon Schwarz

Dear Simon Schwarz,

Quoted 11 lines · In message <[email protected]> you…

This patch moves the setup_clocks_for_console()-call from preloader_console_init() to s_init().
This is done to use the same implementation for OMAP3 and OMAP4
For discussion see: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/104120
This is based on the following patches:
- New SPL framework
- OMAP4 SPL
Both are already in u-boot-ti repo.

Quoted 6 lines

Simon Schwarz (1):
omap-common: move early UART clock setup to s_init
 arch/arm/cpu/armv7/omap-common/spl.c |    1 -
 arch/arm/cpu/armv7/omap4/board.c     |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

There is no patch in this file anywhere.

Also, please omit the "V0" part in the subject, it makes no sense.

Finally, please don't use the same subject for several changes.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It may be bad manners to talk with your mouth full, but it isn't  too
good either if you speak when your head is empty.

Simon Schwarz

author

2011-07-28 14:53 UTC #7 lore raw

PATCH 1/1 omap-common: move early UART clock setup to board.c

Dear Wolfgang Denk,

Quoted 14 lines · Wolfgang Denk

Dear Simon Schwarz,
Quoted 11 lines · In message<[email protected]> you…
This patch moves the setup_clocks_for_console()-call from preloader_console_init() to s_init().
This is done to use the same implementation for OMAP3 and OMAP4
For discussion see: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/104120
This is based on the following patches:
- New SPL framework
- OMAP4 SPL
Both are already in u-boot-ti repo.

Quoted 8 lines

Quoted 6 lines
Simon Schwarz (1):
omap-common: move early UART clock setup to s_init
  arch/arm/cpu/armv7/omap-common/spl.c |    1 -
  arch/arm/cpu/armv7/omap4/board.c     |    1 +
  2 files changed, 1 insertions(+), 1 deletions(-)
There is no patch in this file anywhere.

No cover-letter for patch series - bad idea - noted.

Quoted 2 lines

Also, please omit the "V0" part in the subject, it makes no sense.

ok.

Quoted 7 lines

Finally, please don't use the same subject for several changes.
Best regards,
Wolfgang Denk

Regards
Simon Schwarz