jfs support for xfstests
RFC PATCH 1/1 jfs support for xfstests
The patch below adds basic jfs support to xfstests. Unfortunately it doesn't get very far, as test 001 already blows up with a kernel crash, as do 011 and 013 as other random picks.
common.rc +3 -0
@@ -102,6 +102,9 @@ _mkfs_opts() gfs2) export MKFS_OPTIONS="$GFS2_MKFS_OPTIONS -O -p lock_nolock" ;; + jfs) + export MKFS_OPTIONS="$JFS_MKFS_OPTIONS -q" + ;; *) ;; esac
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 3 lines · Christoph Hellwig
The patch below adds basic jfs support to xfstests. Unfortunately it doesn't get very far, as test 001 already blows up with a kernel crash, as do 011 and 013 as other random picks.
Great :-)
Seems to be a good idea to support jfs. I'll carve out some time to reproduce and debug the crashes.
Thanks,
Shaggy
Quoted 8 lines
Index: xfstests-dev/common.rc
===================================================================
common.rc _mkfs_opts() · line 110
Quoted 9 lines
common.rc +3
-0@@ -102,6 +102,9 @@ _mkfs_opts() gfs2) export MKFS_OPTIONS="$GFS2_MKFS_OPTIONS -O -p lock_nolock" ;; + jfs) + export MKFS_OPTIONS="$JFS_MKFS_OPTIONS -q" + ;; *) ;; esac
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
PATCH 1/1 jfs: flush journal completely before releasing metadata inodes
Quoted 9 lines · Dave Kleikamp
Quoted 3 lines · Christoph Hellwig
The patch below adds basic jfs support to xfstests. Unfortunately it doesn't get very far, as test 001 already blows up with a kernel crash, as do 011 and 013 as other random picks.
Great :-)
Seems to be a good idea to support jfs. I'll carve out some time to reproduce and debug the crashes.
This fixes a race during unmount. We need to not only make sure that the journal is completely written, but that the metadata changes make it to disk before releasing ipimap and ipbmap.
--- fs/jfs/jfs_umount.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
fs/jfs/jfs_umount.c +2 -2
@@ -68,7 +68,7 @@ int jfs_umount(struct super_block *sb)/* * Wait for outstanding transactions to be written to log: */ -jfs_flush_journal (log,1 ); +jfs_flush_journal (log,2 );/* * close fileset inode allocation map (aka fileset inode)
@@ -146,7 +146,7 @@ int jfs_umount_rw(struct super_block *sb)* * remove file system from log active file system list. */ -jfs_flush_journal (log,1 ); +jfs_flush_journal (log,2 );/* * Make sure all metadata makes it to disk
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH] jfs: flush journal completely before releasing metadata inodes
Quoted 6 lines · Dave Kleikamp
Quoted 5 lines · Dave Kleikamp
Quoted 3 lines · Christoph Hellwig
The patch below adds basic jfs support to xfstests. Unfortunately it doesn't get very far, as test 001 already blows up with a kernel crash, as do 011 and 013 as other random picks.
Quoted 8 lines
Quoted 4 lines
Great :-)
Seems to be a good idea to support jfs. I'll carve out some time to reproduce and debug the crashes.
This fixes a race during unmount. We need to not only make sure that the journal is completely written, but that the metadata changes make it to disk before releasing ipimap and ipbmap.
Looks sensible. How far does a ./check -g auto get now? Any other failures?
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH] jfs: flush journal completely before releasing metadata inodes
Quoted 9 lines · Christoph Hellwig
Quoted 5 lines · Dave Kleikamp
On 07/29/2011 11:03 AM, Dave Kleikamp wrote:
This fixes a race during unmount. We need to not only make sure that the journal is completely written, but that the metadata changes make it to disk before releasing ipimap and ipbmap.
Looks sensible. How far does a ./check -g auto get now? Any other failures?
It runs through them all. A lot of tests get skipped claiming not to be supported on jfs. A failure because jfs doesn't support fallocate and hole-punch, but no crashes.
Shaggy
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH] jfs: flush journal completely before releasing metadata inodes
Quoted 3 lines · Dave Kleikamp
It runs through them all. A lot of tests get skipped claiming not to be supported on jfs. A failure because jfs doesn't support fallocate and hole-punch, but no crashes.
Looks like the fallocate feature tests are broken, I'll look into fixing it.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs