Skip to contentSkip to conversation

ARM MX31: fix clock.h: warning: function declaration isn't a prototype

PATCH New Wolfgang Denk 3 participants 4 messages Jul 30, 2011 – Jul 31, 2011 Arm (32-bit)

lore
Share & tools
lore

Wolfgang Denk

author
#0 lore raw

PATCH 1/1 ARM MX31: fix clock.h: warning: function declaration isn't a prototype

Signed-off-by Wolfgang Denk <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Albert Aribaud <[email protected]>
---
 arch/arm/include/asm/arch-mx31/clock.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-mx31/clock.h +1 -1
index fb035c4..d4565ac 100644
@@ -32,7 +32,7 @@ enum mxc_clock {
 };
 
 unsigned int mxc_get_clock(enum mxc_clock clk);
-extern u32 imx_get_uartclk();
+extern uint32_t imx_get_uartclk(void);
 extern void mx31_gpio_mux(unsigned long mode);
 extern void mx31_set_pad(enum iomux_pins pin, u32 config);
Signature · 1 line
1.7.6
#1 lore raw

PATCH 1/1 ARM MX31: fix clock.h: warning: function declaration isn't a prototype

Wolfgang,

On Sat, Jul 30, 2011 at 7:37 PM, Wolfgang Denk <[email protected]> wrote:
...

Quoted 5 lines

?unsigned int mxc_get_clock(enum mxc_clock clk);

arch/arm/include/asm/arch-mx31/clock.h +1 -1
-extern u32 imx_get_uartclk();
+extern uint32_t imx_get_uartclk(void);

?extern void mx31_gpio_mux(unsigned long mode); ?extern void mx31_set_pad(enum iomux_pins pin, u32 config);

Stefano has already addressed this issue:
http://www.mail-archive.com/u-boot at lists.denx.de/msg57483.html

Regards,

Fabio Estevam

author
#2 lore raw

PATCH 1/1 ARM MX31: fix clock.h: warning: function declaration isn't a prototype

Dear Fabio Estevam,

Quoted 3 lines · In message <CAOMZO5Br55A8YO9XVO=urGF_vS3KRtHT3ooJJCMuADrFGUZZmA@mail.gmail.com>…

Stefano has already addressed this issue:
http://www.mail-archive.com/u-boot at lists.denx.de/msg57483.html

Argh.. wasted effort then.

Thanks for pointing out.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Vulcans believe peace should not depend on force.
	-- Amanda, "Journey to Babel", stardate 3842.3
#3 lore raw

PATCH 1/1 ARM MX31: fix clock.h: warning: function declaration isn't a prototype

In reply to Wolfgang Denk
Quoted 4 lines · Wolfgang Denk
Signed-off-by Wolfgang Denk <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Albert Aribaud <[email protected]>

---

Hi Wolfgang,

arch/arm/include/asm/arch-mx31/clock.h enum mxc_clock { · line 37

Quoted 5 lines

unsigned int mxc_get_clock(enum mxc_clock clk);

arch/arm/include/asm/arch-mx31/clock.h +1 -1
-extern u32 imx_get_uartclk();
+extern uint32_t imx_get_uartclk(void);
 extern void mx31_gpio_mux(unsigned long mode);
 extern void mx31_set_pad(enum iomux_pins pin, u32 config);

Thanks, but I have already sent the same patch a couple of days ago to fix this issue ;-)

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================