Skip to contentSkip to conversation

Fix a argument WARN bug of scripts/checkpatch.pl

PATCH New Hui Zhu 1 participant 1 message Aug 3, 2011 Checkpatch

lore
Share & tools
lore

Hui Zhu

author
#0 lore raw

PATCH 1/1 Fix a argument WARN bug of scripts/checkpatch.pl

Hi Joe,

Thanks for your help.

Best,
Hui

The following part is the original patch:

Get following error with a patch that have min_t error:
Use of uninitialized value in concatenation (.) or string at scripts/checkpatch.pl line 1256.
WARNING:
This is because:

				}
				WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
			}

It lost the first argument.
So make a patch to fix it.

---
 scripts/checkpatch.pl |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/checkpatch.pl +2 -1
@@ -2574,7 +2574,8 @@ sub process {
 				} else {
 					$cast = $cast2;
 				}
-				WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
+				WARN("MINMAX",
+				     "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
 			}
 		}