Skip to contentSkip to conversation

gfs2-utils: Update .gitignore for i18n files

PATCH New Andrew Price 3 participants 5 messages Aug 1, 2011 – Aug 4, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2-utils: Update .gitignore for i18n files

Add entries in .gitignore for some i18n-related files which are generated at build time.

---
 .gitignore |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
.gitignore +4 -0
index 62e4ac6..e8b7ea1 100644
@@ -37,3 +37,7 @@ gfs2/tool/gfs2_tool
 gfs2/tune/tunegfs2
 group/gfs_control/gfs_control
 group/gfs_controld/gfs_controld
+ABOUT-NLS
+po/Makevars.template
+po/POTFILES
+po/stamp-po
Signature · 1 line
1.7.6
#1 lore raw

PATCH 1/1 gfs2-utils: Update .gitignore for i18n files

Hi,

Looks good to me,

Steve.

Quoted 20 lines · Andrew Price

Add entries in .gitignore for some i18n-related files which are generated at build time.

---
 .gitignore |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
.gitignore +4 -0
index 62e4ac6..e8b7ea1 100644
@@ -37,3 +37,7 @@ gfs2/tool/gfs2_tool
 gfs2/tune/tunegfs2
 group/gfs_control/gfs_control
 group/gfs_controld/gfs_controld
+ABOUT-NLS
+po/Makevars.template
+po/POTFILES
+po/stamp-po
#2 lore raw

PATCH 1/1 gfs2-utils: Update .gitignore for i18n files

In reply to Andrew Price
Quoted 23 lines · Andrew Price

Add entries in .gitignore for some i18n-related files which are generated at build time.

---
 .gitignore |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
.gitignore +4 -0
index 62e4ac6..e8b7ea1 100644
@@ -37,3 +37,7 @@ gfs2/tool/gfs2_tool
 gfs2/tune/tunegfs2
 group/gfs_control/gfs_control
 group/gfs_controld/gfs_controld
+ABOUT-NLS
+po/Makevars.template
+po/POTFILES
+po/stamp-po
Signature · 1 line
1.7.6

Maybe is a good idea to also add gfs2-utils.pot to this list. I believe we should remove gfs2-utils.pot from the upstream git repo, and leave it to be auto created at the compile time.
Leaving this on the tree (and also into the package when it is created), make the gettext to bypass the creation of gfs2-utils.pot an rely on the one already created, which can be not up2date since we are doing some changes on strings and adding another things.

What you guys think?

Signature · 1 line
--Carlos
#3 lore raw

PATCH 1/1 gfs2-utils: Update .gitignore for i18n files

Quoted 9 lines · Carlos Maiolino

Maybe is a good idea to also add gfs2-utils.pot to this list. I believe we should remove gfs2-utils.pot from the upstream git repo, and leave it to be auto created at the compile time.
Leaving this on the tree (and also into the package when it is created), make the gettext to bypass the creation of gfs2-utils.pot an rely on the one already created, which can be not up2date since we are doing some changes on strings and adding another things.

What you guys think?

I think we need to keep gfs2-utils.pot in the git repo so that we have one single "master" translation template which should be used (by Transifex, translators, ...) to translate gfs2-utils.

When string changes occur (and once per release, minimum) we should regenerate the master gfs2-utils.pot and then merge those changes into the existing .po files and commit. That way we get full control over the current state of the single gfs2-utils.pot which is used by everyone.

Andy

#4 lore raw

PATCH 1/1 gfs2-utils: Update .gitignore for i18n files

In reply to Carlos Maiolino

Hi,

Quoted 33 lines · Carlos Maiolino
Quoted 23 lines · Andrew Price

Add entries in .gitignore for some i18n-related files which are generated at build time.

---
 .gitignore |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
.gitignore +4 -0
index 62e4ac6..e8b7ea1 100644
@@ -37,3 +37,7 @@ gfs2/tool/gfs2_tool
 gfs2/tune/tunegfs2
 group/gfs_control/gfs_control
 group/gfs_controld/gfs_controld
+ABOUT-NLS
+po/Makevars.template
+po/POTFILES
+po/stamp-po
Signature · 1 line
1.7.6

Maybe is a good idea to also add gfs2-utils.pot to this list. I believe we should remove gfs2-utils.pot from the upstream git repo, and leave it to be auto created at the compile time.
Leaving this on the tree (and also into the package when it is created), make the gettext to bypass the creation of gfs2-utils.pot an rely on the one already created, which can be not up2date since we are doing some changes on strings and adding another things.

Quoted 2 lines

What you guys think?

Do we need to have a .pot in the tree for transifex to use as the basis for new translations? If not, then lets create it at build time, otherwise I think we have no choice but to leave it in the tree and to remember to recreate it when the strings have changed,

Steve.