arm: a320: enable tagged list support

PATCH New Po-Yu Chuang 3 participants 13 messages May 16, 2011 – Aug 4, 2011

lore

Share & tools

lore

Po-Yu Chuang

author

2011-05-16 07:41 UTC #0 lore raw

PATCH 1/1 arm: a320: enable tagged list support

From: Po-Yu Chuang <[email protected]>

Signed-off-by Po-Yu Chuang <[email protected]>

---
 include/configs/a320evb.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

include/configs/a320evb.h +6 -0

index 0527822..f12977b 100644
@@ -25,6 +25,12 @@
 #include <asm/arch/a320.h>
 
 /*-----------------------------------------------------------------------
+ * Linux kernel tagged list
+ */
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*-----------------------------------------------------------------------
  * CPU and Board Configuration Options
  */
 #undef CONFIG_USE_IRQ		/* we don't need IRQ/FIQ stuff */

Signature · 1 line

1.6.3.3

Wolfgang Denk

2011-05-16 11:42 UTC #1 lore raw

PATCH 1/1 arm: a320: enable tagged list support

Dear Po-Yu Chuang,

Quoted 13 lines · In message <[email protected]> you…

From: Po-Yu Chuang <[email protected]>
Signed-off-by Po-Yu Chuang <[email protected]>
---
 include/configs/a320evb.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
include/configs/a320evb.h +0 -0
index 0527822..f12977b 100644

include/configs/a320evb.h line 33

Quoted 9 lines

include/configs/a320evb.h +6 -0

@@ -25,6 +25,12 @@
 #include <asm/arch/a320.h>
 
 /*-----------------------------------------------------------------------
+ * Linux kernel tagged list
+ */
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*-----------------------------------------------------------------------

Please also fix the incorrect multiline comment style while modifying this code. Thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Memories of you remind me of you.                   - Karl Lehenbauer

Po-Yu Chuang

author

2011-05-17 02:47 UTC #2 lore raw

PATCH 1/1 arm: a320: enable tagged list support

Dear Wolfgang,

Quoted 18 lines · Wolfgang Denk

Dear Po-Yu Chuang,
Quoted 15 lines · In message <[email protected]> you…
From: Po-Yu Chuang <[email protected]>
Signed-off-by Po-Yu Chuang <[email protected]>
---
?include/configs/a320evb.h | ? ?6 ++++++
?1 files changed, 6 insertions(+), 0 deletions(-)
include/configs/a320evb.h +0 -0
index 0527822..f12977b 100644
@@ -25,6 +25,12 @@
?#include <asm/arch/a320.h>

Quoted 10 lines

include/configs/a320evb.h line 33
Quoted 7 lines
?/*-----------------------------------------------------------------------
+ * Linux kernel tagged list
+ */
include/configs/a320evb.h +4 -0
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*-----------------------------------------------------------------------
Please also fix the incorrect multiline comment style while modifying this code. Thanks.

OK, I will resubmit this patch with a preceding clean patch.

Best regards,
Po-Yu Chuang

Po-Yu Chuang

author

2011-05-17 03:11 UTC #3 lore raw

PATCH v2 1/2 arm: a320: fix multiline comment style

In reply to Po-Yu Chuang

From: Po-Yu Chuang <[email protected]>

Signed-off-by Po-Yu Chuang <[email protected]>

---
 include/configs/a320evb.h |   32 ++++++++++++++------------------
 1 files changed, 14 insertions(+), 18 deletions(-)

include/configs/a320evb.h +14 ~~-18~~

index 0527822..f832d52 100644
@@ -24,29 +24,29 @@
 
 #include <asm/arch/a320.h>
 
-/*-----------------------------------------------------------------------
+/*
  * CPU and Board Configuration Options
  */
 #undef CONFIG_USE_IRQ		/* we don't need IRQ/FIQ stuff */
 
 #undef CONFIG_SKIP_LOWLEVEL_INIT
 
-/*-----------------------------------------------------------------------
+/*
  * Power Management Unit
  */
 #define CONFIG_FTPMU010_POWER
 
-/*-----------------------------------------------------------------------
+/*
  * Timer
  */
 #define CONFIG_SYS_HZ		1000	/* timer ticks per second */
 
-/*-----------------------------------------------------------------------
+/*
  * Real Time Clock
  */
 #define CONFIG_RTC_FTRTC010
 
-/*-----------------------------------------------------------------------
+/*
  * Serial console configuration
  */

@@ -62,7 +62,7 @@
 /* valid baudrates */
 #define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
 
-/*-----------------------------------------------------------------------
+/*
  * Ethernet
  */
 #define CONFIG_NET_MULTI

@@ -70,7 +70,7 @@
 
 #define CONFIG_BOOTDELAY	3
 
-/*-----------------------------------------------------------------------
+/*
  * Command line configuration.
  */
 #include <config_cmd_default.h>

@@ -79,7 +79,7 @@
 #define CONFIG_CMD_DATE
 #define CONFIG_CMD_PING
 
-/*-----------------------------------------------------------------------
+/*
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP			/* undef to save memory */

@@ -96,7 +96,7 @@
 /* Boot Argument Buffer Size */
 #define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE
 
-/*-----------------------------------------------------------------------
+/*
  * Stack sizes
  *
  * The stack sizes are set up in start.S using the settings below

@@ -107,16 +107,12 @@
 #define CONFIG_STACKSIZE_FIQ	(4 * 1024)	/* FIQ stack */
 #endif
 
-/*-----------------------------------------------------------------------
+/*
  * Size of malloc() pool
  */
 #define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + 128 * 1024)
 
-/*-----------------------------------------------------------------------
- * size in bytes reserved for initial data
-*/
-
-/*-----------------------------------------------------------------------
+/*
  * SDRAM controller configuration
  */
 #define CONFIG_SYS_FTSDMC020_TP0	(FTSDMC020_TP0_TRAS(2) |	\

@@ -136,7 +132,7 @@
 					 FTSDMC020_BANK_MBW_32   |	\
 					 FTSDMC020_BANK_SIZE_64M)
 
-/*-----------------------------------------------------------------------
+/*
  * Physical Memory Map
  */
 #define CONFIG_NR_DRAM_BANKS	1		/* we have 1 bank of DRAM */

@@ -159,7 +155,7 @@
 
 #define CONFIG_SYS_TEXT_BASE		0
 
-/*-----------------------------------------------------------------------
+/*
  * Static memory controller configuration
  */

@@ -198,7 +194,7 @@
 	{ FTSMC020_BANK1_CONFIG, FTSMC020_BANK1_TIMING, },	\
 }
 
-/*-----------------------------------------------------------------------
+/*
  * FLASH and environment organization
  */

Signature · 1 line

1.6.3.3

Po-Yu Chuang

author

2011-07-19 02:55 UTC #4 lore raw

PATCH v3 1/2 arm: a320: fix multiline comment style

From: Po-Yu Chuang <[email protected]>

Signed-off-by Po-Yu Chuang <[email protected]>

---
v2:
(new) fix multiline comment style

v3:
rebase

 include/configs/a320evb.h |   28 ++++++++++++++--------------
 1 files changed, 14 insertions(+), 14 deletions(-)

include/configs/a320evb.h +14 ~~-14~~

index dfab0f4..f832d52 100644
@@ -24,29 +24,29 @@
 
 #include <asm/arch/a320.h>
 
-/*-----------------------------------------------------------------------
+/*
  * CPU and Board Configuration Options
  */
 #undef CONFIG_USE_IRQ		/* we don't need IRQ/FIQ stuff */
 
 #undef CONFIG_SKIP_LOWLEVEL_INIT
 
-/*-----------------------------------------------------------------------
+/*
  * Power Management Unit
  */
 #define CONFIG_FTPMU010_POWER
 
-/*-----------------------------------------------------------------------
+/*
  * Timer
  */
 #define CONFIG_SYS_HZ		1000	/* timer ticks per second */
 
-/*-----------------------------------------------------------------------
+/*
  * Real Time Clock
  */
 #define CONFIG_RTC_FTRTC010
 
-/*-----------------------------------------------------------------------
+/*
  * Serial console configuration
  */

@@ -62,7 +62,7 @@
 /* valid baudrates */
 #define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
 
-/*-----------------------------------------------------------------------
+/*
  * Ethernet
  */
 #define CONFIG_NET_MULTI

@@ -70,7 +70,7 @@
 
 #define CONFIG_BOOTDELAY	3
 
-/*-----------------------------------------------------------------------
+/*
  * Command line configuration.
  */
 #include <config_cmd_default.h>

@@ -79,7 +79,7 @@
 #define CONFIG_CMD_DATE
 #define CONFIG_CMD_PING
 
-/*-----------------------------------------------------------------------
+/*
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP			/* undef to save memory */

@@ -96,7 +96,7 @@
 /* Boot Argument Buffer Size */
 #define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE
 
-/*-----------------------------------------------------------------------
+/*
  * Stack sizes
  *
  * The stack sizes are set up in start.S using the settings below

@@ -107,12 +107,12 @@
 #define CONFIG_STACKSIZE_FIQ	(4 * 1024)	/* FIQ stack */
 #endif
 
-/*-----------------------------------------------------------------------
+/*
  * Size of malloc() pool
  */
 #define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + 128 * 1024)
 
-/*-----------------------------------------------------------------------
+/*
  * SDRAM controller configuration
  */
 #define CONFIG_SYS_FTSDMC020_TP0	(FTSDMC020_TP0_TRAS(2) |	\

@@ -132,7 +132,7 @@
 					 FTSDMC020_BANK_MBW_32   |	\
 					 FTSDMC020_BANK_SIZE_64M)
 
-/*-----------------------------------------------------------------------
+/*
  * Physical Memory Map
  */
 #define CONFIG_NR_DRAM_BANKS	1		/* we have 1 bank of DRAM */

@@ -155,7 +155,7 @@
 
 #define CONFIG_SYS_TEXT_BASE		0
 
-/*-----------------------------------------------------------------------
+/*
  * Static memory controller configuration
  */

@@ -194,7 +194,7 @@
 	{ FTSMC020_BANK1_CONFIG, FTSMC020_BANK1_TIMING, },	\
 }
 
-/*-----------------------------------------------------------------------
+/*
  * FLASH and environment organization
  */

Signature · 1 line

1.7.4.1

Po-Yu Chuang

author

2011-05-17 03:11 UTC #5 lore raw

PATCH v2 2/2 arm: a320: enable tagged list support

In reply to Po-Yu Chuang

From: Po-Yu Chuang <[email protected]>

Signed-off-by Po-Yu Chuang <[email protected]>

---
 include/configs/a320evb.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

include/configs/a320evb.h +6 -0

index f832d52..62913b5 100644
@@ -25,6 +25,12 @@
 #include <asm/arch/a320.h>
 
 /*
+ * Linux kernel tagged list
+ */
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*
  * CPU and Board Configuration Options
  */
 #undef CONFIG_USE_IRQ		/* we don't need IRQ/FIQ stuff */

Signature · 1 line

1.6.3.3

Po-Yu Chuang

author

2011-06-09 06:35 UTC #6 lore raw

PATCH v2 2/2 arm: a320: enable tagged list support

Dear Albert,

Quoted 22 lines · Po-Yu Chuang

From: Po-Yu Chuang <[email protected]>
Signed-off-by Po-Yu Chuang <[email protected]>
---
?include/configs/a320evb.h | ? ?6 ++++++
?1 files changed, 6 insertions(+), 0 deletions(-)
include/configs/a320evb.h +0 -0
index f832d52..62913b5 100644
@@ -25,6 +25,12 @@
?#include <asm/arch/a320.h>
?/*
+ * Linux kernel tagged list
+ */
include/configs/a320evb.h +4 -0
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*

Quoted 7 lines

?* CPU and Board Configuration Options
?*/
?#undef CONFIG_USE_IRQ ? ? ? ? ?/* we don't need IRQ/FIQ stuff */ --
1.6.3.3

Is it possible to accept this patch series in v2011.06?

[U-Boot,v2,1/2] arm: a320: fix multiline comment style
http://patchwork.ozlabs.org/patch/95847/

[U-Boot,v2,2/2] arm: a320: enable tagged list support
http://patchwork.ozlabs.org/patch/95848/

Best regards,
Po-Yu Chuang

Po-Yu Chuang

author

2011-06-09 06:44 UTC #7 lore raw

PATCH v2 2/2 arm: a320: enable tagged list support

Dear Albert,

Quoted 35 lines · Po-Yu Chuang

Dear Albert,
Quoted 22 lines · Po-Yu Chuang
From: Po-Yu Chuang <[email protected]>
Signed-off-by Po-Yu Chuang <[email protected]>
---
?include/configs/a320evb.h | ? ?6 ++++++
?1 files changed, 6 insertions(+), 0 deletions(-)
include/configs/a320evb.h +0 -0
index f832d52..62913b5 100644
@@ -25,6 +25,12 @@
?#include <asm/arch/a320.h>
?/*
+ * Linux kernel tagged list
+ */
include/configs/a320evb.h +4 -0
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*
Quoted 7 lines
?* CPU and Board Configuration Options
?*/
?#undef CONFIG_USE_IRQ ? ? ? ? ?/* we don't need IRQ/FIQ stuff */ --
1.6.3.3
Is it possible to accept this patch series in v2011.06?

Quoted 5 lines

[U-Boot,v2,1/2] arm: a320: fix multiline comment style
http://patchwork.ozlabs.org/patch/95847/
[U-Boot,v2,2/2] arm: a320: enable tagged list support
http://patchwork.ozlabs.org/patch/95848/

Just now I noticed that your mail address has changed. So resend this mail.

Best regards,
Po-Yu Chuang

Albert ARIBAUD

2011-07-16 10:25 UTC #8 lore raw

PATCH v2 2/2 arm: a320: enable tagged list support

Hi Po-Yu Chuang,

Le 09/06/2011 08:44, Po-Yu Chuang a ?crit :

Quoted 38 lines

Dear Albert,
Quoted 35 lines · Po-Yu Chuang
Dear Albert,
Quoted 26 lines · Po-Yu Chuang
From: Po-Yu Chuang<[email protected]>
Signed-off-by Po-Yu Chuang<[email protected]>
---
  include/configs/a320evb.h |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)
include/configs/a320evb.h +6 -1
index f832d52..62913b5 100644
@@ -25,6 +25,12 @@
  #include<asm/arch/a320.h>
 
  /*
+ * Linux kernel tagged list
+ */
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*
  * CPU and Board Configuration Options
  */
  #undef CONFIG_USE_IRQ          /* we don't need IRQ/FIQ stuff */
--
Quoted 3 lines
1.6.3.3
Is it possible to accept this patch series in v2011.06?

Quoted 8 lines

Quoted 5 lines
[U-Boot,v2,1/2] arm: a320: fix multiline comment style
http://patchwork.ozlabs.org/patch/95847/
[U-Boot,v2,2/2] arm: a320: enable tagged list support
http://patchwork.ozlabs.org/patch/95848/
Just now I noticed that your mail address has changed. So resend this mail.

Sorry for the delay. Can you please rebase and repost as V3? Ill pull them in ASAP.

Quoted 2 lines

Best regards,
Po-Yu Chuang

Amicalement,

Signature · 1 line

Albert.

Po-Yu Chuang

author

2011-07-19 02:56 UTC #9 lore raw

PATCH v3 2/2 arm: a320: enable tagged list support

In reply to Po-Yu Chuang

From: Po-Yu Chuang <[email protected]>

Signed-off-by Po-Yu Chuang <[email protected]>

---
v2:
add a preceding patch to fix multiline comment style

v3:
rebase

 include/configs/a320evb.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

include/configs/a320evb.h +6 -0

index f832d52..62913b5 100644
@@ -25,6 +25,12 @@
 #include <asm/arch/a320.h>
 
 /*
+ * Linux kernel tagged list
+ */
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*
  * CPU and Board Configuration Options
  */
 #undef CONFIG_USE_IRQ		/* we don't need IRQ/FIQ stuff */

Signature · 1 line

1.7.4.1

Albert ARIBAUD

2011-08-04 09:32 UTC #10 lore raw

PATCH v3 2/2 arm: a320: enable tagged list support

Hi Po Yu Chuang,

Quoted 21 lines · Po-Yu Chuang

From: Po-Yu Chuang<[email protected]>
Signed-off-by Po-Yu Chuang<[email protected]>
---
v2:
add a preceding patch to fix multiline comment style
v3:
rebase
  include/configs/a320evb.h |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)
include/configs/a320evb.h +0 -0
index f832d52..62913b5 100644
@@ -25,6 +25,12 @@
  #include<asm/arch/a320.h>
 

include/configs/a320evb.h line 36

Quoted 10 lines

include/configs/a320evb.h +6 -0

  /*
+ * Linux kernel tagged list
+ */
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*
   * CPU and Board Configuration Options
   */
  #undef CONFIG_USE_IRQ		/* we don't need IRQ/FIQ stuff */

Applied to u-boot-arm (after local fix to context lines -- my fault entirely, waited too long before applying it), thanks!

Amicalement,

Signature · 1 line

Albert.

Po-Yu Chuang

author

2011-08-04 09:44 UTC #11 lore raw

PATCH v3 2/2 arm: a320: enable tagged list support

Dear Albert,

Quoted 25 lines · Albert ARIBAUD

Hi Po Yu Chuang,
Quoted 22 lines · Po-Yu Chuang
From: Po-Yu Chuang<[email protected]>
Signed-off-by Po-Yu Chuang<[email protected]>
---
v2:
add a preceding patch to fix multiline comment style
v3:
rebase
?include/configs/a320evb.h | ? ?6 ++++++
?1 files changed, 6 insertions(+), 0 deletions(-)
include/configs/a320evb.h +0 -0
index f832d52..62913b5 100644
@@ -25,6 +25,12 @@
?#include<asm/arch/a320.h>

Quoted 13 lines

Quoted 10 lines
?/*
+ * Linux kernel tagged list
+ */
include/configs/a320evb.h +4 -0
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*
? * CPU and Board Configuration Options
? */
?#undef CONFIG_USE_IRQ ? ? ? ? /* we don't need IRQ/FIQ stuff */
Applied to u-boot-arm (after local fix to context lines -- my fault entirely, waited too long before applying it), thanks!

Just to remind you.

There is a preceding patch "arm: a320: fix multiline comment style" according to Wolfgang's request.

http://patchwork.ozlabs.org/patch/105374/

I guess that's why you need local fix.

Best regards,
Po-Yu Chuang

Albert ARIBAUD

2011-08-04 09:57 UTC #12 lore raw

PATCH v3 2/2 arm: a320: enable tagged list support

Hi Po Yu Chuang,

Quoted 43 lines · Po-Yu Chuang

Dear Albert,
Quoted 25 lines · Albert ARIBAUD
Hi Po Yu Chuang,
Quoted 22 lines · Po-Yu Chuang
From: Po-Yu Chuang<[email protected]>
Signed-off-by Po-Yu Chuang<[email protected]>
---
v2:
add a preceding patch to fix multiline comment style
v3:
rebase
  include/configs/a320evb.h |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)
include/configs/a320evb.h +0 -0
index f832d52..62913b5 100644
@@ -25,6 +25,12 @@
  #include<asm/arch/a320.h>
 
Quoted 13 lines
include/configs/a320evb.h line 36
Quoted 10 lines
include/configs/a320evb.h +6 -0
  /*
+ * Linux kernel tagged list
+ */
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_SETUP_MEMORY_TAGS
+
+/*
   * CPU and Board Configuration Options
   */
  #undef CONFIG_USE_IRQ         /* we don't need IRQ/FIQ stuff */
Applied to u-boot-arm (after local fix to context lines -- my fault entirely, waited too long before applying it), thanks!

Quoted 8 lines

Just to remind you.
There is a preceding patch "arm: a320: fix multiline comment style" according to Wolfgang's request.
http://patchwork.ozlabs.org/patch/105374/
I guess that's why you need local fix.

Thanks -- I'll reorder u-boot-arm to apply the style fix first.

Quoted 2 lines

Best regards,
Po-Yu Chuang

Amicalement,

Signature · 1 line

Albert.