arm: auto gen asm-offsets.h for mb86r0x
PATCH 1/1 arm: auto gen asm-offsets.h for mb86r0x
auto gen asm-offsets.h for mb86r0x
---
This patch needs http://patchwork.ozlabs.org/patch/102773/ to be applied first.
arch/arm/cpu/arm926ejs/mb86r0x/Makefile | 2 + arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c | 65 ++++++++++++++++++++ arch/arm/include/asm/arch-mb86r0x/asm-offsets.h | 74 ----------------------- 3 files changed, 67 insertions(+), 74 deletions(-) create mode 100644 arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c delete mode 100644 arch/arm/include/asm/arch-mb86r0x/asm-offsets.h
arch/arm/cpu/arm926ejs/mb86r0x/Makefile +2 -0
@@ -37,6 +37,8 @@ all: $(obj).depend $(LIB) $(LIB): $(OBJS) $(call cmd_link_o_target, $(OBJS)) +$(OBJS) : $(TOPDIR)/include/asm/arch/asm-offsets.h + ######################################################################### # defines $(obj).depend target
arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c new file +65 -0
65 lines not on this page · raw message
arch/arm/include/asm/arch-mb86r0x/asm-offsets.h deleted +0 -74
74 lines not on this page · raw message
Signature · 1 line
1.7.0.4
PATCH v2 1/1 arm: auto gen asm-offsets.h for mb86r0x
auto gen asm-offsets.h for mb86r0x
---
Changes in v2:
- Added forgotten register structures
arch/arm/cpu/arm926ejs/mb86r0x/Makefile | 2 + arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c | 65 ++++++++++++++++++++ arch/arm/include/asm/arch-mb86r0x/asm-offsets.h | 74 ----------------------- arch/arm/include/asm/arch-mb86r0x/mb86r0x.h | 42 +++++++++++++ 4 files changed, 109 insertions(+), 74 deletions(-) create mode 100644 arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c delete mode 100644 arch/arm/include/asm/arch-mb86r0x/asm-offsets.h
arch/arm/cpu/arm926ejs/mb86r0x/Makefile +2 -0
@@ -37,6 +37,8 @@ all: $(obj).depend $(LIB) $(LIB): $(OBJS) $(call cmd_link_o_target, $(OBJS)) +$(OBJS) : $(TOPDIR)/include/asm/arch/asm-offsets.h + ######################################################################### # defines $(obj).depend target
arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c new file +65 -0
65 lines not on this page · raw message
arch/arm/include/asm/arch-mb86r0x/asm-offsets.h deleted +0 -74
74 lines not on this page · raw message
arch/arm/include/asm/arch-mb86r0x/mb86r0x.h +42 -0
48 lines not on this page · raw message
Signature · 1 line
1.7.0.4
PATCH v2 1/1 arm: auto gen asm-offsets.h for mb86r0x
Dear Albert
Am 01.08.2011 17:11, schrieb Matthias Weisser:
Quoted 7 lines
auto gen
asm-offsets.hfor mb86r0xSigned-off-by Matthias Weisser <[email protected]>---
Changes in v2:
- Added forgotten register structures
Quoted 7 lines
arch/arm/cpu/arm926ejs/mb86r0x/Makefile | 2 + arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c | 65 ++++++++++++++++++++ arch/arm/include/asm/arch-mb86r0x/asm-offsets.h | 74 ----------------------- arch/arm/include/asm/arch-mb86r0x/mb86r0x.h | 42 +++++++++++++ 4 files changed, 109 insertions(+), 74 deletions(-) create mode 100644 arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c delete mode 100644 arch/arm/include/asm/arch-mb86r0x/asm-offsets.h
Would you please consider this patch for inclusion. Currently jadecpu is broken since [f456445f29d22bb31ad29fdf1d6b2769decd37a2]. It is not clear to me why the referenced patch breaks jadecpu (must be some make dependency stuff) but it slipped through my testing as I had applied the above patch in an earlier version when submitting the patch which breaks it.
This patch fixes jadecpu and also gets rid of the hand written asm-offsets.h.
I can't test it (no powerpc toolchain at hand) but the above mentioned commit may also break mpc512x based boards. If that is the case ./arch/powerpc/cpu/mpc512x/asm-offsets.h should also be autogenerated. If this is done we will not have any non-autogenerated asm-offsets.h in u-boot anymore.
Regards,
Matthias
PATCH v2 1/1 arm: auto gen asm-offsets.h for mb86r0x
Hi Matthias,
Le 01/08/2011 20:16, Matthias Weisser a ?crit :
Quoted 24 lines
Dear Albert
Am 01.08.2011 17:11, schrieb Matthias Weisser:
Quoted 7 lines
auto gen
asm-offsets.hfor mb86r0xSigned-off-by Matthias Weisser<[email protected]>---
Changes in v2:
- Added forgotten register structuresQuoted 7 lines
arch/arm/cpu/arm926ejs/mb86r0x/Makefile | 2 + arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c | 65 ++++++++++++++++++++ arch/arm/include/asm/arch-mb86r0x/asm-offsets.h | 74 ----------------------- arch/arm/include/asm/arch-mb86r0x/mb86r0x.h | 42 +++++++++++++ 4 files changed, 109 insertions(+), 74 deletions(-)create mode 100644
arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.cdelete mode 100644arch/arm/include/asm/arch-mb86r0x/asm-offsets.hWould you please consider this patch for inclusion. Currently jadecpu is broken since [
f456445f29d22bb31ad29fdf1d6b2769decd37a2]. It is not clear to me why the referenced patch breaks jadecpu (must be some make dependency stuff) but it slipped through my testing as I had applied the above patch in an earlier version when submitting the patch which breaks it.
Quoted 8 lines
This patch fixes jadecpu and also gets rid of the hand written
asm-offsets.h.I can't test it (no powerpc toolchain at hand) but the above mentioned commit may also break mpc512x based boards. If that is the case
./arch/powerpc/cpu/mpc512x/asm-offsets.hshould also be autogenerated. If this is done we will not have any non-autogeneratedasm-offsets.hin u-boot anymore.
Wolfgang, can you test on powerpc?
Quoted 2 lines
Regards,
Matthias
Amicalement,
Signature · 1 line
Albert.
PATCH v2 1/1 arm: auto gen asm-offsets.h for mb86r0x
In reply to Matthias WeisserDear Matthias Weisser,
Quoted 7 lines · In message <[email protected]> you wrote:
Would you please consider this patch for inclusion. Currently jadecpu is broken since [
f456445f29d22bb31ad29fdf1d6b2769decd37a2]. It is not clear to me why the referenced patch breaks jadecpu (must be some make dependency stuff) but it slipped through my testing as I had applied the above patch in an earlier version when submitting the patch which breaks it.
Quoted 8 lines
This patch fixes jadecpu and also gets rid of the hand written
asm-offsets.h.I can't test it (no powerpc toolchain at hand) but the above mentioned commit may also break mpc512x based boards. If that is the case
./arch/powerpc/cpu/mpc512x/asm-offsets.hshould also be autogenerated. If this is done we will not have any non-autogeneratedasm-offsets.hin u-boot anymore.
Which sort of errors should I look for? Buil errors? Or run-time errors?
All MPC512x based boards build fine:
+ ./MAKEALL 512x
Configuring for pdm360ng board...
text data bss dec hex filename
285842 32608 29776 348226 55042 /work/wd/tmp-ppc/u-boot
Configuring for aria board...
text data bss dec hex filename
253515 19760 29464 302739 49e93 /work/wd/tmp-ppc/u-boot
Configuring for mecp5123 board...
text data bss dec hex filename
249391 20244 221024 490659 77ca3 /work/wd/tmp-ppc/u-boot
Configuring for mpc5121ads board...
text data bss dec hex filename
322971 22940 270552 616463 9680f /work/wd/tmp-ppc/u-boot
Configuring for mpc5121ads_rev2 - Board: mpc5121ads, Options: MPC5121ADS_REV2
text data bss dec hex filename
309335 22428 270328 602091 92feb /work/wd/tmp-ppc/u-boot
--------------------- SUMMARY ---------------------------- Boards compiled: 5
----------------------------------------------------------
Best regards,
Wolfgang Denk
Signature · 8 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de COMPONENT EQUIVALENCY NOTICE: The Subatomic Particles (Electrons, Protons, etc.) Comprising This Product Are Exactly the Same in Every Measurable Respect as Those Used in the Products of Other Manufactu- rers, and No Claim to the Contrary May Legitimately Be Expressed or Implied.
PATCH v2 1/1 arm: auto gen asm-offsets.h for mb86r0x
In reply to Matthias WeisserHi Matthias,
Quoted 7 lines · Matthias Weisser
auto gen
asm-offsets.hfor mb86r0xSigned-off-by Matthias Weisser<[email protected]>---
Changes in v2:
- Added forgotten register structures
Quoted 7 lines
arch/arm/cpu/arm926ejs/mb86r0x/Makefile | 2 + arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.c | 65 ++++++++++++++++++++ arch/arm/include/asm/arch-mb86r0x/asm-offsets.h | 74 ----------------------- arch/arm/include/asm/arch-mb86r0x/mb86r0x.h | 42 +++++++++++++ 4 files changed, 109 insertions(+), 74 deletions(-)create mode 100644
arch/arm/cpu/arm926ejs/mb86r0x/asm-offsets.cdelete mode 100644arch/arm/include/asm/arch-mb86r0x/asm-offsets.h
Applied to u-boot-arm/master, thanks !
Amicalement,
Signature · 1 line
Albert.