Fix wrong loop bound in flush_cache() when "size" is zero.

The issue is found when calling flush_cache() with zero "size" argument.
The bound of loop is miscalculated in this case and flush_cache() enters a wrong flushing loop. To fix this issue I skipped the operations when "size" is found to be zero.

Signed-off-by Yao Cheng<[email protected]>

Cc Shinya Kuribayashi<[email protected]>

---
  arch/mips/cpu/mips32/cpu.c |    5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)

arch/mips/cpu/mips32/cpu.c +0 -0

index 3ae397c..1bf0094 100644

Hello.

On 08-08-2011 12:07, Yao Cheng wrote:

The issue is found when calling flush_cache() with zero "size" argument.

Quoted 5 lines

The bound of loop is miscalculated in this case and flush_cache() enters a wrong flushing loop.
To fix this issue I skipped the operations when "size" is found to be zero.

Signed-off-by Yao Cheng<[email protected]>

Quoted 5 lines

Cc Shinya Kuribayashi<[email protected]**>

---
 arch/mips/cpu/mips32/cpu.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/mips/cpu/mips32/cpu.c b/arch/mips/cpu/mips32/cpu.c

Quoted 5 lines

index 3ae397c..1bf0094 100644

arch/mips/cpu/mips32/cpu.c +0 -0

@@ -52,6 +52,11 @@ int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char
 * const argv[])

arch/mips/cpu/mips32/cpu.c int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char · line 62

Quoted 10 lines

arch/mips/cpu/mips32/cpu.c +5 -0

 
 void flush_cache(ulong start_addr, ulong size)
 {
+  /* aend will be miscalculated when size is zero, so we need return here
 */
+  if (size == 0) {
+    return;
+  }
 
+

Please indent with tabs, not spaces. Also, doesn't this code generate
warning (code before declarations)?

        unsigned long lsize = CONFIG_SYS_CACHELINE_SIZE;

Quoted 3 lines

       unsigned long addr = start_addr&  ~(lsize - 1);
       unsigned long aend = (start_addr + size - 1)&  ~(lsize - 1);

WBR, Sergei

Please indent with tabs, not spaces. Also, doesn't this code generate
warning (code before declarations)?