Skip to contentSkip to conversation

802.3ad bonding brain damaged?

DISCUSSION Phillip Susi 9 participants 11 messages Aug 7, 2011 – Aug 9, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

- From Documentation/networking/bonding.txt:

Additionally, the linux bonding 802.3ad implementation distributes traffic by peer (using an XOR of MAC addresses),

This is counter to the entire point of 802.3ad. Distributing traffic by hash of the destination address is poor mans load balancing for systems not supporting 802.3ad. When in 802.3ad mode, packets are supposed to be queued to whichever interface has the shortest tx length so a single stream to a single host can be balanced across all links instead of being restricted to one, while the other is idle.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4+7PMACgkQJ4UciIs+XuKJtwCgrubCy9NgiS3HppxpRRtx4W7l aFkAnR1uLW+4aM/TOSQgYZVsf/4yXGvE
=Yetx
-----END PGP SIGNATURE-----

#1 lore raw

Am Sonntag, den 07.08.2011, 15:52 -0400 schrieb Phillip Susi:

Quoted 8 lines

- From Documentation/networking/bonding.txt:

Additionally, the linux bonding 802.3ad implementation distributes traffic by peer (using an XOR of MAC addresses),

This is counter to the entire point of 802.3ad. Distributing traffic by hash of the destination address is poor mans load balancing for systems not supporting 802.3ad.

No, it isn't. 802.3ad/.1AX explicitly requires that no packet re-ordering may ever occur, which can only be guaranteed by enqueueing packets for one host on one TX interface. This behaviour is mandated by 802.1AX-2008 page 15 which reads:

This standard does not mandate any particular distribution algorithm(s); however, any distribution algorithm shall ensure that, when frames are received by a Frame Collector as specified in 5.2.3, the algorithm shall not cause
a) Misordering of frames that are part of any given conversation, or
b) Duplication of frames.

| The above requirement to maintain frame ordering is met by ensuring
| that all frames that compose a given conversation are transmitted on a
| single link in the order that they are generated by the MAC Client;

hence, this requirement does not involve the addition (or modification) of any information to the MAC frame, nor any buffering or processing on the part of the corresponding Frame Collector in order to reorder frames. This approach to the operation of the distribution function permits a wide variety of distribution and load balancing algorithms to be used, while also ensuring interoperability between devices that adopt differing algorithms.

(IMHO it is 802.3ad/.1AX that is brain damaged, I would've made this a weak requirement with an optional mode switch for networks that require a strong one.)

It is true that it might be possible to fulfill this requirement with a more sophisticated approach or just ignore edge cases, but in that case you can just use a different bonding algorithm.

Quoted 4 lines

When in 802.3ad mode, packets are supposed to
be queued to whichever interface has the shortest tx length so a single stream to a single host can be balanced across all links instead of being restricted to one, while the other is idle.

Please make sure to tag your assumptions as such and don't make assertions without reading the specification.

-David

#2 lore raw
Quoted 24 lines · David Lamparter

Am Sonntag, den 07.08.2011, 15:52 -0400 schrieb Phillip Susi:

Quoted 8 lines

- From Documentation/networking/bonding.txt:

Additionally, the linux bonding 802.3ad implementation distributes traffic by peer (using an XOR of MAC addresses),

This is counter to the entire point of 802.3ad. Distributing traffic by hash of the destination address is poor mans load balancing for systems not supporting 802.3ad.

No, it isn't. 802.3ad/.1AX explicitly requires that no packet re-ordering may ever occur, which can only be guaranteed by enqueueing packets for one host on one TX interface. This behaviour is mandated by 802.1AX-2008 page 15 which reads:

This standard does not mandate any particular distribution algorithm(s); however, any distribution algorithm shall ensure that, when frames are received by a Frame Collector as specified in 5.2.3, the algorithm shall not cause
a) Misordering of frames that are part of any given conversation, or
b) Duplication of frames.

| The above requirement to maintain frame ordering is met by ensuring
| that all frames that compose a given conversation are transmitted on a
| single link in the order that they are generated by the MAC Client;
Quoted 8 lines

hence, this requirement does not involve the addition (or modification) of any information to the MAC frame, nor any buffering or processing on the part of the corresponding Frame Collector in order to reorder frames. This approach to the operation of the distribution function permits a wide variety of distribution and load balancing algorithms to be used, while also ensuring interoperability between devices that adopt differing algorithms.

It all depends on the definition of 'conversation'

Phillip assumed two (or more) TCP flows from machine A to machine B could use two different links, while you assert they MUST use a single link.

#3 lore raw
Quoted 34 lines · Eric Dumazet
Quoted 24 lines · David Lamparter

Am Sonntag, den 07.08.2011, 15:52 -0400 schrieb Phillip Susi:

Quoted 8 lines

- From Documentation/networking/bonding.txt:

Additionally, the linux bonding 802.3ad implementation distributes traffic by peer (using an XOR of MAC addresses),

This is counter to the entire point of 802.3ad. Distributing traffic by hash of the destination address is poor mans load balancing for systems not supporting 802.3ad.

No, it isn't. 802.3ad/.1AX explicitly requires that no packet re-ordering may ever occur, which can only be guaranteed by enqueueing packets for one host on one TX interface. This behaviour is mandated by 802.1AX-2008 page 15 which reads:

This standard does not mandate any particular distribution algorithm(s); however, any distribution algorithm shall ensure that, when frames are received by a Frame Collector as specified in 5.2.3, the algorithm shall not cause
a) Misordering of frames that are part of any given conversation, or
b) Duplication of frames.

| The above requirement to maintain frame ordering is met by ensuring
| that all frames that compose a given conversation are transmitted on a
| single link in the order that they are generated by the MAC Client;
Quoted 8 lines

hence, this requirement does not involve the addition (or modification) of any information to the MAC frame, nor any buffering or processing on the part of the corresponding Frame Collector in order to reorder frames. This approach to the operation of the distribution function permits a wide variety of distribution and load balancing algorithms to be used, while also ensuring interoperability between devices that adopt differing algorithms.

Quoted 1 line

It all depends on the definition of 'conversation'

The definition from 802.1AX is:

3.8 conversation: A set of frames transmitted from one end station to another, where all of the frames form an ordered sequence, and where the communicating end stations require the ordering to be maintained among the set of frames exchanged. (See IEEE Std 802.1AX, Clause 5.)

So, basically, a TCP connection or a sequence of UDP datagrams
from one IP.port to another and optionally the reverse.

Quoted 3 lines

Phillip assumed two (or more) TCP flows from machine A to machine B could use two different links, while you assert they MUST use a single link.

The standard permits us to place separate conversations on
different ports, even if they are going to the same MAC destination.

	802.1AX 5.2.1:

f) Frame ordering must be maintained for certain sequences of frame exchanges between MAC Clients (known as conversations, see Clause 3). The Distributor ensures that all frames of a given conversation are passed to a single port. For any given port, the Collector is required to pass frames to the MAC Client in the order that they are received from that port. The Collector is otherwise free to select frames received from the aggregated ports in any order. Since there are no means for frames to be misordered on a single link, this guarantees that frame ordering is maintained for any conversation.

g) Conversations may be moved among ports within an aggregation, both for load balancing and to maintain availability in the event of link failures.

The standard requires ordering for frames within any one
conversation, but does not require ordering of frames between conversations.

The layer2 (MAC) and layer3 (MAC + IP) hashes in bonding are
compliant to this. The layer3+4 (IP + TCP/UDP port) is not, because fragmented datagrams will hash differently than unfragmented datagrams. I've not heard that this noncompliance has been a problem in actual practice.

	-J

---
-Jay Vosburgh, IBM Linux Technology Center, [email protected]

#4 lore raw
In reply to David Lamparter
Quoted 4 lines · David Lamparter

No, it isn't. 802.3ad/.1AX explicitly requires that no packet re-ordering may ever occur, which can only be guaranteed by enqueueing packets for one host on one TX interface. This behaviour is mandated by 802.1AX-2008 page 15 which reads:

Outch, that does cause a big problem for store-and-forward switching. You basically can't split up packets from a single stream without very careful cut-through switching, which we obviously can't do in Linux. That seems a rather silly requirement given that higher level protocols already deal with packet reordering. Why not an option to say stuff the standard?

#5 lore raw
Quoted 6 lines · Phillip Susi
Quoted 4 lines · David Lamparter

No, it isn't. 802.3ad/.1AX explicitly requires that no packet re-ordering may ever occur, which can only be guaranteed by enqueueing packets for one host on one TX interface. This behaviour is mandated by 802.1AX-2008 page 15 which reads:

Quoted 6 lines

Outch, that does cause a big problem for store-and-forward switching. You basically can't split up packets from a single stream without very careful cut-through switching, which we obviously can't do in Linux. That seems a rather silly requirement given that higher level protocols already deal with packet reordering. Why not an option to say stuff the standard?

Packet reordering introduces jitter, which is bad for things like VOIP.

Signature · 3 lines
Chris Adams <[email protected]>
Systems and Network Administrator - HiWAAY Internet Services
I don't speak for anybody but myself - that's enough trouble.
#6 lore raw
In reply to Phillip Susi
Quoted 6 lines · Phillip Susi
Quoted 4 lines · David Lamparter

No, it isn't. 802.3ad/.1AX explicitly requires that no packet re-ordering may ever occur, which can only be guaranteed by enqueueing packets for one host on one TX interface. This behaviour is mandated by 802.1AX-2008 page 15 which reads:

Quoted 6 lines

Outch, that does cause a big problem for store-and-forward switching. You basically can't split up packets from a single stream without very careful cut-through switching, which we obviously can't do in Linux. That seems a rather silly requirement given that higher level protocols already deal with packet reordering. Why not an option to say stuff the standard?

Bonding doesn't know about "higher level protocols". Also, assuming that higher level protocols already deal with reordering can be dangerous. I've dealt with network protocols and apps that assumed there would be no reordering because at the time they were written they used point-to-point links. They actually work fairly well with single links, so it would be reasonable to try and keep them working with bonded links.

Chris

Signature · 5 lines
Chris Friesen
Software Developer
GENBAND
[email protected]
www.genband.com
#7 lore raw
Quoted 6 lines · Chris Friesen

Bonding doesn't know about "higher level protocols". Also, assuming that higher level protocols already deal with reordering can be dangerous. I've dealt with network protocols and apps that assumed there would be no reordering because at the time they were written they used point-to-point links. They actually work fairly well with single links, so it would be reasonable to try and keep them working with bonded links.

Try, sure, but if you can't without seriously affecting performance, then having a knob for damn the torpedoes, full speed ahead mode seems reasonable.

I wonder how it is that people have reported that Windows machines manage to do this? Come to think of it, can windows even bond in software? Maybe it's only possible on Windows with dual port cards where the drivers and hardware can make sure that the bonded interfaces service a single queue and maintain ordering that way?

#8 lore raw
Quoted 12 lines · Phillip Susi
Quoted 6 lines · Chris Friesen

Bonding doesn't know about "higher level protocols". Also, assuming that higher level protocols already deal with reordering can be dangerous. I've dealt with network protocols and apps that assumed there would be no reordering because at the time they were written they used point-to-point links. They actually work fairly well with single links, so it would be reasonable to try and keep them working with bonded links.

Try, sure, but if you can't without seriously affecting performance, then having a knob for damn the torpedoes, full speed ahead mode seems reasonable.

Quoted 5 lines

I wonder how it is that people have reported that Windows machines manage to do this? Come to think of it, can windows even bond in software? Maybe it's only possible on Windows with dual port cards where the drivers and hardware can make sure that the bonded interfaces service a single queue and maintain ordering that way?

Microsoft doesn't provide a generic bonding driver for Windows. (This probably a sensible choice, considering how many different things people expect the Linux bonding driver to do.) Some hardware vendors provide bonding or 'teaming' drivers that work with their own hardware, and sometimes with other drivers as well. So if people report that 'Windows machines manage to do this' then you need to ask those people *which* driver they are using.

Ben.

Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
#9 lore raw
In reply to Phillip Susi
Quoted 3 lines · Phillip Susi

Try, sure, but if you can't without seriously affecting performance, then having a knob for damn the torpedoes, full speed ahead mode seems reasonable.

Packet reordering often affects performance. It can easily be more costly than losing half the bandwidth of a bundled link.

These days you are even dependent on the NIC firmware for good performance with TCP for reordered packets -- if the NIC is bad at handling them, you don't get any performance boost from GRO.

For UDP, applications have to handle it on their own.

/Benny

#10 lore raw
In reply to Phillip Susi
Quoted 6 lines · Phillip Susi
Quoted 4 lines · David Lamparter

No, it isn't. 802.3ad/.1AX explicitly requires that no packet re-ordering may ever occur, which can only be guaranteed by enqueueing packets for one host on one TX interface. This behaviour is mandated by 802.1AX-2008 page 15 which reads:

Quoted 6 lines

Outch, that does cause a big problem for store-and-forward switching. You basically can't split up packets from a single stream without very careful cut-through switching, which we obviously can't do in Linux. That seems a rather silly requirement given that higher level protocols already deal with packet reordering. Why not an option to say stuff the standard?

At even in the case of protocols that deal with packet reordering, it is still quite possible to be sub-optimal. Try running a TCP_STREAM test through a mode-rr bond with 4 or more links in it. I suspect that even without injecting the occasional "other" packet there can be enough re-ordering to trigger spurious fast retransmissions. At the very least it will trigger lots of immediate ACKnowledgements, which will drive-up the CPU utilization per KB transferred. And if these spread packets arrive still spread at the receiver, round-robin will probably preclude effective GRO and certainly preclude LRO.

Apart from some very carefully controlled conditions, if one needs a single flow to go faster than a single link, it is probably time to move up to the next higher link speed.

rick jones