OMAP4: Temperature sensor driver

The device file adds the device support for OMAP4
on die temperature sensor.

Signed-off-by Keerthy <[email protected]>

---
 arch/arm/mach-omap2/Makefile                       |    3 +-
 arch/arm/mach-omap2/temp_sensor_device.c           |   85 +++++++++++++++++++
 arch/arm/plat-omap/Kconfig                         |   12 +++
 .../plat-omap/include/plat/temperature_sensor.h    |   87 ++++++++++++++++++++
 4 files changed, 186 insertions(+), 1 deletions(-)
 create mode 100644 arch/arm/mach-omap2/temp_sensor_device.c
 create mode 100644 arch/arm/plat-omap/include/plat/temperature_sensor.h

arch/arm/mach-omap2/Makefile +2 -1

index fb02937..5812fb4 100644
@@ -18,6 +18,7 @@ obj-$(CONFIG_ARCH_OMAP4) += prm44xx.o $(hwmod-common)
 
 obj-$(CONFIG_OMAP_MCBSP) += mcbsp.o
 
+obj-$(CONFIG_OMAP_TEMP_SENSOR)          += temp_sensor_device.o
 obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
 
 # SMP support ONLY available for OMAP4

@@ -86,7 +87,7 @@ obj-$(CONFIG_ARCH_OMAP3)		+= prcm.o cm2xxx_3xxx.o prm2xxx_3xxx.o \
 obj-$(CONFIG_ARCH_OMAP4)		+= prcm.o cm2xxx_3xxx.o cminst44xx.o \
 					   cm44xx.o prcm_mpu44xx.o \
 					   prminst44xx.o vc44xx_data.o \
-					   vp44xx_data.o
+					   vp44xx_data.o temp_sensor4460_data.o
 
 # OMAP voltage domains
 ifeq ($(CONFIG_PM),y)

arch/arm/mach-omap2/temp_sensor_device.c new file +27 -0

new file mode 100644
index 0000000..5d5e92f
@@ -0,0 +1,85 @@
+/*
+ * OMAP on die Temperature sensor device file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#include <linux/err.h>
+#include <linux/slab.h>
+#include <linux/io.h>
+#include <linux/pm_runtime.h>
+#include <plat/omap_device.h>

arch/arm/mach-omap2/temp_sensor_device.c new file +27 -0

+	temp_sensor_pdata =
+	    kzalloc(sizeof(*temp_sensor_pdata), GFP_KERNEL);
+	if (!temp_sensor_pdata) {
+		dev_err(&oh->od->pdev.dev,
+			"Unable to allocate memory for temp sensor pdata\n");
+		return -ENOMEM;
+	}
+
+	temp_sensor_dev_attr = oh->dev_attr;
+	if (!strcmp(temp_sensor_dev_attr->name, "mpu"))
+		temp_sensor_pdata->registers = &omap_mpu_temp_sensor_registers;
+
+	od = omap_device_build("omap_temp_sensor", device_count++,
+		oh, temp_sensor_pdata, sizeof(*temp_sensor_pdata),
+	       omap_temp_sensor_latency,
+			ARRAY_SIZE(omap_temp_sensor_latency), 0);
+	if (IS_ERR(od)) {
+		dev_warn(&oh->od->pdev.dev,
+			"Could not build omap_device for %s\n", oh->name);
+		ret = PTR_ERR(od);
+	}
+
+	kfree(temp_sensor_pdata);
+
+	return ret;
+}
+

arch/arm/plat-omap/Kconfig +1 -0

index 6e6735f..8fd8e80 100644
@@ -115,6 +115,18 @@ config OMAP_MCBSP
 	  Say Y here if you want support for the OMAP Multichannel
 	  Buffered Serial Port.
 
+config OMAP_TEMP_SENSOR

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +58 -0

new file mode 100644
index 0000000..692ebdc
@@ -0,0 +1,87 @@
+/*
+ * OMAP Temperature sensor header file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+#define __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+
+/* Offsets from the base of temperature sensor registers */
+
+#define OMAP4460_TEMP_SENSOR_CTRL_OFFSET	0x00
+#define OMAP4460_BGAP_CTRL_OFFSET		0x4c
+#define OMAP4460_BGAP_COUNTER_OFFSET		0x50
+#define OMAP4460_BGAP_THRESHOLD_OFFSET		0x54
+#define OMAP4460_BGAP_TSHUT_OFFSET		0x58
+#define OMAP4460_BGAP_STATUS_OFFSET		0x5c
+#define OMAP4460_FUSE_OPP_BGAP			-0xcc
+
+struct omap_temp_sensor_registers {
+	u32	temp_sensor_ctrl;
+	u32	bgap_tempsoff_mask;
+	u32	bgap_soc_mask;
+	u32	bgap_eocz_mask;
+	u32	bgap_dtemp_mask;
+
+	u32	bgap_mask_ctrl;
+	u32	mask_hot_mask;
+	u32	mask_cold_mask;
+
+	u32	bgap_mode_ctrl;
+	u32	mode_ctrl_mask;
+
+	u32	bgap_counter;
+	u32	counter_mask;
+
+	u32	bgap_threshold;
+	u32	threshold_thot_mask;
+	u32	threshold_tcold_mask;
+
+	u32	thsut_threshold;
+	u32	tshut_hot_mask;

arch/arm/mach-omap2/temp_sensor_device.c line 85

Quoted 11 lines · Keerthy

arch/arm/mach-omap2/temp_sensor_device.c new file +11 -0

+
+int __init omap_devinit_temp_sensor(void)
+{
+	if (!cpu_is_omap446x())
+		return 0;
+
+	return omap_hwmod_for_each_by_class("temperature_sensor",
+			temp_sensor_dev_init, NULL);
+}
+
+arch_initcall(omap_devinit_temp_sensor);

I really dislike people adding more and more *initcall() to their pieces of code. But Tony is the final Judge.

Quoted 16 lines · Felipe Balbi

arch/arm/mach-omap2/temp_sensor_device.c line 85

Quoted 11 lines · Keerthy

arch/arm/mach-omap2/temp_sensor_device.c new file +11 -0

+
+int __init omap_devinit_temp_sensor(void)
+{
+	if (!cpu_is_omap446x())
+		return 0;
+
+	return omap_hwmod_for_each_by_class("temperature_sensor",
+			temp_sensor_dev_init, NULL);
+}
+
+arch_initcall(omap_devinit_temp_sensor);

I really dislike people adding more and more *initcall() to their pieces of code. But Tony is the final Judge.

Yes how about making this just a regular device driver and have it live under drivers/ somewhere?

Or is there some reason why this could not be a loadable module?

Hi,

Quoted 21 lines · Tony Lindgren

Quoted 16 lines · Felipe Balbi

arch/arm/mach-omap2/temp_sensor_device.c line 85

Quoted 11 lines · Keerthy

arch/arm/mach-omap2/temp_sensor_device.c new file +11 -0

+
+int __init omap_devinit_temp_sensor(void)
+{
+	if (!cpu_is_omap446x())
+		return 0;
+
+	return omap_hwmod_for_each_by_class("temperature_sensor",
+			temp_sensor_dev_init, NULL);
+}
+
+arch_initcall(omap_devinit_temp_sensor);

I really dislike people adding more and more *initcall() to their pieces of code. But Tony is the final Judge.

Yes how about making this just a regular device driver and have it live under drivers/ somewhere?

Quoted 1 line

Or is there some reason why this could not be a loadable module?

driver is loadable, this is just creating the platform_device, but still I don't think it deserves its own arch_initcall(), it could very well be something which is called after we know we're running at omap4, or called by each board...

Quoted 24 lines · Felipe

Hi,

Quoted 21 lines · Tony Lindgren

Quoted 16 lines · Felipe Balbi

arch/arm/mach-omap2/temp_sensor_device.c line 85

Quoted 11 lines · Keerthy

arch/arm/mach-omap2/temp_sensor_device.c new file +11 -0

+
+int __init omap_devinit_temp_sensor(void)
+{
+	if (!cpu_is_omap446x())
+		return 0;
+
+	return omap_hwmod_for_each_by_class("temperature_sensor",
+			temp_sensor_dev_init, NULL);
+}
+
+arch_initcall(omap_devinit_temp_sensor);

I really dislike people adding more and more *initcall() to their pieces of code. But Tony is the final Judge.

Yes how about making this just a regular device driver and have it live under drivers/ somewhere?

Quoted 6 lines

Quoted 1 line

Or is there some reason why this could not be a loadable module?

driver is loadable, this is just creating the platform_device, but still I don't think it deserves its own arch_initcall(), it could very well be something which is called after we know we're running at omap4, or called by each board...

Funny, because I thought we were trying to get rid of the ugly init devices from board file to use *initcall() from a dedicated device file.
The advantage is that you do not have anymore a central place that everybody will change and that is thus subject to merge conflicts.

The drawback is that you do not know where an when the devices are created.

That being said, device-tree will provide a nice way to build all this devices without any initcall or board hacks.
This is just a temporary issue :-)

Hi,

(you should Cc Tony, as he's OMAP maintainer)

Quoted 71 lines · Keerthy

The device file adds the device support for OMAP4
on die temperature sensor.

Signed-off-by Keerthy <[email protected]>

---
 arch/arm/mach-omap2/Makefile                       |    3 +- arch/arm/mach-omap2/temp_sensor_device.c           |   85 +++++++++++++++++++ arch/arm/plat-omap/Kconfig                         |   12 +++ .../plat-omap/include/plat/temperature_sensor.h    |   87 ++++++++++++++++++++

 4 files changed, 186 insertions(+), 1 deletions(-)

 create mode 100644 arch/arm/mach-omap2/temp_sensor_device.c create mode 100644 arch/arm/plat-omap/include/plat/temperature_sensor.h

arch/arm/mach-omap2/Makefile +0 -0

index fb02937..5812fb4 100644
@@ -18,6 +18,7 @@ obj-$(CONFIG_ARCH_OMAP4) += prm44xx.o $(hwmod-common)
 

 obj-$(CONFIG_OMAP_MCBSP) += mcbsp.o

+obj-$(CONFIG_OMAP_TEMP_SENSOR)          += temp_sensor_device.o obj-$(CONFIG_TWL4030_CORE) += omap_twl.o

 # SMP support ONLY available for OMAP4

arch/arm/mach-omap2/Makefile +1 -1

@@ -86,7 +87,7 @@ obj-$(CONFIG_ARCH_OMAP3)            += prcm.o cm2xxx_3xxx.o prm2xxx_3xxx.o \
  obj-$(CONFIG_ARCH_OMAP4)             += prcm.o cm2xxx_3xxx.o cminst44xx.o \
                                          cm44xx.o prcm_mpu44xx.o \
                                          prminst44xx.o vc44xx_data.o \
-                                        vp44xx_data.o
+                                        vp44xx_data.o temp_sensor4460_data.o
 
  # OMAP voltage domains
  ifeq ($(CONFIG_PM),y)

arch/arm/mach-omap2/temp_sensor_device.c new file +31 -0

new file mode 100644
index 0000000..5d5e92f
@@ -0,0 +1,85 @@
+/*
+ * OMAP on die Temperature sensor device file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#include <linux/err.h>
+#include <linux/slab.h>
+#include <linux/io.h>
+#include <linux/pm_runtime.h>
+#include <plat/omap_device.h>
+#include "control.h"
+#include "pm.h"
+#include <plat/temperature_sensor.h>
+

arch/arm/mach-omap2/temp_sensor_device.c line 37

Quoted 6 lines

arch/arm/mach-omap2/temp_sensor_device.c new file +6 -0

+static struct omap_device_pm_latency omap_temp_sensor_latency[] = {
+     {
+      .deactivate_func = omap_device_idle_hwmods,
+      .activate_func = omap_device_enable_hwmods,
+      .flags = OMAP_DEVICE_LATENCY_AUTO_ADJUST,
+     }

wrong indentation.

arch/arm/mach-omap2/temp_sensor_device.c line 46

Quoted 9 lines

arch/arm/mach-omap2/temp_sensor_device.c new file +9 -0

+};
+
+static int temp_sensor_dev_init(struct omap_hwmod *oh, void *user)
+{
+     struct  omap_temp_sensor_pdata          *temp_sensor_pdata;
+     struct  omap_device                     *od;
+     struct  omap_temp_sensor_dev_attr       *temp_sensor_dev_attr;
+     int                                     ret;
+     static int                              device_count;

use an IDR here (see include/linux/idr.h)

arch/arm/mach-omap2/temp_sensor_device.c line 48

Quoted 2 lines

arch/arm/mach-omap2/temp_sensor_device.c new file +1 -0

+     ret = 0;

initialize on the declarion and you can avoid this line.

Quoted 28 lines

arch/arm/mach-omap2/temp_sensor_device.c new file +27 -0

+     temp_sensor_pdata =
+         kzalloc(sizeof(*temp_sensor_pdata), GFP_KERNEL);
+     if (!temp_sensor_pdata) {
+             dev_err(&oh->od->pdev.dev,
+                     "Unable to allocate memory for temp sensor pdata\n");
+             return -ENOMEM;
+     }
+
+     temp_sensor_dev_attr = oh->dev_attr;
+     if (!strcmp(temp_sensor_dev_attr->name, "mpu"))
+             temp_sensor_pdata->registers = &omap_mpu_temp_sensor_registers;
+
+     od = omap_device_build("omap_temp_sensor", device_count++,
+             oh, temp_sensor_pdata, sizeof(*temp_sensor_pdata),
+            omap_temp_sensor_latency,
+                     ARRAY_SIZE(omap_temp_sensor_latency), 0);
+     if (IS_ERR(od)) {
+             dev_warn(&oh->od->pdev.dev,
+                     "Could not build omap_device for %s\n", oh->name);
+             ret = PTR_ERR(od);
+     }
+
+     kfree(temp_sensor_pdata);
+
+     return ret;
+}
+

arch/arm/mach-omap2/temp_sensor_device.c line 85

Quoted 10 lines

arch/arm/mach-omap2/temp_sensor_device.c new file +10 -0

+int __init omap_devinit_temp_sensor(void)
+{
+     if (!cpu_is_omap446x())
+             return 0;
+
+     return omap_hwmod_for_each_by_class("temperature_sensor",
+                     temp_sensor_dev_init, NULL);
+}
+
+arch_initcall(omap_devinit_temp_sensor);

I really dislike people adding more and more *initcall() to their pieces of code. But Tony is the final Judge.

Quoted 8 lines

arch/arm/plat-omap/Kconfig +0 -0

index 6e6735f..8fd8e80 100644
@@ -115,6 +115,18 @@ config OMAP_MCBSP

        Say Y here if you want support for the OMAP Multichannel Buffered Serial Port.

arch/arm/plat-omap/Kconfig config OMAP_MCBSP · line 128

Quoted 11 lines

arch/arm/plat-omap/Kconfig +11 -0

+config OMAP_TEMP_SENSOR
+     bool "OMAP Temp Sensor Support"
+     depends on ARCH_OMAP
+     default n
+     help
+       Say Y here if you want support for the temp sensor
+       on OMAP4460.
+
+       This provides the temperature of the MPU
+       subsystem. Only one instance of on die temperature
+       sensor is present.

if there's only one instance, why do you use
omap_hwmod_for_each_by_class() ??

Quoted 70 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +63 -0

new file mode 100644
index 0000000..692ebdc
@@ -0,0 +1,87 @@
+/*
+ * OMAP Temperature sensor header file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+#define __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+
+/* Offsets from the base of temperature sensor registers */
+
+#define OMAP4460_TEMP_SENSOR_CTRL_OFFSET     0x00
+#define OMAP4460_BGAP_CTRL_OFFSET            0x4c
+#define OMAP4460_BGAP_COUNTER_OFFSET         0x50
+#define OMAP4460_BGAP_THRESHOLD_OFFSET               0x54
+#define OMAP4460_BGAP_TSHUT_OFFSET           0x58
+#define OMAP4460_BGAP_STATUS_OFFSET          0x5c
+#define OMAP4460_FUSE_OPP_BGAP                       -0xcc
+
+struct omap_temp_sensor_registers {
+     u32     temp_sensor_ctrl;
+     u32     bgap_tempsoff_mask;
+     u32     bgap_soc_mask;
+     u32     bgap_eocz_mask;
+     u32     bgap_dtemp_mask;
+
+     u32     bgap_mask_ctrl;
+     u32     mask_hot_mask;
+     u32     mask_cold_mask;
+
+     u32     bgap_mode_ctrl;
+     u32     mode_ctrl_mask;
+
+     u32     bgap_counter;
+     u32     counter_mask;
+
+     u32     bgap_threshold;
+     u32     threshold_thot_mask;
+     u32     threshold_tcold_mask;
+
+     u32     thsut_threshold;
+     u32     tshut_hot_mask;
+     u32     tshut_cold_mask;
+
+     u32     bgap_status;
+     u32     status_clean_stop_mask;
+     u32     status_bgap_alert_mask;

arch/arm/plat-omap/include/plat/temperature_sensor.h line 68

Quoted 5 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +5 -0

+     u32     status_hot_mask;
+     u32     status_cold_mask;
+
+     u32     bgap_efuse;
+};

I find it unnecessary to pass the register map to driver using platform_data.

arch/arm/plat-omap/include/plat/temperature_sensor.h line 72

Quoted 4 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +3 -0

+/*
+ * @name: Name of the domain of the temperature sensor
+ */

comment fits in one line.

--
balbi

Quoted 8 lines

Quoted 8 lines

arch/arm/plat-omap/Kconfig +0 -0

index 6e6735f..8fd8e80 100644
@@ -115,6 +115,18 @@ config OMAP_MCBSP

        Say Y here if you want support for the OMAP Multichannel Buffered Serial Port.

Quoted 14 lines

arch/arm/plat-omap/Kconfig config OMAP_MCBSP · line 128

Quoted 11 lines

arch/arm/plat-omap/Kconfig +11 -0

+config OMAP_TEMP_SENSOR
+     bool "OMAP Temp Sensor Support"
+     depends on ARCH_OMAP
+     default n
+     help
+       Say Y here if you want support for the temp sensor
+       on OMAP4460.
+
+       This provides the temperature of the MPU
+       subsystem. Only one instance of on die temperature
+       sensor is present.

if there's only one instance, why do you use
omap_hwmod_for_each_by_class() ??

In case of OMAP5 there are multiple instances. Hence using omap_hwmod_for_each_by_class().

Quoted 69 lines

Quoted 69 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +63 -0

new file mode 100644
index 0000000..692ebdc
@@ -0,0 +1,87 @@
+/*
+ * OMAP Temperature sensor header file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+#define __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+
+/* Offsets from the base of temperature sensor registers */
+
+#define OMAP4460_TEMP_SENSOR_CTRL_OFFSET     0x00
+#define OMAP4460_BGAP_CTRL_OFFSET            0x4c
+#define OMAP4460_BGAP_COUNTER_OFFSET         0x50
+#define OMAP4460_BGAP_THRESHOLD_OFFSET               0x54
+#define OMAP4460_BGAP_TSHUT_OFFSET           0x58
+#define OMAP4460_BGAP_STATUS_OFFSET          0x5c
+#define OMAP4460_FUSE_OPP_BGAP                       -0xcc
+
+struct omap_temp_sensor_registers {
+     u32     temp_sensor_ctrl;
+     u32     bgap_tempsoff_mask;
+     u32     bgap_soc_mask;
+     u32     bgap_eocz_mask;
+     u32     bgap_dtemp_mask;
+
+     u32     bgap_mask_ctrl;
+     u32     mask_hot_mask;
+     u32     mask_cold_mask;
+
+     u32     bgap_mode_ctrl;
+     u32     mode_ctrl_mask;
+
+     u32     bgap_counter;
+     u32     counter_mask;
+
+     u32     bgap_threshold;
+     u32     threshold_thot_mask;
+     u32     threshold_tcold_mask;
+
+     u32     thsut_threshold;
+     u32     tshut_hot_mask;
+     u32     tshut_cold_mask;
+
+     u32     bgap_status;
+     u32     status_clean_stop_mask;
+     u32     status_bgap_alert_mask;

Quoted 8 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h line 68

Quoted 5 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +5 -0

+     u32     status_hot_mask;
+     u32     status_cold_mask;
+
+     u32     bgap_efuse;
+};

I find it unnecessary to pass the register map to driver using platform_data.

With multiple instances the register map to individual instances will change. So passing it via platform_data.

Hi,

Quoted 23 lines · KEERTHY

Quoted 22 lines

Quoted 9 lines

arch/arm/plat-omap/Kconfig +0 -0

index 6e6735f..8fd8e80 100644
@@ -115,6 +115,18 @@ config OMAP_MCBSP

        Say Y here if you want support for the OMAP Multichannel Buffered Serial Port.

arch/arm/plat-omap/Kconfig +1 -0

+config OMAP_TEMP_SENSOR

arch/arm/plat-omap/Kconfig config OMAP_MCBSP · line 128

Quoted 10 lines

arch/arm/plat-omap/Kconfig +10 -0

+     bool "OMAP Temp Sensor Support"
+     depends on ARCH_OMAP
+     default n
+     help
+       Say Y here if you want support for the temp sensor
+       on OMAP4460.
+
+       This provides the temperature of the MPU
+       subsystem. Only one instance of on die temperature
+       sensor is present.

if there's only one instance, why do you use
omap_hwmod_for_each_by_class() ??

Quoted 2 lines

In case of OMAP5 there are multiple instances. Hence using omap_hwmod_for_each_by_class().

that's not a reality yet, so why don't you leave it for when OMAP5 is around ?

Quoted 79 lines

Quoted 78 lines

Quoted 65 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +58 -0

new file mode 100644
index 0000000..692ebdc
@@ -0,0 +1,87 @@
+/*
+ * OMAP Temperature sensor header file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+#define __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+
+/* Offsets from the base of temperature sensor registers */
+
+#define OMAP4460_TEMP_SENSOR_CTRL_OFFSET     0x00
+#define OMAP4460_BGAP_CTRL_OFFSET            0x4c
+#define OMAP4460_BGAP_COUNTER_OFFSET         0x50
+#define OMAP4460_BGAP_THRESHOLD_OFFSET               0x54
+#define OMAP4460_BGAP_TSHUT_OFFSET           0x58
+#define OMAP4460_BGAP_STATUS_OFFSET          0x5c
+#define OMAP4460_FUSE_OPP_BGAP                       -0xcc
+
+struct omap_temp_sensor_registers {
+     u32     temp_sensor_ctrl;
+     u32     bgap_tempsoff_mask;
+     u32     bgap_soc_mask;
+     u32     bgap_eocz_mask;
+     u32     bgap_dtemp_mask;
+
+     u32     bgap_mask_ctrl;
+     u32     mask_hot_mask;
+     u32     mask_cold_mask;
+
+     u32     bgap_mode_ctrl;
+     u32     mode_ctrl_mask;
+
+     u32     bgap_counter;
+     u32     counter_mask;
+
+     u32     bgap_threshold;
+     u32     threshold_thot_mask;
+     u32     threshold_tcold_mask;
+
+     u32     thsut_threshold;
+     u32     tshut_hot_mask;

arch/arm/plat-omap/include/plat/temperature_sensor.h line 68

Quoted 10 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +10 -0

+     u32     tshut_cold_mask;
+
+     u32     bgap_status;
+     u32     status_clean_stop_mask;
+     u32     status_bgap_alert_mask;
+     u32     status_hot_mask;
+     u32     status_cold_mask;
+
+     u32     bgap_efuse;
+};

I find it unnecessary to pass the register map to driver using platform_data.

Quoted 2 lines

With multiple instances the register map to individual instances will change. So passing it via platform_data.

what will change is the base address, the offsets should remain the same.

--
balbi

Quoted 29 lines · Felipe Balbi

Hi,

Quoted 25 lines · KEERTHY

Quoted 8 lines

Quoted 8 lines

arch/arm/plat-omap/Kconfig +0 -0

index 6e6735f..8fd8e80 100644
@@ -115,6 +115,18 @@ config OMAP_MCBSP

        Say Y here if you want support for the OMAP Multichannel Buffered Serial Port.

Quoted 14 lines

arch/arm/plat-omap/Kconfig config OMAP_MCBSP · line 128

Quoted 11 lines

arch/arm/plat-omap/Kconfig +11 -0

+config OMAP_TEMP_SENSOR
+     bool "OMAP Temp Sensor Support"
+     depends on ARCH_OMAP
+     default n
+     help
+       Say Y here if you want support for the temp sensor
+       on OMAP4460.
+
+       This provides the temperature of the MPU
+       subsystem. Only one instance of on die temperature
+       sensor is present.

if there's only one instance, why do you use
omap_hwmod_for_each_by_class() ??

In case of OMAP5 there are multiple instances. Hence using omap_hwmod_for_each_by_class().

Quoted 2 lines

that's not a reality yet, so why don't you leave it for when OMAP5 is around ?

Keeping it generic so that we need not change again. We are pretty close to reality i guess. Why not keep it generic? Any specific reason for not keeping this loop?

Quoted 78 lines

Quoted 78 lines

Quoted 77 lines

Quoted 64 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +58 -0

new file mode 100644
index 0000000..692ebdc
@@ -0,0 +1,87 @@
+/*
+ * OMAP Temperature sensor header file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+#define __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+
+/* Offsets from the base of temperature sensor registers */
+
+#define OMAP4460_TEMP_SENSOR_CTRL_OFFSET     0x00
+#define OMAP4460_BGAP_CTRL_OFFSET            0x4c
+#define OMAP4460_BGAP_COUNTER_OFFSET         0x50
+#define OMAP4460_BGAP_THRESHOLD_OFFSET               0x54
+#define OMAP4460_BGAP_TSHUT_OFFSET           0x58
+#define OMAP4460_BGAP_STATUS_OFFSET          0x5c
+#define OMAP4460_FUSE_OPP_BGAP                       -0xcc
+
+struct omap_temp_sensor_registers {
+     u32     temp_sensor_ctrl;
+     u32     bgap_tempsoff_mask;
+     u32     bgap_soc_mask;
+     u32     bgap_eocz_mask;
+     u32     bgap_dtemp_mask;
+
+     u32     bgap_mask_ctrl;
+     u32     mask_hot_mask;
+     u32     mask_cold_mask;
+
+     u32     bgap_mode_ctrl;
+     u32     mode_ctrl_mask;
+
+     u32     bgap_counter;
+     u32     counter_mask;
+
+     u32     bgap_threshold;
+     u32     threshold_thot_mask;
+     u32     threshold_tcold_mask;
+
+     u32     thsut_threshold;
+     u32     tshut_hot_mask;

arch/arm/plat-omap/include/plat/temperature_sensor.h line 68

Quoted 10 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +10 -0

+     u32     tshut_cold_mask;
+
+     u32     bgap_status;
+     u32     status_clean_stop_mask;
+     u32     status_bgap_alert_mask;
+     u32     status_hot_mask;
+     u32     status_cold_mask;
+
+     u32     bgap_efuse;
+};

I find it unnecessary to pass the register map to driver using platform_data.

Quoted 5 lines

Quoted 2 lines

With multiple instances the register map to individual instances will change. So passing it via platform_data.

what will change is the base address, the offsets should remain the same.

The base address offsets and even bit fields seem to be differing across different OMAP versions.

Hi,

Quoted 30 lines · KEERTHY

Quoted 29 lines · Felipe Balbi

Hi,

Quoted 25 lines · KEERTHY

Quoted 8 lines

Quoted 8 lines

arch/arm/plat-omap/Kconfig +0 -0

index 6e6735f..8fd8e80 100644
@@ -115,6 +115,18 @@ config OMAP_MCBSP

        Say Y here if you want support for the OMAP Multichannel Buffered Serial Port.

Quoted 14 lines

arch/arm/plat-omap/Kconfig config OMAP_MCBSP · line 128

Quoted 11 lines

arch/arm/plat-omap/Kconfig +11 -0

+config OMAP_TEMP_SENSOR
+     bool "OMAP Temp Sensor Support"
+     depends on ARCH_OMAP
+     default n
+     help
+       Say Y here if you want support for the temp sensor
+       on OMAP4460.
+
+       This provides the temperature of the MPU
+       subsystem. Only one instance of on die temperature
+       sensor is present.

if there's only one instance, why do you use
omap_hwmod_for_each_by_class() ??

In case of OMAP5 there are multiple instances. Hence using omap_hwmod_for_each_by_class().

Quoted 6 lines

Quoted 2 lines

that's not a reality yet, so why don't you leave it for when OMAP5 is around ?

Keeping it generic so that we need not change again. We are pretty close to reality i guess. Why not keep it generic? Any specific reason for not keeping this loop?

Other than the loop being completely unnecessary on the only OMAP version you're supporting ? no... not really.

Quoted 84 lines

Quoted 83 lines

Quoted 78 lines

Quoted 69 lines

Quoted 69 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +63 -0

new file mode 100644
index 0000000..692ebdc
@@ -0,0 +1,87 @@
+/*
+ * OMAP Temperature sensor header file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+#define __ARCH_ARM_PLAT_OMAP_INCLUDE_PLAT_TEMPERATURE_SENSOR_H
+
+/* Offsets from the base of temperature sensor registers */
+
+#define OMAP4460_TEMP_SENSOR_CTRL_OFFSET     0x00
+#define OMAP4460_BGAP_CTRL_OFFSET            0x4c
+#define OMAP4460_BGAP_COUNTER_OFFSET         0x50
+#define OMAP4460_BGAP_THRESHOLD_OFFSET               0x54
+#define OMAP4460_BGAP_TSHUT_OFFSET           0x58
+#define OMAP4460_BGAP_STATUS_OFFSET          0x5c
+#define OMAP4460_FUSE_OPP_BGAP                       -0xcc
+
+struct omap_temp_sensor_registers {
+     u32     temp_sensor_ctrl;
+     u32     bgap_tempsoff_mask;
+     u32     bgap_soc_mask;
+     u32     bgap_eocz_mask;
+     u32     bgap_dtemp_mask;
+
+     u32     bgap_mask_ctrl;
+     u32     mask_hot_mask;
+     u32     mask_cold_mask;
+
+     u32     bgap_mode_ctrl;
+     u32     mode_ctrl_mask;
+
+     u32     bgap_counter;
+     u32     counter_mask;
+
+     u32     bgap_threshold;
+     u32     threshold_thot_mask;
+     u32     threshold_tcold_mask;
+
+     u32     thsut_threshold;
+     u32     tshut_hot_mask;
+     u32     tshut_cold_mask;
+
+     u32     bgap_status;
+     u32     status_clean_stop_mask;
+     u32     status_bgap_alert_mask;

Quoted 8 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h line 68

Quoted 5 lines

arch/arm/plat-omap/include/plat/temperature_sensor.h new file +5 -0

+     u32     status_hot_mask;
+     u32     status_cold_mask;
+
+     u32     bgap_efuse;
+};

I find it unnecessary to pass the register map to driver using platform_data.

Quoted 2 lines

With multiple instances the register map to individual instances will change. So passing it via platform_data.

what will change is the base address, the offsets should remain the same.

Quoted 2 lines

The base address offsets and even bit fields seem to be differing across different OMAP versions.

then a comment making that clear is necessary. But as of today, you support only one OMAP version, so I'm sure it's worth the trouble for a first version of the driver.

--
balbi

The register set and the
bit fields might vary across OMAP versions. Hence creating a structure comprising of all the registers and bit fields to make the driver uniform for all the versions with different register sets. The data file contains the structure populated with register offsets and bit fields corresponding to OMAP4460 on die sensor.

Signed-off-by Keerthy <[email protected]>

---
 arch/arm/mach-omap2/temp_sensor4460_data.c |   63 ++++++++++++++++++++++++++++
 1 files changed, 63 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/temp_sensor4460_data.c

arch/arm/mach-omap2/temp_sensor4460_data.c new file +21 -0

new file mode 100644
index 0000000..294963d
@@ -0,0 +1,63 @@
+/*
+ * OMAP4460 on die Temperature sensor data file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */

Hi,

Quoted 45 lines · Keerthy

The register set and the
bit fields might vary across OMAP versions. Hence creating a structure comprising of all the registers and bit fields to make the driver uniform for all the versions with different register sets. The data file contains the structure populated with register offsets and bit fields corresponding to OMAP4460 on die sensor.

Signed-off-by Keerthy <[email protected]>

---
 arch/arm/mach-omap2/temp_sensor4460_data.c |   63 ++++++++++++++++++++++++++++

 1 files changed, 63 insertions(+), 0 deletions(-)

 create mode 100644 arch/arm/mach-omap2/temp_sensor4460_data.c

arch/arm/mach-omap2/temp_sensor4460_data.c new file +25 -0

new file mode 100644
index 0000000..294963d
@@ -0,0 +1,63 @@
+/*
+ * OMAP4460 on die Temperature sensor data file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#include <linux/slab.h>
+#include "control.h"
+#include <plat/temperature_sensor.h>

arch/arm/mach-omap2/temp_sensor4460_data.c line 31

Quoted 6 lines

arch/arm/mach-omap2/temp_sensor4460_data.c new file +6 -0

+
+/*
+ * OMAP4460 has one instance of thermal sensor for MPU
+ * need to describe the individual bit fields
+ */
+struct omap_temp_sensor_registers omap_mpu_temp_sensor_registers = {

this is used on previous patch, so you have a compilation error.

--
balbi

On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user is allowed to configure the temperature thresholds vis sysfs nodes exposed using hwmon interface.

Signed-off-by Keerthy <[email protected]>

---
 drivers/hwmon/Kconfig            |   11 +
 drivers/hwmon/Makefile           |    1 +
 drivers/hwmon/omap_temp_sensor.c |  950 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 962 insertions(+), 0 deletions(-)
 create mode 100644 drivers/hwmon/omap_temp_sensor.c

drivers/hwmon/Kconfig +11 -0

index 5f888f7..9c9cd8b 100644
@@ -323,6 +323,17 @@ config SENSORS_F71805F
 	  This driver can also be built as a module.  If so, the module
 	  will be called f71805f.
 
+config SENSORS_OMAP_BANDGAP_TEMP_SENSOR
+	bool "OMAP on-die temperature sensor hwmon driver"
+	depends on HWMON && ARCH_OMAP && OMAP_TEMP_SENSOR
+	help
+	  If you say yes here you get support for hardware
+	  monitoring features of the OMAP on die temperature
+	  sensor.
+
+	  Continuous conversion programmable delay
+	  mode is used for temperature conversion.
+
 config SENSORS_F71882FG
 	tristate "Fintek F71882FG and compatibles"
 	help

drivers/hwmon/Makefile +1 -0

index 28061cf..d0f89f5 100644
@@ -91,6 +91,7 @@ obj-$(CONFIG_SENSORS_MAX6639)	+= max6639.o
 obj-$(CONFIG_SENSORS_MAX6642)	+= max6642.o
 obj-$(CONFIG_SENSORS_MAX6650)	+= max6650.o
 obj-$(CONFIG_SENSORS_MC13783_ADC)+= mc13783-adc.o
+obj-$(CONFIG_SENSORS_OMAP_BANDGAP_TEMP_SENSOR)  += omap_temp_sensor.o
 obj-$(CONFIG_SENSORS_PC87360)	+= pc87360.o
 obj-$(CONFIG_SENSORS_PC87427)	+= pc87427.o
 obj-$(CONFIG_SENSORS_PCF8591)	+= pcf8591.o

drivers/hwmon/omap_temp_sensor.c new file +15 -0

new file mode 100644
index 0000000..15e2559
@@ -0,0 +1,950 @@
+/*
+ * OMAP4 Temperature sensor driver file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ * Author: Moiz Sonasath <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.

drivers/hwmon/omap_temp_sensor.c new file +405 -0

+#define TSHUT_THRESHOLD_HOT	122000	/* 122 deg C */
+#define TSHUT_THRESHOLD_COLD	100000	/* 100 deg C */
+#define BGAP_THRESHOLD_T_HOT	73000	/* 73 deg C */
+#define BGAP_THRESHOLD_T_COLD	71000	/* 71 deg C */
+#define OMAP_ADC_START_VALUE	530
+#define OMAP_ADC_END_VALUE	923
+
+/*
+ * omap_temp_sensor structure
+ * @hwmon_dev - device pointer
+ * @clock - Clock pointer
+ * @registers - Pointer to structure with register offsets and bitfields
+ * @sensor_mutex - Mutex for sysfs, irq and PM
+ * @irq - MPU Irq number for thermal alert
+ * @phy_base - Physical base of the temp I/O
+ * @clk_rate - Holds current clock rate
+ * @temp_sensor_ctrl - temp sensor control register value
+ * @bg_ctrl - bandgap ctrl register value
+ * @bg_counter - bandgap counter value
+ * @bg_threshold - bandgap threshold register value
+ * @temp_sensor_tshut_threshold - bandgap tshut register value
+ * @is_efuse_valid - Flag to determine if efuse is valid or not
+ * @clk_on - Manages the current clock state
+ */
+struct omap_temp_sensor {
+	struct device		*hwmon_dev;
+	struct clk		*clock;
+	struct omap_temp_sensor_registers *registers;
+	struct mutex		sensor_mutex; /* Mutex for sysfs, irq and PM */
+	unsigned int		irq;
+	void __iomem		*phy_base;
+	u32			clk_rate;
+	u32			temp_sensor_ctrl;
+	u32			bg_ctrl;
+	u32			bg_counter;
+	u32			bg_threshold;
+	u32			temp_sensor_tshut_threshold;
+	bool                    is_efuse_valid;
+	bool                    clk_on;
+};
+
+/*
+ * Temperature values in milli degree celsius
+ * ADC code values from 530 to 923
+ */
+static int adc_to_temp[] = {
+	-40000, -40000, -40000, -40000, -39800, -39400, -39000, -38600, -38200,
+	-37800, -37300, -36800, -36400, -36000, -35600, -35200, -34800,
+	-34300, -33800, -33400, -33000, -32600, -32200, -31800, -31300,
+	-30800, -30400, -30000, -29600, -29200, -28700, -28200, -27800,
+	-27400, -27000, -26600, -26200, -25700, -25200, -24800, -24400,
+	-24000, -23600, -23200, -22700, -22200, -21800, -21400, -21000,
+	-20600, -20200, -19700, -19200, -18800, -18400, -18000, -17600,
+	-17200, -16700, -16200, -15800, -15400, -15000, -14600, -14200,
+	-13700, -13200, -12800, -12400, -12000, -11600, -11200, -10700,
+	-10200, -9800, -9400, -9000, -8600, -8200, -7700, -7200, -6800,
+	-6400, -6000, -5600, -5200, -4800, -4300, -3800, -3400, -3000,
+	-2600, -2200, -1800, -1300, -800, -400, 0, 400, 800, 1200, 1600,
+	2100, 2600, 3000, 3400, 3800, 4200, 4600, 5100, 5600, 6000, 6400,
+	6800, 7200, 7600, 8000, 8500, 9000, 9400, 9800, 10200, 10600, 11000,
+	11400, 11900, 12400, 12800, 13200, 13600, 14000, 14400, 14800,
+	15300, 15800, 16200, 16600, 17000, 17400, 17800, 18200, 18700,
+	19200, 19600, 20000, 20400, 20800, 21200, 21600, 22100, 22600,
+	23000, 23400, 23800, 24200, 24600, 25000, 25400, 25900, 26400,
+	26800, 27200, 27600, 28000, 28400, 28800, 29300, 29800, 30200,
+	30600, 31000, 31400, 31800, 32200, 32600, 33100, 33600, 34000,
+	34400, 34800, 35200, 35600, 36000, 36400, 36800, 37300, 37800,
+	38200, 38600, 39000, 39400, 39800, 40200, 40600, 41100, 41600,
+	42000, 42400, 42800, 43200, 43600, 44000, 44400, 44800, 45300,
+	45800, 46200, 46600, 47000, 47400, 47800, 48200, 48600, 49000,
+	49500, 50000, 50400, 50800, 51200, 51600, 52000, 52400, 52800,
+	53200, 53700, 54200, 54600, 55000, 55400, 55800, 56200, 56600,
+	57000, 57400, 57800, 58200, 58700, 59200, 59600, 60000, 60400,
+	60800, 61200, 61600, 62000, 62400, 62800, 63300, 63800, 64200,
+	64600, 65000, 65400, 65800, 66200, 66600, 67000, 67400, 67800,
+	68200, 68700, 69200, 69600, 70000, 70400, 70800, 71200, 71600,
+	72000, 72400, 72800, 73200, 73600, 74100, 74600, 75000, 75400,
+	75800, 76200, 76600, 77000, 77400, 77800, 78200, 78600, 79000,
+	79400, 79800, 80300, 80800, 81200, 81600, 82000, 82400, 82800,
+	83200, 83600, 84000, 84400, 84800, 85200, 85600, 86000, 86400,
+	86800, 87300, 87800, 88200, 88600, 89000, 89400, 89800, 90200,
+	90600, 91000, 91400, 91800, 92200, 92600, 93000, 93400, 93800,
+	94200, 94600, 95000, 95500, 96000, 96400, 96800, 97200, 97600,
+	98000, 98400, 98800, 99200, 99600, 100000, 100400, 100800, 101200,
+	101600, 102000, 102400, 102800, 103200, 103600, 104000, 104400,
+	104800, 105200, 105600, 106100, 106600, 107000, 107400, 107800,
+	108200, 108600, 109000, 109400, 109800, 110200, 110600, 111000,
+	111400, 111800, 112200, 112600, 113000, 113400, 113800, 114200,
+	114600, 115000, 115400, 115800, 116200, 116600, 117000, 117400,
+	117800, 118200, 118600, 119000, 119400, 119800, 120200, 120600,
+	121000, 121400, 121800, 122200, 122600, 123000
+};
+
+static unsigned long omap_temp_sensor_readl(struct omap_temp_sensor
+					    *temp_sensor, u32 reg)
+{
+	return __raw_readl(temp_sensor->phy_base + reg);
+}
+
+static void omap_temp_sensor_writel(struct omap_temp_sensor *temp_sensor,
+				    u32 val, u32 reg)
+{
+	__raw_writel(val, (temp_sensor->phy_base + reg));
+}
+
+static int adc_to_temp_conversion(int adc_val)
+{
+	return adc_to_temp[adc_val - OMAP_ADC_START_VALUE];
+}
+
+static int temp_to_adc_conversion(long temp)
+{
+	int i;
+
+	for (i = 0; i <= OMAP_ADC_END_VALUE - OMAP_ADC_START_VALUE; i++)
+		if (temp < adc_to_temp[i])
+			return OMAP_ADC_START_VALUE + i - 1;
+
+	return -EINVAL;
+}
+
+static void omap_configure_temp_sensor_thresholds(struct omap_temp_sensor
+						  *temp_sensor)
+{
+	u32 temp, t_hot, t_cold, tshut_hot, tshut_cold;
+
+	t_hot = temp_to_adc_conversion(BGAP_THRESHOLD_T_HOT);
+	t_cold = temp_to_adc_conversion(BGAP_THRESHOLD_T_COLD);
+
+	/* Configure the TALERT thresholds */
+	temp = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_threshold);
+	temp |= (t_hot << __ffs(temp_sensor->registers->threshold_thot_mask)) |
+		(t_cold << __ffs(temp_sensor->registers->threshold_tcold_mask));
+	omap_temp_sensor_writel(temp_sensor, temp,
+		temp_sensor->registers->bgap_threshold);
+
+	tshut_hot = temp_to_adc_conversion(TSHUT_THRESHOLD_HOT);
+	tshut_cold = temp_to_adc_conversion(TSHUT_THRESHOLD_COLD);
+
+	/* Configure the TSHUT thresholds */
+	temp = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->thsut_threshold);
+	temp |= (tshut_hot << __ffs(temp_sensor->registers->tshut_hot_mask))
+	    | (tshut_cold << __ffs(temp_sensor->registers->tshut_hot_mask));
+	omap_temp_sensor_writel(temp_sensor, temp,
+			temp_sensor->registers->thsut_threshold);
+}
+
+static void omap_configure_temp_sensor_counter(struct omap_temp_sensor
+					       *temp_sensor, u32 counter)
+{
+	u32 val;
+
+	val = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_counter);
+	val &= ~(temp_sensor->registers->counter_mask);
+	val |= (counter << __ffs(temp_sensor->registers->counter_mask));
+	omap_temp_sensor_writel(temp_sensor, val,
+			temp_sensor->registers->bgap_counter);
+}
+
+static void omap_enable_continuous_mode(struct omap_temp_sensor *temp_sensor,
+					bool enable)
+{
+	u32 val;
+
+	val = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_mode_ctrl);
+
+	if (enable)
+		val |= (1 << __ffs(temp_sensor->registers->mode_ctrl_mask));
+	else
+		val &= ~(temp_sensor->registers->mode_ctrl_mask);
+
+	omap_temp_sensor_writel(temp_sensor, val,
+			temp_sensor->registers->bgap_mode_ctrl);
+}
+
+/* Sysfs hook functions */
+
+static ssize_t show_temp_max(struct device *dev,
+			struct device_attribute *devattr, char *buf)
+{
+	struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+	int temp;
+
+	mutex_lock(&temp_sensor->sensor_mutex);
+
+	temp = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_threshold);
+	temp = (temp & temp_sensor->registers->threshold_thot_mask)
+			>> __ffs(temp_sensor->registers->threshold_thot_mask);
+
+	if (temp < OMAP_ADC_START_VALUE || temp > OMAP_ADC_END_VALUE) {
+		dev_err(dev, "invalid value\n");
+		goto out;
+	}
+	temp = adc_to_temp_conversion(temp);
+
+out:
+	mutex_unlock(&temp_sensor->sensor_mutex);
+
+	return snprintf(buf, 16, "%d\n", temp);
+}
+
+static ssize_t set_temp_max(struct device *dev,
+			    struct device_attribute *devattr,
+			    const char *buf, size_t count)
+{
+	struct omap_temp_sensor	*temp_sensor = dev_get_drvdata(dev);
+	long			val;
+	u32			reg_val, t_cold, t_hot, temp;
+
+	mutex_lock(&temp_sensor->sensor_mutex);
+
+	if (strict_strtol(buf, 10, &val)) {
+		count = -EINVAL;
+		goto out;
+	}
+
+	t_hot = temp_to_adc_conversion(val);
+	if ((t_hot < OMAP_ADC_START_VALUE || t_hot > OMAP_ADC_END_VALUE)) {
+		dev_err(dev, "invalid range\n");
+		count = -EINVAL;
+		goto out;
+	}
+
+	/* obtain the T cold value */
+	t_cold = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_threshold);
+	t_cold = (t_cold & temp_sensor->registers->threshold_tcold_mask) >>
+			__ffs(temp_sensor->registers->threshold_tcold_mask);
+
+	if (t_hot < t_cold) {
+		dev_err(dev, "Error! T_HOT value lesser than T_COLD\n");
+		count = -EINVAL;
+		goto out;
+	}
+
+	/* write the new t_hot value */
+	reg_val = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_threshold);
+	reg_val &= ~(temp_sensor->registers->threshold_thot_mask);
+	reg_val |= (t_hot <<
+			__ffs(temp_sensor->registers->threshold_thot_mask));
+	omap_temp_sensor_writel(temp_sensor, reg_val,
+			temp_sensor->registers->bgap_threshold);
+
+	/* Read the current temperature */
+	temp = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->temp_sensor_ctrl);
+	temp &= (temp_sensor->registers->bgap_dtemp_mask);
+
+	/*
+	 * If user sets the HIGH threshold(t_hot) greater than the current
+	 * temperature(temp) unmask the HOT interrupts
+	 */
+	if (t_hot > temp) {
+		reg_val = omap_temp_sensor_readl(temp_sensor,
+				temp_sensor->registers->bgap_mask_ctrl);
+		reg_val &= ~(temp_sensor->registers->mask_cold_mask);
+		reg_val |= temp_sensor->registers->mask_hot_mask;
+		omap_temp_sensor_writel(temp_sensor, reg_val,
+				temp_sensor->registers->bgap_mask_ctrl);
+	}
+
+	/*
+	 * If current temperature is in-between the hot and cold thresholds,
+	 * Enable both masks.
+	 */
+	if (temp > t_cold && temp < t_hot) {
+		reg_val = omap_temp_sensor_readl(temp_sensor,
+				temp_sensor->registers->bgap_mask_ctrl);
+		reg_val |= temp_sensor->registers->mask_cold_mask;
+		reg_val |= temp_sensor->registers->mask_hot_mask;
+		omap_temp_sensor_writel(temp_sensor, reg_val,
+				OMAP4460_BGAP_CTRL_OFFSET);
+	}
+	/*
+	 * else no need to do anything since HW will immediately compare
+	 * the new threshold and generate interrupt accordingly
+	 */
+out:
+	mutex_unlock(&temp_sensor->sensor_mutex);
+	return count;
+}
+
+static ssize_t show_temp_max_hyst(struct device *dev,
+		struct device_attribute *devattr, char *buf)
+{
+	struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+	u32			temp;
+
+	mutex_lock(&temp_sensor->sensor_mutex);
+
+	temp = omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->bgap_threshold);
+	temp = (temp & temp_sensor->registers->threshold_tcold_mask) >>
+		__ffs(temp_sensor->registers->threshold_tcold_mask);
+
+	if (temp < OMAP_ADC_START_VALUE || temp > OMAP_ADC_END_VALUE) {
+		dev_err(dev, "invalid value\n");
+		goto out;
+	}
+
+	temp = adc_to_temp_conversion(temp);
+out:
+	mutex_unlock(&temp_sensor->sensor_mutex);
+
+	return snprintf(buf, 16, "%d\n", temp);
+}
+
+static ssize_t set_temp_max_hyst(struct device *dev,
+				 struct device_attribute *devattr,
+				 const char *buf, size_t count)
+{
+	struct omap_temp_sensor		*temp_sensor = dev_get_drvdata(dev);
+	u32				reg_val, t_hot, t_cold, temp;
+	long				val;
+
+	mutex_lock(&temp_sensor->sensor_mutex);
+
+	if (strict_strtol(buf, 10, &val)) {
+		count = -EINVAL;
+		goto out;
+	}
+
+	t_cold = temp_to_adc_conversion(val);
+	if (t_cold < OMAP_ADC_START_VALUE || t_cold > OMAP_ADC_END_VALUE) {
+		dev_err(dev, "invalid range");
+		count = -EINVAL;
+		goto out;
+	}
+
+	/* obtain the T HOT value */
+	t_hot = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_threshold);
+	t_hot = (t_hot & temp_sensor->registers->threshold_thot_mask) >>
+			__ffs(temp_sensor->registers->threshold_thot_mask);
+
+	if (t_cold > t_hot) {
+		dev_err(dev, "Error! T_COLD value greater than T_HOT\n");
+		count = -EINVAL;
+		goto out;
+	}
+
+	/* write the new t_cold value */
+	reg_val = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_threshold);
+	reg_val &= ~(temp_sensor->registers->threshold_tcold_mask);
+	reg_val |= (t_cold <<
+			__ffs(temp_sensor->registers->threshold_tcold_mask));
+	omap_temp_sensor_writel(temp_sensor, reg_val,
+			temp_sensor->registers->bgap_threshold);
+
+	/* Read the current temperature */
+	temp = omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->temp_sensor_ctrl);
+	temp &= (temp_sensor->registers->bgap_dtemp_mask);
+
+	/*
+	 * If user sets the LOW threshold(t_cold) lower than the current
+	 * temperature(temp) unmask the COLD interrupts
+	 */
+	if (t_cold < temp) {
+		reg_val = omap_temp_sensor_readl(temp_sensor,
+				temp_sensor->registers->bgap_mask_ctrl);
+		reg_val &= ~(temp_sensor->registers->mask_hot_mask);
+		reg_val |= temp_sensor->registers->mask_cold_mask;
+		omap_temp_sensor_writel(temp_sensor, reg_val,
+			temp_sensor->registers->bgap_mask_ctrl);
+	}
+
+	/*
+	 * If current temperature is in-between the hot and cold thresholds,
+	 * Enable both masks.
+	 */
+	if (temp < t_hot && temp > t_cold) {
+		reg_val = omap_temp_sensor_readl(temp_sensor,
+				temp_sensor->registers->bgap_mask_ctrl);
+		reg_val |= temp_sensor->registers->mask_cold_mask;
+		reg_val |= temp_sensor->registers->mask_hot_mask;
+		omap_temp_sensor_writel(temp_sensor, reg_val,
+				temp_sensor->registers->bgap_mask_ctrl);
+	}
+
+	/*
+	 * else no need to do anything since HW will immediately compare
+	 * the new threshold and generate interrupt accordingly
+	 */
+
+out:
+	mutex_unlock(&temp_sensor->sensor_mutex);
+	return count;
+}
+
+static ssize_t show_update_rate(struct device *dev,
+			struct device_attribute *devattr, char *buf)
+{
+	struct omap_temp_sensor	*temp_sensor = dev_get_drvdata(dev);
+	u32			temp = 0, ret = 0;
+
+	mutex_lock(&temp_sensor->sensor_mutex);
+

drivers/hwmon/omap_temp_sensor.c new file +105 -0

+
+out:
+	mutex_unlock(&temp_sensor->sensor_mutex);
+	if (!ret)
+		return sprintf(buf, "%d\n", temp);
+	else
+		return ret;
+}
+
+static ssize_t set_update_rate(struct device *dev,
+			       struct device_attribute *devattr,
+			       const char *buf, size_t count)
+{
+	struct omap_temp_sensor	*temp_sensor = dev_get_drvdata(dev);
+	u32			reg_val;
+	long			val;
+
+	mutex_lock(&temp_sensor->sensor_mutex);
+
+	if (strict_strtol(buf, 10, &val)) {
+		count = -EINVAL;
+		goto out;
+	}
+
+	val *= temp_sensor->clk_rate / 1000;
+	reg_val = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_counter);
+
+	reg_val &= ~(temp_sensor->registers->counter_mask);
+	reg_val |= val;
+	omap_temp_sensor_writel(temp_sensor, reg_val,
+			temp_sensor->registers->bgap_counter);
+
+out:
+	mutex_unlock(&temp_sensor->sensor_mutex);
+	return count;
+}
+
+static int omap_temp_sensor_read_temp(struct device *dev,
+				      struct device_attribute *devattr,
+				      char *buf)
+{
+	struct omap_temp_sensor	*temp_sensor = dev_get_drvdata(dev);
+	int			temp, ret = 0;
+
+	mutex_lock(&temp_sensor->sensor_mutex);
+
+	temp = omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->temp_sensor_ctrl);
+	temp &= temp_sensor->registers->bgap_dtemp_mask;
+
+	if (!temp_sensor->is_efuse_valid)
+		dev_err(dev, "Invalid EFUSE, Non-trimmed BGAP, Temp not accurate\n");
+
+	/* look up for temperature in the table and return the temperature */
+	if (temp < OMAP_ADC_START_VALUE || temp > OMAP_ADC_END_VALUE) {
+		dev_err(dev, "invalid adc code reported %d", temp);
+		ret = -EINVAL;
+		goto out;
+	}
+
+	temp = adc_to_temp[temp - OMAP_ADC_START_VALUE];
+
+out:
+	mutex_unlock(&temp_sensor->sensor_mutex);
+	if (!ret)
+		return sprintf(buf, "%d\n", temp);
+	else
+		return ret;
+}
+
+static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, omap_temp_sensor_read_temp,
+			  NULL, 0);
+static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp_max,
+			  set_temp_max, 0);
+static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO, show_temp_max_hyst,
+			  set_temp_max_hyst, 0);
+static SENSOR_DEVICE_ATTR(update_rate, S_IWUSR | S_IRUGO, show_update_rate,
+			  set_update_rate, 0);
+
+static struct attribute *omap_temp_sensor_attributes[] = {
+	&sensor_dev_attr_temp1_input.dev_attr.attr,
+	&sensor_dev_attr_temp1_max.dev_attr.attr,
+	&sensor_dev_attr_temp1_max_hyst.dev_attr.attr,
+	&sensor_dev_attr_update_rate.dev_attr.attr,
+	NULL
+};
+
+static const struct attribute_group omap_temp_sensor_group = {
+	.attrs = omap_temp_sensor_attributes,
+};
+
+static int omap_temp_sensor_clk_enable(struct omap_temp_sensor *temp_sensor)
+{
+	u32 ret = 0, temp;
+
+	if (temp_sensor->clk_on) {
+		dev_err(temp_sensor->hwmon_dev, "clock already on\n");
+		goto out;
+	}
+
+	ret = pm_runtime_get_sync(temp_sensor->hwmon_dev);
+	if (ret < 0) {
+		dev_err(temp_sensor->hwmon_dev, "get sync failed\n");
+		ret = -EINVAL;

drivers/hwmon/omap_temp_sensor.c new file +119 -0

+out:
+	return ret;
+}
+
+static int omap_temp_sensor_clk_disable(struct omap_temp_sensor *temp_sensor)
+{
+	u32 temp, ret = 0;
+	unsigned long timeout;
+
+	if (!temp_sensor->clk_on) {
+		dev_err(temp_sensor->hwmon_dev, "clock already off\n");
+		goto out;
+	}
+	temp = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->temp_sensor_ctrl);
+	temp |= temp_sensor->registers->bgap_tempsoff_mask;
+
+	/* BGAP_TEMPSOFF should be set to 1 before gating clock */
+	omap_temp_sensor_writel(temp_sensor, temp,
+			temp_sensor->registers->temp_sensor_ctrl);
+	temp = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_status);
+	timeout = jiffies + msecs_to_jiffies(5);
+
+	/* wait till the clean stop bit is set or till the timeout exppires */
+	while (!(temp | temp_sensor->registers->status_clean_stop_mask) &&
+		!(time_after(jiffies, timeout))) {
+		temp = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_status);
+		usleep_range(500, 2000);
+	}
+
+	if (time_after(jiffies, timeout))
+		dev_err(temp_sensor->hwmon_dev, "Clean stop bit not set\n");
+	/* Gate the clock */
+	ret = pm_runtime_put_sync(temp_sensor->hwmon_dev);
+	if (ret < 0) {
+		dev_err(temp_sensor->hwmon_dev, "put sync failed\n");
+		ret = -EINVAL;
+		goto out;
+	}
+	temp_sensor->clk_on = 0;
+out:
+	return ret;
+}
+static irqreturn_t omap_talert_irq_handler(int irq, void *data)
+{
+	struct omap_temp_sensor		*temp_sensor;
+	int				t_hot, t_cold, temp;
+
+	temp_sensor = data;
+	mutex_lock(&temp_sensor->sensor_mutex);
+
+	/* Read the status of t_hot */
+	t_hot = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_status)
+			& temp_sensor->registers->status_hot_mask;
+
+	/* Read the status of t_cold */
+	t_cold = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_status)
+			& temp_sensor->registers->status_cold_mask;
+
+	temp = omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->bgap_mask_ctrl);
+	/*
+	 * One TALERT interrupt: Two sources
+	 * If the interrupt is due to t_hot then mask t_hot and
+	 * and unmask t_cold else mask t_cold and unmask t_hot
+	 */
+	if (t_hot) {
+		temp &= ~(temp_sensor->registers->mask_hot_mask);
+		temp |= temp_sensor->registers->mask_cold_mask;
+	} else if (t_cold) {
+		temp &= ~(temp_sensor->registers->mask_cold_mask);
+		temp |= temp_sensor->registers->mask_hot_mask;
+	}
+
+	omap_temp_sensor_writel(temp_sensor, temp,
+		temp_sensor->registers->bgap_mask_ctrl);
+
+	/* kobject_uvent to user space telling thermal threshold crossed */
+	kobject_uevent(&temp_sensor->hwmon_dev->kobj, KOBJ_CHANGE);
+
+	mutex_unlock(&temp_sensor->sensor_mutex);
+
+	return IRQ_HANDLED;
+}
+
+static int __devinit omap_temp_sensor_probe(struct platform_device *pdev)
+{
+	struct omap_temp_sensor_pdata	*pdata	= pdev->dev.platform_data;
+	struct omap_temp_sensor		*temp_sensor;
+	struct resource			*mem;
+	int				ret = 0;
+	int				val, clk_rate;
+
+	if (!pdata) {
+		dev_err(&pdev->dev, "platform data missing\n");
+		return -EINVAL;
+	}
+
+	temp_sensor = kzalloc(sizeof(*temp_sensor), GFP_KERNEL);
+	if (!temp_sensor)
+		return -ENOMEM;
+
+	mutex_init(&temp_sensor->sensor_mutex);
+
+	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!mem) {
+		dev_err(&pdev->dev, "no mem resource\n");
+		ret = -EINVAL;
+		goto plat_res_err;
+	}
+
+	temp_sensor->irq = platform_get_irq_byname(pdev, "thermal_alert");
+	if (temp_sensor->irq == -ENXIO) {
+		dev_err(&pdev->dev, "get_irq_byname failed\n");
+		ret = temp_sensor->irq;

drivers/hwmon/omap_temp_sensor.c new file +5 -0

+	if (IS_ERR(temp_sensor->clock)) {
+		ret = PTR_ERR(temp_sensor->clock);
+		dev_err(temp_sensor->hwmon_dev,
+			"unable to get fclk: %d\n", ret);
+		ret = -EINVAL;

drivers/hwmon/omap_temp_sensor.c new file +206 -0

+	if (ret) {
+		dev_err(&pdev->dev, "Cannot set clock rate\n");
+		goto clken_err;
+	}
+
+	temp_sensor->clk_rate = clk_rate;
+	omap_enable_continuous_mode(temp_sensor, 1);
+	omap_configure_temp_sensor_thresholds(temp_sensor);
+	/* 1 ms */
+	omap_configure_temp_sensor_counter(temp_sensor, 1);
+
+	/* Wait till the first conversion is done wait for at least 1ms */
+	usleep_range(1000, 2000);
+
+	/* Read the temperature once due to hw issue*/
+	omap_temp_sensor_readl(temp_sensor,
+			temp_sensor->registers->temp_sensor_ctrl);
+
+	/* Set 2 seconds time as default counter */
+	omap_configure_temp_sensor_counter(temp_sensor,
+						temp_sensor->clk_rate * 2);
+
+	temp_sensor->hwmon_dev = hwmon_device_register(&pdev->dev);
+	if (IS_ERR(temp_sensor->hwmon_dev)) {
+		dev_err(&pdev->dev, "hwmon_device_register failed.\n");
+		ret = PTR_ERR(temp_sensor->hwmon_dev);
+		goto hwmon_reg_err;
+	}
+
+	ret = sysfs_create_group(&pdev->dev.kobj,
+				 &omap_temp_sensor_group);
+	if (ret) {
+		dev_err(&pdev->dev, "could not create sysfs files\n");
+		goto sysfs_create_err;
+	}
+
+	kobject_uevent(&temp_sensor->hwmon_dev->kobj, KOBJ_ADD);
+
+	ret = request_threaded_irq(temp_sensor->irq, NULL,
+		omap_talert_irq_handler, IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+			"temp_sensor", temp_sensor);
+	if (ret) {
+		dev_err(&pdev->dev, "Request threaded irq failed.\n");
+		goto req_irq_err;
+	}
+
+	/* unmask the T_COLD and unmask T_HOT at init */
+	val = omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->bgap_mask_ctrl);
+	val |= temp_sensor->registers->mask_cold_mask
+		| temp_sensor->registers->mask_hot_mask;
+
+	omap_temp_sensor_writel(temp_sensor, val,
+		temp_sensor->registers->bgap_mask_ctrl);
+
+	return 0;
+
+req_irq_err:
+	kobject_uevent(&temp_sensor->hwmon_dev->kobj, KOBJ_REMOVE);
+	sysfs_remove_group(&temp_sensor->hwmon_dev->kobj,
+				&omap_temp_sensor_group);
+sysfs_create_err:
+	hwmon_device_unregister(&pdev->dev);
+hwmon_reg_err:
+	omap_temp_sensor_clk_disable(temp_sensor);
+clken_err:
+	if (temp_sensor->clock)
+		clk_put(temp_sensor->clock);
+plat_res_err:
+	mutex_destroy(&temp_sensor->sensor_mutex);
+	kfree(temp_sensor);
+	return ret;
+}
+
+static int __devexit omap_temp_sensor_remove(struct platform_device *pdev)
+{
+	struct omap_temp_sensor *temp_sensor = platform_get_drvdata(pdev);
+
+	hwmon_device_unregister(&pdev->dev);
+	kobject_uevent(&temp_sensor->hwmon_dev->kobj, KOBJ_REMOVE);
+	sysfs_remove_group(&temp_sensor->hwmon_dev->kobj,
+			&omap_temp_sensor_group);
+	omap_temp_sensor_clk_disable(temp_sensor);
+	clk_put(temp_sensor->clock);
+	platform_set_drvdata(pdev, NULL);
+	free_irq(temp_sensor->irq, temp_sensor);
+	mutex_destroy(&temp_sensor->sensor_mutex);
+	kfree(temp_sensor);
+
+	return 0;
+}
+
+#ifdef CONFIG_PM
+static void omap_temp_sensor_save_ctxt(struct omap_temp_sensor *temp_sensor)
+{
+	temp_sensor->temp_sensor_ctrl = omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->temp_sensor_ctrl);
+	temp_sensor->bg_ctrl = omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->bgap_mask_ctrl);
+	temp_sensor->bg_counter = omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->bgap_counter);
+	temp_sensor->bg_threshold = omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->bgap_threshold);
+	temp_sensor->temp_sensor_tshut_threshold =
+		omap_temp_sensor_readl(temp_sensor,
+		temp_sensor->registers->thsut_threshold);
+}
+
+static void omap_temp_sensor_restore_ctxt(struct omap_temp_sensor *temp_sensor)
+{
+	omap_temp_sensor_writel(temp_sensor,
+				temp_sensor->temp_sensor_ctrl,
+				temp_sensor->registers->temp_sensor_ctrl);
+	omap_temp_sensor_writel(temp_sensor,
+				temp_sensor->bg_ctrl,
+				temp_sensor->registers->bgap_mask_ctrl);
+	omap_temp_sensor_writel(temp_sensor,
+				temp_sensor->bg_counter,
+				temp_sensor->registers->bgap_counter);
+	omap_temp_sensor_writel(temp_sensor,
+				temp_sensor->bg_threshold,
+				temp_sensor->registers->bgap_threshold);
+	omap_temp_sensor_writel(temp_sensor,
+				temp_sensor->temp_sensor_tshut_threshold,
+				temp_sensor->registers->thsut_threshold);
+}
+
+static int omap_temp_sensor_suspend(struct device *dev)
+{
+	struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+
+	omap_temp_sensor_save_ctxt(temp_sensor);
+
+	return 0;
+}
+
+static int omap_temp_sensor_resume(struct device *dev)
+{
+	struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+
+	omap_temp_sensor_restore_ctxt(temp_sensor);
+
+	return 0;
+}
+
+static int omap_temp_sensor_runtime_suspend(struct device *dev)
+{
+	struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+
+	omap_temp_sensor_save_ctxt(temp_sensor);
+
+	return 0;
+}
+
+static int omap_temp_sensor_runtime_resume(struct device *dev)
+{
+	static int context_loss_count;
+	int temp;
+	struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+
+	temp = omap_device_get_context_loss_count(to_platform_device(dev));
+
+	if (temp != context_loss_count && context_loss_count != 0)
+		omap_temp_sensor_restore_ctxt(temp_sensor);
+
+	context_loss_count = temp;
+
+	return 0;
+}
+
+static const struct dev_pm_ops omap_temp_sensor_dev_pm_ops = {
+	.suspend = omap_temp_sensor_suspend,
+	.resume = omap_temp_sensor_resume,
+	.runtime_suspend = omap_temp_sensor_runtime_suspend,
+	.runtime_resume = omap_temp_sensor_runtime_resume,
+};
+
+#endif
+
+static struct platform_driver omap_temp_sensor_driver = {
+	.probe = omap_temp_sensor_probe,
+	.remove = omap_temp_sensor_remove,
+	.driver = {
+			.name = "omap_temp_sensor",
+#ifdef CONFIG_PM
+			.pm = &omap_temp_sensor_dev_pm_ops,
+#endif
+		   },
+};
+
+int __init omap_temp_sensor_init(void)
+{
+	return platform_driver_register(&omap_temp_sensor_driver);
+}
+module_init(omap_temp_sensor_init);
+
+static void __exit omap_temp_sensor_exit(void)
+{
+	platform_driver_unregister(&omap_temp_sensor_driver);
+}
+module_exit(omap_temp_sensor_exit);
+
+MODULE_DESCRIPTION("OMAP446X temperature sensor Driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRIVER_NAME);
+MODULE_AUTHOR("J Keerthy <[email protected]>");

Signature · 6 lines

1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hi,

(why aren't below in Cc ?

HARDWARE MONITORING
M: ? ? ?Jean Delvare <[email protected]>
M: ? ? ?Guenter Roeck <[email protected]>
L: ? ? ?lm-sensors at lm-sensors.org
W: ? ? ?http://www.lm-sensors.org/
T: ? ? ?quilt kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-hwmon/
T: ? ? ?git git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
S: ? ? ?Maintained
F: ? ? ?Documentation/hwmon/
F: ? ? ?drivers/hwmon/
F: ? ? ?include/linux/hwmon*.h)

Quoted 73 lines · Keerthy

On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user is allowed to configure the temperature thresholds vis sysfs nodes exposed using hwmon interface.

Signed-off-by Keerthy <[email protected]>

---

?drivers/hwmon/Kconfig ? ? ? ? ? ?| ? 11 +
?drivers/hwmon/Makefile ? ? ? ? ? | ? ?1 +
?drivers/hwmon/omap_temp_sensor.c | ?950 ++++++++++++++++++++++++++++++++++++++

?3 files changed, 962 insertions(+), 0 deletions(-) ?create mode 100644 drivers/hwmon/omap_temp_sensor.c

drivers/hwmon/Kconfig +0 -0

index 5f888f7..9c9cd8b 100644
@@ -323,6 +323,17 @@ config SENSORS_F71805F

? ? ? ? This driver can also be built as a module. ?If so, the module ? ? ? ? will be called f71805f.

drivers/hwmon/Kconfig +11 -0

+config SENSORS_OMAP_BANDGAP_TEMP_SENSOR
+ ? ? bool "OMAP on-die temperature sensor hwmon driver"
+ ? ? depends on HWMON && ARCH_OMAP && OMAP_TEMP_SENSOR
+ ? ? help
+ ? ? ? If you say yes here you get support for hardware
+ ? ? ? monitoring features of the OMAP on die temperature
+ ? ? ? sensor.
+
+ ? ? ? Continuous conversion programmable delay
+ ? ? ? mode is used for temperature conversion.
+

?config SENSORS_F71882FG
? ? ? tristate "Fintek F71882FG and compatibles"
? ? ? help

drivers/hwmon/Makefile +0 -0

index 28061cf..d0f89f5 100644
@@ -91,6 +91,7 @@ obj-$(CONFIG_SENSORS_MAX6639) ? ? ? += max6639.o

?obj-$(CONFIG_SENSORS_MAX6642) ? ? ? ?+= max6642.o ?obj-$(CONFIG_SENSORS_MAX6650) ? ? ? ?+= max6650.o ?obj-$(CONFIG_SENSORS_MC13783_ADC)+= mc13783-adc.o +obj-$(CONFIG_SENSORS_OMAP_BANDGAP_TEMP_SENSOR) ?+= omap_temp_sensor.o ?obj-$(CONFIG_SENSORS_PC87360) ? ? ? ?+= pc87360.o ?obj-$(CONFIG_SENSORS_PC87427) ? ? ? ?+= pc87427.o ?obj-$(CONFIG_SENSORS_PCF8591) ? ? ? ?+= pcf8591.o

drivers/hwmon/omap_temp_sensor.c new file +19 -0

new file mode 100644
index 0000000..15e2559
@@ -0,0 +1,950 @@
+/*
+ * OMAP4 Temperature sensor driver file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ * Author: Moiz Sonasath <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ?See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA

drivers/hwmon/omap_temp_sensor.c line 25

Quoted 6 lines

drivers/hwmon/omap_temp_sensor.c new file +6 -0

+ * 02110-1301 USA
+ *
+ */
+
+#include <linux/interrupt.h>
+#include <linux/clk.h>

why ??

drivers/hwmon/omap_temp_sensor.c line 27

Quoted 3 lines

drivers/hwmon/omap_temp_sensor.c new file +2 -0

+#include <linux/io.h>
+#include <linux/debugfs.h>

why ??

drivers/hwmon/omap_temp_sensor.c line 32

Quoted 6 lines

drivers/hwmon/omap_temp_sensor.c new file +5 -0

+#include <linux/delay.h>
+#include <linux/slab.h>
+#include <linux/platform_device.h>
+#include <linux/init.h>
+#include <plat/omap_device.h>

why ??

Quoted 7 lines

drivers/hwmon/omap_temp_sensor.c new file +7 -0

+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/device.h>
+#include <linux/jiffies.h>
+#include <linux/hwmon.h>
+#include <linux/hwmon-sysfs.h>
+#include <linux/stddef.h>

drivers/hwmon/omap_temp_sensor.c line 45

Quoted 6 lines

drivers/hwmon/omap_temp_sensor.c new file +6 -0

+#include <linux/sysfs.h>
+#include <linux/err.h>
+#include <linux/types.h>
+#include <linux/mutex.h>
+#include <linux/pm_runtime.h>
+#include <plat/common.h>

why ?

drivers/hwmon/omap_temp_sensor.c line 46

Quoted 2 lines

drivers/hwmon/omap_temp_sensor.c new file +1 -0

+#include <plat/temperature_sensor.h>

why ?

drivers/hwmon/omap_temp_sensor.c line 47

Quoted 1 line

drivers/hwmon/omap_temp_sensor.c new file +1 -0

+#include <mach/ctrl_module_core_44xx.h>

why ?

drivers/hwmon/omap_temp_sensor.c line 48

Quoted 2 lines

drivers/hwmon/omap_temp_sensor.c new file +1 -0

+#include <mach/gpio.h>

linux/gpio.h for crying out loud... how many times Russell has to say the exact same thing ??????

Quoted 405 lines

drivers/hwmon/omap_temp_sensor.c new file +405 -0

+#define TSHUT_THRESHOLD_HOT ?122000 ?/* 122 deg C */
+#define TSHUT_THRESHOLD_COLD 100000 ?/* 100 deg C */
+#define BGAP_THRESHOLD_T_HOT 73000 ? /* 73 deg C */
+#define BGAP_THRESHOLD_T_COLD ? ? ? ?71000 ? /* 71 deg C */
+#define OMAP_ADC_START_VALUE 530
+#define OMAP_ADC_END_VALUE ? 923
+
+/*
+ * omap_temp_sensor structure
+ * @hwmon_dev - device pointer
+ * @clock - Clock pointer
+ * @registers - Pointer to structure with register offsets and bitfields
+ * @sensor_mutex - Mutex for sysfs, irq and PM
+ * @irq - MPU Irq number for thermal alert
+ * @phy_base - Physical base of the temp I/O
+ * @clk_rate - Holds current clock rate
+ * @temp_sensor_ctrl - temp sensor control register value
+ * @bg_ctrl - bandgap ctrl register value
+ * @bg_counter - bandgap counter value
+ * @bg_threshold - bandgap threshold register value
+ * @temp_sensor_tshut_threshold - bandgap tshut register value
+ * @is_efuse_valid - Flag to determine if efuse is valid or not
+ * @clk_on - Manages the current clock state
+ */
+struct omap_temp_sensor {
+ ? ? struct device ? ? ? ? ? *hwmon_dev;
+ ? ? struct clk ? ? ? ? ? ? ?*clock;
+ ? ? struct omap_temp_sensor_registers *registers;
+ ? ? struct mutex ? ? ? ? ? ?sensor_mutex; /* Mutex for sysfs, irq and PM */
+ ? ? unsigned int ? ? ? ? ? ?irq;
+ ? ? void __iomem ? ? ? ? ? ?*phy_base;
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? clk_rate;
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? temp_sensor_ctrl;
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? bg_ctrl;
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? bg_counter;
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? bg_threshold;
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? temp_sensor_tshut_threshold;
+ ? ? bool ? ? ? ? ? ? ? ? ? ?is_efuse_valid;
+ ? ? bool ? ? ? ? ? ? ? ? ? ?clk_on;
+};
+
+/*
+ * Temperature values in milli degree celsius
+ * ADC code values from 530 to 923
+ */
+static int adc_to_temp[] = {
+ ? ? -40000, -40000, -40000, -40000, -39800, -39400, -39000, -38600, -38200,
+ ? ? -37800, -37300, -36800, -36400, -36000, -35600, -35200, -34800,
+ ? ? -34300, -33800, -33400, -33000, -32600, -32200, -31800, -31300,
+ ? ? -30800, -30400, -30000, -29600, -29200, -28700, -28200, -27800,
+ ? ? -27400, -27000, -26600, -26200, -25700, -25200, -24800, -24400,
+ ? ? -24000, -23600, -23200, -22700, -22200, -21800, -21400, -21000,
+ ? ? -20600, -20200, -19700, -19200, -18800, -18400, -18000, -17600,
+ ? ? -17200, -16700, -16200, -15800, -15400, -15000, -14600, -14200,
+ ? ? -13700, -13200, -12800, -12400, -12000, -11600, -11200, -10700,
+ ? ? -10200, -9800, -9400, -9000, -8600, -8200, -7700, -7200, -6800,
+ ? ? -6400, -6000, -5600, -5200, -4800, -4300, -3800, -3400, -3000,
+ ? ? -2600, -2200, -1800, -1300, -800, -400, 0, 400, 800, 1200, 1600,
+ ? ? 2100, 2600, 3000, 3400, 3800, 4200, 4600, 5100, 5600, 6000, 6400,
+ ? ? 6800, 7200, 7600, 8000, 8500, 9000, 9400, 9800, 10200, 10600, 11000,
+ ? ? 11400, 11900, 12400, 12800, 13200, 13600, 14000, 14400, 14800,
+ ? ? 15300, 15800, 16200, 16600, 17000, 17400, 17800, 18200, 18700,
+ ? ? 19200, 19600, 20000, 20400, 20800, 21200, 21600, 22100, 22600,
+ ? ? 23000, 23400, 23800, 24200, 24600, 25000, 25400, 25900, 26400,
+ ? ? 26800, 27200, 27600, 28000, 28400, 28800, 29300, 29800, 30200,
+ ? ? 30600, 31000, 31400, 31800, 32200, 32600, 33100, 33600, 34000,
+ ? ? 34400, 34800, 35200, 35600, 36000, 36400, 36800, 37300, 37800,
+ ? ? 38200, 38600, 39000, 39400, 39800, 40200, 40600, 41100, 41600,
+ ? ? 42000, 42400, 42800, 43200, 43600, 44000, 44400, 44800, 45300,
+ ? ? 45800, 46200, 46600, 47000, 47400, 47800, 48200, 48600, 49000,
+ ? ? 49500, 50000, 50400, 50800, 51200, 51600, 52000, 52400, 52800,
+ ? ? 53200, 53700, 54200, 54600, 55000, 55400, 55800, 56200, 56600,
+ ? ? 57000, 57400, 57800, 58200, 58700, 59200, 59600, 60000, 60400,
+ ? ? 60800, 61200, 61600, 62000, 62400, 62800, 63300, 63800, 64200,
+ ? ? 64600, 65000, 65400, 65800, 66200, 66600, 67000, 67400, 67800,
+ ? ? 68200, 68700, 69200, 69600, 70000, 70400, 70800, 71200, 71600,
+ ? ? 72000, 72400, 72800, 73200, 73600, 74100, 74600, 75000, 75400,
+ ? ? 75800, 76200, 76600, 77000, 77400, 77800, 78200, 78600, 79000,
+ ? ? 79400, 79800, 80300, 80800, 81200, 81600, 82000, 82400, 82800,
+ ? ? 83200, 83600, 84000, 84400, 84800, 85200, 85600, 86000, 86400,
+ ? ? 86800, 87300, 87800, 88200, 88600, 89000, 89400, 89800, 90200,
+ ? ? 90600, 91000, 91400, 91800, 92200, 92600, 93000, 93400, 93800,
+ ? ? 94200, 94600, 95000, 95500, 96000, 96400, 96800, 97200, 97600,
+ ? ? 98000, 98400, 98800, 99200, 99600, 100000, 100400, 100800, 101200,
+ ? ? 101600, 102000, 102400, 102800, 103200, 103600, 104000, 104400,
+ ? ? 104800, 105200, 105600, 106100, 106600, 107000, 107400, 107800,
+ ? ? 108200, 108600, 109000, 109400, 109800, 110200, 110600, 111000,
+ ? ? 111400, 111800, 112200, 112600, 113000, 113400, 113800, 114200,
+ ? ? 114600, 115000, 115400, 115800, 116200, 116600, 117000, 117400,
+ ? ? 117800, 118200, 118600, 119000, 119400, 119800, 120200, 120600,
+ ? ? 121000, 121400, 121800, 122200, 122600, 123000
+};
+
+static unsigned long omap_temp_sensor_readl(struct omap_temp_sensor
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? *temp_sensor, u32 reg)
+{
+ ? ? return __raw_readl(temp_sensor->phy_base + reg);
+}
+
+static void omap_temp_sensor_writel(struct omap_temp_sensor *temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? u32 val, u32 reg)
+{
+ ? ? __raw_writel(val, (temp_sensor->phy_base + reg));
+}
+
+static int adc_to_temp_conversion(int adc_val)
+{
+ ? ? return adc_to_temp[adc_val - OMAP_ADC_START_VALUE];
+}
+
+static int temp_to_adc_conversion(long temp)
+{
+ ? ? int i;
+
+ ? ? for (i = 0; i <= OMAP_ADC_END_VALUE - OMAP_ADC_START_VALUE; i++)
+ ? ? ? ? ? ? if (temp < adc_to_temp[i])
+ ? ? ? ? ? ? ? ? ? ? return OMAP_ADC_START_VALUE + i - 1;
+
+ ? ? return -EINVAL;
+}
+
+static void omap_configure_temp_sensor_thresholds(struct omap_temp_sensor
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? *temp_sensor)
+{
+ ? ? u32 temp, t_hot, t_cold, tshut_hot, tshut_cold;
+
+ ? ? t_hot = temp_to_adc_conversion(BGAP_THRESHOLD_T_HOT);
+ ? ? t_cold = temp_to_adc_conversion(BGAP_THRESHOLD_T_COLD);
+
+ ? ? /* Configure the TALERT thresholds */
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? temp |= (t_hot << __ffs(temp_sensor->registers->threshold_thot_mask)) |
+ ? ? ? ? ? ? (t_cold << __ffs(temp_sensor->registers->threshold_tcold_mask));
+ ? ? omap_temp_sensor_writel(temp_sensor, temp,
+ ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+
+ ? ? tshut_hot = temp_to_adc_conversion(TSHUT_THRESHOLD_HOT);
+ ? ? tshut_cold = temp_to_adc_conversion(TSHUT_THRESHOLD_COLD);
+
+ ? ? /* Configure the TSHUT thresholds */
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->thsut_threshold);
+ ? ? temp |= (tshut_hot << __ffs(temp_sensor->registers->tshut_hot_mask))
+ ? ? ? ? | (tshut_cold << __ffs(temp_sensor->registers->tshut_hot_mask));
+ ? ? omap_temp_sensor_writel(temp_sensor, temp,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->thsut_threshold);
+}
+
+static void omap_configure_temp_sensor_counter(struct omap_temp_sensor
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?*temp_sensor, u32 counter)
+{
+ ? ? u32 val;
+
+ ? ? val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_counter);
+ ? ? val &= ~(temp_sensor->registers->counter_mask);
+ ? ? val |= (counter << __ffs(temp_sensor->registers->counter_mask));
+ ? ? omap_temp_sensor_writel(temp_sensor, val,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_counter);
+}
+
+static void omap_enable_continuous_mode(struct omap_temp_sensor *temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? bool enable)
+{
+ ? ? u32 val;
+
+ ? ? val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mode_ctrl);
+
+ ? ? if (enable)
+ ? ? ? ? ? ? val |= (1 << __ffs(temp_sensor->registers->mode_ctrl_mask));
+ ? ? else
+ ? ? ? ? ? ? val &= ~(temp_sensor->registers->mode_ctrl_mask);
+
+ ? ? omap_temp_sensor_writel(temp_sensor, val,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mode_ctrl);
+}
+
+/* Sysfs hook functions */
+
+static ssize_t show_temp_max(struct device *dev,
+ ? ? ? ? ? ? ? ? ? ? struct device_attribute *devattr, char *buf)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+ ? ? int temp;
+
+ ? ? mutex_lock(&temp_sensor->sensor_mutex);
+
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? temp = (temp & temp_sensor->registers->threshold_thot_mask)
+ ? ? ? ? ? ? ? ? ? ? >> __ffs(temp_sensor->registers->threshold_thot_mask);
+
+ ? ? if (temp < OMAP_ADC_START_VALUE || temp > OMAP_ADC_END_VALUE) {
+ ? ? ? ? ? ? dev_err(dev, "invalid value\n");
+ ? ? ? ? ? ? goto out;
+ ? ? }
+ ? ? temp = adc_to_temp_conversion(temp);
+
+out:
+ ? ? mutex_unlock(&temp_sensor->sensor_mutex);
+
+ ? ? return snprintf(buf, 16, "%d\n", temp);
+}
+
+static ssize_t set_temp_max(struct device *dev,
+ ? ? ? ? ? ? ? ? ? ? ? ? struct device_attribute *devattr,
+ ? ? ? ? ? ? ? ? ? ? ? ? const char *buf, size_t count)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+ ? ? long ? ? ? ? ? ? ? ? ? ?val;
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? reg_val, t_cold, t_hot, temp;
+
+ ? ? mutex_lock(&temp_sensor->sensor_mutex);
+
+ ? ? if (strict_strtol(buf, 10, &val)) {
+ ? ? ? ? ? ? count = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? t_hot = temp_to_adc_conversion(val);
+ ? ? if ((t_hot < OMAP_ADC_START_VALUE || t_hot > OMAP_ADC_END_VALUE)) {
+ ? ? ? ? ? ? dev_err(dev, "invalid range\n");
+ ? ? ? ? ? ? count = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? /* obtain the T cold value */
+ ? ? t_cold = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? t_cold = (t_cold & temp_sensor->registers->threshold_tcold_mask) >>
+ ? ? ? ? ? ? ? ? ? ? __ffs(temp_sensor->registers->threshold_tcold_mask);
+
+ ? ? if (t_hot < t_cold) {
+ ? ? ? ? ? ? dev_err(dev, "Error! T_HOT value lesser than T_COLD\n");
+ ? ? ? ? ? ? count = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? /* write the new t_hot value */
+ ? ? reg_val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? reg_val &= ~(temp_sensor->registers->threshold_thot_mask);
+ ? ? reg_val |= (t_hot <<
+ ? ? ? ? ? ? ? ? ? ? __ffs(temp_sensor->registers->threshold_thot_mask));
+ ? ? omap_temp_sensor_writel(temp_sensor, reg_val,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+
+ ? ? /* Read the current temperature */
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? temp &= (temp_sensor->registers->bgap_dtemp_mask);
+
+ ? ? /*
+ ? ? ?* If user sets the HIGH threshold(t_hot) greater than the current
+ ? ? ?* temperature(temp) unmask the HOT interrupts
+ ? ? ?*/
+ ? ? if (t_hot > temp) {
+ ? ? ? ? ? ? reg_val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? ? ? ? ? reg_val &= ~(temp_sensor->registers->mask_cold_mask);
+ ? ? ? ? ? ? reg_val |= temp_sensor->registers->mask_hot_mask;
+ ? ? ? ? ? ? omap_temp_sensor_writel(temp_sensor, reg_val,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? }
+
+ ? ? /*
+ ? ? ?* If current temperature is in-between the hot and cold thresholds,
+ ? ? ?* Enable both masks.
+ ? ? ?*/
+ ? ? if (temp > t_cold && temp < t_hot) {
+ ? ? ? ? ? ? reg_val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? ? ? ? ? reg_val |= temp_sensor->registers->mask_cold_mask;
+ ? ? ? ? ? ? reg_val |= temp_sensor->registers->mask_hot_mask;
+ ? ? ? ? ? ? omap_temp_sensor_writel(temp_sensor, reg_val,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? OMAP4460_BGAP_CTRL_OFFSET);
+ ? ? }
+ ? ? /*
+ ? ? ?* else no need to do anything since HW will immediately compare
+ ? ? ?* the new threshold and generate interrupt accordingly
+ ? ? ?*/
+out:
+ ? ? mutex_unlock(&temp_sensor->sensor_mutex);
+ ? ? return count;
+}
+
+static ssize_t show_temp_max_hyst(struct device *dev,
+ ? ? ? ? ? ? struct device_attribute *devattr, char *buf)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? temp;
+
+ ? ? mutex_lock(&temp_sensor->sensor_mutex);
+
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? temp = (temp & temp_sensor->registers->threshold_tcold_mask) >>
+ ? ? ? ? ? ? __ffs(temp_sensor->registers->threshold_tcold_mask);
+
+ ? ? if (temp < OMAP_ADC_START_VALUE || temp > OMAP_ADC_END_VALUE) {
+ ? ? ? ? ? ? dev_err(dev, "invalid value\n");
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? temp = adc_to_temp_conversion(temp);
+out:
+ ? ? mutex_unlock(&temp_sensor->sensor_mutex);
+
+ ? ? return snprintf(buf, 16, "%d\n", temp);
+}
+
+static ssize_t set_temp_max_hyst(struct device *dev,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct device_attribute *devattr,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?const char *buf, size_t count)
+{
+ ? ? struct omap_temp_sensor ? ? ? ? *temp_sensor = dev_get_drvdata(dev);
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg_val, t_hot, t_cold, temp;
+ ? ? long ? ? ? ? ? ? ? ? ? ? ? ? ? ?val;
+
+ ? ? mutex_lock(&temp_sensor->sensor_mutex);
+
+ ? ? if (strict_strtol(buf, 10, &val)) {
+ ? ? ? ? ? ? count = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? t_cold = temp_to_adc_conversion(val);
+ ? ? if (t_cold < OMAP_ADC_START_VALUE || t_cold > OMAP_ADC_END_VALUE) {
+ ? ? ? ? ? ? dev_err(dev, "invalid range");
+ ? ? ? ? ? ? count = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? /* obtain the T HOT value */
+ ? ? t_hot = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? t_hot = (t_hot & temp_sensor->registers->threshold_thot_mask) >>
+ ? ? ? ? ? ? ? ? ? ? __ffs(temp_sensor->registers->threshold_thot_mask);
+
+ ? ? if (t_cold > t_hot) {
+ ? ? ? ? ? ? dev_err(dev, "Error! T_COLD value greater than T_HOT\n");
+ ? ? ? ? ? ? count = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? /* write the new t_cold value */
+ ? ? reg_val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? reg_val &= ~(temp_sensor->registers->threshold_tcold_mask);
+ ? ? reg_val |= (t_cold <<
+ ? ? ? ? ? ? ? ? ? ? __ffs(temp_sensor->registers->threshold_tcold_mask));
+ ? ? omap_temp_sensor_writel(temp_sensor, reg_val,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+
+ ? ? /* Read the current temperature */
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? temp &= (temp_sensor->registers->bgap_dtemp_mask);
+
+ ? ? /*
+ ? ? ?* If user sets the LOW threshold(t_cold) lower than the current
+ ? ? ?* temperature(temp) unmask the COLD interrupts
+ ? ? ?*/
+ ? ? if (t_cold < temp) {
+ ? ? ? ? ? ? reg_val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? ? ? ? ? reg_val &= ~(temp_sensor->registers->mask_hot_mask);
+ ? ? ? ? ? ? reg_val |= temp_sensor->registers->mask_cold_mask;
+ ? ? ? ? ? ? omap_temp_sensor_writel(temp_sensor, reg_val,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? }
+
+ ? ? /*
+ ? ? ?* If current temperature is in-between the hot and cold thresholds,
+ ? ? ?* Enable both masks.
+ ? ? ?*/
+ ? ? if (temp < t_hot && temp > t_cold) {
+ ? ? ? ? ? ? reg_val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? ? ? ? ? reg_val |= temp_sensor->registers->mask_cold_mask;
+ ? ? ? ? ? ? reg_val |= temp_sensor->registers->mask_hot_mask;
+ ? ? ? ? ? ? omap_temp_sensor_writel(temp_sensor, reg_val,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? }
+
+ ? ? /*
+ ? ? ?* else no need to do anything since HW will immediately compare
+ ? ? ?* the new threshold and generate interrupt accordingly
+ ? ? ?*/
+
+out:
+ ? ? mutex_unlock(&temp_sensor->sensor_mutex);
+ ? ? return count;
+}
+
+static ssize_t show_update_rate(struct device *dev,
+ ? ? ? ? ? ? ? ? ? ? struct device_attribute *devattr, char *buf)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? temp = 0, ret = 0;
+
+ ? ? mutex_lock(&temp_sensor->sensor_mutex);
+

drivers/hwmon/omap_temp_sensor.c line 463

Quoted 10 lines

drivers/hwmon/omap_temp_sensor.c new file +10 -0

+ ? ? if (!temp_sensor->clk_rate) {
+ ? ? ? ? ? ? dev_err(dev, "clk_rate is NULL\n");
+ ? ? ? ? ? ? ret = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_counter);
+ ? ? temp = (temp & temp_sensor->registers->counter_mask) >>
+ ? ? ? ? ? ? ? ? ? ? __ffs(temp_sensor->registers->counter_mask);

? ? ? ?temp &= ??

drivers/hwmon/omap_temp_sensor.c line 464

Quoted 1 line

drivers/hwmon/omap_temp_sensor.c new file +1 -0

+ ? ? temp = temp * 1000 / (temp_sensor->clk_rate);

? ? ? ?temp *= ??

Quoted 110 lines

drivers/hwmon/omap_temp_sensor.c new file +109 -0

+
+out:
+ ? ? mutex_unlock(&temp_sensor->sensor_mutex);
+ ? ? if (!ret)
+ ? ? ? ? ? ? return sprintf(buf, "%d\n", temp);
+ ? ? else
+ ? ? ? ? ? ? return ret;
+}
+
+static ssize_t set_update_rate(struct device *dev,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct device_attribute *devattr,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ?const char *buf, size_t count)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+ ? ? u32 ? ? ? ? ? ? ? ? ? ? reg_val;
+ ? ? long ? ? ? ? ? ? ? ? ? ?val;
+
+ ? ? mutex_lock(&temp_sensor->sensor_mutex);
+
+ ? ? if (strict_strtol(buf, 10, &val)) {
+ ? ? ? ? ? ? count = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? val *= temp_sensor->clk_rate / 1000;
+ ? ? reg_val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_counter);
+
+ ? ? reg_val &= ~(temp_sensor->registers->counter_mask);
+ ? ? reg_val |= val;
+ ? ? omap_temp_sensor_writel(temp_sensor, reg_val,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_counter);
+
+out:
+ ? ? mutex_unlock(&temp_sensor->sensor_mutex);
+ ? ? return count;
+}
+
+static int omap_temp_sensor_read_temp(struct device *dev,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct device_attribute *devattr,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? char *buf)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+ ? ? int ? ? ? ? ? ? ? ? ? ? temp, ret = 0;
+
+ ? ? mutex_lock(&temp_sensor->sensor_mutex);
+
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? temp &= temp_sensor->registers->bgap_dtemp_mask;
+
+ ? ? if (!temp_sensor->is_efuse_valid)
+ ? ? ? ? ? ? dev_err(dev, "Invalid EFUSE, Non-trimmed BGAP, Temp not accurate\n");
+
+ ? ? /* look up for temperature in the table and return the temperature */
+ ? ? if (temp < OMAP_ADC_START_VALUE || temp > OMAP_ADC_END_VALUE) {
+ ? ? ? ? ? ? dev_err(dev, "invalid adc code reported %d", temp);
+ ? ? ? ? ? ? ret = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? temp = adc_to_temp[temp - OMAP_ADC_START_VALUE];
+
+out:
+ ? ? mutex_unlock(&temp_sensor->sensor_mutex);
+ ? ? if (!ret)
+ ? ? ? ? ? ? return sprintf(buf, "%d\n", temp);
+ ? ? else
+ ? ? ? ? ? ? return ret;
+}
+
+static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, omap_temp_sensor_read_temp,
+ ? ? ? ? ? ? ? ? ? ? ? NULL, 0);
+static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp_max,
+ ? ? ? ? ? ? ? ? ? ? ? set_temp_max, 0);
+static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO, show_temp_max_hyst,
+ ? ? ? ? ? ? ? ? ? ? ? set_temp_max_hyst, 0);
+static SENSOR_DEVICE_ATTR(update_rate, S_IWUSR | S_IRUGO, show_update_rate,
+ ? ? ? ? ? ? ? ? ? ? ? set_update_rate, 0);
+
+static struct attribute *omap_temp_sensor_attributes[] = {
+ ? ? &sensor_dev_attr_temp1_input.dev_attr.attr,
+ ? ? &sensor_dev_attr_temp1_max.dev_attr.attr,
+ ? ? &sensor_dev_attr_temp1_max_hyst.dev_attr.attr,
+ ? ? &sensor_dev_attr_update_rate.dev_attr.attr,
+ ? ? NULL
+};
+
+static const struct attribute_group omap_temp_sensor_group = {
+ ? ? .attrs = omap_temp_sensor_attributes,
+};
+
+static int omap_temp_sensor_clk_enable(struct omap_temp_sensor *temp_sensor)
+{
+ ? ? u32 ret = 0, temp;
+
+ ? ? if (temp_sensor->clk_on) {
+ ? ? ? ? ? ? dev_err(temp_sensor->hwmon_dev, "clock already on\n");
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? ret = pm_runtime_get_sync(temp_sensor->hwmon_dev);
+ ? ? if (ret < 0) {
+ ? ? ? ? ? ? dev_err(temp_sensor->hwmon_dev, "get sync failed\n");
+ ? ? ? ? ? ? ret = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,

drivers/hwmon/omap_temp_sensor.c line 579

Quoted 6 lines

drivers/hwmon/omap_temp_sensor.c new file +6 -0

+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? temp &= ~(temp_sensor->registers->bgap_tempsoff_mask);
+ ? ? /* BGAP_TEMPSOFF should be reset to 0 */
+ ? ? omap_temp_sensor_writel(temp_sensor, temp,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? temp_sensor->clk_on = 1;

why isn't pm_runtime_get_sync() enough ??

Quoted 125 lines

drivers/hwmon/omap_temp_sensor.c new file +124 -0

+out:
+ ? ? return ret;
+}
+
+static int omap_temp_sensor_clk_disable(struct omap_temp_sensor *temp_sensor)
+{
+ ? ? u32 temp, ret = 0;
+ ? ? unsigned long timeout;
+
+ ? ? if (!temp_sensor->clk_on) {
+ ? ? ? ? ? ? dev_err(temp_sensor->hwmon_dev, "clock already off\n");
+ ? ? ? ? ? ? goto out;
+ ? ? }
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? temp |= temp_sensor->registers->bgap_tempsoff_mask;
+
+ ? ? /* BGAP_TEMPSOFF should be set to 1 before gating clock */
+ ? ? omap_temp_sensor_writel(temp_sensor, temp,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_status);
+ ? ? timeout = jiffies + msecs_to_jiffies(5);
+
+ ? ? /* wait till the clean stop bit is set or till the timeout exppires */
+ ? ? while (!(temp | temp_sensor->registers->status_clean_stop_mask) &&
+ ? ? ? ? ? ? !(time_after(jiffies, timeout))) {
+ ? ? ? ? ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_status);
+ ? ? ? ? ? ? usleep_range(500, 2000);
+ ? ? }
+
+ ? ? if (time_after(jiffies, timeout))
+ ? ? ? ? ? ? dev_err(temp_sensor->hwmon_dev, "Clean stop bit not set\n");
+ ? ? /* Gate the clock */
+ ? ? ret = pm_runtime_put_sync(temp_sensor->hwmon_dev);
+ ? ? if (ret < 0) {
+ ? ? ? ? ? ? dev_err(temp_sensor->hwmon_dev, "put sync failed\n");
+ ? ? ? ? ? ? ret = -EINVAL;
+ ? ? ? ? ? ? goto out;
+ ? ? }
+ ? ? temp_sensor->clk_on = 0;
+out:
+ ? ? return ret;
+}
+static irqreturn_t omap_talert_irq_handler(int irq, void *data)
+{
+ ? ? struct omap_temp_sensor ? ? ? ? *temp_sensor;
+ ? ? int ? ? ? ? ? ? ? ? ? ? ? ? ? ? t_hot, t_cold, temp;
+
+ ? ? temp_sensor = data;
+ ? ? mutex_lock(&temp_sensor->sensor_mutex);
+
+ ? ? /* Read the status of t_hot */
+ ? ? t_hot = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_status)
+ ? ? ? ? ? ? ? ? ? ? & temp_sensor->registers->status_hot_mask;
+
+ ? ? /* Read the status of t_cold */
+ ? ? t_cold = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_status)
+ ? ? ? ? ? ? ? ? ? ? & temp_sensor->registers->status_cold_mask;
+
+ ? ? temp = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? /*
+ ? ? ?* One TALERT interrupt: Two sources
+ ? ? ?* If the interrupt is due to t_hot then mask t_hot and
+ ? ? ?* and unmask t_cold else mask t_cold and unmask t_hot
+ ? ? ?*/
+ ? ? if (t_hot) {
+ ? ? ? ? ? ? temp &= ~(temp_sensor->registers->mask_hot_mask);
+ ? ? ? ? ? ? temp |= temp_sensor->registers->mask_cold_mask;
+ ? ? } else if (t_cold) {
+ ? ? ? ? ? ? temp &= ~(temp_sensor->registers->mask_cold_mask);
+ ? ? ? ? ? ? temp |= temp_sensor->registers->mask_hot_mask;
+ ? ? }
+
+ ? ? omap_temp_sensor_writel(temp_sensor, temp,
+ ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+
+ ? ? /* kobject_uvent to user space telling thermal threshold crossed */
+ ? ? kobject_uevent(&temp_sensor->hwmon_dev->kobj, KOBJ_CHANGE);
+
+ ? ? mutex_unlock(&temp_sensor->sensor_mutex);
+
+ ? ? return IRQ_HANDLED;
+}
+
+static int __devinit omap_temp_sensor_probe(struct platform_device *pdev)
+{
+ ? ? struct omap_temp_sensor_pdata ? *pdata ?= pdev->dev.platform_data;
+ ? ? struct omap_temp_sensor ? ? ? ? *temp_sensor;
+ ? ? struct resource ? ? ? ? ? ? ? ? *mem;
+ ? ? int ? ? ? ? ? ? ? ? ? ? ? ? ? ? ret = 0;
+ ? ? int ? ? ? ? ? ? ? ? ? ? ? ? ? ? val, clk_rate;
+
+ ? ? if (!pdata) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "platform data missing\n");
+ ? ? ? ? ? ? return -EINVAL;
+ ? ? }
+
+ ? ? temp_sensor = kzalloc(sizeof(*temp_sensor), GFP_KERNEL);
+ ? ? if (!temp_sensor)
+ ? ? ? ? ? ? return -ENOMEM;
+
+ ? ? mutex_init(&temp_sensor->sensor_mutex);
+
+ ? ? mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ ? ? if (!mem) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "no mem resource\n");
+ ? ? ? ? ? ? ret = -EINVAL;
+ ? ? ? ? ? ? goto plat_res_err;
+ ? ? }
+
+ ? ? temp_sensor->irq = platform_get_irq_byname(pdev, "thermal_alert");
+ ? ? if (temp_sensor->irq == -ENXIO) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "get_irq_byname failed\n");
+ ? ? ? ? ? ? ret = temp_sensor->irq;
+ ? ? ? ? ? ? goto plat_res_err;
+ ? ? }
+
+ ? ? temp_sensor->phy_base = ioremap(mem->start, resource_size(mem));
+ ? ? temp_sensor->clock = NULL;

drivers/hwmon/omap_temp_sensor.c line 708

Quoted 5 lines

drivers/hwmon/omap_temp_sensor.c new file +5 -0

+ ? ? temp_sensor->registers = pdata->registers;
+ ? ? temp_sensor->hwmon_dev = &pdev->dev;
+
+ ? ? pm_runtime_enable(&pdev->dev);
+ ? ? pm_runtime_irq_safe(&pdev->dev);

won't pm_runtime_irq_safe() keep the parent always running, thus preventing MPU from reaching lower power states ??

drivers/hwmon/omap_temp_sensor.c line 720

Quoted 12 lines

drivers/hwmon/omap_temp_sensor.c new file +12 -0

+ ? ? /*
+ ? ? ?* check if the efuse has a non-zero value if not
+ ? ? ?* it is an untrimmed sample and the temperatures
+ ? ? ?* may not be accurate
+ ? ? ?*/
+
+ ? ? if (omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_efuse))
+ ? ? ? ? ? ? temp_sensor->is_efuse_valid = 1;
+
+ ? ? platform_set_drvdata(pdev, temp_sensor);
+ ? ? dev_set_drvdata(&pdev->dev, temp_sensor);

why are you doing the same thing twice ???

drivers/hwmon/omap_temp_sensor.c line 721

Quoted 1 line

drivers/hwmon/omap_temp_sensor.c new file +1 -0

+ ? ? temp_sensor->clock = clk_get(temp_sensor->hwmon_dev, "fck");

why ?

Quoted 10 lines

drivers/hwmon/omap_temp_sensor.c new file +9 -0

+ ? ? if (IS_ERR(temp_sensor->clock)) {
+ ? ? ? ? ? ? ret = PTR_ERR(temp_sensor->clock);
+ ? ? ? ? ? ? dev_err(temp_sensor->hwmon_dev,
+ ? ? ? ? ? ? ? ? ? ? "unable to get fclk: %d\n", ret);
+ ? ? ? ? ? ? ret = -EINVAL;
+ ? ? ? ? ? ? goto plat_res_err;
+ ? ? }
+
+ ? ? ret = omap_temp_sensor_clk_enable(temp_sensor);

drivers/hwmon/omap_temp_sensor.c line 736

Quoted 6 lines

drivers/hwmon/omap_temp_sensor.c new file +6 -0

+ ? ? if (ret) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "Cannot enable temp sensor\n");
+ ? ? ? ? ? ? goto clken_err;
+ ? ? }
+
+ ? ? clk_rate = clk_round_rate(temp_sensor->clock, 2000000);

why ?

drivers/hwmon/omap_temp_sensor.c line 742

Quoted 7 lines

drivers/hwmon/omap_temp_sensor.c new file +6 -0

+ ? ? if (clk_rate < 1000000 || clk_rate == 0xffffffff) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "Error round rate\n");
+ ? ? ? ? ? ? goto clken_err;
+ ? ? }
+
+ ? ? ret = clk_set_rate(temp_sensor->clock, clk_rate);

why ??

Quoted 210 lines

drivers/hwmon/omap_temp_sensor.c new file +206 -1

+ ? ? if (ret) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "Cannot set clock rate\n");
+ ? ? ? ? ? ? goto clken_err;
+ ? ? }
+
+ ? ? temp_sensor->clk_rate = clk_rate;
+ ? ? omap_enable_continuous_mode(temp_sensor, 1);
+ ? ? omap_configure_temp_sensor_thresholds(temp_sensor);
+ ? ? /* 1 ms */
+ ? ? omap_configure_temp_sensor_counter(temp_sensor, 1);
+
+ ? ? /* Wait till the first conversion is done wait for at least 1ms */
+ ? ? usleep_range(1000, 2000);
+
+ ? ? /* Read the temperature once due to hw issue*/
+ ? ? omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+
+ ? ? /* Set 2 seconds time as default counter */
+ ? ? omap_configure_temp_sensor_counter(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->clk_rate * 2);
+
+ ? ? temp_sensor->hwmon_dev = hwmon_device_register(&pdev->dev);
+ ? ? if (IS_ERR(temp_sensor->hwmon_dev)) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "hwmon_device_register failed.\n");
+ ? ? ? ? ? ? ret = PTR_ERR(temp_sensor->hwmon_dev);
+ ? ? ? ? ? ? goto hwmon_reg_err;
+ ? ? }
+
+ ? ? ret = sysfs_create_group(&pdev->dev.kobj,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&omap_temp_sensor_group);
+ ? ? if (ret) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "could not create sysfs files\n");
+ ? ? ? ? ? ? goto sysfs_create_err;
+ ? ? }
+
+ ? ? kobject_uevent(&temp_sensor->hwmon_dev->kobj, KOBJ_ADD);
+
+ ? ? ret = request_threaded_irq(temp_sensor->irq, NULL,
+ ? ? ? ? ? ? omap_talert_irq_handler, IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+ ? ? ? ? ? ? ? ? ? ? "temp_sensor", temp_sensor);
+ ? ? if (ret) {
+ ? ? ? ? ? ? dev_err(&pdev->dev, "Request threaded irq failed.\n");
+ ? ? ? ? ? ? goto req_irq_err;
+ ? ? }
+
+ ? ? /* unmask the T_COLD and unmask T_HOT at init */
+ ? ? val = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? val |= temp_sensor->registers->mask_cold_mask
+ ? ? ? ? ? ? | temp_sensor->registers->mask_hot_mask;
+
+ ? ? omap_temp_sensor_writel(temp_sensor, val,
+ ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+
+ ? ? return 0;
+
+req_irq_err:
+ ? ? kobject_uevent(&temp_sensor->hwmon_dev->kobj, KOBJ_REMOVE);
+ ? ? sysfs_remove_group(&temp_sensor->hwmon_dev->kobj,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? &omap_temp_sensor_group);
+sysfs_create_err:
+ ? ? hwmon_device_unregister(&pdev->dev);
+hwmon_reg_err:
+ ? ? omap_temp_sensor_clk_disable(temp_sensor);
+clken_err:
+ ? ? if (temp_sensor->clock)
+ ? ? ? ? ? ? clk_put(temp_sensor->clock);
+plat_res_err:
+ ? ? mutex_destroy(&temp_sensor->sensor_mutex);
+ ? ? kfree(temp_sensor);
+ ? ? return ret;
+}
+
+static int __devexit omap_temp_sensor_remove(struct platform_device *pdev)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = platform_get_drvdata(pdev);
+
+ ? ? hwmon_device_unregister(&pdev->dev);
+ ? ? kobject_uevent(&temp_sensor->hwmon_dev->kobj, KOBJ_REMOVE);
+ ? ? sysfs_remove_group(&temp_sensor->hwmon_dev->kobj,
+ ? ? ? ? ? ? ? ? ? ? &omap_temp_sensor_group);
+ ? ? omap_temp_sensor_clk_disable(temp_sensor);
+ ? ? clk_put(temp_sensor->clock);
+ ? ? platform_set_drvdata(pdev, NULL);
+ ? ? free_irq(temp_sensor->irq, temp_sensor);
+ ? ? mutex_destroy(&temp_sensor->sensor_mutex);
+ ? ? kfree(temp_sensor);
+
+ ? ? return 0;
+}
+
+#ifdef CONFIG_PM
+static void omap_temp_sensor_save_ctxt(struct omap_temp_sensor *temp_sensor)
+{
+ ? ? temp_sensor->temp_sensor_ctrl = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? temp_sensor->bg_ctrl = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? temp_sensor->bg_counter = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->bgap_counter);
+ ? ? temp_sensor->bg_threshold = omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? temp_sensor->temp_sensor_tshut_threshold =
+ ? ? ? ? ? ? omap_temp_sensor_readl(temp_sensor,
+ ? ? ? ? ? ? temp_sensor->registers->thsut_threshold);
+}
+
+static void omap_temp_sensor_restore_ctxt(struct omap_temp_sensor *temp_sensor)
+{
+ ? ? omap_temp_sensor_writel(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->temp_sensor_ctrl,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->temp_sensor_ctrl);
+ ? ? omap_temp_sensor_writel(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->bg_ctrl,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_mask_ctrl);
+ ? ? omap_temp_sensor_writel(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->bg_counter,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_counter);
+ ? ? omap_temp_sensor_writel(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->bg_threshold,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->bgap_threshold);
+ ? ? omap_temp_sensor_writel(temp_sensor,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->temp_sensor_tshut_threshold,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? temp_sensor->registers->thsut_threshold);
+}
+
+static int omap_temp_sensor_suspend(struct device *dev)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+
+ ? ? omap_temp_sensor_save_ctxt(temp_sensor);
+
+ ? ? return 0;
+}
+
+static int omap_temp_sensor_resume(struct device *dev)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+
+ ? ? omap_temp_sensor_restore_ctxt(temp_sensor);
+
+ ? ? return 0;
+}
+
+static int omap_temp_sensor_runtime_suspend(struct device *dev)
+{
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+
+ ? ? omap_temp_sensor_save_ctxt(temp_sensor);
+
+ ? ? return 0;
+}
+
+static int omap_temp_sensor_runtime_resume(struct device *dev)
+{
+ ? ? static int context_loss_count;
+ ? ? int temp;
+ ? ? struct omap_temp_sensor *temp_sensor = dev_get_drvdata(dev);
+
+ ? ? temp = omap_device_get_context_loss_count(to_platform_device(dev));
+
+ ? ? if (temp != context_loss_count && context_loss_count != 0)
+ ? ? ? ? ? ? omap_temp_sensor_restore_ctxt(temp_sensor);
+
+ ? ? context_loss_count = temp;
+
+ ? ? return 0;
+}
+
+static const struct dev_pm_ops omap_temp_sensor_dev_pm_ops = {
+ ? ? .suspend = omap_temp_sensor_suspend,
+ ? ? .resume = omap_temp_sensor_resume,
+ ? ? .runtime_suspend = omap_temp_sensor_runtime_suspend,
+ ? ? .runtime_resume = omap_temp_sensor_runtime_resume,
+};
+
+#endif
+
+static struct platform_driver omap_temp_sensor_driver = {
+ ? ? .probe = omap_temp_sensor_probe,
+ ? ? .remove = omap_temp_sensor_remove,
+ ? ? .driver = {
+ ? ? ? ? ? ? ? ? ? ? .name = "omap_temp_sensor",
+#ifdef CONFIG_PM
+ ? ? ? ? ? ? ? ? ? ? .pm = &omap_temp_sensor_dev_pm_ops,
+#endif
+ ? ? ? ? ? ? ? ?},
+};
+
+int __init omap_temp_sensor_init(void)
+{
+ ? ? return platform_driver_register(&omap_temp_sensor_driver);
+}
+module_init(omap_temp_sensor_init);
+
+static void __exit omap_temp_sensor_exit(void)
+{
+ ? ? platform_driver_unregister(&omap_temp_sensor_driver);
+}
+module_exit(omap_temp_sensor_exit);
+
+MODULE_DESCRIPTION("OMAP446X temperature sensor Driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRIVER_NAME);
+MODULE_AUTHOR("J Keerthy <[email protected]>");
--

1.7.0.4

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

--
balbi

Quoted 3 lines · Felipe Balbi

Hi,

(why aren't below in Cc ?

I will add them.

Quoted 87 lines

HARDWARE MONITORING
M: ? ? ?Jean Delvare <[email protected]>
M: ? ? ?Guenter Roeck <[email protected]>
L: ? ? ?lm-sensors at lm-sensors.org
W: ? ? ?http://www.lm-sensors.org/
T: ? ? ?quilt kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-hwmon/
T: ? ? ?git git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
S: ? ? ?Maintained
F: ? ? ?Documentation/hwmon/
F: ? ? ?drivers/hwmon/
F: ? ? ?include/linux/hwmon*.h)

Quoted 73 lines · Keerthy

On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user is allowed to configure the temperature thresholds vis sysfs nodes exposed using hwmon interface.

Signed-off-by Keerthy <[email protected]>

---

?drivers/hwmon/Kconfig ? ? ? ? ? ?| ? 11 +
?drivers/hwmon/Makefile ? ? ? ? ? | ? ?1 +
?drivers/hwmon/omap_temp_sensor.c | ?950 ++++++++++++++++++++++++++++++++++++++

?3 files changed, 962 insertions(+), 0 deletions(-) ?create mode 100644 drivers/hwmon/omap_temp_sensor.c

drivers/hwmon/Kconfig +0 -0

index 5f888f7..9c9cd8b 100644
@@ -323,6 +323,17 @@ config SENSORS_F71805F

? ? ? ? This driver can also be built as a module. ?If so, the module ? ? ? ? will be called f71805f.

drivers/hwmon/Kconfig +11 -0

+config SENSORS_OMAP_BANDGAP_TEMP_SENSOR
+ ? ? bool "OMAP on-die temperature sensor hwmon driver"
+ ? ? depends on HWMON && ARCH_OMAP && OMAP_TEMP_SENSOR
+ ? ? help
+ ? ? ? If you say yes here you get support for hardware
+ ? ? ? monitoring features of the OMAP on die temperature
+ ? ? ? sensor.
+
+ ? ? ? Continuous conversion programmable delay
+ ? ? ? mode is used for temperature conversion.
+

?config SENSORS_F71882FG
? ? ? tristate "Fintek F71882FG and compatibles"
? ? ? help

drivers/hwmon/Makefile +0 -0

index 28061cf..d0f89f5 100644
@@ -91,6 +91,7 @@ obj-$(CONFIG_SENSORS_MAX6639) ? ? ? += max6639.o

?obj-$(CONFIG_SENSORS_MAX6642) ? ? ? ?+= max6642.o ?obj-$(CONFIG_SENSORS_MAX6650) ? ? ? ?+= max6650.o ?obj-$(CONFIG_SENSORS_MC13783_ADC)+= mc13783-adc.o +obj-$(CONFIG_SENSORS_OMAP_BANDGAP_TEMP_SENSOR) ?+= omap_temp_sensor.o ?obj-$(CONFIG_SENSORS_PC87360) ? ? ? ?+= pc87360.o ?obj-$(CONFIG_SENSORS_PC87427) ? ? ? ?+= pc87427.o ?obj-$(CONFIG_SENSORS_PCF8591) ? ? ? ?+= pcf8591.o

drivers/hwmon/omap_temp_sensor.c new file +19 -0

new file mode 100644
index 0000000..15e2559
@@ -0,0 +1,950 @@
+/*
+ * OMAP4 Temperature sensor driver file
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ * Author: J Keerthy <[email protected]>
+ * Author: Moiz Sonasath <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ?See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA

Quoted 8 lines

drivers/hwmon/omap_temp_sensor.c line 25

Quoted 6 lines

drivers/hwmon/omap_temp_sensor.c new file +6 -0

+ * 02110-1301 USA
+ *
+ */
+
+#include <linux/interrupt.h>
+#include <linux/clk.h>

why ??

Clock rate setting functions.

Quoted 4 lines

drivers/hwmon/omap_temp_sensor.c line 27

Quoted 2 lines

drivers/hwmon/omap_temp_sensor.c new file +2 -0

+#include <linux/io.h>
+#include <linux/debugfs.h>

why ??

It will be removed.

Quoted 9 lines

drivers/hwmon/omap_temp_sensor.c line 32

Quoted 6 lines

drivers/hwmon/omap_temp_sensor.c new file +5 -0

+#include <linux/delay.h>
+#include <linux/slab.h>
+#include <linux/platform_device.h>
+#include <linux/init.h>
+#include <plat/omap_device.h>

why ??