Skip to contentSkip to conversation

Fix ocf-tester to use bash when testing agents

PATCH New Chris Feist 3 participants 3 messages Aug 12, 2011 – Aug 16, 2011

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 Fix ocf-tester to use bash when testing agents

Quoted 5 lines · Chris Feist

Simple workaround to prevent errors when testing rgmanager resource agents with ocf tester.

Thanks,
Chris

It's probably best to send patches that involves the whole tree to ha-wg-technical, so that also the linux-ha people can look at them.

The change is OK with me, but they might have other opinions.

Fabio

#2 lore raw

PATCH 1/1 Fix ocf-tester to use bash when testing agents

Hi Fabio and Chris,

Quoted 9 lines · Fabio M. Di Nitto
Quoted 5 lines · Chris Feist

Simple workaround to prevent errors when testing rgmanager resource agents with ocf tester.

Thanks,
Chris

It's probably best to send patches that involves the whole tree to ha-wg-technical, so that also the linux-ha people can look at them.

Yes, I missed the patch.

Quoted 1 line

The change is OK with me, but they might have other opinions.

There are some platforms and linux distribution which use a shell different from bash. At least linux-ha RAs often don't require bash. For instance, Debian's default shell is dash, which is POSIX compliant and lighter than bash.

Chris, which errors did you encounter? On most (or all) of my computers there is:

$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Dec  3  2009 /bin/sh -> bash

Cheers,

Dejan

Quoted 2 lines

Fabio