Skip to contentSkip to conversation

Passing stream to userspace

RFC Jan Schmidt 2 participants 2 messages Aug 12, 2011 – Aug 16, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi there,

I was promised you (viro, hch) have a decided opinion on this topic. The original mail ("Getting a lot of fs-generated information to user space") contains a lot of background and is way too long. Point is: I want to get a bunch of data generated by the kernel (btrfs) to userland (really).

Matthew Wilcox suggested to use an ioctl changing f_ops.read. Userland would be like:

Quoted 7 lines

int fd = open("/mnt/btrfs");
ioctl(fd, BTRFS_IOC_STREAM);

while (...) {
	read(fd, buf, 4096);
	...
}

close(fd);

To avoid doing buffering myself, I suggested passing a fd to the kernel where it is expected to dump the generated information, like:

Quoted 8 lines

int fd;
int pipefd[2];
struct io_args io_args;

fd = open("/mnt/btrfs");
pipe(pipefd);
io_agrs.dest = pipefd[0];

Quoted 7 lines

/* thread 1 */
ioctl(fd, BTRFS_IOC_STREAM, &io_args);
/* thread 2 */

while (...) {
	read(pipefd[1], buf, 4096);
	...
}

Any opinions on those or different suggestions? Thanks, -Jan

#1 lore raw

Jan,

I personally like the way we interact with the kernel using the /sys or /proc that's a cool way, mainly because no C code is required. A generic interface like that (or btrfs-control with more commands supported) will enhance troubleshooting and debugging, application interface.
or did I miss anything ?

Cheers, Anand

Quoted 44 lines · Jan Schmidt

Hi there,

I was promised you (viro, hch) have a decided opinion on this topic. The original mail ("Getting a lot of fs-generated information to user space") contains a lot of background and is way too long. Point is: I want to get a bunch of data generated by the kernel (btrfs) to userland (really).

Matthew Wilcox suggested to use an ioctl changing f_ops.read. Userland would be like:

Quoted 7 lines

int fd = open("/mnt/btrfs");
ioctl(fd, BTRFS_IOC_STREAM);

while (...) {
	read(fd, buf, 4096);
	...
}

close(fd);

To avoid doing buffering myself, I suggested passing a fd to the kernel where it is expected to dump the generated information, like:

Quoted 8 lines

int fd;
int pipefd[2];
struct io_args io_args;

fd = open("/mnt/btrfs");
pipe(pipefd);
io_agrs.dest = pipefd[0];

Quoted 7 lines

/* thread 1 */
ioctl(fd, BTRFS_IOC_STREAM,&io_args);
/* thread 2 */

while (...) {
	read(pipefd[1], buf, 4096);
	...
}

Any opinions on those or different suggestions? Thanks,
-Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html