Skip to contentSkip to conversation

HAL support is not mandatory for ConsoleKit

PATCH New Sven Vermeulen 2 participants 2 messages Aug 13, 2011 – Aug 16, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HAL support is not mandatory for ConsoleKit

The current consolekit policy definition has hal_ptrace(consolekit_t) in its main body. However, HAL support within consolekit is not mandatory. As such, this call should be within an optional_policy().

---
 policy/modules/services/consolekit.te |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
policy/modules/services/consolekit.te +4 -2
index dd71359..46cd222 100644
@@ -72,8 +72,6 @@ miscfiles_read_localization(consolekit_t)
 userdom_dontaudit_read_user_home_content_files(consolekit_t)
 userdom_read_user_tmp_files(consolekit_t)
 
-hal_ptrace(consolekit_t)
-
 tunable_policy(`use_nfs_home_dirs',`
 	fs_read_nfs_files(consolekit_t)
 ')
@@ -99,6 +97,10 @@ optional_policy(`
 ')
 
 optional_policy(`
+	hal_ptrace(consolekit_t)
+')
+
+optional_policy(`
 	policykit_dbus_chat(consolekit_t)
 	policykit_domtrans_auth(consolekit_t)
 	policykit_read_lib(consolekit_t)
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 HAL support is not mandatory for ConsoleKit

Quoted 3 lines · Sven Vermeulen

The current consolekit policy definition has hal_ptrace(consolekit_t) in its main body. However, HAL support within consolekit is not mandatory. As such, this call should be within an optional_policy().

Merged.

Quoted 29 lines
---
  policy/modules/services/consolekit.te |    6 ++++--
  1 files changed, 4 insertions(+), 2 deletions(-)
policy/modules/services/consolekit.te +4 -2
index dd71359..46cd222 100644
@@ -72,8 +72,6 @@ miscfiles_read_localization(consolekit_t)
  userdom_dontaudit_read_user_home_content_files(consolekit_t)
  userdom_read_user_tmp_files(consolekit_t)
 
-hal_ptrace(consolekit_t)
-
  tunable_policy(`use_nfs_home_dirs',`
  	fs_read_nfs_files(consolekit_t)
  ')
@@ -99,6 +97,10 @@ optional_policy(`
  ')
 
  optional_policy(`
+	hal_ptrace(consolekit_t)
+')
+
+optional_policy(`
  	policykit_dbus_chat(consolekit_t)
  	policykit_domtrans_auth(consolekit_t)
  	policykit_read_lib(consolekit_t)
Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com