Skip to contentSkip to conversation

nestedhvm: avoid endless loop of nested page faults

PATCH Applied Christoph Egger 2 participants 2 messages Aug 19, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nestedhvm: avoid endless loop of nested page faults

Stop sending IPIs to flush the nested-on-nested pagetable after write operations. Instead flush the TLB only. This fixes an endless loop of nested page faults after adding an entry to the nested-on-nested pagetable.

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
xen/arch/x86/mm/hap/nested_hap.c +2 -1
diff -r ce4768a78051 xen/arch/x86/mm/hap/nested_hap.c
@@ -86,8 +86,9 @@ nestedp2m_write_p2m_entry(struct p2m_dom
 
     old_flags = l1e_get_flags(*p);
     safe_write_pte(p, new);
+
     if (old_flags & _PAGE_PRESENT)
-        nestedhvm_vmcx_flushtlb(p2m);
+        flush_tlb_mask(&p2m->p2m_dirty_cpumask);
     
     paging_unlock(d);
 }

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw
Quoted 6 lines · Christoph Egger

Stop sending IPIs to flush the nested-on-nested pagetable after write operations. Instead flush the TLB only. This fixes an endless loop of nested page faults after adding an entry to the nested-on-nested pagetable.

Applied, thanks.

Tim.

Signature · 3 lines
Tim Deegan <[email protected]>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)