Skip to contentSkip to conversation

x86: trivial: remove unnecessary get_order in free_thread_info

PATCH In review Zhao Jin 1 participant 3 messages Aug 20, 2011 – Aug 23, 2011 x86

lore
Share & tools
lore

Zhao Jin

author
#0 lore raw

PATCH 1/1 x86: trivial: remove unnecessary get_order in free_thread_info

From: Zhao Jin <[email protected]>

Because THREAD_SIZE is defined as PAGE_SIZE << THREAD_ORDER on x86, the call of get_order(THREAD_SIZE) can be replaced with THREAD_ORDER.

---
 arch/x86/kernel/process.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/process.c +1 -1
index e7e3b01..b9b3b1a 100644
@@ -49,7 +49,7 @@ void free_thread_xstate(struct task_struct *tsk)
 void free_thread_info(struct thread_info *ti)
 {
     free_thread_xstate(ti->task);
-    free_pages((unsigned long)ti, get_order(THREAD_SIZE));
+    free_pages((unsigned long)ti, THREAD_ORDER);
 }
 
 void arch_task_cache_init(void)
Signature · 1 line
1.7.4.1
#1 lore raw

[tip:x86/cleanups] x86, mm, trivial: Rmove unnecessary get_order in free_thread_info

Commit-ID:  54f6de81be44e889d66c144fc449fefe586aa3b8
Gitweb:     http://git.kernel.org/tip/54f6de81be44e889d66c144fc449fefe586aa3b8
Author:     Zhao Jin <[email protected]>
AuthorDate: Sat, 20 Aug 2011 21:24:57 +0800
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Mon, 22 Aug 2011 15:37:31 -0700

x86, mm, trivial: Rmove unnecessary get_order in free_thread_info

Because THREAD_SIZE is defined as PAGE_SIZE << THREAD_ORDER on x86, the call of get_order(THREAD_SIZE) can be replaced with THREAD_ORDER.

---
 arch/x86/kernel/process.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/process.c +1 -1
index e7e3b01..b9b3b1a 100644
@@ -49,7 +49,7 @@ void free_thread_xstate(struct task_struct *tsk)
 void free_thread_info(struct thread_info *ti)
 {
 	free_thread_xstate(ti->task);
-	free_pages((unsigned long)ti, get_order(THREAD_SIZE));
+	free_pages((unsigned long)ti, THREAD_ORDER);
 }
 
 void arch_task_cache_init(void)
#2 lore raw

[tip:x86/cleanups] x86, mm, trivial: Remove unnecessary get_order() in free_thread_info()

In reply to Zhao Jin
Commit-ID:  c812d8f7ad27bd5f1ed1c790eea8527b6f8ff1c7
Gitweb:     http://git.kernel.org/tip/c812d8f7ad27bd5f1ed1c790eea8527b6f8ff1c7
Author:     Zhao Jin <[email protected]>
AuthorDate: Sat, 20 Aug 2011 21:24:57 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 23 Aug 2011 21:49:35 +0200

x86, mm, trivial: Remove unnecessary get_order() in free_thread_info()

Because THREAD_SIZE is defined as PAGE_SIZE << THREAD_ORDER on x86, the call of get_order(THREAD_SIZE) can be replaced with THREAD_ORDER.

---
 arch/x86/kernel/process.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/process.c +1 -1
index e7e3b01..b9b3b1a 100644
@@ -49,7 +49,7 @@ void free_thread_xstate(struct task_struct *tsk)
 void free_thread_info(struct thread_info *ti)
 {
 	free_thread_xstate(ti->task);
-	free_pages((unsigned long)ti, get_order(THREAD_SIZE));
+	free_pages((unsigned long)ti, THREAD_ORDER);
 }
 
 void arch_task_cache_init(void)