Skip to contentSkip to conversation

omap4: fix build warning due to signed unsigned comparison

PATCH New Aneesh V 2 participants 2 messages Aug 21, 2011 Arm (32-bit)

lore
Share & tools
lore

Aneesh V

author
#0 lore raw

PATCH 1/1 omap4: fix build warning due to signed unsigned comparison

---
 arch/arm/include/asm/arch-omap4/clocks.h |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/include/asm/arch-omap4/clocks.h +6 -6
index 374e064..45c947d 100644
@@ -679,12 +679,12 @@ struct dpll_regs {
 struct dpll_params {
 	u32 m;
 	u32 n;
-	u8 m2;
-	u8 m3;
-	u8 m4;
-	u8 m5;
-	u8 m6;
-	u8 m7;
+	s8 m2;
+	s8 m3;
+	s8 m4;
+	s8 m5;
+	s8 m6;
+	s8 m7;
 };
 
 #endif /* _CLOCKS_OMAP4_H_ */
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 omap4: fix build warning due to signed unsigned comparison

Hi Aneesh,

Le 21/08/2011 09:40, Aneesh V a ?crit :

Quoted 18 lines
---
  arch/arm/include/asm/arch-omap4/clocks.h |   12 ++++++------
  1 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/include/asm/arch-omap4/clocks.h +0 -5
index 374e064..45c947d 100644
@@ -679,12 +679,12 @@ struct dpll_regs {
  struct dpll_params {
  	u32 m;
  	u32 n;
-	u8 m2;
-	u8 m3;
-	u8 m4;
-	u8 m5;
-	u8 m6;

arch/arm/include/asm/arch-omap4/clocks.h struct dpll_regs { · line 690

Quoted 10 lines
arch/arm/include/asm/arch-omap4/clocks.h +6 -1
-	u8 m7;
+	s8 m2;
+	s8 m3;
+	s8 m4;
+	s8 m5;
+	s8 m6;
+	s8 m7;
  };
 
  #endif /* _CLOCKS_OMAP4_H_ */

Considering that is trivial, that it fixes the warnings on two ARM boards, that Sandeep allowed me to pull in some OMAP patches directly in u-boot-arm, and that will make
<http://patchwork.ozlabs.org/patch/108865/> build omap4 boards cleanly,

Applied to u-boot-arm/master, thanks!

Amicalement,

Signature · 1 line
Albert.