Skip to contentSkip to conversation

ARM: mach-footbridge: add missing header file <video/vga.h>

PATCH New Bryan Wu 4 participants 5 messages Aug 17, 2011 – Aug 21, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/footbridge architecture
lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/1 ARM: mach-footbridge: add missing header file <video/vga.h>

This patch fixes following building error:
--
arch/arm/mach-footbridge/dc21285.c: In function 'dc21285_preinit':
arch/arm/mach-footbridge/dc21285.c:299:2: error: 'vga_base' undeclared (first use in this function) arch/arm/mach-footbridge/dc21285.c:299:2: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/mach-footbridge/dc21285.o] Error 1
--

Signed-off-by Bryan Wu <[email protected]>
---
 arch/arm/mach-footbridge/dc21285.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-footbridge/dc21285.c +1 -0
index 1331fff..18c32a5 100644
@@ -18,6 +18,7 @@
 #include <linux/irq.h>
 #include <linux/io.h>
 #include <linux/spinlock.h>
+#include <video/vga.h>
 
 #include <asm/irq.h>
 #include <asm/system.h>
Signature · 1 line
1.7.5
author
#1 lore raw

PATCH 1/1 ARM: mach-footbridge: add missing header file <video/vga.h>

Russell,

Also this one. any comment?

Thanks,
-Bryan

Quoted 34 lines · Bryan Wu

This patch fixes following building error:
--
arch/arm/mach-footbridge/dc21285.c: In function 'dc21285_preinit':
arch/arm/mach-footbridge/dc21285.c:299:2: error: 'vga_base' undeclared (first use in this function) arch/arm/mach-footbridge/dc21285.c:299:2: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/mach-footbridge/dc21285.o] Error 1
--

Signed-off-by Bryan Wu <[email protected]>

---
?arch/arm/mach-footbridge/dc21285.c | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/mach-footbridge/dc21285.c +0 -0
index 1331fff..18c32a5 100644
@@ -18,6 +18,7 @@

?#include <linux/irq.h>
?#include <linux/io.h>
?#include <linux/spinlock.h>
+#include <video/vga.h>

?#include <asm/irq.h>
?#include <asm/system.h>
--
1.7.5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 5 lines
Bryan Wu <[email protected]>
Kernel Developer ? ?+86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd. ? ? ?www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
#2 lore raw

PATCH 1/1 ARM: mach-footbridge: add missing header file <video/vga.h>

Quoted 3 lines · Bryan Wu

Russell,

Also this one. any comment?

Other than frustration that Rob Herring isn't responding to his breakage (which is making me want to ignore further patches from Rob - clearly doesn't care about the effect of his c9d95fb "ARM: convert PCI defines to variables" patch...)

It looks obviously correct.

#3 lore raw

PATCH 1/1 ARM: mach-footbridge: add missing header file <video/vga.h>

Quoted 10 lines · Russell King - ARM Linux
Quoted 3 lines · Bryan Wu

Russell,

Also this one. any comment?

Other than frustration that Rob Herring isn't responding to his breakage (which is making me want to ignore further patches from Rob - clearly doesn't care about the effect of his c9d95fb "ARM: convert PCI defines to variables" patch...)

I forgot to add Rob in this email loop. Added now.

Quoted 2 lines

It looks obviously correct.

Thanks,

Signature · 5 lines
Bryan Wu <[email protected]>
Kernel Developer ? ?+86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd. ? ? ?www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
#4 lore raw

PATCH 1/1 ARM: mach-footbridge: add missing header file <video/vga.h>

Quoted 5 lines · Bryan Wu
Quoted 3 lines · Russell King - ARM Linux
Quoted 2 lines · Bryan Wu

Russell,

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

Also this one. any comment?

Other than frustration that Rob Herring isn't responding to his breakage (which is making me want to ignore further patches from Rob - clearly doesn't care about the effect of his c9d95fb "ARM: convert PCI defines to variables" patch...)

Sorry, I've been away on vacation Wed-Sat.

Quoted 2 lines

I forgot to add Rob in this email loop. Added now.

Thanks for copying me directly.

Quoted 3 lines
Quoted 3 lines

It looks obviously correct.

I went back to check for other instances and found orion5x is also broken missing this include. It is also broken by another commit which I'll fix. Patches coming soon.

Rob