backlight: ep93xx_bl: add missing include of linux/module.h

PATCH In review Axel Lin 3 participants 4 messages Aug 21, 2011 – Aug 22, 2011

Subsystems (2)

Framebuffer layer Backlight class/subsystem

lore

Share & tools

lore

Axel Lin

author

2011-08-21 14:33 UTC #0 lore raw

PATCH 1/1 backlight: ep93xx_bl: add missing include of linux/module.h

ep93xx_bl.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

CC [M] drivers/video/backlight/ep93xx_bl.o
drivers/video/backlight/ep93xx_bl.c:138: error: 'THIS_MODULE' undeclared here (not in a function) drivers/video/backlight/ep93xx_bl.c:158: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:158: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:158: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/backlight/ep93xx_bl.c:158: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:159: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:159: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:159: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/backlight/ep93xx_bl.c:159: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:160: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:160: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:160: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/backlight/ep93xx_bl.c:160: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:161: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:161: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:161: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/backlight/ep93xx_bl.c:161: warning: function declaration isn't a prototype make[3]: *** [drivers/video/backlight/ep93xx_bl.o] Error 1
make[2]: *** [drivers/video/backlight] Error 2
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

Signed-off-by Axel Lin <[email protected]>

---
 drivers/video/backlight/ep93xx_bl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/video/backlight/ep93xx_bl.c +1 -1

index 9f1e389..b058291 100644
@@ -11,7 +11,7 @@
  * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
  */
 
-
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/fb.h>

Signature · 1 line

1.7.4.1

Ryan Mallon

Acked-by on v1 1/1

2011-08-21 23:39 UTC #1 lore raw

Quoted 2 lines · Axel Lin

ep93xx_bl.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.

Thanks,

Acked-by Ryan Mallon <[email protected]>

Quoted 41 lines

CC [M] drivers/video/backlight/ep93xx_bl.o
drivers/video/backlight/ep93xx_bl.c:138: error: 'THIS_MODULE' undeclared here (not in a function) drivers/video/backlight/ep93xx_bl.c:158: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:158: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:158: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/backlight/ep93xx_bl.c:158: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:159: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:159: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:159: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/backlight/ep93xx_bl.c:159: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:160: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:160: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:160: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/backlight/ep93xx_bl.c:160: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:161: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:161: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:161: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/backlight/ep93xx_bl.c:161: warning: function declaration isn't a prototype make[3]: *** [drivers/video/backlight/ep93xx_bl.o] Error 1
make[2]: *** [drivers/video/backlight] Error 2
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2
Signed-off-by Axel Lin<[email protected]>
---
  drivers/video/backlight/ep93xx_bl.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/ep93xx_bl.c +1 -1
index 9f1e389..b058291 100644
@@ -11,7 +11,7 @@
   * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
   */
 
-
+#include<linux/module.h>
  #include<linux/platform_device.h>
  #include<linux/io.h>
  #include<linux/fb.h>

Ryan Mallon

2011-08-21 23:55 UTC #2 lore raw

Quoted 7 lines · Ryan Mallon

Quoted 2 lines · Axel Lin
ep93xx_bl.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.
Thanks,
Acked-by Ryan Mallon <[email protected]>

Retracted. Please see my reply to the ep93xx framebuffer patch.

~Ryan

Quoted 43 lines

Quoted 42 lines
CC [M] drivers/video/backlight/ep93xx_bl.o
drivers/video/backlight/ep93xx_bl.c:138: error: 'THIS_MODULE' undeclared here (not in a function) drivers/video/backlight/ep93xx_bl.c:158: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:158: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:158: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/backlight/ep93xx_bl.c:158: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:159: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:159: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:159: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/backlight/ep93xx_bl.c:159: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:160: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:160: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:160: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/backlight/ep93xx_bl.c:160: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:161: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:161: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:161: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/backlight/ep93xx_bl.c:161: warning: function declaration isn't a prototype make[3]: *** [drivers/video/backlight/ep93xx_bl.o] Error 1
make[2]: *** [drivers/video/backlight] Error 2
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2
Signed-off-by Axel Lin<[email protected]>
---
  drivers/video/backlight/ep93xx_bl.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/ep93xx_bl.c +1 -1
index 9f1e389..b058291 100644
@@ -11,7 +11,7 @@
   * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
   */
 
-
+#include<linux/module.h>
  #include<linux/platform_device.h>
  #include<linux/io.h>
  #include<linux/fb.h>

H Hartley Sweeten

Acked-by on v1 1/1

2011-08-22 16:35 UTC #3 lore raw

In reply to Axel Lin

Quoted 37 lines · Axel Lin

ep93xx_bl.c uses interfaces from linux/module.h,
so it should include that file. This patch fixes below build errors.
CC [M] drivers/video/backlight/ep93xx_bl.o
drivers/video/backlight/ep93xx_bl.c:138: error: 'THIS_MODULE' undeclared here (not in a function) drivers/video/backlight/ep93xx_bl.c:158: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:158: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:158: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/backlight/ep93xx_bl.c:158: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:159: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:159: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:159: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/backlight/ep93xx_bl.c:159: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:160: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:160: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:160: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/backlight/ep93xx_bl.c:160: warning: function declaration isn't a prototype drivers/video/backlight/ep93xx_bl.c:161: error: expected declaration specifiers or '...' before string constant drivers/video/backlight/ep93xx_bl.c:161: warning: data definition has no type or storage class drivers/video/backlight/ep93xx_bl.c:161: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/backlight/ep93xx_bl.c:161: warning: function declaration isn't a prototype make[3]: *** [drivers/video/backlight/ep93xx_bl.o] Error 1
make[2]: *** [drivers/video/backlight] Error 2
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2
Signed-off-by Axel Lin <[email protected]>
---
 drivers/video/backlight/ep93xx_bl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/ep93xx_bl.c +0 -0
index 9f1e389..b058291 100644

drivers/video/backlight/ep93xx_bl.c line 17

Quoted 8 lines

drivers/video/backlight/ep93xx_bl.c +1 -1

@@ -11,7 +11,7 @@
  * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
  */
 
-
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/fb.h>

Ah.. This was due to commit 089f5643ba "include: replace linux/module.h with "struct module" wherever possible".

Before that commit, including <linux/platform_device.h> would pull in <linux/device.h> which would then pull in <linux/module.h>. Now any driver using the MODULE_ macros needs to include <linux/module.h> directly.

Looks correct to me.

Acked-by H Hartley Sweeten <[email protected]>

��{.n�+��+%��ݶ��w��{.n�+��{��G��{ay�ʇڙ�,j��f��h��z_�(�階�ݢj"��m��G��?��&��~��iO��z��v�^�m��?�I�