Skip to contentSkip to conversation

OMAP4: hwmod data: I2C: add flag for context restore

PATCH Superseded Shubhrajyoti D 2 participants 4 messages Jul 17, 2011 – Aug 25, 2011

Subsystems (5)
Arm (32-bit) Arm sub-architectures I2C subsystem host drivers OMAP2+ support +1 more subsystems
lore
Share & tools
lore

Shubhrajyoti D

author
#0 lore raw

PATCH v4 1/1 OMAP4: hwmod data: I2C: add flag for context restore

Restore of context is not done for OMAP4. This patch adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 hwmod data which activates the restore for OMAP4. Currently the OMAP4 does not hit device off still the driver may have support for it.

Reviewed-by Kevin Hilman <[email protected]>
Signed-off-by Shubhrajyoti D <[email protected]>

---
Applies on top of patches from Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html
Tested on OMAP4430

 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/omap_hwmod_44xx_data.c +2 -1
index 0fe9556..5e2c748 100644
@@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
 };
 
 static struct omap_i2c_dev_attr i2c_dev_attr = {
-	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+			OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
 };
 
 /* i2c1 */
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH v4 1/1 OMAP4: hwmod data: I2C: add flag for context restore

Quoted 5 lines · Shubhrajyoti D

Restore of context is not done for OMAP4. This patch adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 hwmod data which activates the restore for OMAP4. Currently the OMAP4 does not hit device off still the driver may have support for it.

Could this patch be queued as well?

Quoted 24 lines
Reviewed-by Kevin Hilman<[email protected]>
Signed-off-by Shubhrajyoti D<[email protected]>

---
Applies on top of patches from Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html
Tested on OMAP4430

  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/omap_hwmod_44xx_data.c +2 -1
index 0fe9556..5e2c748 100644
@@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
  };
 
  static struct omap_i2c_dev_attr i2c_dev_attr = {
-	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+			OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
  };
 
  /* i2c1 */
#2 lore raw

PATCH v4 1/1 OMAP4: hwmod data: I2C: add flag for context restore

Quoted 7 lines · Shubhrajyoti
Quoted 5 lines · Shubhrajyoti D

Restore of context is not done for OMAP4. This patch adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 hwmod data which activates the restore for OMAP4. Currently the OMAP4 does not hit device off still the driver may have support for it.

Could this patch be queued as well?

Paul is the maintainer for the hwmod data. It is usually helpful to
ensure the maintainer is specifically added to the To line.

Kevin

Quoted 24 lines
Quoted 24 lines
Reviewed-by Kevin Hilman<[email protected]>
Signed-off-by Shubhrajyoti D<[email protected]>

---
Applies on top of patches from Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html
Tested on OMAP4430

  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/omap_hwmod_44xx_data.c +2 -1
index 0fe9556..5e2c748 100644
@@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
  };
 
  static struct omap_i2c_dev_attr i2c_dev_attr = {
-	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+			OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
  };
 
  /* i2c1 */
author
#3 lore raw

PATCH v4 1/1 OMAP4: hwmod data: I2C: add flag for context restore

Quoted 11 lines · Kevin Hilman
Quoted 7 lines · Shubhrajyoti
Quoted 5 lines · Shubhrajyoti D

Restore of context is not done for OMAP4. This patch adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 hwmod data which activates the restore for OMAP4. Currently the OMAP4 does not hit device off still the driver may have support for it.

Could this patch be queued as well?

Paul is the maintainer for the hwmod data. It is usually helpful to
ensure the maintainer is specifically added to the To line.

yes thanks will take care henceforth . For now adding him for comments.

Quoted 26 lines

Kevin

Quoted 24 lines
Quoted 24 lines
Reviewed-by Kevin Hilman<[email protected]>
Signed-off-by Shubhrajyoti D<[email protected]>

---
Applies on top of patches from Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html
Tested on OMAP4430

   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
   1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/omap_hwmod_44xx_data.c +2 -1
index 0fe9556..5e2c748 100644
@@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
   };
 
   static struct omap_i2c_dev_attr i2c_dev_attr = {
-	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+			OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
   };
 
   /* i2c1 */