Skip to contentSkip to conversation

mii_phy.h

U-Boot Michal Simek 3 participants 4 messages Aug 25, 2011 – Aug 26, 2011

lore
Share & tools
lore

Michal Simek

author
#0 lore raw

Hi,

Can someone clear me purpose of mii_phy.h? It looks like that it is really ancient file which hasn't been touched from 2003.

It is use for two files
[monstr at monstr u-boot]$ grep -rn "mii_phy.h" *
board/ep8260/mii_phy.c:2:#include <mii_phy.h>
board/rpxsuper/mii_phy.c:2:#include <mii_phy.h>

+ different numbers of arguments against new "version"
[monstr at monstr u-boot]$ grep -rn "mii_discover_phy" * arch/m68k/include/asm/fec.h:359:int mii_discover_phy(struct eth_device *dev); arch/powerpc/cpu/mpc8xx/fec.c:63:static int mii_discover_phy(struct eth_device *dev);
arch/powerpc/cpu/mpc8xx/fec.c:728: efis->actual_phy_addr = mii_discover_phy (dev);
arch/powerpc/cpu/mpc8xx/fec.c:872:static int mii_discover_phy(struct eth_device *dev)
arch/powerpc/cpu/mpc85xx/ether_fcc.c:237: mii_discover_phy();
arch/powerpc/cpu/mpc8260/ether_fcc.c:234: mii_discover_phy();
board/ep8260/mii_phy.c:10:mii_discover_phy(void) board/rpxsuper/mii_phy.c:10:mii_discover_phy(void) drivers/net/mcfmii.c:150:int mii_discover_phy(struct eth_device *dev)
drivers/net/mcfmii.c:253: info->phy_addr = mii_discover_phy(dev);
include/mii_phy.h:4:void mii_discover_phy(void);

+ that functions without arg are not called either
arch/powerpc/cpu/mpc85xx/ether_fcc.c:237: mii_discover_phy();
arch/powerpc/cpu/mpc8260/ether_fcc.c:234: mii_discover_phy();

I found that Frank Panno is ep8260 maintainer. Any comment?

The best will be to remove mii_phy entirely.
Wolfgang: What do you think?

Thanks,
Michal

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#1 lore raw
Quoted 7 lines · On Thursday, August 25, 2011 03:25:32 Michal Simek wrote:

Can someone clear me purpose of mii_phy.h? It looks like that it is really ancient file which hasn't been touched from 2003.

It is use for two files
[monstr at monstr u-boot]$ grep -rn "mii_phy.h" *
board/ep8260/mii_phy.c:2:#include <mii_phy.h>
board/rpxsuper/mii_phy.c:2:#include <mii_phy.h>

yes, if you look at old files, you often see people using generic names when they should have been driver or arch specific, or people who thought about starting a framework but then nothing ever materialized.

Quoted 1 line

The best will be to remove mii_phy entirely.

sounds good to me ... i imagine the existing functionality might need to be converted into one of the common net frameworks that has been adopted ? -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110825/636da940/attachment.pgp

author
#2 lore raw
Quoted 9 lines · Mike Frysinger
Quoted 7 lines · On Thursday, August 25, 2011 03:25:32 Michal Simek wrote:

Can someone clear me purpose of mii_phy.h? It looks like that it is really ancient file which hasn't been touched from 2003.

It is use for two files
[monstr at monstr u-boot]$ grep -rn "mii_phy.h" *
board/ep8260/mii_phy.c:2:#include <mii_phy.h>
board/rpxsuper/mii_phy.c:2:#include <mii_phy.h>

Quoted 8 lines

yes, if you look at old files, you often see people using generic names when they should have been driver or arch specific, or people who thought about starting a framework but then nothing ever materialized.

Quoted 1 line

The best will be to remove mii_phy entirely.

sounds good to me ... i imagine the existing functionality might need to be converted into one of the common net frameworks that has been adopted ?

Who is responsible for ep8260 and rpxsuper boards?

For ep8260: I cc'ed Frank Panno but his email address doesn't work.

Thanks,
Michal

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#3 lore raw

Dear Michal Simek,

Quoted 4 lines · In message <[email protected]> you wrote:

Who is responsible for ep8260 and rpxsuper boards?

For ep8260: I cc'ed Frank Panno but his email address doesn't work.

I guess it's safe to assume these boards are orphaned / unmaintained.

Shall we remove them?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If only God would give me some clear sign! Like making a large  depo-
sit in my name at a Swiss Bank.                         - Woody Allen