Makefile: remove tx25 exception
PATCH 1/1 Makefile: remove tx25 exception
An entry in the main Makefile for the tx25 board is not necessary, and the board is added to boards.cfg as all other targets.
--- Makefile | 4 ---- boards.cfg | 1 + 2 files changed, 1 insertions(+), 4 deletions(-)
Makefile +0 -4
@@ -847,10 +847,6 @@ SX1_config: unconfig fi; @$(MKCONFIG) -n $@ SX1 arm arm925t sx1 -tx25_config : unconfig - @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk - @$(MKCONFIG) $@ arm arm926ejs tx25 karo mx25 - edb9301_config \ edb9302_config \ edb9302a_config \
boards.cfg +1 -0
@@ -162,6 +162,7 @@ rd6281a arm arm926ejs - Marvell sheevaplug arm arm926ejs - Marvell kirkwood dockstar arm arm926ejs - Seagate kirkwood jadecpu arm arm926ejs jadecpu syteco mb86r0x +tx25 arm arm926ejs tx25 karo mx25 zmx25 arm arm926ejs zmx25 syteco mx25 imx27lite arm arm926ejs imx27lite logicpd mx27 magnesium arm arm926ejs imx27lite logicpd mx27
Signature · 1 line
1.7.1
PATCH 1/1 Makefile: remove tx25 exception
Dear Stefano Babic,
Quoted 3 lines · In message <[email protected]> you wrote:
An entry in the main
Makefilefor the tx25 board is not necessary, and the board is added to boards.cfg as all other targets.
In theorey you are right, but this patch appears to be wrong:
Makefile SX1_config: unconfig · line 852
Quoted 3 lines
Makefile +0
-3-tx25_config : unconfig - @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk - @$(MKCONFIG) $@ arm arm926ejs tx25 karo mx25
The Makefile defined CONFIG_NAND_U_BOOT
Quoted 1 line
+tx25 arm arm926ejs tx25 karo mx25
This new entry fails to do that. Please make sure to add NAND_U_BOOT
in the "Options" column.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de In accord with UNIX philosophy, Perl gives you enough rope to hang yourself. - L. Wall & R. L. Schwartz, _Programming Perl_
PATCH 1/1 Makefile: remove tx25 exception
Quoted 7 lines · Wolfgang Denk
Dear Stefano Babic,
Quoted 3 lines · In message <[email protected]> you wrote:
An entry in the main
Makefilefor the tx25 board is not necessary, and the board is added to boards.cfg as all other targets.
Quoted 7 lines
In theorey you are right, but this patch appears to be wrong:
Makefile SX1_config: unconfig · line 852
Quoted 3 lines
Makefile +0
-3-tx25_config : unconfig - @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk - @$(MKCONFIG) $@ arm arm926ejs tx25 karo mx25The
MakefiledefinedCONFIG_NAND_U_BOOT
In principle you are right, too, but in include/configs/tx25.h:
/* NAND BOOT is the only boot method */
#define CONFIG_NAND_U_BOOT
CONFIG_NAND_U_BOOT is always defined for this board. No idea because there is a special rule in Makefile.
Quoted 5 lines
Quoted 2 lines
+tx25 arm arm926ejs tx25 karo mx25
This new entry fails to do that. Please make sure to add
NAND_U_BOOT
in the "Options" column.
I do not think we need it, because it is already defined in the config.h.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/1 Makefile: remove tx25 exception
Dear Stefano Babic,
Quoted 5 lines · In message <[email protected]> you wrote:
In principle you are right, too, but in
include/configs/tx25.h:/* NAND BOOT is the only boot method */
#defineCONFIG_NAND_U_BOOT
Ah, I see.
Quoted 1 line
I do not think we need it, because it is already defined in the
config.h.
You are right. Thanks for pointing out.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There are three principal ways to lose money: wine, women, and engi- neers. While the first two are more pleasant, the third is by far the more certain." - Baron Rothschild, ca. 1800
Wolfgang Denk
AppliedPATCH 1/1 Makefile: remove tx25 exception
In reply to Stefano BabicDear Stefano Babic,
Quoted 10 lines · In message <[email protected]> you wrote:
An entry in the main
Makefilefor the tx25 board is not necessary, and the board is added to boards.cfg as all other targets.Signed-off-by Stefano Babic <[email protected]>CC Wolfgang Denk <[email protected]>--- Makefile | 4 ---- boards.cfg | 1 + 2 files changed, 1 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "How is this place run - is it an anarchy?" "No, I wouldn't say so; it is not that well organised..."