Skip to contentSkip to conversation

Correct call to eth_write_hwaddr()

PATCH New Simon Glass 5 participants 5 messages Aug 30, 2011 – Sep 5, 2011 Networking

lore
Share & tools
lore

Simon Glass

author
#0 lore raw

PATCH 1/1 Correct call to eth_write_hwaddr()

This fixes "Warning: failed to set MAC address" on platforms which rely on an 'ethaddr' environment variable to set the MAC address.

This bug was introduced by this commit:

7616e785 Add Ethernet hardware MAC address framework to usbnet

Signed-off-by Simon Glass <[email protected]>
---
 net/eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/eth.c +1 -1
index a34fe59..2caaf60 100644
@@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis)
 			if (strchr(dev->name, ' '))
 				puts("\nWarning: eth device name has a space!\n");
 
-			if (eth_write_hwaddr(dev, NULL, eth_number))
+			if (eth_write_hwaddr(dev, "eth", eth_number))
 				puts("Warning: failed to set MAC address\n");
 
 			eth_number++;
Signature · 1 line
1.7.3.1
#1 lore raw

PATCH 1/1 Correct call to eth_write_hwaddr()

Quoted 11 lines · Simon Glass

This fixes "Warning: failed to set MAC address" on platforms which rely on an 'ethaddr' environment variable to set the MAC address.

This bug was introduced by this commit:

7616e785 Add Ethernet hardware MAC address framework to usbnet

Signed-off-by Simon Glass <[email protected]>

---
net/eth.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
Tested-by Kumar Gala <[email protected]>

(for SoC based ethernet)

- k

#2 lore raw

PATCH 1/1 Correct call to eth_write_hwaddr()

Quoted 7 lines · Kumar Gala
Quoted 5 lines · Simon Glass

This fixes "Warning: failed to set MAC address" on platforms which rely on an 'ethaddr' environment variable to set the MAC address.

This bug was introduced by this commit:

Quoted 8 lines
Quoted 6 lines

7616e785 Add Ethernet hardware MAC address framework to usbnet

Signed-off-by Simon Glass <[email protected]>

---
net/eth.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
Tested-by Kumar Gala <[email protected]>

I have made similar patch.

Tested-by Michal Simek <[email protected]>

Thanks,
Michal

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#3 lore raw

PATCH 1/1 Correct call to eth_write_hwaddr()

In reply to Simon Glass

Hello Simon,

Quoted 12 lines · Simon Glass

This fixes "Warning: failed to set MAC address" on platforms which rely on an 'ethaddr' environment variable to set the MAC address.

This bug was introduced by this commit:

7616e785 Add Ethernet hardware MAC address framework to usbnet

Signed-off-by Simon Glass <[email protected]>
---
 net/eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Tested on a davinci am1808 based board, so

Tested-by Heiko Schocher <[email protected]>

Thanks for fixing this!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Applied
#4 lore raw

PATCH 1/1 Correct call to eth_write_hwaddr()

In reply to Simon Glass

Dear Simon Glass,

Quoted 11 lines · In message <[email protected]> you wrote:

This fixes "Warning: failed to set MAC address" on platforms which rely on an 'ethaddr' environment variable to set the MAC address.

This bug was introduced by this commit:

7616e785 Add Ethernet hardware MAC address framework to usbnet

Signed-off-by Simon Glass <[email protected]>
---
 net/eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Until you walk a mile in another man's moccasins, you  can't  imagine
the smell.